Fix --file-filter option on cppcheck command (#3987)

* Add cppcheck handler match on misra msg

* Fix cppcheck --file-filter setting

This time, the tests and actually usage both work.

Co-authored-by: Dan George <dgeorge@anduril.com>
This commit is contained in:
Dan George
2021-11-20 02:01:32 -08:00
committed by GitHub
parent ea643b97ab
commit 072750137f
3 changed files with 15 additions and 11 deletions

View File

@@ -9,6 +9,7 @@ After:
set buftype=nofile
endif
unlet! b:rel_file_path
unlet! b:command_tail
call ale#assert#TearDownLinterTest()
@@ -21,25 +22,27 @@ Execute(The executable should be configurable):
AssertLinter 'foobar', ale#Escape('foobar') . b:command_tail
Execute(cppcheck for C++ should detect compile_commands.json files):
call ale#test#SetFilename('../test-files/cppcheck/one/foo.cpp')
let b:rel_file_path = '../test-files/cppcheck/one/foo.cpp'
call ale#test#SetFilename(b:rel_file_path)
AssertLinterCwd ale#path#Simplify(g:dir . '/../test-files/cppcheck/one')
AssertLinter 'cppcheck', ale#Escape('cppcheck')
\ . ' -q --language=c++'
\ . ' --template=' . ale#Escape('{file}:{line}:{column}: {severity}:{inconclusive:inconclusive:} {message} [{id}]\\n{code}')
\ . ' --project=' . ale#Escape('compile_commands.json')
\ . ' --file-filter=' . ale#Escape('foo.cpp')
\ . ' --file-filter=' . ale#Escape(ale#test#GetFilename(b:rel_file_path))
\ . ' --enable=style %t'
Execute(cppcheck for C++ should detect compile_commands.json files in build directories):
call ale#test#SetFilename('../test-files/cppcheck/with_build_dir/foo.cpp')
let b:rel_file_path = '../test-files/cppcheck/with_build_dir/foo.cpp'
call ale#test#SetFilename(b:rel_file_path)
AssertLinterCwd ale#path#Simplify(g:dir . '/../test-files/cppcheck/with_build_dir')
AssertLinter 'cppcheck', ale#Escape('cppcheck')
\ . ' -q --language=c++'
\ . ' --template=' . ale#Escape('{file}:{line}:{column}: {severity}:{inconclusive:inconclusive:} {message} [{id}]\\n{code}')
\ . ' --project=' . ale#Escape(ale#path#Simplify('build/compile_commands.json'))
\ . ' --file-filter=' . ale#Escape('foo.cpp')
\ . ' --file-filter=' . ale#Escape(ale#test#GetFilename(b:rel_file_path))
\ . ' --enable=style %t'
Execute(cppcheck for C++ should include file dir if compile_commands.json file is not found):