Merge remote-tracking branch 'upstream/master'

Signed-off-by: Pierre-Nicolas Clauss <pinicarus@protonmail.com>

test/command_callback/test_adals_command_callbacks.vader

@@ -0,0 +1,17 @@
+Before:
+  call ale#assert#SetUpLinterTest('ada', 'adals')
+
+After:
+  call ale#assert#TearDownLinterTest()
+
+Execute(Sets adals executable):
+  let g:ale_ada_adals_executable = '/path/to /Ada'
+  AssertLinter '/path/to /Ada', ale#Escape('/path/to /Ada')
+
+Execute(Sets adals encoding):
+  let b:ale_ada_adals_encoding = 'iso-8859-1'
+  AssertLSPConfig {'ada.defaultCharset': 'iso-8859-1', 'ada.projectFile': 'default.gpr'}
+
+Execute(Sets adals project):
+  let g:ale_ada_adals_project = 'myproject.gpr'
+  AssertLSPConfig {'ada.defaultCharset': 'utf-8', 'ada.projectFile': 'myproject.gpr'}

test/command_callback/test_clang_tidy_command_callback.vader

@@ -68,7 +68,6 @@ Execute(The build directory should be used for header files):
   \ ale#Escape('clang-tidy')
   \   . ' -checks=' . ale#Escape('*') . ' %s'
   \   . ' -p ' . ale#Escape('/foo/bar')
-  \   . ' -- -x c++'
 
   call ale#test#SetFilename('test.hpp')
 

test/command_callback/test_dart_analysis_server_command_callback.vader

@@ -0,0 +1,15 @@
+Before:
+  call ale#assert#SetUpLinterTest('dart', 'analysis_server')
+
+After:
+  call ale#assert#TearDownLinterTest()
+
+Execute(The default command should be correct):
+  AssertLinter 'dart', ale#Escape('dart')
+  \   . ' ./snapshots/analysis_server.dart.snapshot --lsp'
+
+Execute(The executable should be configurable):
+  let g:ale_dart_analysis_server_executable = 'foobar'
+
+  AssertLinter 'foobar', ale#Escape('foobar')
+  \   . ' ./snapshots/analysis_server.dart.snapshot --lsp'

test/command_callback/test_elixir_credo.vader

@@ -38,3 +38,10 @@ Execute(Builds credo command with suggest mode when set to 0):
   AssertLinter 'mix',
   \ ale#path#CdString(ale#path#Simplify(g:dir . '/elixir_paths/mix_project'))
   \ . 'mix help credo && mix credo suggest --format=flycheck --read-from-stdin %s'
+
+Execute(Builds credo command with a custom config file):
+  let g:ale_elixir_credo_config_file = '/home/user/custom_credo.exs'
+
+  AssertLinter 'mix',
+  \ ale#path#CdString(ale#path#Simplify(g:dir . '/elixir_paths/mix_project'))
+  \ . 'mix help credo && mix credo suggest --config-file /home/user/custom_credo.exs --format=flycheck --read-from-stdin %s'

test/command_callback/test_erlang_elvis_command_callback.vader

@@ -0,0 +1,16 @@
+Before:
+  let b:file = fnamemodify(bufname(''), ':.')
+  call ale#assert#SetUpLinterTest('erlang', 'elvis')
+
+After:
+  call ale#assert#TearDownLinterTest()
+
+Execute(Default command should be correct):
+  AssertLinter 'elvis',
+  \ ale#Escape('elvis') . ' rock --output-format=parsable ' . ale#Escape(b:file)
+
+Execute(Executable should be configurable):
+  let b:ale_erlang_elvis_executable = '/path/to/elvis'
+
+  AssertLinter '/path/to/elvis',
+  \ ale#Escape('/path/to/elvis') . ' rock --output-format=parsable ' . ale#Escape(b:file)

test/command_callback/test_fecs_command_callback.vader

@@ -1,5 +1,6 @@
 Before:
   call ale#assert#SetUpLinterTest('javascript', 'fecs')
+  runtime autoload/ale/handlers/fecs.vim
 
 After:
   call ale#assert#TearDownLinterTest()

test/command_callback/test_ibm_openapi_validator_command_callback.vader

@@ -0,0 +1,15 @@
+Before:
+  call ale#assert#SetUpLinterTest('openapi', 'ibm_validator')
+
+After:
+  call ale#assert#TearDownLinterTest()
+
+Execute(The yaml ibm-openapi-validator command callback should return the correct default string):
+  AssertLinter 'lint-openapi', ale#Escape('lint-openapi') . ' %t'
+
+Execute(The yaml ibm-openapi-validator command callback should be configurable):
+  let g:ale_openapi_ibm_validator_executable = '~/.local/bin/lint-openapi'
+  let g:ale_openapi_ibm_validator_options = '-c ~/.config'
+
+  AssertLinter '~/.local/bin/lint-openapi', ale#Escape('~/.local/bin/lint-openapi')
+  \ . ' -c ~/.config %t'

test/command_callback/test_inko_inko_callbacks.vader

@@ -0,0 +1,20 @@
+Before:
+  call ale#assert#SetUpLinterTest('inko', 'inko')
+  call ale#test#SetFilename('inko_paths/test.inko')
+
+After:
+  call ale#assert#TearDownLinterTest()
+
+Execute(The default executable path should be correct):
+  AssertLinter 'inko', ale#Escape('inko') . ' build --check --format=json %s'
+
+Execute(The inko callback should include tests/ for test paths):
+  call ale#engine#Cleanup(bufnr(''))
+  noautocmd e! inko_paths/tests/test/test_foo.inko
+  call ale#engine#InitBufferInfo(bufnr(''))
+
+  AssertLinter 'inko',
+  \ ale#Escape('inko')
+  \   . ' build --check --format=json --include '
+  \   . ale#Escape(ale#path#Simplify(g:dir . '/inko_paths/tests/'))
+  \   . ' %s'

test/command_callback/test_julia_languageserver_callbacks.vader

@@ -11,16 +11,16 @@ After:
 Execute(The default executable path should be correct):
   AssertLinter 'julia',
   \ ale#Escape('julia') .
-  \' --startup-file=no --history-file=no -e ' .
-  \ ale#Escape('using LanguageServer; server = LanguageServer.LanguageServerInstance(isdefined(Base, :stdin) ? stdin : STDIN, isdefined(Base, :stdout) ? stdout : STDOUT, false); server.runlinter = true; run(server);')
+  \' --project=@. --startup-file=no --history-file=no -e ' .
+  \ ale#Escape('using LanguageServer; using Pkg; import StaticLint; import SymbolServer; server = LanguageServer.LanguageServerInstance(isdefined(Base, :stdin) ? stdin : STDIN, isdefined(Base, :stdout) ? stdout : STDOUT, dirname(Pkg.Types.Context().env.project_file)); server.runlinter = true; run(server);')
 
 Execute(The executable should be configurable):
   let g:ale_julia_executable = 'julia-new'
 
   AssertLinter 'julia-new',
   \ ale#Escape('julia-new') .
-  \' --startup-file=no --history-file=no -e ' .
-  \ ale#Escape('using LanguageServer; server = LanguageServer.LanguageServerInstance(isdefined(Base, :stdin) ? stdin : STDIN, isdefined(Base, :stdout) ? stdout : STDOUT, false); server.runlinter = true; run(server);')
+  \' --project=@. --startup-file=no --history-file=no -e ' .
+  \ ale#Escape('using LanguageServer; using Pkg; import StaticLint; import SymbolServer; server = LanguageServer.LanguageServerInstance(isdefined(Base, :stdin) ? stdin : STDIN, isdefined(Base, :stdout) ? stdout : STDOUT, dirname(Pkg.Types.Context().env.project_file)); server.runlinter = true; run(server);')
 
 Execute(The project root should be detected correctly):
   AssertLSPProject ''

test/command_callback/test_php_intelephense_command_callback.vader

@@ -0,0 +1,26 @@
+Before:
+  call ale#assert#SetUpLinterTest('php', 'intelephense')
+
+After:
+  call ale#assert#TearDownLinterTest()
+
+Execute(The default executable path should be correct):
+  AssertLinter 'intelephense',
+  \ ale#Escape('intelephense') . ' --stdio'
+
+Execute(The project path should be correct for .git directories):
+  call ale#test#SetFilename('php-intelephense-project/with-git/test.php')
+  silent! call mkdir('php-intelephense-project/with-git/.git', 'p')
+
+  AssertLSPProject ale#path#Simplify(g:dir . '/php-intelephense-project/with-git')
+
+Execute(The project path should be correct for composer.json file):
+  call ale#test#SetFilename('php-intelephense-project/with-composer/test.php')
+
+  AssertLSPProject ale#path#Simplify(g:dir . '/php-intelephense-project/with-composer')
+
+Execute(The project cache should be saved in a temp dir):
+  call ale#test#SetFilename('php-intelephense-project/with-composer/test.php')
+  let g:ale_php_intelephense_config = { 'storagePath': '/tmp/intelephense' }
+
+  AssertLSPProject ale#path#Simplify(g:dir . '/php-intelephense-project/with-composer')

test/command_callback/test_r_languageserver_callbacks.vader

@@ -0,0 +1,22 @@
+Before:
+  call ale#assert#SetUpLinterTest('r', 'languageserver')
+
+After:
+  call ale#assert#TearDownLinterTest()
+
+Execute(The default executable path should be correct):
+  AssertLinter 'Rscript', 'Rscript --vanilla -e ' . ale#Escape('languageserver::run()')
+
+Execute(The project root should be detected correctly):
+  AssertLSPProject '.'
+
+  call ale#test#SetFilename('r_paths/dummy/test.R')
+
+  AssertLSPProject ale#path#Simplify(g:dir . '/r_paths')
+
+Execute(Should accept configuration settings):
+  AssertLSPConfig {}
+
+  let b:ale_r_languageserver_config = {'r': {'lsp': {'debug': 'true', 'diagnostics': 'true'}}}
+
+  AssertLSPConfig {'r': {'lsp': {'debug': 'true', 'diagnostics': 'true'}}}

test/command_callback/test_rust_analyzer_callbacks.vader

@@ -16,5 +16,5 @@ Execute(The project root should be detected correctly):
 
 Execute(Should accept configuration settings):
   AssertLSPConfig {}
-  let b:ale_rust_analyzer_config = {'rust': {'clippy_preference': 'on'}}
-  AssertLSPConfig {'rust': {'clippy_preference': 'on'}}
+  let b:ale_rust_analyzer_config = {'diagnostics': {'disabled': ['unresolved-import']}}
+  AssertLSPOptions {'diagnostics': {'disabled': ['unresolved-import']}}

test/command_callback/test_sorbet_command_callback.vader

@@ -5,6 +5,7 @@ Before:
 
   let g:ale_ruby_sorbet_executable = 'srb'
   let g:ale_ruby_sorbet_options = ''
+  let g:ale_ruby_sorbet_enable_watchman = 0
 
 After:
   call ale#assert#TearDownLinterTest()
@@ -13,6 +14,12 @@ Execute(Executable should default to srb):
   AssertLinter 'srb', ale#Escape('srb')
   \   . ' tc --lsp --disable-watchman'
 
+Execute(Able to enable watchman):
+  let g:ale_ruby_sorbet_enable_watchman = 1
+
+  AssertLinter 'srb', ale#Escape('srb')
+  \   . ' tc --lsp'
+
 Execute(Should be able to set a custom executable):
   let g:ale_ruby_sorbet_executable = 'bin/srb'
 

test/command_callback/test_spectral_command_callback.vader

@@ -0,0 +1,31 @@
+Before:
+  call ale#assert#SetUpLinterTest('yaml', 'spectral')
+
+After:
+  call ale#assert#TearDownLinterTest()
+
+Execute(The yaml spectral command callback should return the correct default string):
+  AssertLinter 'spectral', ale#Escape('spectral') . ' lint --ignore-unknown-format -q -f text %t'
+
+Execute(The yaml spectral command callback should be configurable):
+  let g:ale_yaml_spectral_executable = '~/.local/bin/spectral'
+
+  AssertLinter '~/.local/bin/spectral',
+  \ ale#Escape('~/.local/bin/spectral')
+  \   . ' lint --ignore-unknown-format -q -f text %t'
+
+Execute(The yaml spectral command callback should allow a global installation to be used):
+  let g:ale_yaml_spectral_executable = '/usr/local/bin/spectral'
+  let g:ale_yaml_spectral_use_global = 1
+
+  AssertLinter '/usr/local/bin/spectral',
+  \ ale#Escape('/usr/local/bin/spectral')
+  \   . ' lint --ignore-unknown-format -q -f text %t'
+
+Execute(The yaml spectral command callback should allow a local installation to be used):
+  call ale#test#SetFilename('spectral_paths/openapi.yaml')
+
+  AssertLinter
+  \ ale#path#Simplify(g:dir . '/spectral_paths/node_modules/.bin/spectral'),
+  \ ale#Escape(ale#path#Simplify(g:dir . '/spectral_paths/node_modules/.bin/spectral'))
+  \   . ' lint --ignore-unknown-format -q -f text %t'

test/command_callback/test_typescript_deno_lsp.vader

@@ -0,0 +1,60 @@
+Before:
+  let g:ale_deno_unstable = 0
+  let g:ale_deno_executable = 'deno'
+  let g:ale_deno_project_root = ''
+
+  runtime autoload/ale/handlers/deno.vim
+  call ale#assert#SetUpLinterTest('typescript', 'deno')
+
+After:
+  call ale#assert#TearDownLinterTest()
+
+Execute(Should set deno lsp for TypeScript projects using stable Deno API):
+  AssertLSPLanguage 'typescript'
+  AssertLSPConfig {}
+  AssertLSPProject ale#path#Simplify(g:dir . '/../..')
+  AssertLSPOptions {
+  \   'enable': v:true,
+  \   'lint': v:true,
+  \   'unstable': v:false
+  \}
+
+Execute(Should set deno lsp using unstable Deno API if enabled by user):
+  let g:ale_deno_unstable = 1
+  AssertLSPLanguage 'typescript'
+  AssertLSPConfig {}
+  AssertLSPProject ale#path#Simplify(g:dir . '/../..')
+  AssertLSPOptions {
+  \   'enable': v:true,
+  \   'lint': v:true,
+  \   'unstable': v:true
+  \}
+
+Execute(Should find project root containing tsconfig.json):
+  call ale#test#SetFilename('../typescript/test.ts')
+  AssertLSPLanguage 'typescript'
+  AssertLSPConfig {}
+  AssertLSPProject ale#path#Simplify(g:dir . '/../typescript')
+  AssertLSPOptions {
+  \   'enable': v:true,
+  \   'lint': v:true,
+  \   'unstable': v:false
+  \}
+
+Execute(Should use user-specified project root):
+  let g:ale_deno_lsp_project_root = '/'
+
+  call ale#test#SetFilename('../typescript/test.ts')
+  AssertLSPLanguage 'typescript'
+  AssertLSPConfig {}
+  AssertLSPProject '/'
+  AssertLSPOptions {
+  \   'enable': v:true,
+  \   'lint': v:true,
+  \   'unstable': v:false
+  \}
+
+Execute(Check Deno LSP command):
+  AssertLinter 'deno', [
+  \ ale#Escape('deno') . ' lsp',
+  \]

test/command_callback/test_xo_command_callback.vader

@@ -1,8 +1,11 @@
 Before:
-  call ale#assert#SetUpLinterTest('typescript', 'xo')
-  call ale#test#SetFilename('testfile.ts')
+  call ale#assert#SetUpLinterTest('javascript', 'xo')
+  call ale#test#SetFilename('testfile.jsx')
   unlet! b:executable
 
+  set filetype=javascriptreact
+  runtime autoload/ale/handlers/xo.vim
+
 After:
   call ale#assert#TearDownLinterTest()
 
@@ -10,11 +13,11 @@ Execute(The XO executable should be called):
   AssertLinter 'xo', ale#Escape('xo') . ' --reporter json --stdin --stdin-filename %s'
 
 Execute(The XO executable should be configurable):
-  let b:ale_typescript_xo_executable = 'foobar'
+  let b:ale_javascript_xo_executable = 'foobar'
 
   AssertLinter 'foobar', ale#Escape('foobar') . ' --reporter json --stdin --stdin-filename %s'
 
 Execute(The XO options should be configurable):
-  let b:ale_typescript_xo_options = '--wat'
+  let b:ale_javascript_xo_options = '--wat'
 
   AssertLinter 'xo', ale#Escape('xo') . ' --wat --reporter json --stdin --stdin-filename %s'

test/command_callback/test_xots_command_callback.vader

@@ -0,0 +1,23 @@
+Before:
+  call ale#assert#SetUpLinterTest('typescript', 'xo')
+  call ale#test#SetFilename('testfile.tsx')
+  unlet! b:executable
+
+  set filetype=typescriptreact
+  runtime autoload/ale/handlers/xo.vim
+
+After:
+  call ale#assert#TearDownLinterTest()
+
+Execute(The XO executable should be called):
+  AssertLinter 'xo', ale#Escape('xo') . ' --reporter json --stdin --stdin-filename %s'
+
+Execute(The XO executable should be configurable):
+  let b:ale_typescript_xo_executable = 'foobar'
+
+  AssertLinter 'foobar', ale#Escape('foobar') . ' --reporter json --stdin --stdin-filename %s'
+
+Execute(The XO options should be configurable):
+  let b:ale_typescript_xo_options = '--wat'
+
+  AssertLinter 'xo', ale#Escape('xo') . ' --wat --reporter json --stdin --stdin-filename %s'