VimPlug/ale
1
0
Fork 0
mirror of https://github.com/dense-analysis/ale.git synced 2026-01-19 17:42:57 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: ruff not registered as fixer (#4393)

Browse Source 
this commit fixes the issue reported at:
https://github.com/dense-analysis/ale/issues/4301#issuecomment-1359289391

it also had some code refactored and
tests added for ruff as fixer (missed in PR #4347).
This commit is contained in:
Yining
2022-12-22 11:53:01 +11:00
committed by GitHub
parent 8bcbb29958
commit 1e398202b9
3 changed files with 179 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

122
test/fixers/test_ruff_fixer_callback.vader Normal file
View File

@@ -0,0 +1,122 @@
Before:
call ale#assert#SetUpFixerTest('python', 'ruff')
let b:bin_dir = has('win32') ? 'Scripts' : 'bin'
After:
call ale#assert#TearDownFixerTest()
unlet! g:dir
unlet! b:bin_dir
Execute(The ruff callback should return the correct default values):
let file_path = g:dir . '/../test-files/python/with_virtualenv/subdir/foo/bar.py'
silent execute 'file ' . fnameescape(file_path)
let fname = ale#Escape(ale#path#Simplify(file_path))
" --fix does not support stdin until 0.0.72
GivenCommandOutput ['ruff 0.0.72']
AssertFixer
\ {
\ 'cwd': ale#path#Simplify(g:dir . '/../test-files/python/with_virtualenv/subdir'),
\ 'command': ale#Escape(ale#path#Simplify(g:dir . '/../test-files/python/with_virtualenv/env/' . b:bin_dir . '/ruff')) . ' --stdin-filename ' . fname . ' --fix -',
\ }
Execute(The ruff callback should not use stdin for older versions (< 0.0.72)):
let file_path = g:dir . '/../test-files/python/with_virtualenv/subdir/foo/bar.py'
silent execute 'file ' . fnameescape(file_path)
let fname = ale#Escape(ale#path#Simplify(file_path))
" --fix does not support stdin until 0.0.72
GivenCommandOutput ['ruff 0.0.71']
AssertFixer
\ {
\ 'cwd': ale#path#Simplify(g:dir . '/../test-files/python/with_virtualenv/subdir'),
\ 'command': ale#Escape(ale#path#Simplify(g:dir . '/../test-files/python/with_virtualenv/env/' . b:bin_dir . '/ruff')) . ' --stdin-filename ' . fname . ' --fix %s',
\ }
Execute(The ruff callback should not change directory if the option is set to 0):
let g:ale_python_ruff_change_directory = 0
let file_path = g:dir . '/../test-files/python/with_virtualenv/subdir/foo/bar.py'
silent execute 'file ' . fnameescape(file_path)
let fname = ale#Escape(ale#path#Simplify(file_path))
" --fix does not support stdin until 0.0.72
GivenCommandOutput ['ruff 0.0.72']
AssertFixer
\ {
\ 'cwd': '%s:h',
\ 'command': ale#Escape(ale#path#Simplify(g:dir . '/../test-files/python/with_virtualenv/env/' . b:bin_dir . '/ruff')) . ' --stdin-filename ' . fname . ' --fix -',
\ }
Execute(The ruff callback should respect custom options):
let g:ale_python_ruff_options = '--ignore F401 -q'
let file_path = g:dir . '/../test-files/python/with_virtualenv/subdir/foo/bar.py'
silent execute 'file ' . fnameescape(file_path)
let fname = ale#Escape(ale#path#Simplify(file_path))
GivenCommandOutput ['ruff 0.0.72']
AssertFixer
\ {
\ 'cwd': ale#path#Simplify(g:dir . '/../test-files/python/with_virtualenv/subdir'),
\ 'command': ale#Escape(ale#path#Simplify(g:dir . '/../test-files/python/with_virtualenv/env/' . b:bin_dir . '/ruff'))
\ . ' --ignore F401 -q --stdin-filename '. fname . ' --fix -',
\ }
Execute(Pipenv is detected when python_ruff_auto_pipenv is set):
let g:ale_python_ruff_auto_pipenv = 1
let g:ale_python_ruff_change_directory = 0
let file_path = '../test-files/python/pipenv/whatever.py'
call ale#test#SetFilename(file_path)
let fname = ale#Escape(ale#path#Simplify(g:dir . '/'. file_path))
GivenCommandOutput ['ruff 0.0.72']
AssertFixer
\ {
\ 'cwd': '%s:h',
\ 'command': ale#Escape('pipenv') . ' run ruff --stdin-filename ' . fname . ' --fix -'
\ }
Execute(Poetry is detected when python_ruff_auto_poetry is set):
let g:ale_python_ruff_auto_poetry = 1
let g:ale_python_ruff_change_directory = 0
call ale#test#SetFilename('../test-files/python/poetry/whatever.py')
let fname = ale#Escape(ale#path#Simplify(g:dir .'/../test-files/python/poetry/whatever.py'))
GivenCommandOutput ['ruff 0.0.72']
AssertFixer
\ {
\ 'cwd': '%s:h',
\ 'command': ale#Escape('poetry') . ' run ruff --stdin-filename ' . fname . ' --fix -'
\ }
Execute(Poetry is detected when python_ruff_auto_poetry is set, and cwd respects change_directory option):
let g:ale_python_ruff_auto_poetry = 1
let g:ale_python_ruff_change_directory = 1
call ale#test#SetFilename('../test-files/python/poetry/whatever.py')
let fname = ale#Escape(ale#path#Simplify(g:dir .'/../test-files/python/poetry/whatever.py'))
GivenCommandOutput ['ruff 0.0.72']
AssertFixer
\ {
\ 'cwd': ale#path#Simplify(g:dir . '/../test-files/python/poetry'),
\ 'command': ale#Escape('poetry') . ' run ruff --stdin-filename ' . fname . ' --fix -'
\ }