From f75848b32ca25aec1d5e6c0a5aa9c7b1e6c64539 Mon Sep 17 00:00:00 2001 From: James Owen Date: Wed, 31 Oct 2018 10:17:55 +0100 Subject: [PATCH 1/2] Pass the filename of the current file into jshint --- ale_linters/javascript/jshint.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ale_linters/javascript/jshint.vim b/ale_linters/javascript/jshint.vim index 83909fa4..cb7f66fc 100644 --- a/ale_linters/javascript/jshint.vim +++ b/ale_linters/javascript/jshint.vim @@ -18,7 +18,7 @@ function! ale_linters#javascript#jshint#GetCommand(buffer) abort let l:command .= ' --config ' . ale#Escape(l:jshint_config) endif - let l:command .= ' -' + let l:command .= ' --filename %s -' return l:command endfunction From 39fd7a09613145fe6799716da3d4158bf0d35092 Mon Sep 17 00:00:00 2001 From: James Owen Date: Wed, 31 Oct 2018 11:48:52 +0100 Subject: [PATCH 2/2] Add some basic callback tests for jshint --- .../test_jshint_command_callback.vader | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 test/command_callback/test_jshint_command_callback.vader diff --git a/test/command_callback/test_jshint_command_callback.vader b/test/command_callback/test_jshint_command_callback.vader new file mode 100644 index 00000000..d665a9c1 --- /dev/null +++ b/test/command_callback/test_jshint_command_callback.vader @@ -0,0 +1,14 @@ +Before: + call ale#assert#SetUpLinterTest('javascript', 'jshint') + +After: + call ale#assert#TearDownLinterTest() + +Execute(The default command should be correct): + + AssertLinter 'jshint', '''jshint'' --reporter unix --extract auto --filename %s -' + +Execute(Setting a config location should add the config parameter): + let g:ale_jshint_config_loc = '/some/file' + + AssertLinter 'jshint', '''jshint'' --reporter unix --extract auto --config ''/some/file'' --filename %s -'