VimPlug/ale
1
0
Fork 0
mirror of https://github.com/dense-analysis/ale.git synced 2025-12-06 12:44:23 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add support for multiline messages (#3686)

Browse Source 
This is achieved by switching to JSON, which makes it much easier to
avoid confusion between an error message and the next one. It also
spares us from having to deal with regular expressions, and eliminates
some edge cases that no longer need to be tested.
This commit is contained in:
Grégoire Paris
2021-07-09 16:59:36 +02:00
committed by GitHub
parent 774ab4b4f0
commit 2a5a7baffc
3 changed files with 31 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
test/handler/test_phpstan_handler.vader
View File

@@ -14,7 +14,9 @@ Execute(Output without errors should be parsed correctly):
AssertEqual
\ [],
\ ale_linters#php#phpstan#Handle(bufnr(''), [])
\ ale_linters#php#phpstan#Handle(bufnr(''), [
\ '{"totals":{"errors":0,"file_errors":0},"files":[],"errors":[]}',
\ ])
Execute(Output with some errors should be parsed correctly):
call ale#test#SetFilename('phpstan-test-files/foo/test.php')
@@ -37,38 +39,13 @@ Execute(Output with some errors should be parsed correctly):
\ 'type': 'E'
\ }
\ ],
\ ale_linters#php#phpstan#Handle(bufnr(''), [
\ 'phpstan-test-files/foo/test.php:9:Call to method format() on an unknown class DateTimeImutable.',
\ 'phpstan-test-files/foo/test.php:16:Sample message.',
\ 'phpstan-test-files/foo/test.php:192:Invalid command testCommand.',
\])
Execute(Output should be parsed correctly with Windows paths):
call ale#test#SetFilename('phpstan-test-files/foo/test.php')
AssertEqual
\ [
\ {
\ 'lnum': 9,
\ 'text': 'Access to an undefined property Test::$var.',
\ 'type': 'E'
\ }
\ ],
\ ale_linters#php#phpstan#Handle(bufnr(''), [
\ 'D:\phpstan-test-files\foo\test.php:9:Access to an undefined property Test::$var.',
\])
Execute(Output for .inc files should be parsed correctly):
call ale#test#SetFilename('phpstan-test-files/test.inc')
AssertEqual
\ [
\ {
\ 'lnum': 9,
\ 'text': 'Access to an undefined property Test::$var.',
\ 'type': 'E'
\ }
\ ],
\ ale_linters#php#phpstan#Handle(bufnr(''), [
\ '/phpstan-test-files/foo/test.inc:9:Access to an undefined property Test::$var.',
\])
\ ale_linters#php#phpstan#Handle(bufnr(''), [json_encode(
\ {
\ "totals":{"errors": 0, "file_errors": 11},
\ "files":{expand('%:p'): {"errors": 3, "messages": [
\ {"message": "Call to method format() on an unknown class DateTimeImutable.", "line":9},
\ {"message": "Sample message.", "line":16},
\ {"message": "Invalid command testCommand.", "line": 192}
\ ]}}
\ },
\)])