Update syntax checking

* Line continuation characters should be on the same lines.
* .vim file line indentation should be a multiple of 4.

ale_linters/bib/bibclean.vim

@@ -57,6 +57,7 @@ function! ale_linters#bib#bibclean#Handle(buffer, lines) abort
                 \ 'text': l:msg,
                 \ 'type': l:type
                 \})
+
                 let l:msg = ''
             endif
         endif

ale_linters/go/langserver.vim

@@ -10,7 +10,7 @@ function! ale_linters#go#langserver#GetCommand(buffer) abort
     let l:options = substitute(l:options, '-gocodecompletion', '', 'g')
     let l:options = filter(split(l:options, ' '), 'empty(v:val) != 1')
 
-    if(ale#Var(a:buffer, 'completion_enabled') == 1)
+    if ale#Var(a:buffer, 'completion_enabled')
         call add(l:options, '-gocodecompletion')
     endif
 

autoload/ale/c.vim

@@ -86,8 +86,8 @@ function! ale#c#ParseCFlags(path_prefix, cflag_line) abort
         let l:next_option_index = l:option_index + 1
 
         " Join space-separated option
-        while l:next_option_index < len(l:split_lines) &&
+        while l:next_option_index < len(l:split_lines)
-            \ stridx(l:split_lines[l:next_option_index], '-') != 0
+        \&& stridx(l:split_lines[l:next_option_index], '-') != 0
             let l:next_option_index += 1
         endwhile
 
@@ -96,9 +96,9 @@ function! ale#c#ParseCFlags(path_prefix, cflag_line) abort
         call insert(l:split_lines, l:option, l:option_index)
 
         " Ignore invalid or conflicting options
-        if stridx(l:option, '-') != 0 ||
+        if stridx(l:option, '-') != 0
-            \ stridx(l:option, '-o') == 0 ||
+        \|| stridx(l:option, '-o') == 0
-            \ stridx(l:option, '-c') == 0
+        \|| stridx(l:option, '-c') == 0
             call remove(l:split_lines, l:option_index)
             let l:option_index = l:option_index - 1
         " Fix relative path

autoload/ale/fixers/stylelint.vim

@@ -11,7 +11,6 @@ function! ale#fixers#stylelint#GetExecutable(buffer) abort
     \])
 endfunction
 
-
 function! ale#fixers#stylelint#Fix(buffer) abort
     let l:executable = ale#fixers#stylelint#GetExecutable(a:buffer)
 

autoload/ale/handlers/flawfinder.vim

@@ -1,3 +1,4 @@
+scriptencoding utf-8
 " Author: Christian Gibbons <cgibbons@gmu.edu>
 " Description: This file defines a handler function that should work for the
 " flawfinder format with the -CDQS flags.

autoload/ale/handlers/sml.vim

@@ -71,6 +71,7 @@ function! ale#handlers#sml#Handle(buffer, lines) abort
             \   'text': l:match2[3],
             \   'type': l:match2[3] =~# '^Warning' ? 'W' : 'E',
             \})
+
             continue
         endif
 

autoload/ale/lsp/response.vim

@@ -67,7 +67,11 @@ function! ale#lsp#response#ReadDiagnostics(response) abort
         endif
 
         if has_key(l:diagnostic, 'source')
-           let l:loclist_item.detail = printf('[%s] %s', l:diagnostic.source, l:diagnostic.message)
+            let l:loclist_item.detail = printf(
+            \   '[%s] %s',
+            \   l:diagnostic.source,
+            \   l:diagnostic.message
+            \)
         endif
 
         call add(l:loclist, l:loclist_item)

autoload/ale/preview.vim

@@ -52,7 +52,8 @@ function! ale#preview#ShowSelection(item_list, ...) abort
         let l:filename = l:item.filename
 
         if get(l:options, 'use_relative_paths')
-          let l:filename = substitute(l:item.filename, '^' . getcwd() . l:sep, '', '') " no-custom-checks
+            let l:cwd = getcwd() " no-custom-checks
+            let l:filename = substitute(l:filename, '^' . l:cwd . l:sep, '', '')
         endif
 
         call add(

autoload/ale/statusline.vim

@@ -78,8 +78,10 @@ endfunction
 function! s:UpdateCacheIfNecessary(buffer) abort
     " Cache is cold, so manually ask for an update.
     if !has_key(g:ale_buffer_info[a:buffer], 'count')
-        call ale#statusline#Update(a:buffer,
+        call ale#statusline#Update(
-            \ g:ale_buffer_info[a:buffer].loclist)
+        \   a:buffer,
+        \   g:ale_buffer_info[a:buffer].loclist
+        \)
     endif
 endfunction
 

test/script/block-padding-checker

@@ -10,7 +10,7 @@ import re
 
 INDENTATION_RE = re.compile(r'^ *')
 COMMENT_LINE_RE = re.compile(r'^ *"')
-COMMAND_RE = re.compile(r'^ *([a-zA-Z]+)')
+COMMAND_RE = re.compile(r'^ *([a-zA-Z\\]+)')
 
 START_BLOCKS = set(['if', 'for', 'while', 'try', 'function'])
 END_BLOCKS = set(['endif', 'endfor', 'endwhile', 'endtry', 'endfunction'])
@@ -21,6 +21,7 @@ WHITESPACE_BEFORE_SET = START_BLOCKS | TERMINATORS
 WHITESPACE_FORBIDDEN_BEFORE_SET = END_BLOCKS | MIDDLE_BLOCKS
 WHITESPACE_AFTER_SET = END_BLOCKS
 WHITESPACE_FORBIDDEN_AFTER_SET = START_BLOCKS | MIDDLE_BLOCKS
+SAME_INDENTATION_SET = set(['\\'])
 
 
 def remove_comment_lines(line_iter):
@@ -44,7 +45,7 @@ def check_lines(line_iter):
             ):
                 yield (
                     line_number,
-                    'Blank line forbidden after `%s`' % (command,)
+                    'Blank line forbidden after `%s`' % (previous_command,)
                 )
 
             previous_line_blank = True
@@ -56,6 +57,26 @@ def check_lines(line_iter):
             if command_match:
                 command = command_match.group(1)
 
+                if (
+                    command in SAME_INDENTATION_SET
+                    and previous_indentation_level is not None
+                    and indentation_level != previous_indentation_level
+                ):
+                    yield (
+                        line_number,
+                        'Line continuation should match previous indentation'
+                    )
+
+                if (
+                    previous_indentation_level is not None
+                    and indentation_level != previous_indentation_level
+                    and abs(indentation_level - previous_indentation_level) != 4
+                ):
+                    yield (
+                        line_number,
+                        'Indentation should be 4 spaces'
+                    )
+
                 # Check for commands requiring blank lines before them, if they
                 # aren't at the start of a block.
                 if (