VimPlug/ale
1
0
Fork 0
mirror of https://github.com/dense-analysis/ale.git synced 2025-12-07 21:24:33 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't use a temporary file for tflint (#3717)

Browse Source 
* Don't use a temporary file for tflint

* set cwd for tflint
This commit is contained in:
David Hotham
2021-05-25 01:41:14 +01:00
committed by GitHub
parent bf1c30f585
commit 3f386ae5e9
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
ale_linters/terraform/tflint.vim
View File

@@ -91,7 +91,7 @@ function! ale_linters#terraform#tflint#GetCommand(buffer) abort
let l:cmd .= ' ' . l:opts let l:cmd .= ' ' . l:opts
endif endif
let l:cmd .= ' -f json %t' let l:cmd .= ' -f json'
return l:cmd return l:cmd
endfunction endfunction
@@ -99,6 +99,7 @@ endfunction
call ale#linter#Define('terraform', { call ale#linter#Define('terraform', {
\ 'name': 'tflint', \ 'name': 'tflint',
\ 'executable': {b -> ale#Var(b, 'terraform_tflint_executable')}, \ 'executable': {b -> ale#Var(b, 'terraform_tflint_executable')},
\ 'cwd': '%s:h',
\ 'command': function('ale_linters#terraform#tflint#GetCommand'), \ 'command': function('ale_linters#terraform#tflint#GetCommand'),
\ 'callback': 'ale_linters#terraform#tflint#Handle', \ 'callback': 'ale_linters#terraform#tflint#Handle',
\}) \})

8
test/linter/test_terraform_tflint.vader
View File

@@ -5,18 +5,18 @@ After:
call ale#assert#TearDownLinterTest() call ale#assert#TearDownLinterTest()
Execute(The default command should be correct): Execute(The default command should be correct):
AssertLinter 'tflint', ale#Escape('tflint') . ' -f json %t' AssertLinter 'tflint', ale#Escape('tflint') . ' -f json'
Execute(The default executable should be configurable): Execute(The default executable should be configurable):
let b:ale_terraform_tflint_executable = 'asdf' let b:ale_terraform_tflint_executable = 'asdf'
AssertLinter 'asdf', ale#Escape('asdf') . ' -f json %t' AssertLinter 'asdf', ale#Escape('asdf') . ' -f json'
Execute(Overriding options should work): Execute(Overriding options should work):
let g:ale_terraform_tflint_executable = 'fnord' let g:ale_terraform_tflint_executable = 'fnord'
let g:ale_terraform_tflint_options = '--whatever' let g:ale_terraform_tflint_options = '--whatever'
AssertLinter 'fnord', ale#Escape('fnord') . ' --whatever -f json %t' AssertLinter 'fnord', ale#Escape('fnord') . ' --whatever -f json'
Execute(Configuration files should be found): Execute(Configuration files should be found):
call ale#test#SetFilename('../test-files/tflint/foo/bar.tf') call ale#test#SetFilename('../test-files/tflint/foo/bar.tf')
@@ -25,4 +25,4 @@ Execute(Configuration files should be found):
\ ale#Escape('tflint') \ ale#Escape('tflint')
\ . ' --config ' \ . ' --config '
\ . ale#Escape(ale#path#Simplify(g:dir . '/../test-files/tflint/foo/.tflint.hcl')) \ . ale#Escape(ale#path#Simplify(g:dir . '/../test-files/tflint/foo/.tflint.hcl'))
\ . ' -f json %t' \ . ' -f json'