Fix #1122 - Handle notes for shellcheck errors again, and use type 'I' for notes

This commit is contained in:
w0rp
2017-11-13 16:08:09 +00:00
parent a5f7f51c9a
commit 6c112dd1cc
2 changed files with 76 additions and 1 deletions

View File

@@ -0,0 +1,40 @@
Before:
runtime ale_linters/shell/shellcheck.vim
After:
call ale#linter#Reset()
Execute(The shellcheck handler should handle basic errors or warnings):
AssertEqual
\ [
\ {
\ 'lnum': 2,
\ 'col': 1,
\ 'type': 'W',
\ 'text': 'In POSIX sh, ''let'' is not supported. [SC2039]',
\ },
\ {
\ 'lnum': 2,
\ 'col': 3,
\ 'type': 'E',
\ 'text': 'Don''t put spaces around the = in assignments. [SC1068]',
\ },
\ ],
\ ale_linters#sh#shellcheck#Handle(bufnr(''), [
\ '-:2:1: warning: In POSIX sh, ''let'' is not supported. [SC2039]',
\ '-:2:3: error: Don''t put spaces around the = in assignments. [SC1068]',
\ ])
Execute(The shellcheck handler should handle notes):
AssertEqual
\ [
\ {
\ 'lnum': 3,
\ 'col': 3,
\ 'type': 'I',
\ 'text': 'Double quote to prevent globbing and word splitting. [SC2086]',
\ },
\ ],
\ ale_linters#sh#shellcheck#Handle(bufnr(''), [
\ '-:3:3: note: Double quote to prevent globbing and word splitting. [SC2086]',
\ ])