Add golangci-lint (#1890)

test/command_callback/test_golangci_lint_command_callback.vader

@@ -0,0 +1,38 @@
+Before:
+  call ale#assert#SetUpLinterTest('go', 'golangci_lint')
+  call ale#test#SetFilename('test.go')
+
+After:
+  call ale#assert#TearDownLinterTest()
+
+Execute(The golangci-lint defaults should be correct):
+  AssertLinter 'golangci-lint',
+  \ 'cd ' . ale#Escape(expand('%:p:h')) . ' && '
+  \   . ale#Escape('golangci-lint')
+  \   . ' run ' . ale#util#EscapePCRE(expand('%' . ':t'))
+  \   . ' --enable-all'
+
+Execute(The golangci-lint callback should use a configured executable):
+  let b:ale_go_golangci_lint_executable = 'something else'
+
+  AssertLinter 'something else',
+  \ 'cd ' . ale#Escape(expand('%:p:h')) . ' && '
+  \   . ale#Escape('something else')
+  \   . ' run ' . ale#util#EscapePCRE(expand('%' . ':t'))
+  \   . ' --enable-all'
+
+Execute(The golangci-lint callback should use configured options):
+  let b:ale_go_golangci_lint_options = '--foobar'
+
+  AssertLinter 'golangci-lint',
+  \ 'cd ' . ale#Escape(expand('%:p:h')) . ' && '
+  \   . ale#Escape('golangci-lint')
+  \   . ' run ' . ale#util#EscapePCRE(expand('%' . ':t'))
+  \   . ' --foobar'
+
+Execute(The golangci-lint `lint_package` option should use the correct command):
+  let b:ale_go_golangci_lint_package = 1
+
+  AssertLinter 'golangci-lint',
+  \ 'cd ' . ale#Escape(expand('%:p:h')) . ' && '
+  \   . ale#Escape('golangci-lint') . ' run --enable-all'

test/handler/test_golangci_lint_handler.vader

@@ -0,0 +1,55 @@
+Before:
+  runtime ale_linters/go/golangci_lint.vim
+
+After:
+  call ale#linter#Reset()
+
+Execute (The golangci-lint handler should handle names with spaces):
+  " We can't test Windows paths with the path resovling on Linux, but we can
+  " test the regex.
+  AssertEqual
+  \ [
+  \   [
+  \     'C:\something\file with spaces.go',
+  \     '12',
+  \     '3',
+  \     'expected ''package'', found ''IDENT'' gibberish (staticcheck)',
+  \   ],
+  \   [
+  \     'C:\something\file with spaces.go',
+  \     '37',
+  \     '5',
+  \     'expected ''package'', found ''IDENT'' gibberish (golint)',
+  \   ],
+  \ ],
+  \ map(ale_linters#go#golangci_lint#GetMatches([
+  \   'C:\something\file with spaces.go:12:3: expected ''package'', found ''IDENT'' gibberish (staticcheck)',
+  \   'C:\something\file with spaces.go:37:5: expected ''package'', found ''IDENT'' gibberish (golint)',
+  \ ]), 'v:val[1:4]')
+
+Execute (The golangci-lint handler should handle paths correctly):
+  call ale#test#SetFilename('app/test.go')
+
+  let file = ale#path#GetAbsPath(expand('%:p:h'), 'test.go')
+
+  AssertEqual
+  \ [
+  \   {
+  \     'lnum': 12,
+  \     'col': 3,
+  \     'text': 'expected ''package'', found ''IDENT'' gibberish (staticcheck)',
+  \     'type': 'E',
+  \     'filename': ale#path#Simplify(expand('%:p:h') . '/test.go'),
+  \   },
+  \   {
+  \     'lnum': 37,
+  \     'col': 5,
+  \     'text': 'expected ''package'', found ''IDENT'' gibberish (golint)',
+  \     'type': 'E',
+  \     'filename': ale#path#Simplify(expand('%:p:h') . '/test.go'),
+  \   },
+  \ ],
+  \ ale_linters#go#golangci_lint#Handler(bufnr(''), [
+  \   file . ':12:3: expected ''package'', found ''IDENT'' gibberish (staticcheck)',
+  \   file . ':37:5: expected ''package'', found ''IDENT'' gibberish (golint)',
+  \ ])