VimPlug/ale
1
0
Fork 0
mirror of https://github.com/dense-analysis/ale.git synced 2025-12-08 05:24:46 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #2845 from DonnieWest/fixItemDetailsOnEmptySource

Browse Source 
Fix tsserver not returning details for items with empty source
This commit is contained in:
w0rp
2019-10-18 15:16:54 +01:00
committed by GitHub
parent 99e64ed084 8698c44e2a
commit 9125ec8739
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
autoload/ale/completion.vim
View File

@@ -492,10 +492,17 @@ function! ale#completion#HandleTSServerResponse(conn_id, response) abort
let l:identifiers = [] let l:identifiers = []
for l:name in l:names for l:name in l:names
call add(l:identifiers, { let l:identifier = {
\ 'name': l:name.word, \ 'name': l:name.word,
\ 'source': get(l:name, 'source', ''), \}
\}) let l:source = get(l:name, 'source', '')
" Empty source results in no details for the completed item
if !empty(l:source)
call extend(l:identifier, { 'source': l:source })
endif
call add(l:identifiers, l:identifier)
endfor endfor
let b:ale_completion_info.request_id = ale#lsp#Send( let b:ale_completion_info.request_id = ale#lsp#Send(

2
test/completion/test_lsp_completion_messages.vader
View File

@@ -190,10 +190,8 @@ Execute(The right message sent to the tsserver LSP when the first completion mes
\ 'source': '/path/to/foo.ts', \ 'source': '/path/to/foo.ts',
\ }, { \ }, {
\ 'name': 'FooBar', \ 'name': 'FooBar',
\ 'source': '',
\ }, { \ }, {
\ 'name': 'frazzle', \ 'name': 'frazzle',
\ 'source': '',
\ }], \ }],
\ 'offset': 1, \ 'offset': 1,
\ 'line': 1, \ 'line': 1,