Fix #924 - Make changing the sign column color work again

This commit is contained in:
w0rp
2017-09-12 21:17:54 +01:00
parent 4e9420d1f5
commit 91df9ba2c0
2 changed files with 36 additions and 12 deletions

View File

@@ -1,4 +1,6 @@
Before:
Save g:ale_change_sign_column_color
function! ParseHighlight(name) abort
redir => l:output
silent execute 'highlight ' . a:name
@@ -20,14 +22,34 @@ Before:
let g:sign_highlight = ParseHighlight('SignColumn')
After:
Restore
delfunction ParseHighlight
call SetHighlight('SignColumn', g:sign_highlight)
delfunction SetHighlight
unlet! g:sign_highlight
sign unplace *
Execute(The SignColumn highlight shouldn't be changed if the option is off):
let g:ale_change_sign_column_color = 0
let b:sign_highlight = ParseHighlight('SignColumn')
call ale#sign#SetSigns(bufnr(''), [
\ {'bufnr': bufnr(''), 'lnum': 1, 'col': 1, 'type': 'W', 'text': 'x'},
\])
AssertEqual b:sign_highlight, ParseHighlight('SignColumn')
call ale#sign#SetSigns(bufnr(''), [])
AssertEqual b:sign_highlight, ParseHighlight('SignColumn')
Execute(The SignColumn highlight should be set and reset):
call ale#sign#SetSignColumnHighlight(1)
let g:ale_change_sign_column_color = 1
call ale#sign#SetSigns(bufnr(''), [
\ {'bufnr': bufnr(''), 'lnum': 1, 'col': 1, 'type': 'W', 'text': 'x'},
\])
AssertEqual 'links to ALESignColumnWithErrors', ParseHighlight('SignColumn')
call ale#sign#SetSignColumnHighlight(0)
call ale#sign#SetSigns(bufnr(''), [])
AssertEqual 'links to ALESignColumnWithoutErrors', ParseHighlight('SignColumn')