VimPlug/ale
1
0
Fork 0
mirror of https://github.com/dense-analysis/ale.git synced 2025-12-06 12:44:23 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

hadolint: multiple fixes and adapt expected format (#3678)

Browse Source 
- Show hadolint rule number in vim gutter in addition to `ALEDetails`
- Capture and show error in case of syntax errors
- Add tests for error capture
- Adapt existing tests

fixes: #2333
fixes: #958
This commit is contained in:
Moritz Röhrich
2021-07-05 14:54:03 +02:00
committed by GitHub
parent af13c350d2
commit 958f30c163
3 changed files with 43 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
test/handler/test_hadolint.vader
View File

@@ -16,34 +16,41 @@ Execute(The hadolint handler should handle a normal example):
\ 'lnum': 1,
\ 'col': 0,
\ 'type': 'W',
\ 'text': "Always tag the version of an image explicitly",
\ 'text': "DL3006: Always tag the version of an image explicitly",
\ 'detail': "DL3006 ( https://github.com/hadolint/hadolint/wiki/DL3006 )\n\nAlways tag the version of an image explicitly",
\ },
# \ {
# \ 'lnum': 2,
# \ 'col': 0,
# \ 'type': 'E',
# \ 'text': "MAINTAINER is deprecated",
# \ 'detail': "DL4000 ( https://github.com/hadolint/hadolint/wiki/DL4000 )\n\nMAINTAINER is deprecated",
# \ },
# \ {
# \ 'lnum': 4,
# \ 'col': 0,
# \ 'type': 'W',
# \ 'text': "Specify version with `yum install -y <package>-<version>`.",
# \ 'detail': "DL3033 ( https://github.com/hadolint/hadolint/wiki/DL3033 )\n\nSpecify version with `yum install -y <package>-<version>`.",
# \ },
# \ {
# \ 'lnum': 12,
# \ 'col': 0,
# \ 'type': 'W',
# \ 'text': "In POSIX sh, brace expansion is undefined.",
# \ 'detail': "SC2039 ( https://github.com/koalaman/shellcheck/wiki/SC2039 )\n\nIn POSIX sh, brace expansion is undefined.",
# \ },
\ {
\ 'lnum': 4,
\ 'col': 0,
\ 'type': 'W',
\ 'text': "DL3033: Specify version with `yum install -y <package>-<version>`.",
\ 'detail': "DL3033 ( https://github.com/hadolint/hadolint/wiki/DL3033 )\n\nSpecify version with `yum install -y <package>-<version>`.",
\ },
\ {
\ 'lnum': 12,
\ 'col': 0,
\ 'type': 'W',
\ 'text': "SC2039: In POSIX sh, brace expansion is undefined.",
\ 'detail': "SC2039 ( https://github.com/koalaman/shellcheck/wiki/SC2039 )\n\nIn POSIX sh, brace expansion is undefined.",
\ },
\ ],
\ ale_linters#dockerfile#hadolint#Handle(bufnr(''), [
\ '/dev/stdin:1 DL3006 warning: Always tag the version of an image explicitly',
# \ '/dev/stdin:2 DL4000 error: MAINTAINER is deprecated',
# \ '/dev/stdin:4 DL3033 warning: Specify version with `yum install -y <package>-<version>`.',
# \ '/dev/stdin:12 SC2039 warning: In POSIX sh, brace expansion is undefined.'
\ '-:1 DL3006 warning: Always tag the version of an image explicitly',
\ '-:4 DL3033 warning: Specify version with `yum install -y <package>-<version>`.',
\ '-:12 SC2039 warning: In POSIX sh, brace expansion is undefined.',
\ ])
Execute(The hadolint handler should handle parsing errors):
AssertEqual
\ [
\ {
\ 'lnum': 1,
\ 'col': 1,
\ 'type': 'E',
\ 'text': "unexpected 'b' expecting '#', ADD, ARG, CMD, COPY, ENTRYPOINT, ENV, EXPOSE, FROM, HEALTHCHECK, LABEL, MAINTAINER, ONBUILD, RUN, SHELL, STOPSIGNAL, USER, VOLUME, WORKDIR, or end of input",
\ 'detail': "hadolint could not parse the file because of a syntax error.",
\ },
\ ],
\ ale_linters#dockerfile#hadolint#Handle(bufnr(''), [
\ '/dev/stdin:1:1 unexpected ''b'' expecting ''#'', ADD, ARG, CMD, COPY, ENTRYPOINT, ENV, EXPOSE, FROM, HEALTHCHECK, LABEL, MAINTAINER, ONBUILD, RUN, SHELL, STOPSIGNAL, USER, VOLUME, WORKDIR, or end of input',
\ ])