Update all Ruby linters to work consistently with bundler

This commit is contained in:
Ryan Rosenblum
2018-09-12 16:53:28 -04:00
parent 78af99c256
commit 9e09b7ca35
12 changed files with 111 additions and 39 deletions
+15 -3
View File
@@ -3,6 +3,14 @@
call ale#Set('ruby_reek_show_context', 0)
call ale#Set('ruby_reek_show_wiki_link', 0)
call ale#Set('ruby_reek_options', '')
call ale#Set('ruby_reek_executable', 'reek')
function! ale_linters#ruby#reek#GetExecutable(buffer) abort
let l:executable = ale#Var(a:buffer, 'ruby_reek_executable')
return ale#handlers#ruby#EscapeExecutable(l:executable, 'reek')
endfunction
function! ale_linters#ruby#reek#VersionCheck(buffer) abort
" If we have previously stored the version number in a cache, then
@@ -12,18 +20,22 @@ function! ale_linters#ruby#reek#VersionCheck(buffer) abort
return ''
endif
return 'reek --version'
let l:executable = ale_linters#ruby#reek#GetExecutable(a:buffer)
return l:executable . ' --version'
endfunction
function! ale_linters#ruby#reek#GetCommand(buffer, version_output) abort
let l:version = ale#semver#GetVersion('reek', a:version_output)
let l:executable = ale_linters#ruby#reek#GetExecutable(a:buffer)
" Tell reek what the filename is if the version of reek is new enough.
let l:display_name_args = ale#semver#GTE(l:version, [5, 0, 0])
\ ? ' --stdin-filename %s'
\ : ''
return 'reek -f json --no-progress --no-color'
return l:executable
\ . ' -f json --no-progress --no-color'
\ . l:display_name_args
endfunction
@@ -62,7 +74,7 @@ endfunction
call ale#linter#Define('ruby', {
\ 'name': 'reek',
\ 'executable': 'reek',
\ 'executable_callback': ale#VarFunc('ruby_reek_executable'),
\ 'command_chain': [
\ {'callback': 'ale_linters#ruby#reek#VersionCheck'},
\ {'callback': 'ale_linters#ruby#reek#GetCommand'},