Update all Ruby linters to work consistently with bundler

This commit is contained in:
Ryan Rosenblum
2018-08-24 11:33:59 -04:00
parent 78af99c256
commit 9e09b7ca35
12 changed files with 111 additions and 39 deletions

View File

@@ -7,8 +7,8 @@ After:
Execute(The reek callbacks should return the correct default values):
WithChainResults ['reek 5.0.0']
AssertLinter 'reek', [
\ 'reek --version',
\ 'reek -f json --no-progress --no-color --stdin-filename %s',
\ ale#Escape('reek') . ' --version',
\ ale#Escape('reek') . ' -f json --no-progress --no-color --stdin-filename %s',
\]
" Try with older versions.
@@ -16,19 +16,35 @@ Execute(The reek callbacks should return the correct default values):
WithChainResults ['reek 4.8.2']
AssertLinter 'reek', [
\ 'reek --version',
\ 'reek -f json --no-progress --no-color',
\ ale#Escape('reek') . ' --version',
\ ale#Escape('reek') . ' -f json --no-progress --no-color',
\]
Execute(Setting bundle appends 'exec reek'):
let g:ale_ruby_reek_executable = 'bundle'
WithChainResults ['reek 5.0.0']
AssertLinter 'bundle', ale#Escape('bundle')
\ . ' exec reek'
\ . ' -f json --no-progress --no-color --stdin-filename %s',
" Try with older versions.
call ale#semver#ResetVersionCache()
WithChainResults ['reek 4.8.2']
AssertLinter 'bundle', ale#Escape('bundle')
\ . ' exec reek'
\ . ' -f json --no-progress --no-color'
Execute(The reek version check should be cached):
WithChainResults ['reek 5.0.0']
AssertLinter 'reek', [
\ 'reek --version',
\ 'reek -f json --no-progress --no-color --stdin-filename %s',
\ ale#Escape('reek') . ' --version',
\ ale#Escape('reek') . ' -f json --no-progress --no-color --stdin-filename %s',
\]
WithChainResults []
AssertLinter 'reek', [
\ '',
\ 'reek -f json --no-progress --no-color --stdin-filename %s',
\ ale#Escape('reek') . ' -f json --no-progress --no-color --stdin-filename %s',
\]