Ban use of ==# or ==? in the codebase, and prefer is# or is? instead

ale_linters/ansible/ansible_lint.vim

@@ -21,8 +21,8 @@ function! ale_linters#ansible#ansible_lint#Handle(buffer, lines) abort
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
         let l:code = l:match[4]
 
-        if (l:code ==# 'EANSIBLE002')
-        \ && !ale#Var(a:buffer, 'warn_about_trailing_whitespace')
+        if l:code is# 'EANSIBLE002'
+        \&& !ale#Var(a:buffer, 'warn_about_trailing_whitespace')
             " Skip warnings for trailing whitespace if the option is off.
             continue
         endif
@@ -32,7 +32,7 @@ function! ale_linters#ansible#ansible_lint#Handle(buffer, lines) abort
             \   'lnum': l:match[2] + 0,
             \   'col': l:match[3] + 0,
             \   'text': l:code . ': ' . l:match[5],
-            \   'type': l:code[:0] ==# 'E' ? 'E' : 'W',
+            \   'type': l:code[:0] is# 'E' ? 'E' : 'W',
             \})
         endif
     endfor

ale_linters/coffee/coffeelint.vim

@@ -27,7 +27,7 @@ function! ale_linters#coffee#coffeelint#Handle(buffer, lines) abort
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
         call add(l:output, {
         \   'lnum': str2nr(l:match[1]),
-        \   'type': l:match[3] ==# 'error' ? 'E' : 'W',
+        \   'type': l:match[3] is# 'error' ? 'E' : 'W',
         \   'text': l:match[4],
         \})
     endfor

ale_linters/d/dmd.vim

@@ -60,7 +60,7 @@ function! ale_linters#d#dmd#Handle(buffer, lines) abort
         call add(l:output, {
         \   'lnum': l:match[1],
         \   'col': l:match[2],
-        \   'type': l:match[3] ==# 'Warning' ? 'W' : 'E',
+        \   'type': l:match[3] is# 'Warning' ? 'W' : 'E',
         \   'text': l:match[4],
         \})
     endfor

ale_linters/dart/dartanalyzer.vim

@@ -22,7 +22,7 @@ function! ale_linters#dart#dartanalyzer#Handle(buffer, lines) abort
 
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
         call add(l:output, {
-        \   'type': l:match[1] ==# 'error' ? 'E' : 'W',
+        \   'type': l:match[1] is# 'error' ? 'E' : 'W',
         \   'text': l:match[6] . ': ' . l:match[2],
         \   'lnum': str2nr(l:match[4]),
         \   'col': str2nr(l:match[5]),

ale_linters/dockerfile/hadolint.vim

@@ -45,9 +45,9 @@ function! ale_linters#dockerfile#hadolint#GetExecutable(buffer) abort
     let l:use_docker = ale#Var(a:buffer, 'dockerfile_hadolint_use_docker')
 
     " check for mandatory directives
-    if l:use_docker ==# 'never'
+    if l:use_docker is# 'never'
         return 'hadolint'
-    elseif l:use_docker ==# 'always'
+    elseif l:use_docker is# 'always'
         return 'docker'
     endif
 
@@ -62,7 +62,7 @@ endfunction
 
 function! ale_linters#dockerfile#hadolint#GetCommand(buffer) abort
     let l:command = ale_linters#dockerfile#hadolint#GetExecutable(a:buffer)
-    if l:command ==# 'docker'
+    if l:command is# 'docker'
         return 'docker run --rm -i ' . ale#Var(a:buffer, 'dockerfile_hadolint_docker_image')
     endif
     return 'hadolint -'

ale_linters/elixir/credo.vim

@@ -11,9 +11,9 @@ function! ale_linters#elixir#credo#Handle(buffer, lines) abort
         let l:type = l:match[3]
         let l:text = l:match[4]
 
-        if l:type ==# 'C'
+        if l:type is# 'C'
             let l:type = 'E'
-        elseif l:type ==# 'R'
+        elseif l:type is# 'R'
             let l:type = 'W'
         endif
 

ale_linters/elixir/dogma.vim

@@ -11,9 +11,9 @@ function! ale_linters#elixir#dogma#Handle(buffer, lines) abort
         let l:type = l:match[3]
         let l:text = l:match[4]
 
-        if l:type ==# 'C'
+        if l:type is# 'C'
             let l:type = 'E'
-        elseif l:type ==# 'R'
+        elseif l:type is# 'R'
             let l:type = 'W'
         endif
 

ale_linters/elm/make.vim

@@ -7,16 +7,16 @@ function! ale_linters#elm#make#Handle(buffer, lines) abort
     let l:temp_dir = l:is_windows ? $TMP : $TMPDIR
     let l:unparsed_lines = []
     for l:line in a:lines
-        if l:line[0] ==# '['
+        if l:line[0] is# '['
             let l:errors = json_decode(l:line)
 
             for l:error in l:errors
                 " Check if file is from the temp directory.
                 " Filters out any errors not related to the buffer.
                 if l:is_windows
-                    let l:file_is_buffer = l:error.file[0:len(l:temp_dir) - 1] ==? l:temp_dir
+                    let l:file_is_buffer = l:error.file[0:len(l:temp_dir) - 1] is? l:temp_dir
                 else
-                    let l:file_is_buffer = l:error.file[0:len(l:temp_dir) - 1] ==# l:temp_dir
+                    let l:file_is_buffer = l:error.file[0:len(l:temp_dir) - 1] is# l:temp_dir
                 endif
 
                 if l:file_is_buffer
@@ -25,7 +25,7 @@ function! ale_linters#elm#make#Handle(buffer, lines) abort
                     \    'col': l:error.region.start.column,
                     \    'end_lnum': l:error.region.end.line,
                     \    'end_col': l:error.region.end.column,
-                    \    'type': (l:error.type ==? 'error') ? 'E' : 'W',
+                    \    'type': (l:error.type is? 'error') ? 'E' : 'W',
                     \    'text': l:error.overview,
                     \    'detail': l:error.overview . "\n\n" . l:error.details
                     \})

ale_linters/erlang/erlc.vim

@@ -27,7 +27,7 @@ function! ale_linters#erlang#erlc#Handle(buffer, lines) abort
     let l:pattern_no_module_definition = '\v(no module definition)$'
     let l:pattern_unused = '\v(.* is unused)$'
 
-    let l:is_hrl = fnamemodify(bufname(a:buffer), ':e') ==# 'hrl'
+    let l:is_hrl = fnamemodify(bufname(a:buffer), ':e') is# 'hrl'
 
     for l:line in a:lines
         let l:match = matchlist(l:line, l:pattern)

ale_linters/fortran/gcc.vim

@@ -44,7 +44,7 @@ function! ale_linters#fortran#gcc#Handle(buffer, lines) abort
 
             " Now we have the text, we can set it and add the error.
             let l:last_loclist_obj.text = l:match[2]
-            let l:last_loclist_obj.type = l:match[1] ==# 'Warning' ? 'W' : 'E'
+            let l:last_loclist_obj.type = l:match[1] is# 'Warning' ? 'W' : 'E'
             call add(l:output, l:last_loclist_obj)
         else
             let l:last_loclist_obj = {

ale_linters/go/gometalinter.vim

@@ -32,7 +32,7 @@ function! ale_linters#go#gometalinter#Handler(buffer, lines) abort
         call add(l:output, {
         \   'lnum': l:match[2] + 0,
         \   'col': l:match[3] + 0,
-        \   'type': tolower(l:match[4]) ==# 'warning' ? 'W' : 'E',
+        \   'type': tolower(l:match[4]) is# 'warning' ? 'W' : 'E',
         \   'text': l:match[5],
         \})
     endfor

ale_linters/haskell/hlint.vim

@@ -5,9 +5,9 @@ function! ale_linters#haskell#hlint#Handle(buffer, lines) abort
     let l:output = []
 
     for l:error in ale#util#FuzzyJSONDecode(a:lines, [])
-        if l:error.severity ==# 'Error'
+        if l:error.severity is# 'Error'
             let l:type = 'E'
-        elseif l:error.severity ==# 'Suggestion'
+        elseif l:error.severity is# 'Suggestion'
             let l:type = 'I'
         else
             let l:type = 'W'

ale_linters/html/tidy.vim

@@ -46,7 +46,7 @@ function! ale_linters#html#tidy#Handle(buffer, lines) abort
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
         let l:line = l:match[1] + 0
         let l:col = l:match[2] + 0
-        let l:type = l:match[3] ==# 'Error' ? 'E' : 'W'
+        let l:type = l:match[3] is# 'Error' ? 'E' : 'W'
         let l:text = l:match[4]
 
         call add(l:output, {

ale_linters/java/javac.vim

@@ -68,14 +68,14 @@ function! ale_linters#java#javac#Handle(buffer, lines) abort
                 let l:output[-1].col = len(l:match[1])
         elseif empty(l:match[3])
             " Add symbols to 'cannot find symbol' errors.
-            if l:output[-1].text ==# 'error: cannot find symbol'
+            if l:output[-1].text is# 'error: cannot find symbol'
                 let l:output[-1].text .= ': ' . l:match[2]
             endif
         else
             call add(l:output, {
             \   'lnum': l:match[1] + 0,
             \   'text': l:match[2] . ':' . l:match[3],
-            \   'type': l:match[2] ==# 'error' ? 'E' : 'W',
+            \   'type': l:match[2] is# 'error' ? 'E' : 'W',
             \})
         endif
     endfor

ale_linters/javascript/flow.vim

@@ -46,7 +46,7 @@ function! s:GetJSONLines(lines) abort
     let l:start_index = 0
 
     for l:line in a:lines
-        if l:line[:0] ==# '{'
+        if l:line[:0] is# '{'
             break
         endif
 
@@ -77,13 +77,13 @@ function! ale_linters#javascript#flow#Handle(buffer, lines) abort
             " In certain cases, `l:message.loc.source` points to a different path
             " than the buffer one, thus we skip this loc information too.
             if has_key(l:message, 'loc')
-            \&& l:line ==# 0
+            \&& l:line is# 0
             \&& ale#path#IsBufferPath(a:buffer, l:message.loc.source)
                 let l:line = l:message.loc.start.line + 0
                 let l:col = l:message.loc.start.column + 0
             endif
 
-            if l:text ==# ''
+            if l:text is# ''
                 let l:text = l:message.descr . ':'
             else
                 let l:text = l:text . ' ' . l:message.descr
@@ -98,7 +98,7 @@ function! ale_linters#javascript#flow#Handle(buffer, lines) abort
         \   'lnum': l:line,
         \   'col': l:col,
         \   'text': l:text,
-        \   'type': l:error.level ==# 'error' ? 'E' : 'W',
+        \   'type': l:error.level is# 'error' ? 'E' : 'W',
         \})
     endfor
 

ale_linters/kotlin/kotlinc.vim

@@ -124,7 +124,7 @@ function! ale_linters#kotlin#kotlinc#Handle(buffer, lines) abort
         if l:buf_abspath !=# l:curbuf_abspath
             continue
         endif
-        let l:type_marker_str = l:type ==# 'warning' ? 'W' : 'E'
+        let l:type_marker_str = l:type is# 'warning' ? 'W' : 'E'
 
         call add(l:output, {
         \   'lnum': l:line,
@@ -145,7 +145,7 @@ function! ale_linters#kotlin#kotlinc#Handle(buffer, lines) abort
         let l:type = l:match[1]
         let l:text = l:match[2]
 
-        let l:type_marker_str = l:type ==# 'warning' || l:type ==# 'info' ? 'W' : 'E'
+        let l:type_marker_str = l:type is# 'warning' || l:type is# 'info' ? 'W' : 'E'
 
         call add(l:output, {
         \   'lnum': 1,

ale_linters/matlab/mlint.vim

@@ -30,7 +30,7 @@ function! ale_linters#matlab#mlint#Handle(buffer, lines) abort
 
         " Suppress erroneous waring about filename
         " TODO: Enable this error when copying filename is supported
-        if l:code ==# 'FNDEF'
+        if l:code is# 'FNDEF'
             continue
         endif
 

ale_linters/nim/nimcheck.vim

@@ -26,7 +26,7 @@ function! ale_linters#nim#nimcheck#Handle(buffer, lines) abort
 
         if len(l:textmatch) > 0
             let l:errortype = l:textmatch[1]
-            if l:errortype ==# 'Error'
+            if l:errortype is# 'Error'
                 let l:type = 'E'
             endif
         endif

ale_linters/perl/perlcritic.vim

@@ -21,7 +21,7 @@ function! ale_linters#perl#perlcritic#GetProfile(buffer) abort
 
     " first see if we've been overridden
     let l:profile = ale#Var(a:buffer, 'perl_perlcritic_profile')
-    if l:profile ==? ''
+    if l:profile is? ''
         return ''
     endif
 

ale_linters/php/phpcs.vim

@@ -40,7 +40,7 @@ function! ale_linters#php#phpcs#Handle(buffer, lines) abort
         \   'lnum': l:match[1] + 0,
         \   'col': l:match[2] + 0,
         \   'text': l:text,
-        \   'type': l:type ==# 'error' ? 'E' : 'W',
+        \   'type': l:type is# 'error' ? 'E' : 'W',
         \})
     endfor
 

ale_linters/python/flake8.vim

@@ -115,7 +115,7 @@ function! ale_linters#python#flake8#Handle(buffer, lines) abort
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
         let l:code = l:match[3]
 
-        if (l:code ==# 'W291' || l:code ==# 'W293')
+        if (l:code is# 'W291' || l:code is# 'W293')
         \ && !ale#Var(a:buffer, 'warn_about_trailing_whitespace')
             " Skip warnings for trailing whitespace if the option is off.
             continue
@@ -128,12 +128,12 @@ function! ale_linters#python#flake8#Handle(buffer, lines) abort
         \   'type': 'W',
         \}
 
-        if l:code[:0] ==# 'F' || l:code ==# 'E999'
+        if l:code[:0] is# 'F' || l:code is# 'E999'
             let l:item.type = 'E'
-        elseif l:code[:0] ==# 'E'
+        elseif l:code[:0] is# 'E'
             let l:item.type = 'E'
             let l:item.sub_type = 'style'
-        elseif l:code[:0] ==# 'W'
+        elseif l:code[:0] is# 'W'
             let l:item.sub_type = 'style'
         endif
 

ale_linters/python/pylint.vim

@@ -31,13 +31,13 @@ function! ale_linters#python#pylint#Handle(buffer, lines) abort
         "let l:failed = append(0, l:match)
         let l:code = l:match[3]
 
-        if (l:code ==# 'C0303')
+        if (l:code is# 'C0303')
         \ && !ale#Var(a:buffer, 'warn_about_trailing_whitespace')
             " Skip warnings for trailing whitespace if the option is off.
             continue
         endif
 
-        if l:code ==# 'I0011'
+        if l:code is# 'I0011'
             " Skip 'Locally disabling' message
              continue
         endif
@@ -46,7 +46,7 @@ function! ale_linters#python#pylint#Handle(buffer, lines) abort
         \   'lnum': l:match[1] + 0,
         \   'col': l:match[2] + 1,
         \   'text': l:code . ': ' . l:match[5] . ' (' . l:match[4] . ')',
-        \   'type': l:code[:0] ==# 'E' ? 'E' : 'W',
+        \   'type': l:code[:0] is# 'E' ? 'E' : 'W',
         \})
     endfor
 

ale_linters/ruby/brakeman.vim

@@ -33,7 +33,7 @@ endfunction
 function! ale_linters#ruby#brakeman#GetCommand(buffer) abort
     let l:rails_root = ale#ruby#FindRailsRoot(a:buffer)
 
-    if l:rails_root ==? ''
+    if l:rails_root is? ''
         return ''
     endif
 

ale_linters/ruby/rails_best_practices.vim

@@ -30,7 +30,7 @@ function! ale_linters#ruby#rails_best_practices#GetCommand(buffer) abort
 
     let l:rails_root = ale#ruby#FindRailsRoot(a:buffer)
 
-    if l:rails_root ==? ''
+    if l:rails_root is? ''
         return ''
     endif
 

ale_linters/ruby/rubocop.vim

@@ -43,9 +43,9 @@ function! ale_linters#ruby#rubocop#Handle(buffer, lines) abort
 endfunction
 
 function! ale_linters#ruby#rubocop#GetType(severity) abort
-    if a:severity ==? 'convention'
-    \|| a:severity ==? 'warning'
-    \|| a:severity ==? 'refactor'
+    if a:severity is? 'convention'
+    \|| a:severity is? 'warning'
+    \|| a:severity is? 'refactor'
         return 'W'
     endif
 

ale_linters/scala/scalac.vim

@@ -38,7 +38,7 @@ function! ale_linters#scala#scalac#Handle(buffer, lines) abort
         endif
 
         let l:text = l:match[3]
-        let l:type = l:match[2] ==# 'error' ? 'E' : 'W'
+        let l:type = l:match[2] is# 'error' ? 'E' : 'W'
         let l:col = 0
 
         if l:ln + 1 < len(a:lines)

ale_linters/scss/scsslint.vim

@@ -19,7 +19,7 @@ function! ale_linters#scss#scsslint#Handle(buffer, lines) abort
         \   'lnum': l:match[1] + 0,
         \   'col': l:match[2] + 0,
         \   'text': l:match[4],
-        \   'type': l:match[3] ==# 'E' ? 'E' : 'W',
+        \   'type': l:match[3] is# 'E' ? 'E' : 'W',
         \})
     endfor
 

ale_linters/sh/shell.vim

@@ -11,7 +11,7 @@ endif
 if !exists('g:ale_sh_shell_default_shell')
     let g:ale_sh_shell_default_shell = fnamemodify($SHELL, ':t')
 
-    if g:ale_sh_shell_default_shell ==# '' || g:ale_sh_shell_default_shell ==# 'fish'
+    if g:ale_sh_shell_default_shell is# '' || g:ale_sh_shell_default_shell is# 'fish'
         let g:ale_sh_shell_default_shell = 'bash'
     endif
 endif

ale_linters/sml/smlnj.vim

@@ -29,7 +29,7 @@ function! ale_linters#sml#smlnj#Handle(buffer, lines) abort
           \   'bufnr': a:buffer,
           \   'lnum': l:match[1] + 0,
           \   'text': l:match[2] . ': ' . l:match[3],
-          \   'type': l:match[2] ==# 'error' ? 'E' : 'W',
+          \   'type': l:match[2] is# 'error' ? 'E' : 'W',
           \})
           continue
         endif

ale_linters/tcl/nagelfar.vim

@@ -28,7 +28,7 @@ function! ale_linters#tcl#nagelfar#Handle(buffer, lines) abort
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
         call add(l:output, {
         \   'lnum': l:match[1] + 0,
-        \   'type': l:match[2] ==# 'N' ? 'W' : l:match[2],
+        \   'type': l:match[2] is# 'N' ? 'W' : l:match[2],
         \   'text': l:match[3],
         \})
     endfor

ale_linters/typescript/tslint.vim

@@ -17,7 +17,7 @@ function! ale_linters#typescript#tslint#Handle(buffer, lines) abort
     for l:error in ale#util#FuzzyJSONDecode(a:lines, [])
         if ale#path#IsBufferPath(a:buffer, l:error.name)
             call add(l:output, {
-            \   'type': (get(l:error, 'ruleSeverity', '') ==# 'WARNING' ? 'W' : 'E'),
+            \   'type': (get(l:error, 'ruleSeverity', '') is# 'WARNING' ? 'W' : 'E'),
             \   'text': l:error.failure,
             \   'lnum': l:error.startPosition.line + 1,
             \   'col': l:error.startPosition.character + 1,

ale_linters/verilog/iverilog.vim

@@ -14,7 +14,7 @@ function! ale_linters#verilog#iverilog#Handle(buffer, lines) abort
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
         let l:line = l:match[1] + 0
         let l:type = l:match[2] =~# 'error' ? 'E' : 'W'
-        let l:text = l:match[2] ==# 'syntax error' ? 'syntax error' : l:match[4]
+        let l:text = l:match[2] is# 'syntax error' ? 'syntax error' : l:match[4]
 
         call add(l:output, {
         \   'lnum': l:line,

ale_linters/verilog/verilator.vim

@@ -33,7 +33,7 @@ function! ale_linters#verilog#verilator#Handle(buffer, lines) abort
 
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
         let l:line = l:match[3] + 0
-        let l:type = l:match[1] ==# 'Error' ? 'E' : 'W'
+        let l:type = l:match[1] is# 'Error' ? 'E' : 'W'
         let l:text = l:match[4]
         let l:file = l:match[2]
 

ale_linters/yaml/swaglint.vim

@@ -21,7 +21,7 @@ function! ale_linters#yaml#swaglint#Handle(buffer, lines) abort
 
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
         let l:obj = {
-        \   'type': l:match[1] ==# 'error' ? 'E' : 'W',
+        \   'type': l:match[1] is# 'error' ? 'E' : 'W',
         \   'lnum': l:match[2] + 0,
         \   'col': l:match[3] + 0,
         \   'text': l:match[4],

ale_linters/yaml/yamllint.vim

@@ -33,7 +33,7 @@ function! ale_linters#yaml#yamllint#Handle(buffer, lines) abort
         \   'lnum': l:line,
         \   'col': l:col,
         \   'text': l:text,
-        \   'type': l:type ==# 'error' ? 'E' : 'W',
+        \   'type': l:type is# 'error' ? 'E' : 'W',
         \})
     endfor