VimPlug/ale
1
0
Fork 0
mirror of https://github.com/dense-analysis/ale.git synced 2025-12-23 04:21:26 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

pylama: Use %s instead of %t

Browse Source 
Although using %t to lint changes was desirable, many pylama checks use
surrounding paths and file contents (e.g. C0103 module name, E0402
relative import beyond top, etc.)  The more such errors I find during
testing, the less %t seems like a good idea.  Switch to %s.

Also set `lint_file` to 1 and mark Pylama as a file linter in the docs.

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
This commit is contained in:
Kevin Locke
2019-02-10 20:37:13 -07:00
parent bf196ba17c
commit a6caa85a58
5 changed files with 8 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
test/handler/test_pylama_handler.vader
View File

@@ -191,22 +191,3 @@ Execute(The pylama handler should handle message codes followed by a colon):
\ ale_linters#python#pylama#Handle(bufnr(''), [
\ 'index.py:31:1: E800: Found commented out code: # needs_sphinx = ''1.0'' [eradicate]',
\ ])
" The directory created for %t may not comply with pylint module name config.
" This should not be reported to users.
Execute(The pylama handler should ignore C0103 from temp dir, not others):
AssertEqual
\ [
\ {
\ 'lnum': 29,
\ 'col': 0,
\ 'code': 'C0103',
\ 'type': 'W',
\ 'sub_type': 'style',
\ 'text': 'Constant name "badname" doesn''t conform to UPPER_CASE naming style [pylint]',
\ },
\ ],
\ ale_linters#python#pylama#Handle(bufnr(''), [
\ '../../../../tmp/vmynR33/456/__init__.py:1:0: C0103 Module name "456" doesn''t conform to snake_case naming style [pylint]',
\ '../../../../tmp/vmynR33/456/__init__.py:29:0: C0103 Constant name "badname" doesn''t conform to UPPER_CASE naming style [pylint]',
\ ])