VimPlug/ale
1
0
Fork 0
mirror of https://github.com/dense-analysis/ale.git synced 2025-12-06 20:54:26 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use rubocop's JSON output format (resolves #339) (#738)

Browse Source 
* Use rubocop's JSON output format (resolves #339)

Rubocop's emacs formatter seems to have changed format in some
not-so-ancient version. The JSON formatter should provide a more stable
interface than parsing lines with a regex.

The JSON formatter was introduced in mid-2013, so it should be safe to
assume available in any reasonably-modern environment. The oldest
currently-supported version of ruby (according to ruby-lang.org) was
not supported by rubocop until 2014.

* Rubocop: Use global function for GetType

* Rubocop: Use scope prefix in GetType

* Rubocop: Update command_callback test

* Rubocop: add end_col to Handle
This commit is contained in:
Eddie Lebow
2017-07-09 10:48:04 -04:00
committed by w0rp
parent 836a2cfe3b
commit ab0e76dbd5
3 changed files with 41 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/command_callback/test_rubocop_command_callback.vader
View File

@@ -3,17 +3,17 @@ Before:
Execute(Executable should default to rubocop):
AssertEqual
\ '''rubocop'' --format emacs --force-exclusion --stdin ''dummy.py''',
\ '''rubocop'' --format json --force-exclusion --stdin ''dummy.py''',
\ ale_linters#ruby#rubocop#GetCommand(bufnr(''))
Execute(Should be able to set a custom executable):
let g:ale_ruby_rubocop_executable = 'bin/rubocop'
AssertEqual
\ '''bin/rubocop'' --format emacs --force-exclusion --stdin ''dummy.py''',
\ '''bin/rubocop'' --format json --force-exclusion --stdin ''dummy.py''',
\ ale_linters#ruby#rubocop#GetCommand(bufnr(''))
Execute(Setting bundle appends 'exec rubocop'):
let g:ale_ruby_rubocop_executable = 'path to/bundle'
AssertEqual
\ '''path to/bundle'' exec rubocop --format emacs --force-exclusion --stdin ''dummy.py''',
\ '''path to/bundle'' exec rubocop --format json --force-exclusion --stdin ''dummy.py''',
\ ale_linters#ruby#rubocop#GetCommand(bufnr(''))