#1151 - Overhaul the foodcritic linter for checking files on disk

test/command_callback/test_foodcritic_command_callback.vader

@@ -0,0 +1,44 @@
+Before:
+  Save g:ale_chef_foodcritic_executable
+  Save g:ale_chef_foodcritic_options
+
+  unlet! g:ale_chef_foodcritic_executable
+  unlet! g:ale_chef_foodcritic_options
+
+  call ale#test#SetDirectory('/testplugin/test')
+
+  runtime ale_linters/chef/foodcritic.vim
+
+After:
+  Restore
+
+  unlet! b:ale_chef_foodcritic_executable
+  unlet! b:ale_chef_foodcritic_options
+
+  call ale#test#RestoreDirectory()
+  call ale#linter#Reset()
+
+Execute(The default command should be correct):
+  AssertEqual
+  \ 'foodcritic',
+  \ ale_linters#chef#foodcritic#GetExecutable(bufnr(''))
+  AssertEqual
+  \ ale#Escape('foodcritic') . ' %s',
+  \ ale_linters#chef#foodcritic#GetCommand(bufnr(''))
+
+Execute(Extra options should be included with escapeed tildes (~)):
+  let b:ale_chef_foodcritic_options = '-t ~F011'
+
+  AssertEqual
+  \ ale#Escape('foodcritic') . ' -t \~F011 %s',
+  \ ale_linters#chef#foodcritic#GetCommand(bufnr(''))
+
+Execute(The executable should be configurable):
+  let b:ale_chef_foodcritic_executable = 'foobar'
+
+  AssertEqual
+  \ 'foobar',
+  \ ale_linters#chef#foodcritic#GetExecutable(bufnr(''))
+  AssertEqual
+  \ ale#Escape('foobar') . ' %s',
+  \ ale_linters#chef#foodcritic#GetCommand(bufnr(''))

test/handler/test_foodcritic_handler.vader

@@ -0,0 +1,44 @@
+Before:
+  runtime ale_linters/chef/foodcritic.vim
+
+After:
+  call ale#linter#Reset()
+
+Execute(Basic warnings should be handled):
+  AssertEqual
+  \ [
+  \   {
+  \     'lnum': 1,
+  \     'code': 'CINK001',
+  \     'type': 'W',
+  \     'text': 'Missing CHANGELOG in markdown format',
+  \     'filename': '/foo/bar/CHANGELOG.md',
+  \   },
+  \   {
+  \     'lnum': 1,
+  \     'code': 'FC011',
+  \     'type': 'W',
+  \     'text': 'Missing README in markdown format',
+  \     'filename': '/foo/bar/README.md',
+  \   },
+  \   {
+  \     'lnum': 1,
+  \     'code': 'FC031',
+  \     'type': 'W',
+  \     'text': 'Cookbook without metadata.rb file',
+  \     'filename': '/foo/bar/metadata.rb',
+  \   },
+  \   {
+  \     'lnum': 1,
+  \     'code': 'FC071',
+  \     'type': 'W',
+  \     'text': 'Missing LICENSE file',
+  \     'filename': '/foo/bar/LICENSE',
+  \   },
+  \ ],
+  \ ale_linters#chef#foodcritic#Handle(bufnr(''), [
+  \   'CINK001: Missing CHANGELOG in markdown format: /foo/bar/CHANGELOG.md:1',
+  \   'FC011: Missing README in markdown format: /foo/bar/README.md:1',
+  \   'FC031: Cookbook without metadata.rb file: /foo/bar/metadata.rb:1',
+  \   'FC071: Missing LICENSE file: /foo/bar/LICENSE:1',
+  \ ])

test/test_foodcritic_command_callback.vader

@@ -1,18 +0,0 @@
-Before:
-  let g:ale_chef_foodcritic_options = '-t ~F011'
-  let g:ale_chef_foodcritic_executable = 'foodcritic'
-
-  call ale#test#SetDirectory('/testplugin/test')
-  runtime ale_linters/chef/foodcritic.vim
-
-After:
-  let g:ale_chef_foodcritic_options = ''
-  let g:ale_chef_foodcritic_executable = ''
-
-  call ale#test#RestoreDirectory()
-  call ale#linter#Reset()
-
-Execute(command line should be assembled correctly):
-  AssertEqual
-  \ 'foodcritic -t \~F011 %t',
-  \ ale_linters#chef#foodcritic#GetCommand(bufnr(''))