VimPlug/ale
1
0
Fork 0
mirror of https://github.com/dense-analysis/ale.git synced 2026-01-10 05:22:31 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add an option for ignoring the output of TSLint if a file contains a single blank line

Browse Source
This commit is contained in:
w0rp
2017-09-06 11:17:21 +01:00
parent ad1bd424fa
commit c277cdef8c
3 changed files with 138 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

119
test/handler/test_tslint_handler.vader
View File

@@ -1,9 +1,18 @@
Before:
Save g:ale_typescript_tslint_ignore_empty_files
unlet! g:ale_typescript_tslint_ignore_empty_files
unlet! b:ale_typescript_tslint_ignore_empty_files
runtime ale_linters/typescript/tslint.vim
call ale#test#SetDirectory('/testplugin/test/handler')
After:
Restore
unlet! b:ale_typescript_tslint_ignore_empty_files
call ale#test#RestoreDirectory()
call ale#linter#Reset()
@@ -133,3 +142,113 @@ Execute(The tslint handler should handle empty output):
AssertEqual
\ [],
\ ale_linters#typescript#tslint#Handle(bufnr(''), [])
Execute(The tslint handler report errors for empty files by default):
call ale#test#SetFilename('app/test.ts')
AssertEqual
\ [
\ {
\ 'lnum': 2,
\ 'col': 1,
\ 'filename': expand('%:p:h') . '/test.ts',
\ 'end_lnum': 2,
\ 'type': 'E',
\ 'end_col': 1,
\ 'text': 'no-consecutive-blank-lines: Consecutive blank lines are forbidden',
\ },
\ ],
\ ale_linters#typescript#tslint#Handle(bufnr(''), [json_encode([{
\ 'endPosition': {
\ 'character': 0,
\ 'line': 1,
\ 'position': 1
\ },
\ 'failure': 'Consecutive blank lines are forbidden',
\ 'fix': [{
\ 'innerStart': 0,
\ 'innerLength': 1,
\ 'innerText': ''
\ }],
\ 'name': 'test.ts',
\ 'ruleName': 'no-consecutive-blank-lines',
\ 'ruleSeverity': 'ERROR',
\ 'startPosition': {
\ 'character': 0,
\ 'line': 1,
\ 'position': 1
\ }
\ }])])
Execute(The tslint handler should not report errors for empty files when the ignore option is on):
let b:ale_typescript_tslint_ignore_empty_files = 1
call ale#test#SetFilename('app/test.ts')
AssertEqual
\ [
\ ],
\ ale_linters#typescript#tslint#Handle(bufnr(''), [json_encode([{
\ 'endPosition': {
\ 'character': 0,
\ 'line': 1,
\ 'position': 1
\ },
\ 'failure': 'Consecutive blank lines are forbidden',
\ 'fix': [{
\ 'innerStart': 0,
\ 'innerLength': 1,
\ 'innerText': ''
\ }],
\ 'name': 'test.ts',
\ 'ruleName': 'no-consecutive-blank-lines',
\ 'ruleSeverity': 'ERROR',
\ 'startPosition': {
\ 'character': 0,
\ 'line': 1,
\ 'position': 1
\ }
\ }])])
Given typescript(A file with extra blank lines):
const x = 3
const y = 4
Execute(The tslint handler should report errors when the ignore option is on, but the file is not empty):
let b:ale_typescript_tslint_ignore_empty_files = 1
call ale#test#SetFilename('app/test.ts')
AssertEqual
\ [
\ {
\ 'lnum': 2,
\ 'col': 1,
\ 'filename': expand('%:p:h') . '/test.ts',
\ 'end_lnum': 2,
\ 'type': 'E',
\ 'end_col': 1,
\ 'text': 'no-consecutive-blank-lines: Consecutive blank lines are forbidden',
\ },
\ ],
\ ale_linters#typescript#tslint#Handle(bufnr(''), [json_encode([{
\ 'endPosition': {
\ 'character': 0,
\ 'line': 1,
\ 'position': 1
\ },
\ 'failure': 'Consecutive blank lines are forbidden',
\ 'fix': [{
\ 'innerStart': 0,
\ 'innerLength': 1,
\ 'innerText': ''
\ }],
\ 'name': 'test.ts',
\ 'ruleName': 'no-consecutive-blank-lines',
\ 'ruleSeverity': 'ERROR',
\ 'startPosition': {
\ 'character': 0,
\ 'line': 1,
\ 'position': 1
\ }
\ }])])