Do not save for ALERename and ALEOrganizeImports

autoload/ale/code_action.vim

@@ -1,7 +1,7 @@
 " Author: Jerko Steiner <jerko.steiner@gmail.com>
 " Description: Code action support for LSP / tsserver
 
-function! ale#code_action#HandleCodeAction(code_action) abort
+function! ale#code_action#HandleCodeAction(code_action, should_save) abort
     let l:current_buffer = bufnr('')
     let l:changes = a:code_action.changes
 
@@ -17,11 +17,14 @@ function! ale#code_action#HandleCodeAction(code_action) abort
 
     for l:file_code_edit in l:changes
         call ale#code_action#ApplyChanges(
-        \ l:file_code_edit.fileName, l:file_code_edit.textChanges)
+        \ l:file_code_edit.fileName,
+        \ l:file_code_edit.textChanges,
+        \ a:should_save,
+        \ )
     endfor
 endfunction
 
-function! ale#code_action#ApplyChanges(filename, changes) abort
+function! ale#code_action#ApplyChanges(filename, changes, should_save) abort
     let l:current_buffer = bufnr('')
     " The buffer is used to determine the fileformat, if available.
     let l:buffer = bufnr(a:filename)
@@ -106,10 +109,17 @@ function! ale#code_action#ApplyChanges(filename, changes) abort
         call remove(l:lines, -1)
     endif
 
-    call ale#util#Writefile(l:buffer, l:lines, a:filename)
+    if a:should_save
+        call ale#util#Writefile(l:buffer, l:lines, a:filename)
+    else
+        call ale#fix#SetBufferContents(l:buffer, l:lines)
+    endif
 
     if l:is_current_buffer
-        call ale#util#Execute(':e!')
+        if a:should_save
+            call ale#util#Execute(':e!')
+        endif
+
         call setpos('.', [0, l:pos[0], l:pos[1], 0])
     endif
 endfunction

autoload/ale/completion.vim

@@ -739,7 +739,7 @@ function! ale#completion#HandleUserData(completed_item) abort
     endif
 
     for l:code_action in get(l:user_data, 'codeActions', [])
-        call ale#code_action#HandleCodeAction(l:code_action)
+        call ale#code_action#HandleCodeAction(l:code_action, v:false)
     endfor
 endfunction
 

autoload/ale/fix.vim

@@ -4,40 +4,15 @@ call ale#Set('fix_on_save_ignore', {})
 " Vim doesn't let you modify hidden buffers.
 function! ale#fix#ApplyQueuedFixes(buffer) abort
     let l:data = get(g:ale_fix_buffer_data, a:buffer, {'done': 0})
-    let l:has_bufline_api = exists('*deletebufline') && exists('*setbufline')
 
-    if !l:data.done || (!l:has_bufline_api && a:buffer isnot bufnr(''))
+    if !l:data.done
         return
     endif
 
     call remove(g:ale_fix_buffer_data, a:buffer)
 
     if l:data.changes_made
-        " If the file is in DOS mode, we have to remove carriage returns from
-        " the ends of lines before calling setline(), or we will see them
-        " twice.
-        let l:new_lines = getbufvar(a:buffer, '&fileformat') is# 'dos'
-        \   ? map(copy(l:data.output), 'substitute(v:val, ''\r\+$'', '''', '''')')
-        \   : l:data.output
-        let l:first_line_to_remove = len(l:new_lines) + 1
-
-        " Use a Vim API for setting lines in other buffers, if available.
-        if l:has_bufline_api
-            call setbufline(a:buffer, 1, l:new_lines)
-            call deletebufline(a:buffer, l:first_line_to_remove, '$')
-        " Fall back on setting lines the old way, for the current buffer.
-        else
-            let l:old_line_length = len(l:data.lines_before)
-
-            if l:old_line_length >= l:first_line_to_remove
-                let l:save = winsaveview()
-                silent execute
-                \   l:first_line_to_remove . ',' . l:old_line_length . 'd_'
-                call winrestview(l:save)
-            endif
-
-            call setline(1, l:new_lines)
-        endif
+        let l:new_lines = ale#fix#SetBufferContents(a:buffer, l:data.output)
 
         if l:data.should_save
             if a:buffer is bufnr('')
@@ -71,6 +46,43 @@ function! ale#fix#ApplyQueuedFixes(buffer) abort
     endif
 endfunction
 
+" Sets buffer contents to lines
+function! ale#fix#SetBufferContents(buffer, lines) abort
+    let l:has_bufline_api = exists('*deletebufline') && exists('*setbufline')
+
+    if !l:has_bufline_api && a:buffer isnot bufnr('')
+        return
+    endif
+
+    " If the file is in DOS mode, we have to remove carriage returns from
+    " the ends of lines before calling setline(), or we will see them
+    " twice.
+    let l:new_lines = getbufvar(a:buffer, '&fileformat') is# 'dos'
+    \   ? map(copy(a:lines), 'substitute(v:val, ''\r\+$'', '''', '''')')
+    \   : a:lines
+    let l:first_line_to_remove = len(l:new_lines) + 1
+
+    " Use a Vim API for setting lines in other buffers, if available.
+    if l:has_bufline_api
+        call setbufline(a:buffer, 1, l:new_lines)
+        call deletebufline(a:buffer, l:first_line_to_remove, '$')
+    " Fall back on setting lines the old way, for the current buffer.
+    else
+        let l:old_line_length = line('$')
+
+        if l:old_line_length >= l:first_line_to_remove
+            let l:save = winsaveview()
+            silent execute
+            \   l:first_line_to_remove . ',' . l:old_line_length . 'd_'
+            call winrestview(l:save)
+        endif
+
+        call setline(1, l:new_lines)
+    endif
+
+    return l:new_lines
+endfunction
+
 function! ale#fix#ApplyFixes(buffer, output) abort
     let l:data = g:ale_fix_buffer_data[a:buffer]
     let l:data.output = a:output

autoload/ale/organize_imports.vim

@@ -15,7 +15,7 @@ function! ale#organize_imports#HandleTSServerResponse(conn_id, response) abort
     call ale#code_action#HandleCodeAction({
     \   'description': 'Organize Imports',
     \   'changes': l:file_code_edits,
-    \})
+    \}, v:false)
 endfunction
 
 function! s:OnReady(linter, lsp_details) abort

autoload/ale/rename.vim

@@ -80,7 +80,7 @@ function! ale#rename#HandleTSServerResponse(conn_id, response) abort
     call ale#code_action#HandleCodeAction({
     \ 'description': 'rename',
     \ 'changes': l:changes,
-    \})
+    \}, v:true)
 endfunction
 
 function! ale#rename#HandleLSPResponse(conn_id, response) abort
@@ -134,7 +134,7 @@ function! ale#rename#HandleLSPResponse(conn_id, response) abort
         call ale#code_action#HandleCodeAction({
         \   'description': 'rename',
         \   'changes': l:changes,
-        \})
+        \}, v:true)
     endif
 endfunction