Use explicit scope in the ale core, as advised by vint -s

This commit is contained in:
Bjorn Neergaard
2016-10-10 18:00:09 -05:00
parent 9a519684f2
commit ca4badfb3a
8 changed files with 186 additions and 188 deletions

View File

@@ -9,32 +9,32 @@ function! ale#linter#Define(filetype, linter) abort
let s:linters[a:filetype] = []
endif
let new_linter = {
let l:new_linter = {
\ 'name': a:linter.name,
\ 'callback': a:linter.callback,
\}
if has_key(a:linter, 'executable_callback')
let new_linter.executable_callback = a:linter.executable_callback
let l:new_linter.executable_callback = a:linter.executable_callback
else
let new_linter.executable = a:linter.executable
let l:new_linter.executable = a:linter.executable
endif
if has_key(a:linter, 'command_callback')
let new_linter.command_callback = a:linter.command_callback
let l:new_linter.command_callback = a:linter.command_callback
else
let new_linter.command = a:linter.command
let l:new_linter.command = a:linter.command
endif
if has_key(a:linter, 'output_stream')
let new_linter.output_stream = a:linter.output_stream
let l:new_linter.output_stream = a:linter.output_stream
else
let new_linter.output_stream = 'stdout'
let l:new_linter.output_stream = 'stdout'
endif
" TODO: Assert the value of the output_stream to be something sensible.
call add(s:linters[a:filetype], new_linter)
call add(s:linters[a:filetype], l:new_linter)
endfunction
function! ale#linter#Get(filetype) abort
@@ -50,8 +50,8 @@ function! ale#linter#Get(filetype) abort
if has_key(g:ale_linters, a:filetype)
" Filter loaded linters according to list of linters specified in option.
for linter in g:ale_linters[a:filetype]
execute 'runtime! ale_linters/' . a:filetype . '/' . linter . '.vim'
for l:linter in g:ale_linters[a:filetype]
execute 'runtime! ale_linters/' . a:filetype . '/' . l:linter . '.vim'
endfor
else
execute 'runtime! ale_linters/' . a:filetype . '/*.vim'