#1497 Tolerate important ALE variables being undefined for some reason when viewing buffers like git commits

This commit is contained in:
w0rp
2018-04-12 20:31:33 +01:00
parent 0e4a7a7187
commit d1224a05c4
3 changed files with 29 additions and 12 deletions

View File

@@ -1,11 +1,13 @@
Before:
Save g:ale_filetype_blacklist
runtime autoload/ale.vim
" Delete some variable which should be defined.
unlet! g:ale_filetype_blacklist
" Replace one of the key ALE functions and make it throw.
function! ale#FileTooLarge() abort
throw 'broken'
endfunction
After:
Restore
runtime autoload/ale.vim
call ale#ResetErrorDelays()

View File

@@ -1,4 +1,7 @@
Before:
Save g:ale_filetype_blacklist
Save g:ale_maximum_file_size
Save g:ale_enabled
Save &l:statusline
call ale#test#SetDirectory('/testplugin/test')
@@ -12,6 +15,8 @@ Before:
endif
After:
Restore
call ale#test#RestoreDirectory()
if b:funky_command_created
@@ -21,8 +26,6 @@ After:
unlet! b:funky_command_created
Restore
Execute(ALE shouldn't do much of anything for ctrlp-funky buffers):
Assert !ale#ShouldDoNothing(bufnr('')), 'The preliminary check failed'
@@ -39,3 +42,11 @@ Execute(ALE shouldn't try to check buffers with '.' as the filename):
silent! noautocmd file .
Assert ale#ShouldDoNothing(bufnr(''))
Execute(The DoNothing check should work if the ALE globals aren't defined):
unlet! g:ale_filetype_blacklist
unlet! g:ale_maximum_file_size
unlet! g:ale_enabled
" This shouldn't throw exceptions.
call ale#ShouldDoNothing(bufnr(''))