VimPlug/ale
1
0
Fork 0
mirror of https://github.com/dense-analysis/ale.git synced 2026-09-03 13:26:58 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(lsp): check completionProvider key existence, not emptiness (#5157)
CI / Build (push) Canceled after 0s
Details
CI / Neovim 0.10 Windows (push) Canceled after 0s
Details
CI / Neovim 0.12 Windows (push) Canceled after 0s
Details
CI / Vim 8.2 Windows (push) Canceled after 0s
Details
CI / Vim 9.2 Windows (push) Canceled after 0s
Details
CI / Lint (push) Canceled after 0s
Details
CI / Lua (push) Canceled after 0s
Details
CI / Neovim 0.10 Linux (push) Canceled after 0s
Details
CI / Neovim 0.12 Linux (push) Canceled after 0s
Details
CI / Vim 8.2 Linux (push) Canceled after 0s
Details
CI / Vim 9.2 Linux (push) Canceled after 0s
Details

Browse Source 
completionProvider: {} is valid per the LSP spec (means completion
enabled with default options). The old !empty() check incorrectly
rejected empty objects, causing ALE to silently disable completion
for servers that send completionProvider: {}.
This commit is contained in:
Johan
2026-08-21 11:38:28 +09:00
committed by GitHub
parent eff718bee9
commit e1789bc544
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
autoload/ale/lsp.vim
+3 -1
View File
@@ -265,7 +265,9 @@ function! ale#lsp#UpdateCapabilities(conn_id, capabilities) abort
let l:conn.capabilities.code_actions = 1 let l:conn.capabilities.code_actions = 1
endif endif
if !empty(get(a:capabilities, 'completionProvider')) let l:completion = get(a:capabilities, 'completionProvider', v:false)
if type(l:completion) is v:t_dict || l:completion is v:true
let l:conn.capabilities.completion = 1 let l:conn.capabilities.completion = 1
endif endif