Enable gopls by default with GOPATH detection

ale_linters/css/stylelint.vim

@@ -11,7 +11,7 @@ endfunction
 
 call ale#linter#Define('css', {
 \   'name': 'stylelint',
-\   'executable': {b -> ale#node#FindExecutable(b, 'css_stylelint', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'css_stylelint', [
 \       'node_modules/.bin/stylelint',
 \   ])},
 \   'command': function('ale_linters#css#stylelint#GetCommand'),

ale_linters/elm/elm_ls.vim

@@ -28,7 +28,7 @@ endfunction
 call ale#linter#Define('elm', {
 \   'name': 'elm_ls',
 \   'lsp': 'stdio',
-\   'executable': {b -> ale#node#FindExecutable(b, 'elm_ls', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'elm_ls', [
 \       'node_modules/.bin/elm-language-server',
 \       'node_modules/.bin/elm-lsp',
 \       'elm-lsp'

ale_linters/elm/make.vim

@@ -202,7 +202,7 @@ function! ale_linters#elm#make#GetCommand(buffer) abort
     " elm-test needs to know the path of elm-make if elm isn't installed globally.
     " https://github.com/rtfeldman/node-test-runner/blob/57728f10668f2d2ab3179e7e3208bcfa9a1f19aa/README.md#--compiler
     if l:is_v19 && l:is_using_elm_test
-        let l:elm_make_executable = ale#node#FindExecutable(a:buffer, 'elm_make', ['node_modules/.bin/elm'])
+        let l:elm_make_executable = ale#path#FindExecutable(a:buffer, 'elm_make', ['node_modules/.bin/elm'])
         let l:elm_test_compiler_flag = ' --compiler ' . l:elm_make_executable . ' '
     else
         let l:elm_test_compiler_flag = ' '
@@ -222,13 +222,13 @@ function! ale_linters#elm#make#GetExecutable(buffer) abort
     let l:is_v19 = ale_linters#elm#make#IsVersionGte19(a:buffer)
 
     if l:is_test && l:is_v19
-        return ale#node#FindExecutable(
+        return ale#path#FindExecutable(
         \   a:buffer,
         \   'elm_make',
         \   ['node_modules/.bin/elm-test', 'node_modules/.bin/elm']
         \)
     else
-        return ale#node#FindExecutable(a:buffer, 'elm_make', ['node_modules/.bin/elm'])
+        return ale#path#FindExecutable(a:buffer, 'elm_make', ['node_modules/.bin/elm'])
     endif
 endfunction
 

ale_linters/go/gopls.vim

@@ -5,6 +5,21 @@
 call ale#Set('go_gopls_executable', 'gopls')
 call ale#Set('go_gopls_options', '--mode stdio')
 call ale#Set('go_gopls_init_options', {})
+call ale#Set('go_gopls_use_global', get(g:, 'ale_use_global_executables', 0))
+
+function! s:GetGoPathExecutable(suffix) abort
+    let l:prefix = $GOPATH
+
+    if !empty($GOPATH)
+        let l:prefix = $GOPATH
+    elseif has('win32')
+        let l:prefix = $USERPROFILE . '/go'
+    else
+        let l:prefix = $HOME . '/go'
+    endif
+
+    return ale#path#Simplify(l:prefix . '/' . a:suffix)
+endfunction
 
 function! ale_linters#go#gopls#GetCommand(buffer) abort
     return ale#go#EnvString(a:buffer)
@@ -29,7 +44,9 @@ endfunction
 call ale#linter#Define('go', {
 \   'name': 'gopls',
 \   'lsp': 'stdio',
-\   'executable': {b -> ale#Var(b, 'go_gopls_executable')},
+\   'executable': {b -> ale#path#FindExecutable(b, 'go_gopls', [
+\       s:GetGoPathExecutable('bin/gopls'),
+\   ])},
 \   'command': function('ale_linters#go#gopls#GetCommand'),
 \   'project_root': function('ale_linters#go#gopls#FindProjectRoot'),
 \   'initialization_options': {b -> ale#Var(b, 'go_gopls_init_options')},

ale_linters/handlebars/embertemplatelint.vim

@@ -5,7 +5,7 @@ call ale#Set('handlebars_embertemplatelint_executable', 'ember-template-lint')
 call ale#Set('handlebars_embertemplatelint_use_global', get(g:, 'ale_use_global_executables', 0))
 
 function! ale_linters#handlebars#embertemplatelint#GetExecutable(buffer) abort
-    return ale#node#FindExecutable(a:buffer, 'handlebars_embertemplatelint', [
+    return ale#path#FindExecutable(a:buffer, 'handlebars_embertemplatelint', [
     \   'node_modules/.bin/ember-template-lint',
     \])
 endfunction

ale_linters/html/angular.vim

@@ -11,7 +11,7 @@ function! ale_linters#html#angular#GetProjectRoot(buffer) abort
 endfunction
 
 function! ale_linters#html#angular#GetExecutable(buffer) abort
-    return ale#node#FindExecutable(a:buffer, 'html_angular', [
+    return ale#path#FindExecutable(a:buffer, 'html_angular', [
     \   'node_modules/@angular/language-server/bin/ngserver',
     \   'node_modules/@angular/language-server/index.js',
     \])

ale_linters/html/htmlhint.vim

@@ -24,7 +24,7 @@ endfunction
 
 call ale#linter#Define('html', {
 \   'name': 'htmlhint',
-\   'executable': {b -> ale#node#FindExecutable(b, 'html_htmlhint', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'html_htmlhint', [
 \       'node_modules/.bin/htmlhint',
 \   ])},
 \   'command': function('ale_linters#html#htmlhint#GetCommand'),

ale_linters/html/stylelint.vim

@@ -5,7 +5,7 @@ call ale#Set('html_stylelint_options', '')
 call ale#Set('html_stylelint_use_global', 0)
 
 function! ale_linters#html#stylelint#GetExecutable(buffer) abort
-    return ale#node#FindExecutable(a:buffer, 'html_stylelint', [
+    return ale#path#FindExecutable(a:buffer, 'html_stylelint', [
     \   'node_modules/.bin/stylelint',
     \])
 endfunction

ale_linters/ink/ls.vim

@@ -6,7 +6,7 @@ call ale#Set('ink_ls_use_global', get(g:, 'ale_use_global_executables', 0))
 call ale#Set('ink_ls_initialization_options', {})
 
 function! ale_linters#ink#ls#GetExecutable(buffer) abort
-    return ale#node#FindExecutable(a:buffer, 'ink_ls', [
+    return ale#path#FindExecutable(a:buffer, 'ink_ls', [
     \   'ink-language-server',
     \   'node_modules/.bin/ink-language-server',
     \])

ale_linters/javascript/flow.vim

@@ -22,7 +22,7 @@ function! ale_linters#javascript#flow#GetExecutable(buffer) abort
         return ''
     endif
 
-    return ale#node#FindExecutable(a:buffer, 'javascript_flow', [
+    return ale#path#FindExecutable(a:buffer, 'javascript_flow', [
     \   'node_modules/.bin/flow',
     \])
 endfunction

ale_linters/javascript/flow_ls.vim

@@ -19,7 +19,7 @@ endfunction
 call ale#linter#Define('javascript', {
 \   'name': 'flow-language-server',
 \   'lsp': 'stdio',
-\   'executable': {b -> ale#node#FindExecutable(b, 'javascript_flow_ls', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'javascript_flow_ls', [
 \       'node_modules/.bin/flow',
 \   ])},
 \   'command': '%e lsp --from ale-lsp',

ale_linters/javascript/jscs.vim

@@ -53,7 +53,7 @@ endfunction
 
 call ale#linter#Define('javascript', {
 \   'name': 'jscs',
-\   'executable': {b -> ale#node#FindExecutable(b, 'javascript_jscs', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'javascript_jscs', [
 \       'node_modules/.bin/jscs',
 \   ])},
 \   'command': function('ale_linters#javascript#jscs#GetCommand'),

ale_linters/javascript/jshint.vim

@@ -25,7 +25,7 @@ endfunction
 
 call ale#linter#Define('javascript', {
 \   'name': 'jshint',
-\   'executable': {b -> ale#node#FindExecutable(b, 'javascript_jshint', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'javascript_jshint', [
 \       'node_modules/.bin/jshint',
 \   ])},
 \   'command': function('ale_linters#javascript#jshint#GetCommand'),

ale_linters/javascript/standard.vim

@@ -6,7 +6,7 @@ call ale#Set('javascript_standard_use_global', get(g:, 'ale_use_global_executabl
 call ale#Set('javascript_standard_options', '')
 
 function! ale_linters#javascript#standard#GetExecutable(buffer) abort
-    return ale#node#FindExecutable(a:buffer, 'javascript_standard', [
+    return ale#path#FindExecutable(a:buffer, 'javascript_standard', [
     \   'node_modules/standardx/bin/cmd.js',
     \   'node_modules/standard/bin/cmd.js',
     \   'node_modules/semistandard/bin/cmd.js',

ale_linters/javascript/tsserver.vim

@@ -8,7 +8,7 @@ call ale#Set('javascript_tsserver_use_global', get(g:, 'ale_use_global_executabl
 call ale#linter#Define('javascript', {
 \   'name': 'tsserver',
 \   'lsp': 'tsserver',
-\   'executable': {b -> ale#node#FindExecutable(b, 'javascript_tsserver', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'javascript_tsserver', [
 \       'node_modules/.bin/tsserver',
 \   ])},
 \   'command': '%e',

ale_linters/json/jsonlint.vim

@@ -4,7 +4,7 @@ call ale#Set('json_jsonlint_executable', 'jsonlint')
 call ale#Set('json_jsonlint_use_global', get(g:, 'ale_use_global_executables', 0))
 
 function! ale_linters#json#jsonlint#GetExecutable(buffer) abort
-    return ale#node#FindExecutable(a:buffer, 'json_jsonlint', [
+    return ale#path#FindExecutable(a:buffer, 'json_jsonlint', [
     \   'node_modules/.bin/jsonlint',
     \   'node_modules/jsonlint/lib/cli.js',
     \])

ale_linters/json/spectral.vim

@@ -6,7 +6,7 @@ call ale#Set('json_spectral_use_global', get(g:, 'ale_use_global_executables', 0
 
 call ale#linter#Define('json', {
 \   'name': 'spectral',
-\   'executable': {b -> ale#node#FindExecutable(b, 'json_spectral', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'json_spectral', [
 \       'node_modules/.bin/spectral',
 \   ])},
 \   'command': '%e lint --ignore-unknown-format -q -f text %t',

ale_linters/less/lessc.vim

@@ -38,7 +38,7 @@ endfunction
 
 call ale#linter#Define('less', {
 \   'name': 'lessc',
-\   'executable': {b -> ale#node#FindExecutable(b, 'less_lessc', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'less_lessc', [
 \       'node_modules/.bin/lessc',
 \   ])},
 \   'command': function('ale_linters#less#lessc#GetCommand'),

ale_linters/less/stylelint.vim

@@ -12,7 +12,7 @@ endfunction
 
 call ale#linter#Define('less', {
 \   'name': 'stylelint',
-\   'executable': {b -> ale#node#FindExecutable(b, 'less_stylelint', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'less_stylelint', [
 \       'node_modules/.bin/stylelint',
 \   ])},
 \   'command': function('ale_linters#less#stylelint#GetCommand'),

ale_linters/markdown/remark_lint.vim

@@ -39,7 +39,7 @@ endfunction
 call ale#linter#Define('markdown', {
 \   'name': 'remark_lint',
 \   'aliases': ['remark-lint'],
-\   'executable': {b -> ale#node#FindExecutable(b, 'markdown_remark_lint', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'markdown_remark_lint', [
 \       'node_modules/.bin/remark',
 \   ])},
 \   'command': function('ale_linters#markdown#remark_lint#GetCommand'),

ale_linters/php/intelephense.vim

@@ -26,7 +26,7 @@ call ale#linter#Define('php', {
 \   'name': 'intelephense',
 \   'lsp': 'stdio',
 \   'initialization_options': function('ale_linters#php#intelephense#GetInitializationOptions'),
-\   'executable': {b -> ale#node#FindExecutable(b, 'php_intelephense', [])},
+\   'executable': {b -> ale#path#FindExecutable(b, 'php_intelephense', [])},
 \   'command': '%e --stdio',
 \   'project_root': function('ale_linters#php#intelephense#GetProjectRoot'),
 \})

ale_linters/php/langserver.vim

@@ -19,7 +19,7 @@ endfunction
 call ale#linter#Define('php', {
 \   'name': 'langserver',
 \   'lsp': 'stdio',
-\   'executable': {b -> ale#node#FindExecutable(b, 'php_langserver', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'php_langserver', [
 \       'vendor/bin/php-language-server.php',
 \   ])},
 \   'command': 'php %e',

ale_linters/php/phpcs.vim

@@ -44,7 +44,7 @@ endfunction
 
 call ale#linter#Define('php', {
 \   'name': 'phpcs',
-\   'executable': {b -> ale#node#FindExecutable(b, 'php_phpcs', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'php_phpcs', [
 \       'vendor/bin/phpcs',
 \       'phpcs'
 \   ])},

ale_linters/php/psalm.vim

@@ -18,7 +18,7 @@ endfunction
 call ale#linter#Define('php', {
 \   'name': 'psalm',
 \   'lsp': 'stdio',
-\   'executable': {b -> ale#node#FindExecutable(b, 'php_psalm', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'php_psalm', [
 \       'vendor/bin/psalm',
 \   ])},
 \   'command': function('ale_linters#php#psalm#GetCommand'),

ale_linters/php/tlint.vim

@@ -20,7 +20,7 @@ function! ale_linters#php#tlint#GetProjectRoot(buffer) abort
 endfunction
 
 function! ale_linters#php#tlint#GetExecutable(buffer) abort
-    return ale#node#FindExecutable(a:buffer, 'php_tlint', [
+    return ale#path#FindExecutable(a:buffer, 'php_tlint', [
     \   'vendor/bin/tlint',
     \   'tlint',
     \])

ale_linters/pug/puglint.vim

@@ -47,7 +47,7 @@ endfunction
 
 call ale#linter#Define('pug', {
 \   'name': 'puglint',
-\   'executable': {b -> ale#node#FindExecutable(b, 'pug_puglint', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'pug_puglint', [
 \       'node_modules/.bin/pug-lint',
 \   ])},
 \   'output_stream': 'stderr',

ale_linters/purescript/ls.vim

@@ -6,7 +6,7 @@ call ale#Set('purescript_ls_use_global', get(g:, 'ale_use_global_executables', 0
 call ale#Set('purescript_ls_config', {})
 
 function! ale_linters#purescript#ls#GetExecutable(buffer) abort
-    return ale#node#FindExecutable(a:buffer, 'purescript_ls', [
+    return ale#path#FindExecutable(a:buffer, 'purescript_ls', [
     \   'node_modules/.bin/purescript-language-server',
     \])
 endfunction

ale_linters/sass/sasslint.vim

@@ -5,7 +5,7 @@ call ale#Set('sass_sasslint_options', '')
 call ale#Set('sass_sasslint_use_global', get(g:, 'ale_use_global_executables', 0))
 
 function! ale_linters#sass#sasslint#GetExecutable(buffer) abort
-    return ale#node#FindExecutable(a:buffer, 'sass_sasslint', [
+    return ale#path#FindExecutable(a:buffer, 'sass_sasslint', [
     \   'node_modules/sass-lint/bin/sass-lint.js',
     \   'node_modules/.bin/sass-lint',
     \])

ale_linters/sass/stylelint.vim

@@ -5,7 +5,7 @@ call ale#Set('sass_stylelint_use_global', get(g:, 'ale_use_global_executables',
 
 call ale#linter#Define('sass', {
 \   'name': 'stylelint',
-\   'executable': {b -> ale#node#FindExecutable(b, 'sass_stylelint', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'sass_stylelint', [
 \       'node_modules/.bin/stylelint',
 \   ])},
 \   'command': '%e --stdin-filename %s',

ale_linters/scss/sasslint.vim

@@ -5,7 +5,7 @@ call ale#Set('scss_sasslint_options', '')
 call ale#Set('scss_sasslint_use_global', get(g:, 'ale_use_global_executables', 0))
 
 function! ale_linters#scss#sasslint#GetExecutable(buffer) abort
-    return ale#node#FindExecutable(a:buffer, 'scss_sasslint', [
+    return ale#path#FindExecutable(a:buffer, 'scss_sasslint', [
     \   'node_modules/sass-lint/bin/sass-lint.js',
     \   'node_modules/.bin/sass-lint',
     \])

ale_linters/scss/stylelint.vim

@@ -11,7 +11,7 @@ endfunction
 
 call ale#linter#Define('scss', {
 \   'name': 'stylelint',
-\   'executable': {b -> ale#node#FindExecutable(b, 'scss_stylelint', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'scss_stylelint', [
 \       'node_modules/.bin/stylelint',
 \   ])},
 \   'command': function('ale_linters#scss#stylelint#GetCommand'),

ale_linters/sh/language_server.vim

@@ -6,7 +6,7 @@ call ale#Set('sh_language_server_executable', 'bash-language-server')
 call ale#Set('sh_language_server_use_global', get(g:, 'ale_use_global_executables', 0))
 
 function! ale_linters#sh#language_server#GetExecutable(buffer) abort
-    return ale#node#FindExecutable(a:buffer, 'sh_language_server', [
+    return ale#path#FindExecutable(a:buffer, 'sh_language_server', [
     \   'node_modules/.bin/bash-language-server',
     \])
 endfunction

ale_linters/stylus/stylelint.vim

@@ -12,7 +12,7 @@ endfunction
 
 call ale#linter#Define('stylus', {
 \   'name': 'stylelint',
-\   'executable': {b -> ale#node#FindExecutable(b, 'stylus_stylelint', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'stylus_stylelint', [
 \       'node_modules/.bin/stylelint',
 \   ])},
 \   'command': function('ale_linters#stylus#stylelint#GetCommand'),

ale_linters/sugarss/stylelint.vim

@@ -13,7 +13,7 @@ endfunction
 
 call ale#linter#Define('sugarss', {
 \   'name': 'stylelint',
-\   'executable': {b -> ale#node#FindExecutable(b, 'sugarss_stylelint', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'sugarss_stylelint', [
 \       'node_modules/.bin/stylelint',
 \   ])},
 \   'command': function('ale_linters#sugarss#stylelint#GetCommand'),

ale_linters/svelte/svelteserver.vim

@@ -13,7 +13,7 @@ endfunction
 call ale#linter#Define('svelte', {
 \   'name': 'svelteserver',
 \   'lsp': 'stdio',
-\   'executable': {b -> ale#node#FindExecutable(b, 'svelte_svelteserver', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'svelte_svelteserver', [
 \       'node_modules/.bin/svelteserver',
 \   ])},
 \   'command': '%e --stdio',

ale_linters/swift/swiftlint.vim

@@ -5,7 +5,7 @@ call ale#Set('swift_swiftlint_executable', 'swiftlint')
 call ale#Set('swift_swiftlint_use_global', get(g:, 'ale_use_global_executables', 0))
 
 function! ale_linters#swift#swiftlint#GetExecutable(buffer) abort
-    return ale#node#FindExecutable(a:buffer, 'swift_swiftlint', [
+    return ale#path#FindExecutable(a:buffer, 'swift_swiftlint', [
     \ 'Pods/SwiftLint/swiftlint',
     \ 'ios/Pods/SwiftLint/swiftlint',
     \ 'swiftlint',

ale_linters/typescript/standard.vim

@@ -6,7 +6,7 @@ call ale#Set('typescript_standard_use_global', get(g:, 'ale_use_global_executabl
 call ale#Set('typescript_standard_options', '')
 
 function! ale_linters#typescript#standard#GetExecutable(buffer) abort
-    return ale#node#FindExecutable(a:buffer, 'typescript_standard', [
+    return ale#path#FindExecutable(a:buffer, 'typescript_standard', [
     \   'node_modules/standardx/bin/cmd.js',
     \   'node_modules/standard/bin/cmd.js',
     \   'node_modules/.bin/standard',

ale_linters/typescript/tsserver.vim

@@ -8,7 +8,7 @@ call ale#Set('typescript_tsserver_use_global', get(g:, 'ale_use_global_executabl
 call ale#linter#Define('typescript', {
 \   'name': 'tsserver',
 \   'lsp': 'tsserver',
-\   'executable': {b -> ale#node#FindExecutable(b, 'typescript_tsserver', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'typescript_tsserver', [
 \       '.yarn/sdks/typescript/bin/tsserver',
 \       'node_modules/.bin/tsserver',
 \   ])},

ale_linters/vim/vimls.vim

@@ -52,7 +52,7 @@ call ale#linter#Define('vim', {
 \   'name': 'vimls',
 \   'lsp': 'stdio',
 \   'lsp_config': {b -> ale#Var(b, 'vim_vimls_config')},
-\   'executable': {b -> ale#node#FindExecutable(b, 'vim_vimls', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'vim_vimls', [
 \       'node_modules/.bin/vim-language-server',
 \   ])},
 \   'command': '%e --stdio',

ale_linters/vue/vls.vim

@@ -13,7 +13,7 @@ endfunction
 call ale#linter#Define('vue', {
 \   'name': 'vls',
 \   'lsp': 'stdio',
-\   'executable': {b -> ale#node#FindExecutable(b, 'vue_vls', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'vue_vls', [
 \       'node_modules/.bin/vls',
 \   ])},
 \   'command': '%e --stdio',

ale_linters/yaml/spectral.vim

@@ -6,7 +6,7 @@ call ale#Set('yaml_spectral_use_global', get(g:, 'ale_use_global_executables', 0
 
 call ale#linter#Define('yaml', {
 \   'name': 'spectral',
-\   'executable': {b -> ale#node#FindExecutable(b, 'yaml_spectral', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'yaml_spectral', [
 \       'node_modules/.bin/spectral',
 \   ])},
 \   'command': '%e lint --ignore-unknown-format -q -f text %t',

ale_linters/yaml/swaglint.vim

@@ -32,7 +32,7 @@ endfunction
 
 call ale#linter#Define('yaml', {
 \   'name': 'swaglint',
-\   'executable': {b -> ale#node#FindExecutable(b, 'yaml_swaglint', [
+\   'executable': {b -> ale#path#FindExecutable(b, 'yaml_swaglint', [
 \       'node_modules/.bin/swaglint',
 \   ])},
 \   'command': '%e -r compact --stdin',