VimPlug/ale
1
0
Fork 0
mirror of https://github.com/dense-analysis/ale.git synced 2025-12-07 05:04:28 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix #3273 - Handle missing keys in hover information

Browse Source
This commit is contained in:
w0rp
2020-08-07 12:34:45 +01:00
parent 388049dbea
commit f741245f11
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
autoload/ale/hover.vim
View File

@@ -91,11 +91,12 @@ function! ale#hover#HandleLSPResponse(conn_id, response) abort
if type(l:result) is v:t_dict if type(l:result) is v:t_dict
" If the result is an object, then it's markup content. " If the result is an object, then it's markup content.
let l:result = [l:result.value] let l:result = has_key(l:result, 'value') ? [l:result.value] : []
endif endif
if type(l:result) is v:t_list if type(l:result) is v:t_list
" Replace objects with text values. " Replace objects with text values.
call filter(l:result, '!(type(v:val) is v:t_dict && !has_key(v:val, ''value''))')
call map(l:result, 'type(v:val) is v:t_string ? v:val : v:val.value') call map(l:result, 'type(v:val) is v:t_string ? v:val : v:val.value')
let l:str = join(l:result, "\n") let l:str = join(l:result, "\n")
let l:str = substitute(l:str, '^\s*\(.\{-}\)\s*$', '\1', '') let l:str = substitute(l:str, '^\s*\(.\{-}\)\s*$', '\1', '')

7
test/test_hover.vader
View File

@@ -133,6 +133,12 @@ Execute(LSP hover responses with markup content should be handled):
AssertEqual ['markup'], g:echo_list AssertEqual ['markup'], g:echo_list
AssertEqual {}, ale#hover#GetMap() AssertEqual {}, ale#hover#GetMap()
Execute(LSP hover responses with markup content missing values should be handled):
call HandleValidLSPResult({'contents': {'kind': 'something'}})
AssertEqual [], g:echo_list
AssertEqual {}, ale#hover#GetMap()
Execute(LSP hover response with lists of strings should be handled): Execute(LSP hover response with lists of strings should be handled):
call HandleValidLSPResult({'contents': [ call HandleValidLSPResult({'contents': [
\ "foo\n", \ "foo\n",
@@ -145,6 +151,7 @@ Execute(LSP hover response with lists of strings should be handled):
Execute(LSP hover response with lists of strings and marked strings should be handled): Execute(LSP hover response with lists of strings and marked strings should be handled):
call HandleValidLSPResult({'contents': [ call HandleValidLSPResult({'contents': [
\ {'language': 'rust', 'value': 'foo'}, \ {'language': 'rust', 'value': 'foo'},
\ {'language': 'foobar'},
\ "bar\n", \ "bar\n",
\]}) \]})