VimPlug/ale
1
0
Fork 0
mirror of https://github.com/dense-analysis/ale.git synced 2025-12-09 22:14:44 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix error loading "text" syntax for hover (#4574)

Browse Source 
rust-analyzer sometimes returns a hover result with language being
"text", but there's no syntax/text.vim, so this would fail with:

    Error detected while processing function <SNR>150_VimOutputCallback[6]..<lambda>8[1]..ale#lsp#HandleMessage[30]..ale#hover#HandleLSPResponse[42]..ale#floating_preview#Show[13]..<SNR>161_VimShow:
    line   13:
    E484: Cannot open file syntax/text.vim

Only including the file when it actually exists fixes this.
This commit is contained in:
Tomáš Janoušek
2023-08-15 11:20:47 +01:00
committed by GitHub
parent 951b280bd5
commit fe38101db7
3 changed files with 46 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
test/test_hover_parsing.vader
View File

@@ -35,12 +35,12 @@ Execute(A string with a code fence should be handled):
\ [
\ [
\ 'unlet! b:current_syntax',
\ 'syntax include @ALE_hover_python syntax/python.vim',
\ 'syntax include @ALE_hover_javascript syntax/javascript.vim',
\ 'unlet! b:current_syntax',
\ 'syntax include @ALE_hover_typescript syntax/typescript.vim',
\ 'syntax include @ALE_hover_python syntax/python.vim',
\ 'syntax region ALE_hover_1 start=/\%1l/ end=/\%3l/ contains=@ALE_hover_python',
\ 'syntax region ALE_hover_2 start=/\%5l/ end=/\%8l/ contains=@ALE_hover_python',
\ 'syntax region ALE_hover_3 start=/\%8l/ end=/\%10l/ contains=@ALE_hover_typescript',
\ 'syntax region ALE_hover_3 start=/\%8l/ end=/\%10l/ contains=@ALE_hover_javascript',
\ ],
\ [
\ 'def foo():',
@@ -64,7 +64,7 @@ Execute(A string with a code fence should be handled):
\ 'def bar():',
\ ' pass',
\ '```',
\ '```typescript',
\ '```javascript',
\ 'const baz = () => undefined',
\ '```',
\ ], "\n"))
@@ -74,12 +74,12 @@ Execute(Multiple strings with fences should be handled):
\ [
\ [
\ 'unlet! b:current_syntax',
\ 'syntax include @ALE_hover_python syntax/python.vim',
\ 'syntax include @ALE_hover_javascript syntax/javascript.vim',
\ 'unlet! b:current_syntax',
\ 'syntax include @ALE_hover_typescript syntax/typescript.vim',
\ 'syntax include @ALE_hover_python syntax/python.vim',
\ 'syntax region ALE_hover_1 start=/\%1l/ end=/\%3l/ contains=@ALE_hover_python',
\ 'syntax region ALE_hover_2 start=/\%5l/ end=/\%8l/ contains=@ALE_hover_python',
\ 'syntax region ALE_hover_3 start=/\%8l/ end=/\%10l/ contains=@ALE_hover_typescript',
\ 'syntax region ALE_hover_3 start=/\%8l/ end=/\%10l/ contains=@ALE_hover_javascript',
\ ],
\ [
\ 'def foo():',
@@ -106,7 +106,7 @@ Execute(Multiple strings with fences should be handled):
\ 'def bar():',
\ ' pass',
\ '```',
\ '```typescript',
\ '```javascript',
\ 'const baz = () => undefined',
\ '```',
\ ], "\n"),
@@ -124,7 +124,7 @@ Execute(Objects with kinds should be handled):
\ 'def foo():',
\ ' pass',
\ '',
\ '```typescript',
\ '```javascript',
\ 'const baz = () => undefined',
\ '```',
\ ],
@@ -142,7 +142,7 @@ Execute(Objects with kinds should be handled):
\ {
\ 'kind': 'plaintext',
\ 'value': join([
\ '```typescript',
\ '```javascript',
\ 'const baz = () => undefined',
\ '```',
\ ], "\n"),
@@ -171,3 +171,19 @@ Execute(Simple markdown formatting should be handled):
\ '```',
\ 'formatted \_ line \_',
\ ], "\n"))
Execute(Non-existent syntax files shouldn't be loaded):
AssertEqual
\ [
\ [
\ 'syntax region ALE_hover_1 start=/\%1l/ end=/\%2l/ contains=@ALE_hover_text',
\ ],
\ [
\ 'hello',
\ ],
\ ],
\ ale#hover#ParseLSPResult(join([
\ '```text',
\ 'hello',
\ '```',
\ ], "\n"))