VimPlug/ale
1
0
Fork 0
mirror of https://github.com/dense-analysis/ale.git synced 2025-12-06 12:44:23 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove hadolint rule code from location list entry text (#4939)
Some checks failed
CI / build_image (push) Has been cancelled
Details
CI / test_ale (--linters-only) (push) Has been cancelled
Details
CI / test_ale (--lua-only) (push) Has been cancelled
Details
CI / test_ale (--neovim-07-only) (push) Has been cancelled
Details
CI / test_ale (--neovim-08-only) (push) Has been cancelled
Details
CI / test_ale (--vim-80-only) (push) Has been cancelled
Details
CI / test_ale (--vim-90-only) (push) Has been cancelled
Details

Browse Source 
The code is already passed with the code key of location list entry.
Before this change, when using the default message format, it appeared
twice in the description of each location list entry and twice in each
echo message.
This commit is contained in:
Dmitri Vereshchagin
2025-03-30 07:58:04 +03:00
committed by GitHub
parent 6433d31f47
commit ff8fe94494
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
ale_linters/dockerfile/hadolint.vim
View File

@@ -49,7 +49,6 @@ function! ale_linters#dockerfile#hadolint#Handle(buffer, lines) abort
if l:match[5] isnot# '' if l:match[5] isnot# ''
let l:code = l:match[4] . l:match[5] let l:code = l:match[4] . l:match[5]
let l:link = ' ( ' . l:domain . l:code . ' )' let l:link = ' ( ' . l:domain . l:code . ' )'
let l:text = l:code . ': ' . l:detail
let l:detail = l:code . l:link . "\n\n" . l:detail let l:detail = l:code . l:link . "\n\n" . l:detail
else else
let l:type = 'E' let l:type = 'E'

6
test/handler/test_hadolint.vader
View File

@@ -17,7 +17,7 @@ Execute(The hadolint handler should handle a normal example):
\ 'col': 0, \ 'col': 0,
\ 'type': 'W', \ 'type': 'W',
\ 'code': 'DL3006', \ 'code': 'DL3006',
\ 'text': "DL3006: Always tag the version of an image explicitly", \ 'text': 'Always tag the version of an image explicitly',
\ 'detail': "DL3006 ( https://github.com/hadolint/hadolint/wiki/DL3006 )\n\nAlways tag the version of an image explicitly", \ 'detail': "DL3006 ( https://github.com/hadolint/hadolint/wiki/DL3006 )\n\nAlways tag the version of an image explicitly",
\ }, \ },
\ { \ {
@@ -25,7 +25,7 @@ Execute(The hadolint handler should handle a normal example):
\ 'col': 0, \ 'col': 0,
\ 'type': 'W', \ 'type': 'W',
\ 'code': 'DL3033', \ 'code': 'DL3033',
\ 'text': "DL3033: Specify version with `yum install -y <package>-<version>`.", \ 'text': 'Specify version with `yum install -y <package>-<version>`.',
\ 'detail': "DL3033 ( https://github.com/hadolint/hadolint/wiki/DL3033 )\n\nSpecify version with `yum install -y <package>-<version>`.", \ 'detail': "DL3033 ( https://github.com/hadolint/hadolint/wiki/DL3033 )\n\nSpecify version with `yum install -y <package>-<version>`.",
\ }, \ },
\ { \ {
@@ -33,7 +33,7 @@ Execute(The hadolint handler should handle a normal example):
\ 'col': 0, \ 'col': 0,
\ 'type': 'W', \ 'type': 'W',
\ 'code': 'SC2039', \ 'code': 'SC2039',
\ 'text': "SC2039: In POSIX sh, brace expansion is undefined.", \ 'text': 'In POSIX sh, brace expansion is undefined.',
\ 'detail': "SC2039 ( https://github.com/koalaman/shellcheck/wiki/SC2039 )\n\nIn POSIX sh, brace expansion is undefined.", \ 'detail': "SC2039 ( https://github.com/koalaman/shellcheck/wiki/SC2039 )\n\nIn POSIX sh, brace expansion is undefined.",
\ }, \ },
\ ], \ ],