Add defensive ale#Set for c_build_dir_names in FindCompileCommands

Mirror the existing s:CanParseMakefile pattern to ensure the
g:ale_c_build_dir_names variable always exists when ale#Var is
called, even if test Save/Restore cycles delete it.

Co-authored-by: w0rp <3518142+w0rp@users.noreply.github.com>

.appveyor.yml

@@ -41,10 +41,10 @@ install:
   - ps: >-
       if (!(Test-Path -Path C:\vim)){
         Add-Type -A System.IO.Compression.FileSystem
-        Invoke-WebRequest ftp://ftp.vim.org/pub/vim/pc/vim80-586w32.zip `
+        Invoke-WebRequest https://github.com/dense-analysis/ale/releases/download/v4.0.0/vim80-586w32.zip `
           -OutFile C:\vim.zip
         [IO.Compression.ZipFile]::ExtractToDirectory('C:\vim.zip', 'C:\vim')
-        Invoke-WebRequest ftp://ftp.vim.org/pub/vim/pc/vim80-586rt.zip `
+        Invoke-WebRequest https://github.com/dense-analysis/ale/releases/download/v4.0.0/vim80-586rt.zip `
           -OutFile C:\rt.zip
         [IO.Compression.ZipFile]::ExtractToDirectory('C:\rt.zip', 'C:\vim')
       }

.github/ISSUE_TEMPLATE/report-a-bug.md

@@ -1,6 +1,7 @@
 ---
 name: Report a bug
 labels: bug
+type: Bug
 about: Report a bug with ALE.
 
 ---

.github/ISSUE_TEMPLATE/suggest-a-new-linter-or-fixer.md

@@ -1,6 +1,7 @@
 ---
 name: Suggest a new linter or fixer
 labels: new tool
+type: Task
 about: Suggest a new tool ALE can officially integrate with.
 
 ---

.github/ISSUE_TEMPLATE/suggest-an-improvement.md

@@ -1,6 +1,7 @@
 ---
 name: Suggest an improvement
 labels: enhancement
+type: Feature
 about: Suggest some way to improve ALE, or add a new feature.
 
 ---

.luarc.json

@@ -7,7 +7,8 @@
     "test"
   ],
   "workspace.library": [
-    "/usr/share/nvim/runtime/lua"
+    "/usr/share/nvim/runtime/lua",
+    "/opt/homebrew/share/nvim/runtime/lua"
   ],
   "runtime.pathStrict": true,
   "runtime.path": [

AGENTS.md

@@ -0,0 +1,6 @@
+# ALE Agent instructions
+
+1. Read documentation from `doc/ale-development.txt` to understand how to be an
+   ALE developer.
+2. Run Vader/Vim tests with `./run-tests -q --fast test/path/some_file.vader`
+3. When editing Lua code run Lua tests with `./run-tests -q --lua-only`

README.md

@@ -61,6 +61,14 @@ linting and fixing of code in Vim. ALE offers the following.
 * Windows support
 * Well-integrated with other plugins
 
+## Sponsorship
+
+If you would like to donate to Dense Analysis to say thank you for ALE, please
+consider visiting our [Sponsorship page](https://denseanalysis.org/sponsors/).
+Funds will be used to pay for our hosting fees and research. Whilst visiting our
+site, please feel free to make use of our educational resources and other
+recommended tools.
+
 ## Supported Languages and Tools
 
 ALE supports a wide variety of languages and tools. See the

ale_linters/ansible/ansible_lint.vim

@@ -2,11 +2,44 @@
 " Description: ansible-lint for ansible-yaml files
 
 call ale#Set('ansible_ansible_lint_executable', 'ansible-lint')
+call ale#Set('ansible_ansible_lint_auto_pipenv', 0)
+call ale#Set('ansible_ansible_lint_auto_poetry', 0)
+call ale#Set('ansible_ansible_lint_auto_uv', 0)
+call ale#Set('ansible_ansible_lint_change_directory', 1)
 
 function! ale_linters#ansible#ansible_lint#GetExecutable(buffer) abort
+    if (ale#Var(a:buffer, 'python_auto_pipenv')
+    \ || ale#Var(a:buffer, 'ansible_ansible_lint_auto_pipenv'))
+    \ && ale#python#PipenvPresent(a:buffer)
+        return 'pipenv'
+    endif
+
+    if (ale#Var(a:buffer, 'python_auto_poetry')
+    \ || ale#Var(a:buffer, 'ansible_ansible_lint_auto_poetry'))
+    \ && ale#python#PoetryPresent(a:buffer)
+        return 'poetry'
+    endif
+
+    if (ale#Var(a:buffer, 'python_auto_uv')
+    \ || ale#Var(a:buffer, 'ansible_ansible_lint_auto_uv'))
+    \ && ale#python#UvPresent(a:buffer)
+        return 'uv'
+    endif
+
     return ale#Var(a:buffer, 'ansible_ansible_lint_executable')
 endfunction
 
+function! ale_linters#ansible#ansible_lint#GetCwd(buffer) abort
+    if ale#Var(a:buffer, 'ansible_ansible_lint_change_directory')
+        " Run from project root if found, else from buffer dir.
+        let l:project_root = ale#python#FindProjectRoot(a:buffer)
+
+        return !empty(l:project_root) ? l:project_root : '%s:h'
+    endif
+
+    return ''
+endfunction
+
 function! ale_linters#ansible#ansible_lint#Handle(buffer, version, lines) abort
     for l:line in a:lines[:10]
         if match(l:line, '^Traceback') >= 0
@@ -103,28 +136,50 @@ function! ale_linters#ansible#ansible_lint#Handle(buffer, version, lines) abort
 endfunction
 
 function! ale_linters#ansible#ansible_lint#GetCommand(buffer, version) abort
-    let l:commands = {
+    let l:executable = ale_linters#ansible#ansible_lint#GetExecutable(a:buffer)
-    \   '>=6.0.0': '%e --nocolor -f json -x yaml %s',
+
-    \   '>=5.0.0': '%e --nocolor --parseable-severity -x yaml %s',
+    let l:exec_args = l:executable =~? '\(pipenv\|poetry\|uv\)$'
-    \   '<5.0.0': '%e --nocolor -p %t'
+    \   ? ' run ansible-lint'
+    \   : ''
+
+    let l:opts_map = {
+    \   '>=6.0.0': ' --nocolor -f json -x yaml %s',
+    \   '>=5.0.0': ' --nocolor --parseable-severity -x yaml %s',
+    \   '<5.0.0': ' --nocolor -p %t'
     \}
-    let l:command = ale#semver#GTE(a:version, [6, 0]) ? l:commands['>=6.0.0'] :
+
-    \               ale#semver#GTE(a:version, [5, 0]) ? l:commands['>=5.0.0'] :
+    let l:cmd_opts = ale#semver#GTE(a:version, [6, 0]) ? l:opts_map['>=6.0.0'] :
-    \               l:commands['<5.0.0']
+    \               ale#semver#GTE(a:version, [5, 0]) ? l:opts_map['>=5.0.0'] :
+    \               l:opts_map['<5.0.0']
+
+    let l:command = ale#Escape(l:executable) . l:exec_args . l:cmd_opts
 
     return l:command
 endfunction
 
+function! ale_linters#ansible#ansible_lint#RunWithVersionCheck(buffer) abort
+    let l:executable = ale_linters#ansible#ansible_lint#GetExecutable(a:buffer)
+
+    let l:exec_args = l:executable =~? '\(pipenv\|poetry\|uv\)$'
+    \ ? ' run ansible-lint'
+    \ : ''
+
+    let l:command = ale#Escape(l:executable) . l:exec_args . ' --version'
+
+    return ale#semver#RunWithVersionCheck(
+    \   a:buffer,
+    \   l:executable,
+    \   l:command,
+    \   function('ale_linters#ansible#ansible_lint#GetCommand'),
+    \)
+endfunction
+
 call ale#linter#Define('ansible', {
 \   'name': 'ansible_lint',
 \   'aliases': ['ansible', 'ansible-lint'],
 \   'executable': function('ale_linters#ansible#ansible_lint#GetExecutable'),
-\   'command': {buffer -> ale#semver#RunWithVersionCheck(
+\   'cwd': function('ale_linters#ansible#ansible_lint#GetCwd'),
-\       buffer,
+\   'command':  function('ale_linters#ansible#ansible_lint#RunWithVersionCheck'),
-\       ale_linters#ansible#ansible_lint#GetExecutable(buffer),
-\       '%e --version',
-\       function('ale_linters#ansible#ansible_lint#GetCommand'),
-\   )},
 \   'lint_file': 1,
 \   'callback': {buffer, lines -> ale#semver#RunWithVersionCheck(
 \       buffer,

ale_linters/asciidoc/proselint.vim

@@ -1,9 +1,11 @@
 " Author: Daniel M. Capella https://github.com/polyzen
 " Description: proselint for AsciiDoc files
 
+call ale#Set('proselint_executable', 'proselint')
+
 call ale#linter#Define('asciidoc', {
 \   'name': 'proselint',
-\   'executable': 'proselint',
+\   'executable': function('ale#proselint#GetExecutable'),
-\   'command': 'proselint %t',
+\   'command': function('ale#proselint#GetCommandWithVersionCheck'),
 \   'callback': 'ale#handlers#unix#HandleAsWarning',
 \})

ale_linters/asciidoc/redpen.vim

@@ -1,9 +1,4 @@
 " Author: rhysd https://rhysd.github.io
 " Description: Redpen, a proofreading tool (http://redpen.cc)
 
-call ale#linter#Define('asciidoc', {
+call ale#handlers#redpen#DefineLinter('asciidoc')
-\   'name': 'redpen',
-\   'executable': 'redpen',
-\   'command': 'redpen -f asciidoc -r json %t',
-\   'callback': 'ale#handlers#redpen#HandleRedpenOutput',
-\})

ale_linters/asm/gcc.vim

@@ -9,7 +9,7 @@ function! ale_linters#asm#gcc#GetCommand(buffer) abort
     " -fsyntax-only doesn't catch everything.
     return '%e -x assembler'
     \   . ' -o ' . g:ale#util#nul_file
-    \   . '-iquote %s:h'
+    \   . ' -iquote %s:h'
     \   . ' ' . ale#Var(a:buffer, 'asm_gcc_options') . ' -'
 endfunction
 

ale_linters/bindzone/checkzone.vim

@@ -0,0 +1,43 @@
+" Description: named-checkzone for bindzone
+
+call ale#Set('bindzone_checkzone_executable', 'named-checkzone')
+call ale#Set('bindzone_checkzone_options', '-c IN')
+
+function! ale_linters#bindzone#checkzone#GetCommand(buffer) abort
+    return '%e' . ale#Pad(ale#Var(a:buffer, 'bindzone_checkzone_options'))
+    \   . ' example.com %t'
+endfunction
+
+function! ale_linters#bindzone#checkzone#Handle(buffer, lines) abort
+    let l:warning_pattern = '\vzone example.com/IN: (.+)$'
+    let l:error_pattern = '\v:(\d+): (.+)$'
+    let l:output = []
+
+    for l:match in ale#util#GetMatches(a:lines, l:error_pattern)
+        let l:lnum = l:match[1]
+        let l:text = l:match[2]
+
+        call add(l:output, {'text': l:text, 'lnum': l:lnum + 0, 'type': 'E'})
+    endfor
+
+    for l:match in ale#util#GetMatches(a:lines, l:warning_pattern)
+        let l:text = l:match[1]
+
+        " Ignore information messages
+        let l:scrub_match = matchlist(l:text, '\v(loaded serial|not loaded due to) ')
+
+        if empty(l:scrub_match)
+            call add(l:output, {'text': l:text, 'lnum': 0, 'type': 'W'})
+        endif
+    endfor
+
+    return l:output
+endfunction
+
+call ale#linter#Define('bindzone', {
+\   'name': 'checkzone',
+\   'executable': {b -> ale#Var(b, 'bindzone_checkzone_executable')},
+\   'command': function('ale_linters#bindzone#checkzone#GetCommand'),
+\   'callback': 'ale_linters#bindzone#checkzone#Handle',
+\   'read_buffer': 0,
+\})

ale_linters/bitbake/oelint_adv.vim

@@ -5,6 +5,14 @@ call ale#Set('bitbake_oelint_adv_executable', 'oelint-adv')
 call ale#Set('bitbake_oelint_adv_options', '')
 call ale#Set('bitbake_oelint_adv_config', '.oelint.cfg')
 
+function! ale_linters#bitbake#oelint_adv#StripAnsiCodes(line) abort
+    return substitute(a:line, '\e\[[0-9;]\+[mK]', '', 'g')
+endfunction
+
+function! ale_linters#bitbake#oelint_adv#RemoveBranch(line) abort
+    return substitute(a:line, ' \[branch:.*', '', 'g')
+endfunction
+
 function! ale_linters#bitbake#oelint_adv#Command(buffer) abort
     let l:config_file = ale#path#FindNearestFile(a:buffer,
     \    ale#Var(a:buffer, 'bitbake_oelint_adv_config'))
@@ -17,26 +25,25 @@ function! ale_linters#bitbake#oelint_adv#Command(buffer) abort
 endfunction
 
 function! ale_linters#bitbake#oelint_adv#Handle(buffer, lines) abort
-    let l:pattern = '\v^(.+):(.+):(.+):(.+):(.+)$'
+    let l:pattern = '\v^(.{-}):(.{-}):(.{-}):(.{-}):(.{-})$'
     let l:output = []
 
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
         call add(l:output, {
-        \    'lnum': str2nr(l:match[2]),
+        \   'lnum': str2nr(l:match[2]),
-        \    'type': l:match[3] is# 'error'
+        \   'type': l:match[3] is# 'error'
-        \          ? 'E' : (l:match[3] is# 'warning' ? 'W' : 'I'),
+        \       ? 'E'
-        \    'text': StripAnsiCodes(l:match[5]),
+        \       : (l:match[3] is# 'warning' ? 'W' : 'I'),
-        \    'code': l:match[4]
+        \   'text': ale_linters#bitbake#oelint_adv#RemoveBranch(
-        \    })
+        \       ale_linters#bitbake#oelint_adv#StripAnsiCodes(l:match[5])
+        \   ),
+        \   'code': l:match[4],
+        \})
     endfor
 
     return l:output
 endfunction
 
-function! StripAnsiCodes(line) abort
-    return substitute(a:line, '\e\[[0-9;]\+[mK]', '', 'g')
-endfunction
-
 call ale#linter#Define('bitbake', {
 \    'name': 'oelint_adv',
 \    'output_stream': 'both',

ale_linters/c/cppcheck.vim

@@ -10,13 +10,18 @@ function! ale_linters#c#cppcheck#GetCommand(buffer) abort
     \   ? ale#handlers#cppcheck#GetBufferPathIncludeOptions(a:buffer)
     \   : ''
     let l:template = ' --template=' . ale#Escape('{file}:{line}:{column}: {severity}:{inconclusive:inconclusive:} {message} [{id}]\\n{code}')
+    " Versions >=2.13 don't allow using --project in conjunction with an
+    " explicit source file.
+    let l:source_file = stridx(l:compile_commands_option, '--project=') < 0
+    \   ? ' %t'
+    \   : ''
 
     return '%e -q --language=c'
     \   . l:template
     \   . ale#Pad(l:compile_commands_option)
     \   . ale#Pad(ale#Var(a:buffer, 'c_cppcheck_options'))
     \   . l:buffer_path_include
-    \   . ' %t'
+    \   . l:source_file
 endfunction
 
 call ale#linter#Define('c', {

ale_linters/cloudformation/checkov.vim

@@ -0,0 +1,41 @@
+" Author: J. Handsel <jennpbc@posteo.net>, Thyme-87 <thyme-87@posteo.me>
+" Description: use checkov for providing warnings for cloudformation via ale
+
+call ale#Set('cloudformation_checkov_executable', 'checkov')
+call ale#Set('cloudformation_checkov_options', '')
+
+function! ale_linters#cloudformation#checkov#GetExecutable(buffer) abort
+    return ale#Var(a:buffer, 'cloudformation_checkov_executable')
+endfunction
+
+function! ale_linters#cloudformation#checkov#GetCommand(buffer) abort
+    return '%e ' . '-f %t -o json --quiet --framework cloudformation ' . ale#Var(a:buffer, 'cloudformation_checkov_options')
+endfunction
+
+function! ale_linters#cloudformation#checkov#Handle(buffer, lines) abort
+    let l:output = []
+
+    let l:results = get(get(ale#util#FuzzyJSONDecode(a:lines, {}), 'results', []), 'failed_checks', [])
+
+    for l:violation in l:results
+        call add(l:output, {
+        \   'filename': l:violation['file_path'],
+        \   'lnum': l:violation['file_line_range'][0],
+        \   'end_lnum': l:violation['file_line_range'][1],
+        \   'text': l:violation['check_name'] . ' [' . l:violation['check_id'] . ']',
+        \   'detail': l:violation['check_id'] . ': ' . l:violation['check_name'] . "\n" .
+        \             'For more information, see: '. l:violation['guideline'],
+        \   'type': 'W',
+        \   })
+    endfor
+
+    return l:output
+endfunction
+
+call ale#linter#Define('cloudformation', {
+\   'name': 'checkov',
+\   'output_stream': 'stdout',
+\   'executable': function('ale_linters#cloudformation#checkov#GetExecutable'),
+\   'command': function('ale_linters#cloudformation#checkov#GetCommand'),
+\   'callback': 'ale_linters#cloudformation#checkov#Handle',
+\})

ale_linters/cpp/clazy.vim

@@ -18,7 +18,7 @@ function! ale_linters#cpp#clazy#GetCommand(buffer) abort
     return '%e'
     \   . (!empty(l:checks) ? ' -checks=' . ale#Escape(l:checks) : '')
     \   . (!empty(l:build_dir) ? ' -p ' . ale#Escape(l:build_dir) : '')
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . ' %s'
 endfunction
 

ale_linters/cpp/cppcheck.vim

@@ -10,13 +10,18 @@ function! ale_linters#cpp#cppcheck#GetCommand(buffer) abort
     \   ? ale#handlers#cppcheck#GetBufferPathIncludeOptions(a:buffer)
     \   : ''
     let l:template = ' --template=' . ale#Escape('{file}:{line}:{column}: {severity}:{inconclusive:inconclusive:} {message} [{id}]\\n{code}')
+    " Versions >=2.13 don't allow using --project in conjunction with an
+    " explicit source file.
+    let l:source_file = stridx(l:compile_commands_option, '--project=') < 0
+    \   ? ' %t'
+    \   : ''
 
     return '%e -q --language=c++'
     \   . l:template
     \   . ale#Pad(l:compile_commands_option)
     \   . ale#Pad(ale#Var(a:buffer, 'cpp_cppcheck_options'))
     \   . l:buffer_path_include
-    \   . ' %t'
+    \   . l:source_file
 endfunction
 
 call ale#linter#Define('cpp', {

ale_linters/cs/mcs.vim

@@ -4,7 +4,7 @@ function! ale_linters#cs#mcs#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'cs_mcs_options')
 
     return 'mcs -unsafe --parse'
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . ' %t'
 endfunction
 

ale_linters/css/stylelint.vim

@@ -6,7 +6,7 @@ call ale#Set('css_stylelint_use_global', get(g:, 'ale_use_global_executables', 0
 
 function! ale_linters#css#stylelint#GetCommand(buffer) abort
     return '%e ' . ale#Pad(ale#Var(a:buffer, 'css_stylelint_options'))
-    \   . ' --stdin-filename %s'
+    \   . ' --no-color --stdin-filename %s'
 endfunction
 
 call ale#linter#Define('css', {

ale_linters/dockerfile/hadolint.vim

@@ -49,7 +49,6 @@ function! ale_linters#dockerfile#hadolint#Handle(buffer, lines) abort
         if l:match[5] isnot# ''
             let l:code = l:match[4] . l:match[5]
             let l:link = ' ( ' . l:domain . l:code . ' )'
-            let l:text = l:code . ': ' . l:detail
             let l:detail = l:code . l:link . "\n\n" . l:detail
         else
             let l:type = 'E'

ale_linters/elixir/expert.vim

@@ -0,0 +1,12 @@
+" Author: Paul Monson <pmonson711@pm.me>
+" Description: Expert integration (https://github.com/elixir-lang/expert)
+
+call ale#Set('elixir_expert_executable', 'expert')
+
+call ale#linter#Define('elixir', {
+\   'name': 'expert',
+\   'lsp': 'stdio',
+\   'executable': {b -> ale#Var(b, 'elixir_expert_executable')},
+\   'command': '%e',
+\   'project_root': function('ale#handlers#elixir#FindMixUmbrellaRoot'),
+\})

ale_linters/fortran/fortitude.vim

@@ -0,0 +1,47 @@
+" Author: gomfol12
+" Desciption: A linter for fortran using fortitude.
+
+call ale#Set('fortran_fortitude_executable', 'fortitude')
+call ale#Set('fortran_fortitude_options', '')
+
+let s:severity_map = {
+\   'E': 'E',
+\   'C': 'W',
+\   'OB': 'I',
+\   'MOD': 'I',
+\   'S': 'I',
+\   'PORT': 'I',
+\   'FORT': 'I',
+\}
+
+function! ale_linters#fortran#fortitude#Handle(buffer, lines) abort
+    let l:output = []
+
+    for l:error in ale#util#FuzzyJSONDecode(a:lines, [])
+        let l:prefix = matchstr(l:error['code'], '^\a\+')
+        let l:type = get(s:severity_map, l:prefix, 'I')
+
+        call add(l:output, {
+        \   'lnum': l:error['location']['row'],
+        \   'end_lnum': l:error['end_location']['row'],
+        \   'col': l:error['location']['column'],
+        \   'end_col': l:error['end_location']['column'],
+        \   'text': l:error['message'],
+        \   'type': l:type,
+        \   'code': l:error['code'],
+        \})
+    endfor
+
+    return l:output
+endfunction
+
+call ale#linter#Define('fortran', {
+\   'name': 'fortitude',
+\   'output_stream': 'stdout',
+\   'executable': {b -> ale#Var(b, 'fortran_fortitude_executable')},
+\   'command': {b ->
+\       '%e' . ' check --output-format json' . ale#Pad(ale#Var(b, 'fortran_fortitude_options')) . ' %s'
+\   },
+\   'callback': 'ale_linters#fortran#fortitude#Handle',
+\   'lint_file': 1,
+\})

ale_linters/fountain/proselint.vim

@@ -1,9 +1,11 @@
 " Author: Jansen Mitchell https://github.com/JansenMitchell
 " Description: proselint for Fountain files
 
+call ale#Set('proselint_executable', 'proselint')
+
 call ale#linter#Define('fountain', {
-\    'name': 'proselint',
+\   'name': 'proselint',
-\    'executable': 'proselint',
+\   'executable': function('ale#proselint#GetExecutable'),
-\    'command': 'proselint %t',
+\   'command': function('ale#proselint#GetCommandWithVersionCheck'),
-\    'callback': 'ale#handlers#unix#HandleAsWarning',
+\   'callback': 'ale#handlers#unix#HandleAsWarning',
 \})

ale_linters/go/golangci_lint.vim

@@ -5,26 +5,38 @@ call ale#Set('go_golangci_lint_options', '')
 call ale#Set('go_golangci_lint_executable', 'golangci-lint')
 call ale#Set('go_golangci_lint_package', 1)
 
-function! ale_linters#go#golangci_lint#GetCommand(buffer) abort
+function! ale_linters#go#golangci_lint#GetExecutable(buffer) abort
+    let l:executable = ale#Var(a:buffer, 'go_golangci_lint_executable')
+
+    return l:executable
+endfunction
+
+function! ale_linters#go#golangci_lint#GetCommand(buffer, version) abort
     let l:filename = expand('#' . a:buffer . ':t')
     let l:options = ale#Var(a:buffer, 'go_golangci_lint_options')
     let l:lint_package = ale#Var(a:buffer, 'go_golangci_lint_package')
 
+    if ale#semver#GTE(a:version, [2, 0, 0])
+        let l:options = l:options
+        \ . ' --output.json.path stdout'
+        \ . ' --output.text.path stderr'
+        \ . ' --show-stats=0'
+    else
+        let l:options = l:options
+        \   . ' --out-format=json'
+        \   . ' --show-stats=0'
+    endif
 
     if l:lint_package
         return ale#go#EnvString(a:buffer)
         \   . '%e run '
         \   .  l:options
-        \   . ' --out-format=json'
-        \   . ' --show-stats=0'
     endif
 
     return ale#go#EnvString(a:buffer)
     \   . '%e run '
     \   . ale#Escape(l:filename)
     \   . ' ' . l:options
-    \   . ' --out-format=json'
-    \   . ' --show-stats=0'
 endfunction
 
 function! ale_linters#go#golangci_lint#Handler(buffer, lines) abort
@@ -58,9 +70,14 @@ endfunction
 
 call ale#linter#Define('go', {
 \   'name': 'golangci-lint',
-\   'executable': {b -> ale#Var(b, 'go_golangci_lint_executable')},
+\   'executable': function('ale_linters#go#golangci_lint#GetExecutable'),
 \   'cwd': '%s:h',
-\   'command': function('ale_linters#go#golangci_lint#GetCommand'),
+\   'command': {buffer -> ale#semver#RunWithVersionCheck(
+\       buffer,
+\       ale_linters#go#golangci_lint#GetExecutable(buffer),
+\       '%e --version',
+\       function('ale_linters#go#golangci_lint#GetCommand'),
+\   )},
 \   'callback': 'ale_linters#go#golangci_lint#Handler',
 \   'lint_file': 1,
 \})

ale_linters/go/revive.vim

@@ -8,7 +8,7 @@ function! ale_linters#go#revive#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'go_revive_options')
 
     return ale#go#EnvString(a:buffer) . '%e'
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . ' %t'
 endfunction
 

ale_linters/go/staticcheck.vim

@@ -13,11 +13,11 @@ function! ale_linters#go#staticcheck#GetCommand(buffer) abort
 
     if l:lint_package
         return l:env . '%e'
-        \   . (!empty(l:options) ? ' ' . l:options : '') . ' .'
+        \   . ale#Pad(l:options) . ' .'
     endif
 
     return l:env . '%e'
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . ' %s:t'
 endfunction
 

ale_linters/groovy/npmgroovylint.vim

@@ -8,7 +8,7 @@ function! ale_linters#groovy#npmgroovylint#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'groovy_npmgroovylint_options')
 
     return '%e --failon none --output json'
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . ' %t'
 endfunction
 

ale_linters/help/proselint.vim

@@ -1,9 +1,11 @@
 " Author: Daniel M. Capella https://github.com/polyzen
 " Description: proselint for Vim help files
 
+call ale#Set('proselint_executable', 'proselint')
+
 call ale#linter#Define('help', {
 \   'name': 'proselint',
-\   'executable': 'proselint',
+\   'executable': function('ale#proselint#GetExecutable'),
-\   'command': 'proselint %t',
+\   'command': function('ale#proselint#GetCommandWithVersionCheck'),
 \   'callback': 'ale#handlers#unix#HandleAsWarning',
 \})

ale_linters/html/proselint.vim

@@ -1,9 +1,11 @@
 " Author: Daniel M. Capella https://github.com/polyzen
 " Description: proselint for HTML files
 
+call ale#Set('proselint_executable', 'proselint')
+
 call ale#linter#Define('html', {
 \   'name': 'proselint',
-\   'executable': 'proselint',
+\   'executable': function('ale#proselint#GetExecutable'),
-\   'command': 'proselint %t',
+\   'command': function('ale#proselint#GetCommandWithVersionCheck'),
 \   'callback': 'ale#handlers#unix#HandleAsWarning',
 \})

ale_linters/html/stylelint.vim

@@ -15,8 +15,8 @@ function! ale_linters#html#stylelint#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'html_stylelint_options')
 
     return ale#Escape(l:executable)
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
-    \   . ' --stdin-filename %s'
+    \   . ' --no-color --stdin-filename %s'
 endfunction
 
 call ale#linter#Define('html', {

ale_linters/html/superhtml.vim

@@ -0,0 +1,34 @@
+call ale#Set('html_superhtml_executable', 'superhtml')
+call ale#Set('html_superhtml_use_global', get(g:, 'ale_use_global_executables', 0))
+
+function! ale_linters#html#superhtml#GetCommand(buffer) abort
+    return '%e check --stdin'
+endfunction
+
+function! ale_linters#html#superhtml#Handle(buffer, lines) abort
+    let l:output = []
+    let l:pattern = '^\(.*\):\(\d\+\):\(\d\+\): \(.*\)$'
+
+    for l:line in a:lines
+        let l:match = matchlist(l:line, l:pattern)
+
+        if !empty(l:match)
+            call add(l:output, {
+            \ 'lnum': str2nr(l:match[2]),
+            \ 'col': str2nr(l:match[3]),
+            \ 'text': l:match[4],
+            \ 'type': 'E'
+            \})
+        endif
+    endfor
+
+    return l:output
+endfunction
+
+call ale#linter#Define('html', {
+\   'name': 'superhtml',
+\   'executable': {b -> ale#Var(b, 'html_superhtml_executable')},
+\   'command': function('ale_linters#html#superhtml#GetCommand'),
+\   'output_stream': 'stderr',
+\   'callback': 'ale_linters#html#superhtml#Handle',
+\})

ale_linters/javascript/standard.vim

@@ -19,7 +19,7 @@ function! ale_linters#javascript#standard#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'javascript_standard_options')
 
     return ale#node#Executable(a:buffer, l:executable)
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . ' --stdin %s'
 endfunction
 

ale_linters/jinja/j2lint.vim

@@ -0,0 +1,46 @@
+" Description: linter for jinja using j2lint
+
+call ale#Set('jinja_j2lint_executable', 'j2lint')
+call ale#Set('jinja_j2lint_options', '')
+call ale#Set('jinja_j2lint_use_global', get(g:, 'ale_use_global_executables', 0))
+call ale#Set('jinja_j2lint_auto_pipenv', 0)
+call ale#Set('jinja_j2lint_auto_poetry', 0)
+call ale#Set('jinja_j2lint_auto_uv', 0)
+
+function! ale_linters#jinja#j2lint#GetExecutable(buffer) abort
+    if (ale#Var(a:buffer, 'python_auto_pipenv') || ale#Var(a:buffer, 'jinja_j2lint_auto_pipenv'))
+    \ && ale#python#PipenvPresent(a:buffer)
+        return 'pipenv'
+    endif
+
+    if (ale#Var(a:buffer, 'python_auto_poetry') || ale#Var(a:buffer, 'jinja_j2lint_auto_poetry'))
+    \ && ale#python#PoetryPresent(a:buffer)
+        return 'poetry'
+    endif
+
+    if (ale#Var(a:buffer, 'python_auto_uv') || ale#Var(a:buffer, 'jinja_j2lint_auto_uv'))
+    \ && ale#python#UvPresent(a:buffer)
+        return 'uv'
+    endif
+
+    return ale#python#FindExecutable(a:buffer, 'jinja_j2lint', ['j2lint'])
+endfunction
+
+function! ale_linters#jinja#j2lint#GetCommand(buffer) abort
+    let l:executable = ale_linters#jinja#j2lint#GetExecutable(a:buffer)
+
+    let l:exec_args = l:executable =~? 'pipenv\|poetry\|uv$'
+    \   ? ' run j2lint'
+    \   : ''
+
+    return ale#Escape(l:executable) . l:exec_args
+    \   . ale#Pad(ale#Var(a:buffer, 'jinja_j2lint_options'))
+    \   . ' %t'
+endfunction
+
+call ale#linter#Define('jinja', {
+\   'name': 'j2lint',
+\   'executable': function('ale_linters#jinja#j2lint#GetExecutable'),
+\   'command': function('ale_linters#jinja#j2lint#GetCommand'),
+\   'callback': 'ale#handlers#unix#HandleAsError',
+\})

ale_linters/lean/lake.vim

@@ -0,0 +1,28 @@
+" Author: Benjamin Block <https://github.com/benjamindblock>
+" Description: A language server for Lean 4.
+
+function! ale_linters#lean#lake#GetProjectRoot(buffer) abort
+    let l:lakefile_toml = ale#path#FindNearestFile(a:buffer, 'lakefile.toml')
+    let l:lakefile_lean = ale#path#FindNearestFile(a:buffer, 'lakefile.lean')
+
+    if !empty(l:lakefile_toml)
+        return fnamemodify(l:lakefile_toml, ':p:h')
+    elseif !empty(l:lakefile_lean)
+        return fnamemodify(l:lakefile_lean, ':p:h')
+    else
+        return fnamemodify('', ':h')
+    endif
+endfunction
+
+call ale#Set('lean_lake_executable', 'lake')
+call ale#Set('lean_lake_config', {})
+
+call ale#linter#Define('lean', {
+\   'name': 'lake',
+\   'lsp': 'stdio',
+\   'language': 'lean',
+\   'lsp_config': {b -> ale#Var(b, 'lean_lake_config')},
+\   'executable': {b -> ale#Var(b, 'lean_lake_executable')},
+\   'command': '%e serve',
+\   'project_root': function('ale_linters#lean#lake#GetProjectRoot'),
+\})

ale_linters/less/stylelint.vim

@@ -7,7 +7,7 @@ call ale#Set('less_stylelint_use_global', get(g:, 'ale_use_global_executables',
 function! ale_linters#less#stylelint#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'less_stylelint_options')
 
-    return '%e' . ale#Pad(l:options) . ' --stdin-filename %s'
+    return '%e' . ale#Pad(l:options) . ' --no-color --stdin-filename %s'
 endfunction
 
 call ale#linter#Define('less', {

ale_linters/mail/proselint.vim

@@ -1,9 +1,11 @@
 " Author: Daniel M. Capella https://github.com/polyzen
 " Description: proselint for mail files
 
+call ale#Set('proselint_executable', 'proselint')
+
 call ale#linter#Define('mail', {
 \   'name': 'proselint',
-\   'executable': 'proselint',
+\   'executable': function('ale#proselint#GetExecutable'),
-\   'command': 'proselint %t',
+\   'command': function('ale#proselint#GetCommandWithVersionCheck'),
 \   'callback': 'ale#handlers#unix#HandleAsWarning',
 \})

ale_linters/markdown/markdownlint.vim

@@ -14,7 +14,7 @@ function! ale_linters#markdown#markdownlint#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'markdown_markdownlint_options')
 
     return ale#Escape(l:executable)
-    \ . (!empty(l:options) ? ' ' . l:options : '') . ' %s'
+    \ . ale#Pad(l:options) . ' %s'
 endfunction
 
 call ale#linter#Define('markdown', {

ale_linters/markdown/mdl.vim

@@ -17,7 +17,7 @@ function! ale_linters#markdown#mdl#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'markdown_mdl_options')
 
     return ale#Escape(l:executable) . l:exec_args
-    \   . ' -j' . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ' -j' . ale#Pad(l:options)
 endfunction
 
 function! ale_linters#markdown#mdl#Handle(buffer, lines) abort

ale_linters/markdown/proselint.vim

@@ -1,9 +1,11 @@
 " Author: poohzrn https://github.com/poohzrn
 " Description: proselint for Markdown files
 
+call ale#Set('proselint_executable', 'proselint')
+
 call ale#linter#Define('markdown', {
 \   'name': 'proselint',
-\   'executable': 'proselint',
+\   'executable': function('ale#proselint#GetExecutable'),
-\   'command': 'proselint %t',
+\   'command': function('ale#proselint#GetCommandWithVersionCheck'),
 \   'callback': 'ale#handlers#unix#HandleAsWarning',
 \})

ale_linters/markdown/pymarkdown.vim

@@ -33,9 +33,8 @@ function! ale_linters#markdown#pymarkdown#GetCommand(buffer) abort
     \   : ''
 
     return ale#Escape(l:executable) . l:exec_args
-    \   . ' '
+    \   . ale#Pad(ale#Var(a:buffer, 'markdown_pymarkdown_options'))
-    \   . ale#Var(a:buffer, 'markdown_pymarkdown_options')
+    \   . ' scan-stdin'
-    \   . 'scan-stdin'
 endfunction
 
 function! ale_linters#markdown#pymarkdown#Handle(buffer, lines) abort

ale_linters/markdown/redpen.vim

@@ -1,9 +1,4 @@
 " Author: rhysd https://rhysd.github.io
 " Description: Redpen, a proofreading tool (http://redpen.cc)
 
-call ale#linter#Define('markdown', {
+call ale#handlers#redpen#DefineLinter('markdown')
-\   'name': 'redpen',
-\   'executable': 'redpen',
-\   'command': 'redpen -f markdown -r json %t',
-\   'callback': 'ale#handlers#redpen#HandleRedpenOutput',
-\})

ale_linters/nix/nix.vim

@@ -29,7 +29,7 @@ function! ale_linters#nix#nix#Handle(buffer, lines) abort
                     \     'type': 'E',
                     \     'lnum': l:result.line,
                     \     'col': l:result.column,
-                    \     'text': l:result.raw_msg
+                    \     'text': substitute(l:result.raw_msg, '\e\[[0-9;]*m', '', 'g'),
                     \})
                 endif
             endif

ale_linters/nroff/proselint.vim

@@ -1,9 +1,11 @@
 " Author: Daniel M. Capella https://github.com/polyzen
 " Description: proselint for nroff files
 
+call ale#Set('proselint_executable', 'proselint')
+
 call ale#linter#Define('nroff', {
 \   'name': 'proselint',
-\   'executable': 'proselint',
+\   'executable': function('ale#proselint#GetExecutable'),
-\   'command': 'proselint %t',
+\   'command': function('ale#proselint#GetCommandWithVersionCheck'),
 \   'callback': 'ale#handlers#unix#HandleAsWarning',
 \})

ale_linters/perl/languageserver.vim

@@ -0,0 +1,49 @@
+" Authors: ophirr33 <coghlan.ty@gmail.com>, rymdbar <https://rymdbar.x20.se/>
+" Description: Perl::LanguageServer for perl, from cpan.org
+
+" This should have the same value as in perl.vim
+call ale#Set('perl_perl_executable', 'perl')
+" Please note that perl_perl_options does not exist here.
+
+function! ale_linters#perl#languageserver#GetProjectRoot(buffer) abort
+    " Makefile.PL, https://perldoc.perl.org/ExtUtils::MakeMaker
+    " Build.PL, https://metacpan.org/pod/Module::Build
+    " dist.ini, https://metacpan.org/pod/Dist::Zilla
+    let l:potential_roots = [ 'Makefile.PL', 'Build.PL', 'dist.ini' ]
+
+    for l:root in l:potential_roots
+        let l:project_root = ale#path#FindNearestFile(a:buffer, l:root)
+
+        if !empty(l:project_root)
+            return fnamemodify(l:project_root . '/', ':p:h:h')
+        endif
+    endfor
+
+    let l:project_root = ale#path#FindNearestFileOrDirectory(a:buffer, '.git')
+
+    if !empty(l:project_root)
+        return fnamemodify(l:project_root . '/', ':p:h:h')
+    endif
+
+    return fnamemodify(expand('#' . a:buffer . ':p:h'), ':p:h')
+endfunction
+
+call ale#Set('perl_languageserver_config', {})
+
+function! s:get_lsp_config(buffer) abort
+    " This tool doesn't kick in unless workspace/didChangeConfiguration is
+    " called, thus this function returning a fallback dict when there is no
+    " config.
+    let l:lsp_config = ale#Var(a:buffer, 'perl_languageserver_config')
+
+    return empty(l:lsp_config) ? { 'perl': { 'enable': 1 } } : l:lsp_config
+endfunction
+
+call ale#linter#Define('perl', {
+\   'name': 'languageserver',
+\   'lsp': 'stdio',
+\   'executable': {b -> ale#Var(b, 'perl_perl_executable')},
+\   'command': '%e -MPerl::LanguageServer -ePerl::LanguageServer::run',
+\   'lsp_config': {b -> s:get_lsp_config(b)},
+\   'project_root': function('ale_linters#perl#languageserver#GetProjectRoot'),
+\ })

ale_linters/php/phpactor.vim

@@ -1,6 +1,9 @@
 " Author: Arizard <https://github.com/Arizard>
 " Description: PHPactor integration for ALE
 
+call ale#Set('php_phpactor_executable', 'phpactor')
+call ale#Set('php_phpactor_init_options', {})
+
 " Copied from langserver.vim
 function! ale_linters#php#phpactor#GetProjectRoot(buffer) abort
     let l:composer_path = ale#path#FindNearestFile(a:buffer, 'composer.json')
@@ -17,7 +20,8 @@ endfunction
 call ale#linter#Define('php', {
 \   'name': 'phpactor',
 \   'lsp': 'stdio',
-\   'executable': 'phpactor',
+\   'executable': {b -> ale#Var(b, 'php_phpactor_executable')},
 \   'command': '%e language-server',
+\   'initialization_options': {b -> ale#Var(b, 'php_phpactor_init_options')},
 \   'project_root': function('ale_linters#php#phpactor#GetProjectRoot'),
 \})

ale_linters/php/phpstan.vim

@@ -27,6 +27,10 @@ function! ale_linters#php#phpstan#GetCommand(buffer, version) abort
 
     let l:level =  ale#Var(a:buffer, 'php_phpstan_level')
 
+    if type(l:level) is v:t_number
+        let l:level = string(l:level)
+    endif
+
     if empty(l:level) && empty(ale_linters#php#phpstan#FindConfigFile(a:buffer))
         " if no configuration file is found, then use 4 as a default level
         let l:level = '4'
@@ -83,6 +87,10 @@ function! ale_linters#php#phpstan#FindConfigFile(buffer) abort
         let l:result = ale#path#FindNearestFile(a:buffer, 'phpstan.neon.dist')
     endif
 
+    if empty(l:result)
+        let l:result = ale#path#FindNearestFile(a:buffer, 'phpstan.dist.neon')
+    endif
+
     return l:result
 endfunction
 

ale_linters/php/tlint.vim

@@ -31,7 +31,7 @@ function! ale_linters#php#tlint#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'php_tlint_options')
 
     return ale#node#Executable(a:buffer, l:executable)
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . ' lint %s'
 endfunction
 

ale_linters/po/proselint.vim

@@ -1,9 +1,11 @@
 " Author: Cian Butler https://github.com/butlerx
 " Description: proselint for PO files
 
+call ale#Set('proselint_executable', 'proselint')
+
 call ale#linter#Define('po', {
 \   'name': 'proselint',
-\   'executable': 'proselint',
+\   'executable': function('ale#proselint#GetExecutable'),
-\   'command': 'proselint %t',
+\   'command': function('ale#proselint#GetCommandWithVersionCheck'),
 \   'callback': 'ale#handlers#unix#HandleAsWarning',
 \})

ale_linters/pod/proselint.vim

@@ -1,9 +1,11 @@
 " Author: Daniel M. Capella https://github.com/polyzen
 " Description: proselint for Pod files
 
+call ale#Set('proselint_executable', 'proselint')
+
 call ale#linter#Define('pod', {
 \   'name': 'proselint',
-\   'executable': 'proselint',
+\   'executable': function('ale#proselint#GetExecutable'),
-\   'command': 'proselint %t',
+\   'command': function('ale#proselint#GetCommandWithVersionCheck'),
 \   'callback': 'ale#handlers#unix#HandleAsWarning',
 \})

ale_linters/proto/buf_lint.vim

@@ -11,7 +11,7 @@ function! ale_linters#proto#buf_lint#GetCommand(buffer) abort
 
     return '%e lint'
     \ . (!empty(l:config) ? ' --config=' . ale#Escape(l:config) : '')
-    \ . (!empty(l:options) ? ' ' . l:options : '')
+    \ . ale#Pad(l:options)
     \ . ' %s#include_package_files=true'
 endfunction
 

ale_linters/python/flake8.vim

@@ -87,7 +87,7 @@ function! ale_linters#python#flake8#GetCommand(buffer, version) abort
     let l:options = ale#Var(a:buffer, 'python_flake8_options')
 
     return ale#Escape(l:executable) . l:exec_args
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . ' --format=default'
     \   . l:display_name_args . ' -'
 endfunction

ale_linters/python/pyrefly.vim

@@ -0,0 +1,57 @@
+" Author: oliverralbertini <oliver.albertini@gmail.com>
+" Description: A performant type-checker supporting LSP for Python 3 created by Facebook
+
+call ale#Set('python_pyrefly_executable', 'pyrefly')
+call ale#Set('python_pyrefly_use_global', get(g:, 'ale_use_global_executables', 0))
+call ale#Set('python_pyrefly_auto_pipenv', 0)
+call ale#Set('python_pyrefly_auto_poetry', 0)
+call ale#Set('python_pyrefly_auto_uv', 0)
+
+function! ale_linters#python#pyrefly#GetExecutable(buffer) abort
+    if (ale#Var(a:buffer, 'python_auto_pipenv') || ale#Var(a:buffer, 'python_pyrefly_auto_pipenv'))
+    \ && ale#python#PipenvPresent(a:buffer)
+        return 'pipenv'
+    endif
+
+    if (ale#Var(a:buffer, 'python_auto_poetry') || ale#Var(a:buffer, 'python_pyrefly_auto_poetry'))
+    \ && ale#python#PoetryPresent(a:buffer)
+        return 'poetry'
+    endif
+
+    if (ale#Var(a:buffer, 'python_auto_uv') || ale#Var(a:buffer, 'python_pyrefly_auto_uv'))
+    \ && ale#python#UvPresent(a:buffer)
+        return 'uv'
+    endif
+
+    return ale#python#FindExecutable(a:buffer, 'python_pyrefly', ['pyrefly'])
+endfunction
+
+function! ale_linters#python#pyrefly#GetCommand(buffer) abort
+    let l:executable = ale_linters#python#pyrefly#GetExecutable(a:buffer)
+    let l:exec_args = [
+    \ ale#Escape(l:executable)
+    \ ]
+    \ + (l:executable =~? '\(pipenv\|poetry\|uv\)$' ? ['run', 'pyrefly'] : [])
+    \ + [
+    \ 'lsp',
+    \ ]
+
+    return join(l:exec_args, ' ')
+endfunction
+
+function! ale_linters#python#pyrefly#GetCwd(buffer) abort
+    " Run from project root if found, else from buffer dir.
+    let l:project_root = ale#python#FindProjectRoot(a:buffer)
+
+    return !empty(l:project_root) ? l:project_root : '%s:h'
+endfunction
+
+call ale#linter#Define('python', {
+\   'name': 'pyrefly',
+\   'lsp': 'stdio',
+\   'executable': function('ale_linters#python#pyrefly#GetExecutable'),
+\   'command': function('ale_linters#python#pyrefly#GetCommand'),
+\   'project_root': function('ale#python#FindProjectRoot'),
+\   'completion_filter': 'ale#completion#python#CompletionItemFilter',
+\   'cwd': function('ale_linters#python#pyrefly#GetCwd'),
+\})

ale_linters/python/ruff.vim

@@ -34,6 +34,22 @@ function! ale_linters#python#ruff#GetExecutable(buffer) abort
     return ale#python#FindExecutable(a:buffer, 'python_ruff', ['ruff'])
 endfunction
 
+function! ale_linters#python#ruff#RunWithVersionCheck(buffer) abort
+    let l:executable = ale_linters#python#ruff#GetExecutable(a:buffer)
+    let l:exec_args = l:executable =~? '\(pipenv\|poetry\|uv\)$'
+    \   ? ' run ruff'
+    \   : ''
+
+    let l:command = ale#Escape(l:executable) . l:exec_args . ' --version'
+
+    return ale#semver#RunWithVersionCheck(
+    \   a:buffer,
+    \   l:executable,
+    \   l:command,
+    \   function('ale_linters#python#ruff#GetCommand'),
+    \)
+endfunction
+
 function! ale_linters#python#ruff#GetCwd(buffer) abort
     if ale#Var(a:buffer, 'python_ruff_change_directory')
         " Run from project root if found, else from buffer dir.
@@ -72,20 +88,35 @@ function! ale_linters#python#ruff#Handle(buffer, lines) abort
         try
             let l:item = json_decode(l:line)
         catch
-            let l:item = v:null
+            " If we can't decode a line, skip it.
+            continue
         endtry
 
-        if !empty(l:item)
+        if empty(l:item)
-            call add(l:output, {
+            continue
-            \   'lnum': l:item.location.row,
-            \   'col': l:item.location.column,
-            \   'end_lnum': l:item.end_location.row,
-            \   'end_col': l:item.end_location.column - 1,
-            \   'code': l:item.code,
-            \   'text': l:item.message,
-            \   'type': l:item.code =~? '\vE\d+' ? 'E' : 'W',
-            \})
         endif
+
+        if (l:item.code is# 'W291' || l:item.code is# 'W293')
+        \&& !ale#Var(a:buffer, 'warn_about_trailing_whitespace')
+            " Skip warnings for trailing whitespace if the option is off.
+            continue
+        endif
+
+        if l:item.code is# 'W391'
+        \&& !ale#Var(a:buffer, 'warn_about_trailing_blank_lines')
+            " Skip warnings for trailing blank lines if the option is off
+            continue
+        endif
+
+        call add(l:output, {
+        \   'lnum': l:item.location.row,
+        \   'col': l:item.location.column,
+        \   'end_lnum': l:item.end_location.row,
+        \   'end_col': l:item.end_location.column - 1,
+        \   'code': l:item.code,
+        \   'text': l:item.message,
+        \   'type': l:item.code =~? '\vE\d+' ? 'E' : 'W',
+        \})
     endfor
 
     return l:output
@@ -95,12 +126,7 @@ call ale#linter#Define('python', {
 \   'name': 'ruff',
 \   'executable': function('ale_linters#python#ruff#GetExecutable'),
 \   'cwd': function('ale_linters#python#ruff#GetCwd'),
-\   'command': {buffer -> ale#semver#RunWithVersionCheck(
+\   'command': function('ale_linters#python#ruff#RunWithVersionCheck'),
-\       buffer,
-\       ale_linters#python#ruff#GetExecutable(buffer),
-\       '%e --version',
-\       function('ale_linters#python#ruff#GetCommand'),
-\   )},
 \   'callback': 'ale_linters#python#ruff#Handle',
 \   'output_stream': 'both',
 \   'read_buffer': 1,

ale_linters/rego/opacheck.vim

@@ -12,7 +12,7 @@ function! ale_linters#rego#opacheck#GetCommand(buffer) abort
 
     return ale#Escape(ale_linters#rego#opacheck#GetExecutable(a:buffer))
     \   . ' check %s:h --format json '
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
 endfunction
 
 function! ale_linters#rego#opacheck#Handle(buffer, lines) abort

ale_linters/rescript/rescript_language_server.vim

@@ -0,0 +1,24 @@
+" Author: John Jackson <john@johnridesa.bike>
+" Description: The official language server for ReScript.
+
+call ale#Set('rescript_language_server_executable', 'rescript-language-server')
+call ale#Set(
+\   'rescript_language_server_use_global',
+\   get(g:, 'ale_use_global_executables', v:true),
+\ )
+
+function! s:GetProjectRoot(buffer) abort
+    let l:config_file = ale#path#FindNearestFile(a:buffer, 'rescript.json')
+
+    return !empty(l:config_file) ? fnamemodify(l:config_file, ':h') : ''
+endfunction
+
+call ale#linter#Define('rescript', {
+\   'name': 'rescript_language_server',
+\   'lsp': 'stdio',
+\   'executable': {b -> ale#path#FindExecutable(b, 'rescript_language_server', [
+\       'node_modules/.bin/rescript-language-server'
+\   ])},
+\   'command': '%e --stdio',
+\   'project_root': function('s:GetProjectRoot'),
+\})

ale_linters/review/redpen.vim

@@ -1,9 +1,4 @@
 " Author: rhysd https://rhysd.github.io
 " Description: Redpen, a proofreading tool (http://redpen.cc)
 
-call ale#linter#Define('review', {
+call ale#handlers#redpen#DefineLinter('review')
-\   'name': 'redpen',
-\   'executable': 'redpen',
-\   'command': 'redpen -f review -r json %t',
-\   'callback': 'ale#handlers#redpen#HandleRedpenOutput',
-\})

ale_linters/roc/roc_language_server.vim

@@ -0,0 +1,25 @@
+" Author: Benjamin Block <https://github.com/benjamindblock>
+" Description: A language server for Roc.
+
+function! ale_linters#roc#roc_language_server#GetProjectRoot(buffer) abort
+    let l:roc_main_file = ale#path#FindNearestFile(a:buffer, 'main.roc')
+
+    if !empty(l:roc_main_file)
+        return fnamemodify(l:roc_main_file, ':p:h')
+    else
+        return fnamemodify('', ':h')
+    endif
+endfunction
+
+call ale#Set('roc_roc_language_server_executable', 'roc_language_server')
+call ale#Set('roc_roc_language_server_config', {})
+
+call ale#linter#Define('roc', {
+\   'name': 'roc_language_server',
+\   'lsp': 'stdio',
+\   'language': 'roc',
+\   'lsp_config': {b -> ale#Var(b, 'roc_roc_language_server_config')},
+\   'executable': {b -> ale#Var(b, 'roc_roc_language_server_executable')},
+\   'command': '%e',
+\   'project_root': function('ale_linters#roc#roc_language_server#GetProjectRoot'),
+\})

ale_linters/rst/proselint.vim

@@ -1,9 +1,11 @@
 " Author: Daniel M. Capella https://github.com/polyzen
-" Description: proselint for reStructuredText files
+" Description: proselint for reStructuredrst files
+
+call ale#Set('proselint_executable', 'proselint')
 
 call ale#linter#Define('rst', {
 \   'name': 'proselint',
-\   'executable': 'proselint',
+\   'executable': function('ale#proselint#GetExecutable'),
-\   'command': 'proselint %t',
+\   'command': function('ale#proselint#GetCommandWithVersionCheck'),
 \   'callback': 'ale#handlers#unix#HandleAsWarning',
 \})

ale_linters/rst/redpen.vim

@@ -1,9 +1,4 @@
 " Author: rhysd https://rhysd.github.io
 " Description: Redpen, a proofreading tool (http://redpen.cc)
 
-call ale#linter#Define('rst', {
+call ale#handlers#redpen#DefineLinter('rst')
-\   'name': 'redpen',
-\   'executable': 'redpen',
-\   'command': 'redpen -f rest -r json %t',
-\   'callback': 'ale#handlers#redpen#HandleRedpenOutput',
-\})

ale_linters/rst/rstcheck.vim

@@ -1,5 +1,13 @@
-" Author: John Nduli https://github.com/jnduli
+" Authors:
-" Description: Rstcheck for reStructuredText files
+"   John Nduli https://github.com/jnduli,
+"   Michael Goerz https://github.com/goerz
+
+call ale#Set('rst_rstcheck_executable', 'rstcheck')
+call ale#Set('rst_rstcheck_options', '')
+
+function! ale_linters#rst#rstcheck#GetExecutable(buffer) abort
+    return ale#Var(a:buffer, 'rst_rstcheck_executable')
+endfunction
 
 function! ale_linters#rst#rstcheck#Handle(buffer, lines) abort
     " matches: 'bad_rst.rst:1: (SEVERE/4) Title overline & underline
@@ -21,11 +29,35 @@ function! ale_linters#rst#rstcheck#Handle(buffer, lines) abort
     return l:output
 endfunction
 
+function! ale_linters#rst#rstcheck#GetCommand(buffer, version) abort
+    let l:executable = ale_linters#rst#rstcheck#GetExecutable(a:buffer)
+    let l:options = ale#Var(a:buffer, 'rst_rstcheck_options')
+    let l:dir = expand('#' . a:buffer . ':p:h')
+    let l:exec_args = ale#Pad(l:options)
+
+    if ale#semver#GTE(a:version, [3, 4, 0])
+        let l:exec_args .= ' --config ' . ale#Escape(l:dir)
+    endif
+
+    return ale#Escape(l:executable)
+    \   . l:exec_args
+    \   . ' %t'
+endfunction
+
+function! ale_linters#rst#rstcheck#GetCommandWithVersionCheck(buffer) abort
+    return ale#semver#RunWithVersionCheck(
+    \   a:buffer,
+    \   ale_linters#rst#rstcheck#GetExecutable(a:buffer),
+    \   '%e --version',
+    \   function('ale_linters#rst#rstcheck#GetCommand')
+    \)
+endfunction
+
 call ale#linter#Define('rst', {
 \   'name': 'rstcheck',
 \   'executable': 'rstcheck',
 \   'cwd': '%s:h',
-\   'command': 'rstcheck %t',
+\   'command': function('ale_linters#rst#rstcheck#GetCommandWithVersionCheck'),
 \   'callback': 'ale_linters#rst#rstcheck#Handle',
 \   'output_stream': 'both',
 \})

ale_linters/ruby/sorbet.vim

@@ -1,6 +1,7 @@
 call ale#Set('ruby_sorbet_executable', 'srb')
 call ale#Set('ruby_sorbet_options', '')
 call ale#Set('ruby_sorbet_enable_watchman', 0)
+call ale#Set('ruby_sorbet_initialization_options', { 'highlightUntyped': v:false })
 
 function! ale_linters#ruby#sorbet#GetCommand(buffer) abort
     let l:executable = ale#Var(a:buffer, 'ruby_sorbet_executable')
@@ -9,7 +10,7 @@ function! ale_linters#ruby#sorbet#GetCommand(buffer) abort
 
     return ale#ruby#EscapeExecutable(l:executable, 'srb')
     \   . ' tc'
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . ' --lsp'
     \   . (l:enable_watchman ? '' : ' --disable-watchman')
 endfunction
@@ -21,6 +22,6 @@ call ale#linter#Define('ruby', {
 \   'language': 'ruby',
 \   'executable': {b -> ale#Var(b, 'ruby_sorbet_executable')},
 \   'command': function('ale_linters#ruby#sorbet#GetCommand'),
-\   'project_root': function('ale#ruby#FindProjectRoot')
+\   'project_root': function('ale#ruby#FindProjectRoot'),
+\   'initialization_options': {b -> ale#Var(b, 'ruby_sorbet_initialization_options')}
 \})
-

ale_linters/rust/rustc.vim

@@ -20,7 +20,7 @@ function! ale_linters#rust#rustc#RustcCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'rust_rustc_options')
 
     return 'rustc --error-format=json'
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . l:dependencies . ' -'
 endfunction
 

ale_linters/sass/sasslint.vim

@@ -16,7 +16,7 @@ function! ale_linters#sass#sasslint#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'sass_sasslint_options')
 
     return ale#node#Executable(a:buffer, l:executable)
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . ' -v -q -f compact %t'
 endfunction
 

ale_linters/sass/stylelint.vim

@@ -9,6 +9,6 @@ call ale#linter#Define('sass', {
 \   'executable': {b -> ale#path#FindExecutable(b, 'sass_stylelint', [
 \       'node_modules/.bin/stylelint',
 \   ])},
-\   'command': '%e --stdin-filename %s',
+\   'command': '%e --no-color --stdin-filename %s',
 \   'callback': 'ale#handlers#css#HandleStyleLintFormat',
 \})

ale_linters/scala/metals.vim

@@ -13,6 +13,7 @@ function! ale_linters#scala#metals#GetProjectRoot(buffer) abort
 
     let l:potential_roots = [
     \   'build.sc',
+    \   'build.mill',
     \   'build.sbt',
     \   '.bloop',
     \   '.metals',

ale_linters/scss/sasslint.vim

@@ -16,7 +16,7 @@ function! ale_linters#scss#sasslint#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'scss_sasslint_options')
 
     return ale#node#Executable(a:buffer, l:executable)
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . ' -v -q -f compact %t'
 endfunction
 

ale_linters/scss/stylelint.vim

@@ -6,7 +6,7 @@ call ale#Set('scss_stylelint_use_global', get(g:, 'ale_use_global_executables',
 
 function! ale_linters#scss#stylelint#GetCommand(buffer) abort
     return '%e ' . ale#Pad(ale#Var(a:buffer, 'scss_stylelint_options'))
-    \   . ' --stdin-filename %s'
+    \   . ' --no-color --stdin-filename %s'
 endfunction
 
 call ale#linter#Define('scss', {

ale_linters/sh/language_server.vim

@@ -25,6 +25,7 @@ endfunction
 
 call ale#linter#Define('sh', {
 \   'name': 'language_server',
+\   'aliases': ['bash-language-server'],
 \   'lsp': 'stdio',
 \   'executable': function('ale_linters#sh#language_server#GetExecutable'),
 \   'command': function('ale_linters#sh#language_server#GetCommand'),

ale_linters/stylus/stylelint.vim

@@ -7,7 +7,7 @@ call ale#Set('stylus_stylelint_use_global', get(g:, 'ale_use_global_executables'
 function! ale_linters#stylus#stylelint#GetCommand(buffer) abort
     return '%e'
     \   . ale#Pad(ale#Var(a:buffer, 'stylus_stylelint_options'))
-    \   . ' --stdin-filename %s'
+    \   . ' --no-color --stdin-filename %s'
 endfunction
 
 call ale#linter#Define('stylus', {

ale_linters/sugarss/stylelint.vim

@@ -8,7 +8,7 @@ call ale#Set('sugarss_stylelint_use_global', get(g:, 'ale_use_global_executables
 function! ale_linters#sugarss#stylelint#GetCommand(buffer) abort
     return '%e ' . ale#Pad(ale#Var(a:buffer, 'sugarss_stylelint_options'))
     \   . ' --syntax=sugarss'
-    \   . ' --stdin-filename %s'
+    \   . ' --no-color --stdin-filename %s'
 endfunction
 
 call ale#linter#Define('sugarss', {

ale_linters/tex/proselint.vim

@@ -1,9 +1,11 @@
 " Author: poohzrn https://github.com/poohzrn
 " Description: proselint for TeX files
 
+call ale#Set('proselint_executable', 'proselint')
+
 call ale#linter#Define('tex', {
 \   'name': 'proselint',
-\   'executable': 'proselint',
+\   'executable': function('ale#proselint#GetExecutable'),
-\   'command': 'proselint %t',
+\   'command': function('ale#proselint#GetCommandWithVersionCheck'),
 \   'callback': 'ale#handlers#unix#HandleAsWarning',
 \})

ale_linters/tex/redpen.vim

@@ -1,9 +1,4 @@
 " Author: rhysd https://rhysd.github.io
 " Description: Redpen, a proofreading tool (http://redpen.cc)
 
-call ale#linter#Define('tex', {
+call ale#handlers#redpen#DefineLinter('tex')
-\   'name': 'redpen',
-\   'executable': 'redpen',
-\   'command': 'redpen -f latex -r json %t',
-\   'callback': 'ale#handlers#redpen#HandleRedpenOutput',
-\})

ale_linters/texinfo/proselint.vim

@@ -1,9 +1,11 @@
 " Author: Daniel M. Capella https://github.com/polyzen
 " Description: proselint for Texinfo files
 
+call ale#Set('proselint_executable', 'proselint')
+
 call ale#linter#Define('texinfo', {
 \   'name': 'proselint',
-\   'executable': 'proselint',
+\   'executable': function('ale#proselint#GetExecutable'),
-\   'command': 'proselint %t',
+\   'command': function('ale#proselint#GetCommandWithVersionCheck'),
 \   'callback': 'ale#handlers#unix#HandleAsWarning',
 \})

ale_linters/text/proselint.vim

@@ -1,9 +1,11 @@
 " Author: poohzrn https://github.com/poohzrn
 " Description: proselint for text files
 
+call ale#Set('proselint_executable', 'proselint')
+
 call ale#linter#Define('text', {
 \   'name': 'proselint',
-\   'executable': 'proselint',
+\   'executable': function('ale#proselint#GetExecutable'),
-\   'command': 'proselint %t',
+\   'command': function('ale#proselint#GetCommandWithVersionCheck'),
 \   'callback': 'ale#handlers#unix#HandleAsWarning',
 \})

ale_linters/text/redpen.vim

@@ -1,9 +1,4 @@
 " Author: rhysd https://rhysd.github.io
 " Description: Redpen, a proofreading tool (http://redpen.cc)
 
-call ale#linter#Define('text', {
+call ale#handlers#redpen#DefineLinter('text')
-\   'name': 'redpen',
-\   'executable': 'redpen',
-\   'command': 'redpen -f plain -r json %t',
-\   'callback': 'ale#handlers#redpen#HandleRedpenOutput',
-\})

ale_linters/text/vale.vim

@@ -1,9 +1,22 @@
 " Author: chew-z https://github.com/chew-z
 " Description: vale for text files
 
+call ale#Set('vale_executable', 'vale')
+call ale#Set('vale_options', '')
+
+function! ale_linters#text#vale#GetCommand(buffer) abort
+    let l:executable = ale#Var(a:buffer, 'vale_executable')
+
+    let l:options = ale#Var(a:buffer, 'vale_options')
+
+    return ale#Escape(l:executable)
+    \   . ale#Pad(l:options)
+    \   . ' --output=JSON %t'
+endfunction
+
 call ale#linter#Define('text', {
 \   'name': 'vale',
 \   'executable': 'vale',
-\   'command': 'vale --output=JSON %t',
+\   'command': function('ale_linters#text#vale#GetCommand'),
 \   'callback': 'ale#handlers#vale#Handle',
 \})

ale_linters/toml/tombi.vim

@@ -0,0 +1,51 @@
+" Author: Ben Boeckel <github@me.benboeckel.net>
+" Description: TOML Formatter / Linter / Language Server
+
+call ale#Set('toml_tombi_executable', 'tombi')
+call ale#Set('toml_tombi_lsp_options', '')
+call ale#Set('toml_tombi_online', 0)
+
+function! ale_linters#toml#tombi#GetCommand(buffer) abort
+    let l:offline = ''
+
+    if !ale#Var(a:buffer, 'toml_tombi_online')
+        let l:offline = '--offline'
+    endif
+
+    return '%e lsp'
+    \       . ale#Pad(l:offline)
+    \       . ale#Pad(ale#Var(a:buffer, 'toml_tombi_lsp_options'))
+endfunction
+
+function! ale_linters#toml#tombi#GetProjectRoot(buffer) abort
+    " Try to find nearest tombi.toml
+    let l:tombiconfig_file = ale#path#FindNearestFile(a:buffer, 'tombi.toml')
+
+    if !empty(l:tombiconfig_file)
+        return fnamemodify(l:tombiconfig_file . '/', ':p:h:h')
+    endif
+
+    " Try to find nearest pyproject.toml
+    let l:pyproject_file = ale#path#FindNearestFile(a:buffer, 'pyproject.toml')
+
+    if !empty(l:pyproject_file)
+        return fnamemodify(l:pyproject_file . '/', ':p:h:h')
+    endif
+
+    " Try to find nearest `git` directory
+    let l:gitdir = ale#path#FindNearestFile(a:buffer, '.git')
+
+    if !empty(l:gitdir)
+        return fnamemodify(l:gitdir . '/', ':p:h:h')
+    endif
+
+    return ''
+endfunction
+
+call ale#linter#Define('toml', {
+\   'name': 'tombi',
+\   'lsp': 'stdio',
+\   'executable': {b -> ale#Var(b, 'toml_tombi_executable')},
+\   'command': function('ale_linters#toml#tombi#GetCommand'),
+\   'project_root': function('ale_linters#toml#tombi#GetProjectRoot'),
+\})

ale_linters/typescript/standard.vim

@@ -18,7 +18,7 @@ function! ale_linters#typescript#standard#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'typescript_standard_options')
 
     return ale#node#Executable(a:buffer, l:executable)
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . ' --stdin %s'
 endfunction
 

ale_linters/verilog/slang.vim

@@ -9,7 +9,9 @@ endif
 " --lint-only
 function! ale_linters#verilog#slang#GetCommand(buffer) abort
     return 'slang -Weverything '
+    \   . '--diag-abs-paths '
     \   . '-I%s:h '
+    \   . '-y%s:h '
     \   . ale#Var(a:buffer, 'verilog_slang_options') .' '
     \   . '%t'
 endfunction
@@ -28,6 +30,7 @@ function! ale_linters#verilog#slang#Handle(buffer, lines) abort
 
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
         let l:item = {
+        \   'filename': l:match[1],
         \   'lnum': str2nr(l:match[2]),
         \   'type': (l:match[4] is# 'error') ? 'E' : 'W',
         \   'text': s:RemoveUnicodeQuotes(l:match[5]),

ale_linters/verilog/verible_ls.vim

@@ -0,0 +1,43 @@
+" Author: Nicolas Derumigny <https://github.com/nicolasderumigny>
+" Description: Verible LSP for verilog
+
+call ale#Set('verilog_verible_ls_options', '--rules_config_search')
+call ale#Set('verilog_verible_ls_rules', '')
+call ale#Set('verilog_verible_ls_executable', 'verible-verilog-ls')
+call ale#Set('verilog_verible_ls_config', {})
+
+function! ale_linters#verilog#verible_ls#GetProjectRoot(buffer) abort
+    let l:git_dir = ale#path#FindNearestFile(a:buffer, 'verible.filelist')
+
+    if !empty(l:git_dir)
+        return fnamemodify(l:git_dir, ':p:h')
+    else
+        return fnamemodify('', ':h')
+    endif
+endfunction
+
+function! ale_linters#verilog#verible_ls#GetCommand(buffer) abort
+    let l:command = ale#Escape(ale#Var(a:buffer, 'verilog_verible_ls_executable'))
+    let l:options = ale#Var(a:buffer, 'verilog_verible_ls_options')
+    let l:rules = ale#Var(a:buffer, 'verilog_verible_ls_rules')
+
+    if l:options isnot# ''
+        let l:command .= ' ' . l:options
+    endif
+
+    if l:rules isnot# ''
+        let l:command .= ' --rules=' . l:rules
+    endif
+
+    return l:command
+endfunction
+
+
+call ale#linter#Define('verilog', {
+\   'name': 'verible_ls',
+\   'lsp': 'stdio',
+\   'lsp_config': {b -> ale#Var(b, 'verilog_verible_ls_config')},
+\   'executable': {b -> ale#Var(b, 'verilog_verible_ls_executable')},
+\   'command': function('ale_linters#verilog#verible_ls#GetCommand') ,
+\   'project_root': function('ale_linters#verilog#verible_ls#GetProjectRoot'),
+\})

ale_linters/verilog/verilator.vim

@@ -10,6 +10,7 @@ function! ale_linters#verilog#verilator#GetCommand(buffer) abort
     " the path to the current file is systematically added to the search path
     return 'verilator --lint-only -Wall -Wno-DECLFILENAME '
     \   . '-I%s:h '
+    \   . '-y %s:h '
     \   . ale#Var(a:buffer, 'verilog_verilator_options') .' '
     \   . '%t'
 endfunction

ale_linters/xhtml/proselint.vim

@@ -1,9 +1,11 @@
 " Author: Daniel M. Capella https://github.com/polyzen
 " Description: proselint for XHTML files
 
+call ale#Set('proselint_executable', 'proselint')
+
 call ale#linter#Define('xhtml', {
 \   'name': 'proselint',
-\   'executable': 'proselint',
+\   'executable': function('ale#proselint#GetExecutable'),
-\   'command': 'proselint %t',
+\   'command': function('ale#proselint#GetCommandWithVersionCheck'),
 \   'callback': 'ale#handlers#unix#HandleAsWarning',
 \})

autoload/ale.vim

@@ -48,7 +48,7 @@ function! ale#ShouldDoNothing(buffer) abort
     endif
 
     " Do nothing for diff buffers.
-    if getbufvar(a:buffer, '&diff')
+    if getbufvar(a:buffer, '&diff') && !get(g:, 'ale_lint_diff', 0)
         return 1
     endif
 

autoload/ale/c.vim

@@ -12,6 +12,8 @@ let g:__ale_c_project_filenames = ['.git/HEAD', 'configure', 'Makefile', 'CMakeL
 
 let g:ale_c_build_dir_names = get(g:, 'ale_c_build_dir_names', [
 \   'build',
+\   'build/Debug',
+\   'build/Release',
 \   'bin',
 \])
 
@@ -244,14 +246,31 @@ function! ale#c#FindCompileCommands(buffer) abort
         return [fnamemodify(l:json_file, ':h'), l:json_file]
     endif
 
+    " Something somewhere seems to delete this setting in tests, so ensure
+    " we always have a default value.
+    call ale#Set('c_build_dir_names', [
+    \   'build',
+    \   'build/Debug',
+    \   'build/Release',
+    \   'bin',
+    \])
+
     " Search in build directories if we can't find it in the project.
     for l:path in ale#path#Upwards(expand('#' . a:buffer . ':p:h'))
         for l:dirname in ale#Var(a:buffer, 'c_build_dir_names')
-            let l:c_build_dir = l:path . s:sep . l:dirname
+            let l:c_build_dir = ale#path#GetAbsPath(l:path, l:dirname)
             let l:json_file = l:c_build_dir . s:sep . 'compile_commands.json'
 
             if filereadable(l:json_file)
-                return [l:path, l:json_file]
+                " For absolute build dir paths, use the parent
+                " of the build dir as the project root. For
+                " relative paths, use the directory found by
+                " searching upwards from the file.
+                let l:root = ale#path#IsAbsolute(l:dirname)
+                \   ? fnamemodify(l:c_build_dir, ':h')
+                \   : l:path
+
+                return [l:root, l:json_file]
             endif
         endfor
     endfor

autoload/ale/cursor.vim

@@ -23,7 +23,7 @@ function! ale#cursor#TruncatedEcho(original_message) abort
     " Change tabs to spaces.
     let l:message = substitute(l:message, "\t", ' ', 'g')
     " Remove any newlines in the message.
-    let l:message = substitute(l:message, "\n", '', 'g')
+    let l:message = substitute(l:message, "\n", ' ', 'g')
     " Convert indentation groups into single spaces for better legibility when
     " put on a single line
     let l:message = substitute(l:message, ' \+', ' ', 'g')
@@ -93,6 +93,7 @@ function! ale#cursor#EchoCursorWarning(...) abort
         if !empty(l:loc)
             let l:format = ale#Var(l:buffer, 'echo_msg_format')
             let l:msg = ale#GetLocItemMessage(l:loc, l:format)
+
             call ale#cursor#TruncatedEcho(l:msg)
             let l:info.echoed = 1
         elseif get(l:info, 'echoed')

autoload/ale/fix.vim

@@ -78,7 +78,7 @@ function! ale#fix#ApplyFixes(buffer, output) abort
 
             if !l:data.ignore_file_changed_errors
                 " no-custom-checks
-                echoerr 'The file was changed before fixing finished'
+                echom 'The file was changed before fixing finished'
             endif
 
             return

autoload/ale/fix/registry.vim

@@ -192,6 +192,11 @@ let s:default_registry = {
 \       'suggested_filetypes': ['python'],
 \       'description': 'Tidy Python imports with pyflyby.',
 \   },
+\   'unimport': {
+\       'function': 'ale#fixers#unimport#Fix',
+\       'suggested_filetypes': ['python'],
+\       'description': 'unimport fixer',
+\   },
 \   'importjs': {
 \       'function': 'ale#fixers#importjs#Fix',
 \       'suggested_filetypes': ['javascript'],
@@ -452,6 +457,11 @@ let s:default_registry = {
 \       'suggested_filetypes': ['markdown'],
 \       'description': 'Fix markdown files with pandoc.',
 \   },
+\   'pymarkdown': {
+\       'function': 'ale#fixers#pymarkdown#Fix',
+\       'suggested_filetypes': ['markdown'],
+\       'description': 'Fix markdown files with pymarkdown.',
+\   },
 \   'shfmt': {
 \       'function': 'ale#fixers#shfmt#Fix',
 \       'suggested_filetypes': ['sh'],
@@ -667,6 +677,11 @@ let s:default_registry = {
 \       'suggested_filetypes': ['racket'],
 \       'description': 'Fix Racket files with raco fmt.',
 \   },
+\   'rescript_format': {
+\       'function': 'ale#fixers#rescript_format#Fix',
+\       'suggested_filetypes': ['rescript'],
+\       'description': 'Official formatter for ReScript.',
+\   },
 \   'ruff': {
 \       'function': 'ale#fixers#ruff#Fix',
 \       'suggested_filetypes': ['python'],
@@ -722,6 +737,36 @@ let s:default_registry = {
 \       'suggested_filetypes': ['typst'],
 \       'description': 'A formatter for Typst files',
 \   },
+\   'roc_format': {
+\       'function': 'ale#fixers#roc_format#Fix',
+\       'suggested_filetypes': ['roc'],
+\       'description': 'Formats Roc files.',
+\   },
+\   'roc_annotate': {
+\       'function': 'ale#fixers#roc_annotate#Fix',
+\       'suggested_filetypes': ['roc'],
+\       'description': 'Annotates all top-level definitions in Roc files.',
+\   },
+\   'tombi_format': {
+\       'function': 'ale#fixers#tombi_format#Fix',
+\       'suggested_filetypes': ['toml'],
+\       'description': 'Formats TOML files',
+\   },
+\   'tombi_lint': {
+\       'function': 'ale#fixers#tombi_lint#Fix',
+\       'suggested_filetypes': ['toml'],
+\       'description': 'Lints TOML files',
+\   },
+\   'verible_format': {
+\       'function': 'ale#fixers#verible_format#Fix',
+\       'suggested_filetypes': ['verilog'],
+\       'description': 'Formats verilog files using verible.',
+\   },
+\   'markdownlint': {
+\       'function': 'ale#fixers#markdownlint#Fix',
+\       'suggested_filetypes': ['markdown'],
+\       'description': 'Fix markdown files with markdownlint.',
+\   },
 \}
 
 " Reset the function registry to the default entries.

autoload/ale/fixers/autoflake.vim

@@ -38,7 +38,7 @@ function! ale#fixers#autoflake#Fix(buffer) abort
 
     return {
     \   'command': ale#Escape(l:executable) . l:exec_args
-    \       . (!empty(l:options) ? ' ' . l:options : '')
+    \       . ale#Pad(l:options)
     \       . ' --in-place '
     \       . ' %t',
     \   'read_temporary_file': 1,

autoload/ale/fixers/autoimport.vim

@@ -39,7 +39,7 @@ function! ale#fixers#autoimport#Fix(buffer) abort
     return {
     \   'cwd': '%s:h',
     \   'command': ale#Escape(l:executable) . l:exec_args
-    \       . (!empty(l:options) ? ' ' . l:options : '')
+    \       . ale#Pad(l:options)
     \       . ' -',
     \}
 endfunction

autoload/ale/fixers/autopep8.vim

@@ -38,7 +38,7 @@ function! ale#fixers#autopep8#Fix(buffer) abort
 
     return {
     \   'command': ale#Escape(l:executable) . l:exec_args
-    \       . (!empty(l:options) ? ' ' . l:options : '')
+    \       . ale#Pad(l:options)
     \       . ' -',
     \}
 endfunction

autoload/ale/fixers/biome.vim

@@ -1,12 +1,11 @@
 function! ale#fixers#biome#Fix(buffer) abort
     let l:executable = ale#handlers#biome#GetExecutable(a:buffer)
     let l:options = ale#Var(a:buffer, 'biome_options')
-    let l:apply = ale#Var(a:buffer, 'biome_fixer_apply_unsafe') ? '--apply-unsafe' : '--apply'
+    let l:unsafe = ale#Var(a:buffer, 'biome_fixer_apply_unsafe') ? ' --unsafe' : ''
 
     return {
-    \   'read_temporary_file': 1,
+    \   'command': ale#Escape(l:executable) . ' check '
-    \   'command': ale#Escape(l:executable) . ' check ' . l:apply
+    \       . '--write --stdin-file-path %s' . l:unsafe
-    \       . (!empty(l:options) ? ' ' . l:options : '')
+    \       . ale#Pad(l:options)
-    \       . ' %t'
     \}
 endfunction

autoload/ale/fixers/clangformat.vim

@@ -22,7 +22,7 @@ function! ale#fixers#clangformat#Fix(buffer) abort
     let l:use_local_file = ale#Var(a:buffer, 'c_clangformat_use_local_file')
 
     if l:style_option isnot# ''
-        let l:style_option = '-style=' . "'" . l:style_option . "'"
+        let l:style_option = '-style=' . ale#Escape(l:style_option)
     endif
 
     if l:use_local_file

autoload/ale/fixers/erblint.vim

@@ -28,7 +28,7 @@ function! ale#fixers#erblint#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'eruby_erblint_options')
 
     return ale#ruby#EscapeExecutable(l:executable, 'erblint')
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . ' --autocorrect --stdin %s'
 endfunction
 

autoload/ale/fixers/erlang_mode.vim

@@ -17,10 +17,11 @@ let s:variables = {
 \}
 
 function! ale#fixers#erlang_mode#Fix(buffer) abort
-    let emacs_executable =
+    let l:emacs_executable =
     \   ale#Var(a:buffer, 'erlang_erlang_mode_emacs_executable')
 
     let l:exprs = [
+    \   '(setq enable-local-variables :safe)',
     \   s:SetqDefault(a:buffer, s:variables),
     \   '(erlang-mode)',
     \   '(font-lock-fontify-region (point-min) (point-max))',

autoload/ale/fixers/gnatpp.vim

@@ -10,7 +10,7 @@ function! ale#fixers#gnatpp#Fix(buffer) abort
 
     return {
     \   'command': ale#Escape(l:executable)
-    \       . (!empty(l:options) ? ' ' . l:options : '')
+    \       . ale#Pad(l:options)
     \       . ' %t',
     \   'read_temporary_file': 1,
     \}

autoload/ale/fixers/golangci_lint.vim

@@ -1,32 +1,48 @@
 " Author: Ian Stapleton Cordasco <graffatcolmingov@gmail.com>
 " Description: Run golangci-lint with the --fix flag to autofix some issues
 
-call ale#Set('go_golangci_lint_options', '')
+call ale#Set('go_golangci_formatter_options', '')
-call ale#Set('go_golangci_lint_executable', 'golangci-lint')
+call ale#Set('go_golangci_formatter_executable', 'golangci-lint')
-call ale#Set('go_golangci_lint_package', 1)
 
-function! ale#fixers#golangci_lint#GetCommand(buffer) abort
+function! ale#fixers#golangci_lint#GetExecutable(buffer) abort
+    let l:executable = ale#Var(a:buffer, 'go_golangci_formatter_executable')
+
+    return l:executable
+endfunction
+
+function! ale#fixers#golangci_lint#GetCommand(buffer, version) abort
     let l:filename = expand('#' . a:buffer . ':t')
-    let l:executable = ale#Var(a:buffer, 'go_golangci_lint_executable')
+    let l:executable = ale#fixers#golangci_lint#GetExecutable(a:buffer)
-    let l:options = ale#Var(a:buffer, 'go_golangci_lint_options') . ' --fix'
+    let l:options = ale#Var(a:buffer, 'go_golangci_formatter_options')
-    let l:package_mode = ale#Var(a:buffer, 'go_golangci_lint_package')
     let l:env = ale#go#EnvString(a:buffer)
 
-
+    if ale#semver#GTE(a:version, [2, 0, 0])
-    if l:package_mode
         return l:env . ale#Escape(l:executable)
-        \   . ' run '
+        \   . ' fmt --stdin '
-        \   .  l:options
+        \   . l:options
+    else
+        return l:env . ale#Escape(l:executable)
+        \   . ' run --fix '
+        \   . l:options
+        \   . ' '
+        \   . ale#Escape(l:filename)
     endif
+endfunction
 
-    return l:env . ale#Escape(l:executable)
+function! ale#fixers#golangci_lint#GetCommandForVersion(buffer, version) abort
-    \   . ' run '
+    return {
-    \   . l:options
+    \ 'command': ale#fixers#golangci_lint#GetCommand(a:buffer, a:version)
-    \   . ' ' . ale#Escape(l:filename)
+    \}
 endfunction
 
 function! ale#fixers#golangci_lint#Fix(buffer) abort
-    return {
+    let l:executable =  ale#fixers#golangci_lint#GetExecutable(a:buffer)
-    \  'command': ale#fixers#golangci_lint#GetCommand(a:buffer),
+    let l:command = ale#fixers#golangci_lint#GetExecutable(a:buffer) . ale#Pad('--version')
-    \}
+
+    return ale#semver#RunWithVersionCheck(
+    \   a:buffer,
+    \   l:executable,
+    \   l:command,
+    \   function('ale#fixers#golangci_lint#GetCommandForVersion'),
+    \)
 endfunction

autoload/ale/fixers/markdownlint.vim

@@ -0,0 +1,15 @@
+:scriptencoding utf-8
+
+call ale#Set('markdownlint_executable', 'markdownlint')
+call ale#Set('markdownlint_options', '--fix')
+
+function! ale#fixers#markdownlint#Fix(buffer) abort
+    let l:executable = ale#Var(a:buffer, 'markdownlint_executable')
+    let l:options = ale#Var(a:buffer, 'markdownlint_options')
+
+    return {
+    \   'command': ale#Escape(l:executable)
+    \       . ' ' . l:options,
+    \}
+endfunction
+

autoload/ale/fixers/mix_format.vim

@@ -13,7 +13,7 @@ function! ale#fixers#mix_format#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'elixir_mix_format_options')
 
     return l:executable . ' format'
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . ' %t'
 endfunction
 

autoload/ale/fixers/npmgroovylint.vim

@@ -9,7 +9,7 @@ function! ale#fixers#npmgroovylint#Fix(buffer) abort
 
     return {
     \   'command': ale#Escape(l:executable)
-    \       . (!empty(l:options) ? ' ' . l:options : '')
+    \       . ale#Pad(l:options)
     \       . ' %t',
     \   'read_temporary_file': 1,
     \}

autoload/ale/fixers/prettier.vim

@@ -99,7 +99,7 @@ function! ale#fixers#prettier#ApplyFixForVersion(buffer, version) abort
         return {
         \   'cwd': '%s:h',
         \   'command':ale#Escape(l:executable)
-        \       . (!empty(l:options) ? ' ' . l:options : '')
+        \       . ale#Pad(l:options)
         \       . ' --stdin-filepath %s --stdin',
         \   'process_with': 'ale#fixers#prettier#ProcessPrettierDOutput',
         \}
@@ -110,7 +110,7 @@ function! ale#fixers#prettier#ApplyFixForVersion(buffer, version) abort
         return {
         \   'cwd': ale#fixers#prettier#GetCwd(a:buffer),
         \   'command': ale#Escape(l:executable)
-        \       . (!empty(l:options) ? ' ' . l:options : '')
+        \       . ale#Pad(l:options)
         \       . ' --stdin-filepath %s --stdin',
         \}
     endif
@@ -118,7 +118,7 @@ function! ale#fixers#prettier#ApplyFixForVersion(buffer, version) abort
     return {
     \   'command': ale#Escape(l:executable)
     \       . ' %t'
-    \       . (!empty(l:options) ? ' ' . l:options : '')
+    \       . ale#Pad(l:options)
     \       . ' --write',
     \   'read_temporary_file': 1,
     \}