Merge pull request #1900 from McSwaggens/master

Fixed NASM linter from outputting junk file

.github/ISSUE_TEMPLATE/report-a-bug.md

@@ -23,12 +23,14 @@ about: Report a bug with ALE.
 
 Operating System: <!-- Describe your operating system version. -->
 
+### :ALEInfo
+
+<!-- Paste the output of :ALEInfo here. Try :ALEInfoToClipboard -->
+<!-- Make sure to run :ALEInfo from the buffer where the bug occurred. -->
+
 ## What went wrong
 
-<!-- Describe what went wrong here. Be specific. -->
+<!-- Describe what went wrong here. -->
-
-Something went wrong in specifically this place, and I also searched through
-both open and closed issues for the same problem before reporting a bug here.
 
 ## Reproducing the bug
 
@@ -36,9 +38,3 @@ both open and closed issues for the same problem before reporting a bug here.
 
 1. I did this.
 2. Then this happened.
-
-### :ALEInfo
-
-<!-- Paste the output of :ALEInfo here. Try :ALEInfoToClipboard -->
-<!-- Make sure to run :ALEInfo from the buffer where the bug occurred. -->
-<!-- Read the output. You might figure out what went wrong yourself. -->

.github/PULL_REQUEST_TEMPLATE.md

@@ -6,8 +6,3 @@ Before creating a pull request, do the following.
 
 Have fun!
 -->
-
-Where are the tests? Have you added tests? Have you updated the tests? Read the
-comment above and the documentation referenced in it first. Write tests!
-
-Seriously, read `:help ale-development` and write tests.

README.md

@@ -7,7 +7,7 @@ ALE (Asynchronous Lint Engine) is a plugin for providing linting in NeoVim
 0.2.0+ and Vim 8 while you edit your text files, and acts as a Vim
 [Language Server Protocol](https://langserver.org/) client.
 
-<img src="img/example.gif?raw=true" alt="A linting example with the darkspectrum color scheme in GVim." title="A linting example with the darkspectrum color scheme in GVim.">
+![linting example](img/example.gif?raw=true)
 
 ALE makes use of NeoVim and Vim 8 job control functions and timers to
 run linters on the contents of text buffers and return errors as
@@ -26,18 +26,14 @@ features, including:
 
 * Diagnostics (via Language Server Protocol linters)
 * Go To Definition (`:ALEGoToDefinition`)
-* Completion (`let g:ale_completion_enabled = 1` before ALE is loaded)
+* Completion (`let g:ale_completion_enabled = 1`)
 * Finding references (`:ALEFindReferences`)
 * Hover information (`:ALEHover`)
-* Symbol search (`:ALESymbolSearch`)
 
 If you don't care about Language Server Protocol, ALE won't load any of the code
 for working with it unless needed. One of ALE's general missions is that you
 won't pay for the features that you don't use.
 
-If you enjoy this plugin, feel free to contribute or check out the author's
-other content at [w0rp.com](https://w0rp.com).
-
 ## Table of Contents
 
 1. [Supported Languages and Tools](#supported-languages)
@@ -48,12 +44,10 @@ other content at [w0rp.com](https://w0rp.com).
     4. [Go To Definition](#usage-go-to-definition)
     5. [Find References](#usage-find-references)
     6. [Hovering](#usage-hover)
-    7. [Symbol Search](#usage-symbol-search)
 3. [Installation](#installation)
     1. [Installation with Vim package management](#standard-installation)
     2. [Installation with Pathogen](#installation-with-pathogen)
     3. [Installation with Vundle](#installation-with-vundle)
-    4. [Installation with Vim-Plug](#installation-with-vim-plug)
 4. [Contributing](#contributing)
 5. [FAQ](#faq)
     1. [How do I disable particular linters?](#faq-disable-linters)
@@ -68,11 +62,10 @@ other content at [w0rp.com](https://w0rp.com).
     10. [How can I run linters only when I save files?](#faq-lint-on-save)
     11. [How can I use the quickfix list instead of the loclist?](#faq-quickfix)
     12. [How can I check JSX files with both stylelint and eslint?](#faq-jsx-stylelint-eslint)
-    13. [How can I check Vue files with ESLint?](#faq-vue-eslint)
+    13. [Will this plugin eat all of my laptop battery power?](#faq-my-battery-is-sad)
-    14. [Will this plugin eat all of my laptop battery power?](#faq-my-battery-is-sad)
+    14. [How can I configure my C or C++ project?](#faq-c-configuration)
-    15. [How can I configure my C or C++ project?](#faq-c-configuration)
+    15. [How can I configure ALE differently for different buffers?](#faq-buffer-configuration)
-    16. [How can I configure ALE differently for different buffers?](#faq-buffer-configuration)
+    16. [How can I configure the height of the list in which ALE displays errors?](#faq-list-window-height)
-    17. [How can I configure the height of the list in which ALE displays errors?](#faq-list-window-height)
 
 <a name="supported-languages"></a>
 
@@ -97,18 +90,17 @@ formatting.
 
 | Language | Tools |
 | -------- | ----- |
-| Ada | [gcc](https://gcc.gnu.org) |
 | ASM | [gcc](https://gcc.gnu.org) |
 | Ansible | [ansible-lint](https://github.com/willthames/ansible-lint) |
 | API Blueprint | [drafter](https://github.com/apiaryio/drafter) |
-| AsciiDoc | [alex](https://github.com/wooorm/alex) !!, [proselint](http://proselint.com/), [redpen](http://redpen.cc/), [write-good](https://github.com/btford/write-good), [vale](https://github.com/ValeLint/vale) |
+| AsciiDoc | [alex](https://github.com/wooorm/alex) !!, [proselint](http://proselint.com/), [redpen](http://redpen.cc/), [write-good](https://github.com/btford/write-good) |
 | Awk | [gawk](https://www.gnu.org/software/gawk/)|
 | Bash | [language-server](https://github.com/mads-hartmann/bash-language-server), shell [-n flag](https://www.gnu.org/software/bash/manual/bash.html#index-set), [shellcheck](https://www.shellcheck.net/), [shfmt](https://github.com/mvdan/sh) |
 | Bourne Shell | shell [-n flag](http://linux.die.net/man/1/sh), [shellcheck](https://www.shellcheck.net/), [shfmt](https://github.com/mvdan/sh) |
-| C | [cppcheck](http://cppcheck.sourceforge.net), [cpplint](https://github.com/google/styleguide/tree/gh-pages/cpplint), [clang](http://clang.llvm.org/), [clangd](https://clang.llvm.org/extra/clangd.html), [clangtidy](http://clang.llvm.org/extra/clang-tidy/) !!, [clang-format](https://clang.llvm.org/docs/ClangFormat.html), [cquery](https://github.com/cquery-project/cquery), [flawfinder](https://www.dwheeler.com/flawfinder/), [gcc](https://gcc.gnu.org/), [uncrustify](https://github.com/uncrustify/uncrustify), [ccls](https://github.com/MaskRay/ccls) |
+| C | [cppcheck](http://cppcheck.sourceforge.net), [cpplint](https://github.com/google/styleguide/tree/gh-pages/cpplint), [clang](http://clang.llvm.org/), [clangd](https://clang.llvm.org/extra/clangd.html), [clangtidy](http://clang.llvm.org/extra/clang-tidy/) !!, [clang-format](https://clang.llvm.org/docs/ClangFormat.html), [cquery](https://github.com/cquery-project/cquery), [flawfinder](https://www.dwheeler.com/flawfinder/), [gcc](https://gcc.gnu.org/) |
-| C++ (filetype cpp) | [clang](http://clang.llvm.org/), [clangd](https://clang.llvm.org/extra/clangd.html), [clangcheck](http://clang.llvm.org/docs/ClangCheck.html) !!, [clangtidy](http://clang.llvm.org/extra/clang-tidy/) !!, [clang-format](https://clang.llvm.org/docs/ClangFormat.html), [clazy](https://github.com/KDE/clazy) !!, [cppcheck](http://cppcheck.sourceforge.net), [cpplint](https://github.com/google/styleguide/tree/gh-pages/cpplint) !!, [cquery](https://github.com/cquery-project/cquery), [flawfinder](https://www.dwheeler.com/flawfinder/), [gcc](https://gcc.gnu.org/), [uncrustify](https://github.com/uncrustify/uncrustify), [ccls](https://github.com/MaskRay/ccls) |
+| C++ (filetype cpp) | [clang](http://clang.llvm.org/), [clangcheck](http://clang.llvm.org/docs/ClangCheck.html) !!, [clangtidy](http://clang.llvm.org/extra/clang-tidy/) !!, [clang-format](https://clang.llvm.org/docs/ClangFormat.html), [cppcheck](http://cppcheck.sourceforge.net), [cpplint](https://github.com/google/styleguide/tree/gh-pages/cpplint) !!, [cquery](https://github.com/cquery-project/cquery), [flawfinder](https://www.dwheeler.com/flawfinder/), [gcc](https://gcc.gnu.org/) |
 | CUDA | [nvcc](http://docs.nvidia.com/cuda/cuda-compiler-driver-nvcc/index.html) |
-| C# | [mcs](http://www.mono-project.com/docs/about-mono/languages/csharp/) see:`help ale-cs-mcs` for details, [mcsc](http://www.mono-project.com/docs/about-mono/languages/csharp/) !! see:`help ale-cs-mcsc` for details and configuration, [uncrustify](https://github.com/uncrustify/uncrustify) |
+| C# | [mcs](http://www.mono-project.com/docs/about-mono/languages/csharp/) see:`help ale-cs-mcs` for details, [mcsc](http://www.mono-project.com/docs/about-mono/languages/csharp/) !! see:`help ale-cs-mcsc` for details and configuration|
 | Chef | [foodcritic](http://www.foodcritic.io/) |
 | Clojure | [joker](https://github.com/candid82/joker) |
 | CloudFormation | [cfn-python-lint](https://github.com/awslabs/cfn-python-lint) |
@@ -118,13 +110,13 @@ formatting.
 | CSS | [csslint](http://csslint.net/), [prettier](https://github.com/prettier/prettier), [stylelint](https://github.com/stylelint/stylelint) |
 | Cucumber | [cucumber](https://cucumber.io/) |
 | Cython (pyrex filetype) | [cython](http://cython.org/) |
-| D | [dls](https://github.com/d-language-server/dls), [dmd](https://dlang.org/dmd-linux.html), [uncrustify](https://github.com/uncrustify/uncrustify) |
+| D | [dmd](https://dlang.org/dmd-linux.html) |
 | Dafny | [dafny](https://rise4fun.com/Dafny) !! |
 | Dart | [dartanalyzer](https://github.com/dart-lang/sdk/tree/master/pkg/analyzer_cli) !!, [language_server](https://github.com/natebosch/dart_language_server), [dartfmt](https://github.com/dart-lang/sdk/tree/master/utils/dartfmt) |
-| Dockerfile | [dockerfile_lint](https://github.com/projectatomic/dockerfile_lint), [hadolint](https://github.com/hadolint/hadolint) |
+| Dockerfile | [hadolint](https://github.com/hadolint/hadolint) |
-| Elixir | [credo](https://github.com/rrrene/credo), [dialyxir](https://github.com/jeremyjh/dialyxir), [dogma](https://github.com/lpil/dogma), [mix](https://hexdocs.pm/mix/Mix.html) !!, [elixir-ls](https://github.com/JakeBecker/elixir-ls) |
+| Elixir | [credo](https://github.com/rrrene/credo), [dialyxir](https://github.com/jeremyjh/dialyxir), [dogma](https://github.com/lpil/dogma), [mix](https://hexdocs.pm/mix/Mix.html) !!|
 | Elm | [elm-format](https://github.com/avh4/elm-format), [elm-make](https://github.com/elm-lang/elm-make) |
-| Erb | [erb](https://apidock.com/ruby/ERB), [erubi](https://github.com/jeremyevans/erubi), [erubis](https://github.com/kwatch/erubis), [ruumba](https://github.com/ericqweinstein/ruumba) |
+| Erb | [erb](https://apidock.com/ruby/ERB), [erubi](https://github.com/jeremyevans/erubi), [erubis](https://github.com/kwatch/erubis) |
 | Erlang | [erlc](http://erlang.org/doc/man/erlc.html), [SyntaxErl](https://github.com/ten0s/syntaxerl) |
 | Fish | fish [-n flag](https://linux.die.net/man/1/fish)
 | Fortran | [gcc](https://gcc.gnu.org/), [language_server](https://github.com/hansec/fortran-language-server) |
@@ -132,20 +124,17 @@ formatting.
 | FusionScript | [fusion-lint](https://github.com/RyanSquared/fusionscript) |
 | Git Commit Messages | [gitlint](https://github.com/jorisroovers/gitlint) |
 | GLSL | [glslang](https://github.com/KhronosGroup/glslang), [glslls](https://github.com/svenstaro/glsl-language-server) |
-| Go | [gofmt](https://golang.org/cmd/gofmt/), [goimports](https://godoc.org/golang.org/x/tools/cmd/goimports), [go mod](https://golang.org/cmd/go/) !!, [go vet](https://golang.org/cmd/vet/) !!, [golint](https://godoc.org/github.com/golang/lint), [gotype](https://godoc.org/golang.org/x/tools/cmd/gotype) !!, [gometalinter](https://github.com/alecthomas/gometalinter) !!, [go build](https://golang.org/cmd/go/) !!, [gosimple](https://github.com/dominikh/go-tools/tree/master/cmd/gosimple) !!, [staticcheck](https://github.com/dominikh/go-tools/tree/master/cmd/staticcheck) !!, [golangserver](https://github.com/sourcegraph/go-langserver), [golangci-lint](https://github.com/golangci/golangci-lint) !! |
+| Go | [gofmt](https://golang.org/cmd/gofmt/), [goimports](https://godoc.org/golang.org/x/tools/cmd/goimports), [go vet](https://golang.org/cmd/vet/) !!, [golint](https://godoc.org/github.com/golang/lint), [gotype](https://godoc.org/golang.org/x/tools/cmd/gotype) !!, [gometalinter](https://github.com/alecthomas/gometalinter) !!, [go build](https://golang.org/cmd/go/) !!, [gosimple](https://github.com/dominikh/go-tools/tree/master/cmd/gosimple) !!, [staticcheck](https://github.com/dominikh/go-tools/tree/master/cmd/staticcheck) !! |
 | GraphQL | [eslint](http://eslint.org/), [gqlint](https://github.com/happylinks/gqlint), [prettier](https://github.com/prettier/prettier) |
 | Hack | [hack](http://hacklang.org/), [hackfmt](https://github.com/facebook/hhvm/tree/master/hphp/hack/hackfmt), [hhast](https://github.com/hhvm/hhast) (disabled by default; see `:help ale-integration-hack`) |
 | Haml | [haml-lint](https://github.com/brigade/haml-lint) |
 | Handlebars | [ember-template-lint](https://github.com/rwjblue/ember-template-lint) |
-| Haskell | [brittany](https://github.com/lspitzner/brittany), [ghc](https://www.haskell.org/ghc/), [cabal-ghc](https://www.haskell.org/cabal/), [stylish-haskell](https://github.com/jaspervdj/stylish-haskell), [stack-ghc](https://haskellstack.org/), [stack-build](https://haskellstack.org/) !!, [ghc-mod](https://github.com/DanielG/ghc-mod), [hlint](https://hackage.haskell.org/package/hlint), [hdevtools](https://hackage.haskell.org/package/hdevtools), [hfmt](https://github.com/danstiner/hfmt), [hie](https://github.com/haskell/haskell-ide-engine) |
+| Haskell | [brittany](https://github.com/lspitzner/brittany), [ghc](https://www.haskell.org/ghc/), [cabal-ghc](https://www.haskell.org/cabal/), [stack-ghc](https://haskellstack.org/), [stack-build](https://haskellstack.org/) !!, [ghc-mod](https://github.com/DanielG/ghc-mod), [stack-ghc-mod](https://github.com/DanielG/ghc-mod), [hlint](https://hackage.haskell.org/package/hlint), [hdevtools](https://hackage.haskell.org/package/hdevtools), [hfmt](https://github.com/danstiner/hfmt), [hie](https://github.com/haskell/haskell-ide-engine) |
-| HCL | [terraform-fmt](https://github.com/hashicorp/terraform) |
+| HTML | [alex](https://github.com/wooorm/alex) !!, [HTMLHint](http://htmlhint.com/), [proselint](http://proselint.com/), [tidy](http://www.html-tidy.org/), [write-good](https://github.com/btford/write-good) |
-| HTML | [alex](https://github.com/wooorm/alex) !!, [HTMLHint](http://htmlhint.com/), [proselint](http://proselint.com/), [tidy](http://www.html-tidy.org/), [prettier](https://github.com/prettier/prettier), [write-good](https://github.com/btford/write-good) |
 | Idris | [idris](http://www.idris-lang.org/) |
-| ISPC | [ispc](https://ispc.github.io/) !! |
+| Java | [checkstyle](http://checkstyle.sourceforge.net), [javac](http://www.oracle.com/technetwork/java/javase/downloads/index.html), [google-java-format](https://github.com/google/google-java-format), [PMD](https://pmd.github.io/) |
-| Java | [checkstyle](http://checkstyle.sourceforge.net), [javac](http://www.oracle.com/technetwork/java/javase/downloads/index.html), [google-java-format](https://github.com/google/google-java-format), [PMD](https://pmd.github.io/), [javalsp](https://github.com/georgewfraser/vscode-javac), [uncrustify](https://github.com/uncrustify/uncrustify) |
 | JavaScript | [eslint](http://eslint.org/), [flow](https://flowtype.org/), [jscs](http://jscs.info/), [jshint](http://jshint.com/), [prettier](https://github.com/prettier/prettier), [prettier-eslint](https://github.com/prettier/prettier-eslint-cli), [prettier-standard](https://github.com/sheerun/prettier-standard), [standard](http://standardjs.com/), [xo](https://github.com/sindresorhus/xo)
 | JSON | [fixjson](https://github.com/rhysd/fixjson), [jsonlint](http://zaa.ch/jsonlint/), [jq](https://stedolan.github.io/jq/), [prettier](https://github.com/prettier/prettier) |
-| Julia | [languageserver](https://github.com/JuliaEditorSupport/LanguageServer.jl) |
 | Kotlin | [kotlinc](https://kotlinlang.org) !!, [ktlint](https://ktlint.github.io) !!, [languageserver](https://github.com/fwcd/KotlinLanguageServer) see `:help ale-integration-kotlin` for configuration instructions |
 | LaTeX | [alex](https://github.com/wooorm/alex) !!, [chktex](http://www.nongnu.org/chktex/), [lacheck](https://www.ctan.org/pkg/lacheck), [proselint](http://proselint.com/), [redpen](http://redpen.cc/), [vale](https://github.com/ValeLint/vale), [write-good](https://github.com/btford/write-good) |
 | Less | [lessc](https://www.npmjs.com/package/less), [prettier](https://github.com/prettier/prettier), [stylelint](https://github.com/stylelint/stylelint) |
@@ -160,52 +149,48 @@ formatting.
 | Nim | [nim check](https://nim-lang.org/docs/nimc.html) !! |
 | nix | [nix-instantiate](http://nixos.org/nix/manual/#sec-nix-instantiate) |
 | nroff | [alex](https://github.com/wooorm/alex) !!, [proselint](http://proselint.com/), [write-good](https://github.com/btford/write-good)|
-| Objective-C | [clang](http://clang.llvm.org/), [clangd](https://clang.llvm.org/extra/clangd.html), [uncrustify](https://github.com/uncrustify/uncrustify), [ccls](https://github.com/MaskRay/ccls) |
+| Objective-C | [clang](http://clang.llvm.org/) |
-| Objective-C++ | [clang](http://clang.llvm.org/), [clangd](https://clang.llvm.org/extra/clangd.html), [uncrustify](https://github.com/uncrustify/uncrustify) |
+| Objective-C++ | [clang](http://clang.llvm.org/) |
-| OCaml | [merlin](https://github.com/the-lambda-church/merlin) see `:help ale-ocaml-merlin` for configuration instructions, [ols](https://github.com/freebroccolo/ocaml-language-server), [ocamlformat](https://github.com/ocaml-ppx/ocamlformat) |
+| OCaml | [merlin](https://github.com/the-lambda-church/merlin) see `:help ale-ocaml-merlin` for configuration instructions, [ols](https://github.com/freebroccolo/ocaml-language-server) |
-| Pawn | [uncrustify](https://github.com/uncrustify/uncrustify) |
 | Perl | [perl -c](https://perl.org/), [perl-critic](https://metacpan.org/pod/Perl::Critic), [perltidy](https://metacpan.org/pod/distribution/Perl-Tidy/bin/perltidy) |
-| Perl6 | [perl6 -c](https://perl6.org) |
+| PHP | [langserver](https://github.com/felixfbecker/php-language-server), [phan](https://github.com/phan/phan) see `:help ale-php-phan` to instructions, [php -l](https://secure.php.net/), [phpcs](https://github.com/squizlabs/PHP_CodeSniffer), [phpmd](https://phpmd.org), [phpstan](https://github.com/phpstan/phpstan), [phpcbf](https://github.com/squizlabs/PHP_CodeSniffer), [php-cs-fixer](http://cs.sensiolabs.org/) |
-| PHP | [langserver](https://github.com/felixfbecker/php-language-server), [phan](https://github.com/phan/phan) see `:help ale-php-phan` to instructions, [php -l](https://secure.php.net/), [phpcs](https://github.com/squizlabs/PHP_CodeSniffer), [phpmd](https://phpmd.org), [phpstan](https://github.com/phpstan/phpstan), [phpcbf](https://github.com/squizlabs/PHP_CodeSniffer), [php-cs-fixer](http://cs.sensiolabs.org/), [psalm](https://getpsalm.org) !!  |
 | PO | [alex](https://github.com/wooorm/alex) !!, [msgfmt](https://www.gnu.org/software/gettext/manual/html_node/msgfmt-Invocation.html), [proselint](http://proselint.com/), [write-good](https://github.com/btford/write-good) |
 | Pod | [alex](https://github.com/wooorm/alex) !!, [proselint](http://proselint.com/), [write-good](https://github.com/btford/write-good) |
 | Pony | [ponyc](https://github.com/ponylang/ponyc) |
-| Prolog | [swipl](https://github.com/SWI-Prolog/swipl-devel) |
 | proto | [protoc-gen-lint](https://github.com/ckaznocha/protoc-gen-lint) |
 | Pug | [pug-lint](https://github.com/pugjs/pug-lint) |
 | Puppet | [languageserver](https://github.com/lingua-pupuli/puppet-editor-services), [puppet](https://puppet.com), [puppet-lint](https://puppet-lint.com) |
-| Python | [autopep8](https://github.com/hhatto/autopep8), [black](https://github.com/ambv/black), [flake8](http://flake8.pycqa.org/en/latest/), [isort](https://github.com/timothycrosley/isort), [mypy](http://mypy-lang.org/), [prospector](https://github.com/PyCQA/prospector), [pycodestyle](https://github.com/PyCQA/pycodestyle), [pyls](https://github.com/palantir/python-language-server), [pyre](https://github.com/facebook/pyre-check), [pylint](https://www.pylint.org/) !!, [vulture](https://github.com/jendrikseipp/vulture) !!, [yapf](https://github.com/google/yapf) |
+| Python | [autopep8](https://github.com/hhatto/autopep8), [black](https://github.com/ambv/black), [flake8](http://flake8.pycqa.org/en/latest/), [isort](https://github.com/timothycrosley/isort), [mypy](http://mypy-lang.org/), [prospector](http://github.com/landscapeio/prospector), [pycodestyle](https://github.com/PyCQA/pycodestyle), [pyls](https://github.com/palantir/python-language-server), [pyre](https://github.com/facebook/pyre-check), [pylint](https://www.pylint.org/) !!, [vulture](https://github.com/jendrikseipp/vulture) !!, [yapf](https://github.com/google/yapf) |
 | QML | [qmlfmt](https://github.com/jesperhh/qmlfmt), [qmllint](https://github.com/qt/qtdeclarative/tree/5.11/tools/qmllint) |
 | R | [lintr](https://github.com/jimhester/lintr) |
 | ReasonML | [merlin](https://github.com/the-lambda-church/merlin) see `:help ale-reasonml-ols` for configuration instructions, [ols](https://github.com/freebroccolo/ocaml-language-server), [refmt](https://github.com/reasonml/reason-cli) |
 | reStructuredText | [alex](https://github.com/wooorm/alex) !!, [proselint](http://proselint.com/), [redpen](http://redpen.cc/), [rstcheck](https://github.com/myint/rstcheck), [vale](https://github.com/ValeLint/vale), [write-good](https://github.com/btford/write-good) |
 | Re:VIEW | [redpen](http://redpen.cc/) |
 | RPM spec | [rpmlint](https://github.com/rpm-software-management/rpmlint) (disabled by default; see `:help ale-integration-spec`) |
-| Ruby | [brakeman](http://brakemanscanner.org/) !!, [rails_best_practices](https://github.com/flyerhzm/rails_best_practices) !!, [reek](https://github.com/troessner/reek), [rubocop](https://github.com/bbatsov/rubocop), [ruby](https://www.ruby-lang.org), [rufo](https://github.com/ruby-formatter/rufo), [solargraph](https://solargraph.org) |
+| Ruby | [brakeman](http://brakemanscanner.org/) !!, [rails_best_practices](https://github.com/flyerhzm/rails_best_practices) !!, [reek](https://github.com/troessner/reek), [rubocop](https://github.com/bbatsov/rubocop), [ruby](https://www.ruby-lang.org), [rufo](https://github.com/ruby-formatter/rufo) |
-| Rust |  [cargo](https://github.com/rust-lang/cargo) !! (see `:help ale-integration-rust` for configuration instructions), [rls](https://github.com/rust-lang-nursery/rls), [rustc](https://www.rust-lang.org/), [rustfmt](https://github.com/rust-lang-nursery/rustfmt) |
+| Rust |  cargo !! (see `:help ale-integration-rust` for configuration instructions), [rls](https://github.com/rust-lang-nursery/rls), [rustc](https://www.rust-lang.org/), [rustfmt](https://github.com/rust-lang-nursery/rustfmt) |
 | SASS | [sass-lint](https://www.npmjs.com/package/sass-lint), [stylelint](https://github.com/stylelint/stylelint) |
 | SCSS | [prettier](https://github.com/prettier/prettier), [sass-lint](https://www.npmjs.com/package/sass-lint), [scss-lint](https://github.com/brigade/scss-lint), [stylelint](https://github.com/stylelint/stylelint) |
-| Scala | [fsc](https://www.scala-lang.org/old/sites/default/files/linuxsoft_archives/docu/files/tools/fsc.html), [sbtserver](https://www.scala-sbt.org/1.x/docs/sbt-server.html), [scalac](http://scala-lang.org), [scalafmt](https://scalameta.org/scalafmt/), [scalastyle](http://www.scalastyle.org)|
+| Scala | [fsc](https://www.scala-lang.org/old/sites/default/files/linuxsoft_archives/docu/files/tools/fsc.html), [scalac](http://scala-lang.org), [scalafmt](https://scalameta.org/scalafmt/), [scalastyle](http://www.scalastyle.org) |
 | Slim | [slim-lint](https://github.com/sds/slim-lint) |
 | SML | [smlnj](http://www.smlnj.org/) |
 | Solidity | [solhint](https://github.com/protofire/solhint), [solium](https://github.com/duaraghav8/Solium) |
 | Stylus | [stylelint](https://github.com/stylelint/stylelint) |
-| SQL | [sqlint](https://github.com/purcell/sqlint), [sqlfmt](https://github.com/jackc/sqlfmt) |
+| SQL | [sqlint](https://github.com/purcell/sqlint) |
 | Swift | [swiftlint](https://github.com/realm/SwiftLint), [swiftformat](https://github.com/nicklockwood/SwiftFormat) |
 | Tcl | [nagelfar](http://nagelfar.sourceforge.net) !! |
-| Terraform | [fmt](https://github.com/hashicorp/terraform), [tflint](https://github.com/wata727/tflint) |
+| Terraform | [tflint](https://github.com/wata727/tflint) |
 | Texinfo | [alex](https://github.com/wooorm/alex) !!, [proselint](http://proselint.com/), [write-good](https://github.com/btford/write-good)|
 | Text^ | [alex](https://github.com/wooorm/alex) !!, [proselint](http://proselint.com/), [redpen](http://redpen.cc/), [textlint](https://textlint.github.io/), [vale](https://github.com/ValeLint/vale), [write-good](https://github.com/btford/write-good) |
 | Thrift | [thrift](http://thrift.apache.org/) |
-| TypeScript | [eslint](http://eslint.org/), [prettier](https://github.com/prettier/prettier), [tslint](https://github.com/palantir/tslint), [tsserver](https://github.com/Microsoft/TypeScript/wiki/Standalone-Server-%28tsserver%29), typecheck |
+| TypeScript | [eslint](http://eslint.org/), [prettier](https://github.com/prettier/prettier), [tslint](https://github.com/palantir/tslint), tsserver, typecheck |
-| VALA | [uncrustify](https://github.com/uncrustify/uncrustify) |
 | Verilog | [iverilog](https://github.com/steveicarus/iverilog), [verilator](http://www.veripool.org/projects/verilator/wiki/Intro) |
 | Vim | [vint](https://github.com/Kuniwak/vint) |
 | Vim help^ | [alex](https://github.com/wooorm/alex) !!, [proselint](http://proselint.com/), [write-good](https://github.com/btford/write-good) |
 | Vue | [prettier](https://github.com/prettier/prettier), [vls](https://github.com/vuejs/vetur/tree/master/server) |
 | XHTML | [alex](https://github.com/wooorm/alex) !!, [proselint](http://proselint.com/), [write-good](https://github.com/btford/write-good) |
 | XML | [xmllint](http://xmlsoft.org/xmllint.html) |
-| YAML | [prettier](https://github.com/prettier/prettier), [swaglint](https://github.com/byCedric/swaglint), [yamllint](https://yamllint.readthedocs.io/) |
+| YAML | [swaglint](https://github.com/byCedric/swaglint), [yamllint](https://yamllint.readthedocs.io/) |
 | YANG | [yang-lsp](https://github.com/theia-ide/yang-lsp) |
 
 <a name="usage"></a>
@@ -246,18 +231,12 @@ let b:ale_fixers = ['prettier', 'eslint']
 let b:ale_fixers = {'javascript': ['prettier', 'eslint']}
 ```
 
-You can also configure your fixers from vimrc using `g:ale_fixers`, before or
+You can also configure your fixers from vimrc using `g:ale_fixers`, before
-after ALE has been loaded.
+or after ALE has been loaded.
-
-A `*` in place of the filetype will apply a List of fixers to all files which
-do not match some filetype in the Dictionary.
-
-Note that using a plain List for `g:ale_fixers` is not supported.
 
 ```vim
 " In ~/.vim/vimrc, or somewhere similar.
 let g:ale_fixers = {
-\   '*': ['remove_trailing_lines', 'trim_whitespace'],
 \   'javascript': ['eslint'],
 \}
 ```
@@ -286,7 +265,6 @@ Protocol linters, or from `tsserver` for TypeScript.
 
 ```vim
 " Enable completion where available.
-" This setting must be set before ALE is loaded.
 let g:ale_completion_enabled = 1
 ```
 
@@ -320,24 +298,11 @@ ALE supports "hover" information for printing brief information about symbols at
 the cursor taken from Language Server Protocol linters and `tsserver` with the
 `ALEHover` command.
 
-The information can be displayed in a `balloon` tooltip in Vim or GVim by
+On vim/gvim with `balloon` support you can see the information in a tooltip
-hovering your mouse over symbols. Mouse hovering is enabled by default in GVim,
+that appears under the mouse when you mouseover a symbol.
-and needs to be configured for Vim 8.1+ in terminals.
 
 See `:help ale-hover` for more information.
 
-<a name="usage-symbol-search"></a>
-
-### 2.vii Symbol Search
-
-ALE supports searching for workspace symbols via Language Server Protocol
-linters with the `ALESymbolSearch` command.
-
-Search queries can be performed to find functions, types, and more which are
-similar to a given query string.
-
-See `:help ale-symbol-search` for more information.
-
 <a name="installation"></a>
 
 ## 3. Installation
@@ -421,18 +386,6 @@ Plugin 'w0rp/ale'
 
 See the Vundle documentation for more information.
 
-<a name="installation-with-vim-plug"></a>
-
-### 3.iiii. Installation with Vim-Plug
-
-You can install this plugin using [Vim-Plug](https://github.com/junegunn/vim-plug)
-by adding the GitHub path for this repository to your `~/.vimrc`
-and running `:PlugInstall`.
-
-```vim
-Plug 'w0rp/ale'
-```
-
 <a name="contributing"></a>
 
 ## 4. Contributing
@@ -751,16 +704,16 @@ options in a jsx.vim ftplugin file.
 
 ```vim
 " In ~/.vim/ftplugin/jsx.vim, or somewhere similar.
-let b:ale_linter_aliases = ['css', 'javascript']
 let b:ale_linters = ['stylelint', 'eslint']
+let b:ale_linter_aliases = ['css']
 ```
 
 Or if you want, you can configure the linters from your vimrc file.
 
 ```vim
 " In ~/.vim/vimrc, or somewhere similar.
-let g:ale_linter_aliases = {'jsx': ['css, 'javascript']}
 let g:ale_linters = {'jsx': ['stylelint', 'eslint']}
+let g:ale_linter_aliases = {'jsx': 'css'}
 ```
 
 ALE will alias the `jsx` filetype so it uses the `css` filetype linters, and
@@ -768,40 +721,9 @@ use the original Array of selected linters for `jsx` from the `g:ale_linters`
 object. All available linters will be used for the filetype `javascript`, and
 no linter will be run twice for the same file.
 
-<a name="faq-vue-eslint"></a>
-
-### 5.xiii. How can I check Vue files with ESLint?
-
-To check Vue files with ESLint, your ESLint project configuration file must be
-configured to use the [Vue plugin](https://github.com/vuejs/eslint-plugin-vue).
-After that, you need to configure ALE so it will run the JavaScript ESLint
-linter on your files. The settings you need are similar to the settings needed
-for checking JSX code with both stylelint and ESLint, in the previous section.
-
-```vim
-" In ~/.vim/ftplugin/vue.vim, or somewhere similar.
-
-" Run both javascript and vue linters for vue files.
-let b:ale_linter_aliases = ['javascript', 'vue']
-" Select the eslint and vls linters.
-let b:ale_linters = ['eslint', 'vls']
-```
-
-Run `:ALEInfo` to see which linters are available after telling ALE to run
-JavaScript linters on Vue files. Not all linters support checking Vue files.
-
-If you don't want to configure your linters in ftplugin files for some reason,
-you can configure them from your vimrc file instead.
-
-```vim
-" In ~/.vim/vimrc, or somewhere similar.
-let g:ale_linter_aliases = {'vue': ['vue', 'javascript']}
-let g:ale_linters = {'vue': ['eslint', 'vls']}
-```
-
 <a name="faq-my-battery-is-sad"></a>
 
-### 5.xiv. Will this plugin eat all of my laptop battery power?
+### 5.xiii. Will this plugin eat all of my laptop battery power?
 
 ALE takes advantage of the power of various tools to check your code. This of
 course means that CPU time will be used to continuously check your code. If you
@@ -826,7 +748,7 @@ including the option `g:ale_lint_on_enter`, and you can run ALE manually with
 
 <a name="faq-c-configuration"></a>
 
-### 5.xv. How can I configure my C or C++ project?
+### 5.xiv. How can I configure my C or C++ project?
 
 The structure of C and C++ projects varies wildly from project to project, with
 many different build tools being used for building them, and many different
@@ -852,7 +774,7 @@ used for executing local vimrc files which can be shared in your project.
 
 <a name="faq-buffer-configuration"></a>
 
-### 5.xvi. How can I configure ALE differently for different buffers?
+### 5.xv. How can I configure ALE differently for different buffers?
 
 ALE offers various ways to configure which linters or fixers are run, and
 other settings. For the majority of ALE's settings, they can either be
@@ -888,7 +810,7 @@ Buffer-local variables for settings always override the global settings.
 
 <a name="faq-list-window-height"></a>
 
-### 5.xvii. How can I configure the height of the list in which ALE displays errors?
+### 5.xvi. How can I configure the height of the list in which ALE displays errors?
 
 To set a default height for the error list, use the `g:ale_list_window_size` variable.
 

ale_linters/ada/gcc.vim

@@ -1,54 +0,0 @@
-" Author: Martino Pilia <martino.pilia@gmail.com>
-" Description: Lint Ada files with GCC
-
-call ale#Set('ada_gcc_executable', 'gcc')
-
-" -gnatwa: activate most optional warnings
-" -gnatq: try semantic analysis even if syntax errors have been found
-call ale#Set('ada_gcc_options', '-gnatwa -gnatq')
-
-function! ale_linters#ada#gcc#GetCommand(buffer) abort
-    " Build a suitable output file name. The output file is specified because
-    " the .ali file may be created even if no code generation is attempted.
-    " The output file name must match the source file name (except for the
-    " extension), so here we cannot use the null file as output.
-    let l:tmp_dir = fnamemodify(ale#engine#CreateDirectory(a:buffer), ':p')
-    let l:out_file = l:tmp_dir . fnamemodify(bufname(a:buffer), ':t:r') . '.o'
-
-    " -gnatc: Check syntax and semantics only (no code generation attempted)
-    return '%e -x ada -c -gnatc'
-    \   . ' -o ' . ale#Escape(l:out_file)
-    \   . ' -I ' . ale#Escape(fnamemodify(bufname(a:buffer), ':p:h'))
-    \   . ale#Pad(ale#Var(a:buffer, 'ada_gcc_options'))
-    \   . ' %t'
-endfunction
-
-" For the message format please refer to:
-"   https://gcc.gnu.org/onlinedocs/gnat_ugn/Output-and-Error-Message-Control.html
-"   https://gcc.gnu.org/onlinedocs/gnat_ugn/Warning-Message-Control.html
-function! ale_linters#ada#gcc#Handle(buffer, lines) abort
-    " Error format: <filename>:<lnum>:<col>: <text>
-    " Warning format: <filename>:<lnum>:<col>: warning: <text>
-    let l:re = '\v(.+):([0-9]+):([0-9]+):\s+(warning:)?\s*(.+)\s*'
-    let l:output = []
-
-    for l:match in ale#util#GetMatches(a:lines, l:re)
-        call add(l:output, {
-        \   'bufnr': a:buffer,
-        \   'lnum': str2nr(l:match[2]),
-        \   'col': str2nr(l:match[3]),
-        \   'type': l:match[4] is# 'warning:' ? 'W' : 'E',
-        \   'text': l:match[5],
-        \})
-    endfor
-
-    return l:output
-endfunction
-
-call ale#linter#Define('ada', {
-\   'name': 'gcc',
-\   'output_stream': 'stderr',
-\   'executable_callback': ale#VarFunc('ada_gcc_executable'),
-\   'command_callback': 'ale_linters#ada#gcc#GetCommand',
-\   'callback': 'ale_linters#ada#gcc#Handle',
-\})

ale_linters/ansible/ansible_lint.vim

@@ -1,12 +1,6 @@
 " Author: Bjorn Neergaard <bjorn@neersighted.com>
 " Description: ansible-lint for ansible-yaml files
 
-call ale#Set('ansible_ansible_lint_executable', 'ansible-lint')
-
-function! ale_linters#ansible#ansible_lint#GetExecutable(buffer) abort
-    return ale#Var(a:buffer, 'ansible_ansible_lint_executable')
-endfunction
-
 function! ale_linters#ansible#ansible_lint#Handle(buffer, lines) abort
     for l:line in a:lines[:10]
         if match(l:line, '^Traceback') >= 0
@@ -48,9 +42,8 @@ function! ale_linters#ansible#ansible_lint#Handle(buffer, lines) abort
 endfunction
 
 call ale#linter#Define('ansible', {
-\   'name': 'ansible_lint',
+\   'name': 'ansible',
-\   'aliases': ['ansible', 'ansible-lint'],
+\   'executable': 'ansible',
-\   'executable_callback': 'ale_linters#ansible#ansible_lint#GetExecutable',
+\   'command': 'ansible-lint -p %t',
-\   'command': '%e -p %t',
 \   'callback': 'ale_linters#ansible#ansible_lint#Handle',
 \})

ale_linters/apiblueprint/drafter.vim

@@ -16,12 +16,10 @@ function! ale_linters#apiblueprint#drafter#HandleErrors(buffer, lines) abort
         \   'lnum': l:match[3] + 0,
         \   'col': l:match[4] + 0,
         \}
-
         if l:match[5] isnot# ''
             let l:item.end_lnum = l:match[6] + 0
             let l:item.end_col = l:match[7] + 0
         endif
-
         call add(l:output, l:item)
     endfor
 

ale_linters/asciidoc/vale.vim

@@ -1,9 +0,0 @@
-" Author: Jeff Kreeftmeijer https://github.com/jeffkreeftmeijer
-" Description: vale for AsciiDoc files
-
-call ale#linter#Define('asciidoc', {
-\   'name': 'vale',
-\   'executable': 'vale',
-\   'command': 'vale --output=line %t',
-\   'callback': 'ale#handlers#unix#HandleAsWarning',
-\})

ale_linters/c/ccls.vim

@@ -1,14 +0,0 @@
-" Author: Ye Jingchen <ye.jingchen@gmail.com>, Ben Falconer <ben@falconers.me.uk>, jtalowell <jtalowell@protonmail.com>
-" Description: A language server for C
-
-call ale#Set('c_ccls_executable', 'ccls')
-call ale#Set('c_ccls_init_options', {})
-
-call ale#linter#Define('c', {
-\   'name': 'ccls',
-\   'lsp': 'stdio',
-\   'executable_callback': ale#VarFunc('c_ccls_executable'),
-\   'command': '%e',
-\   'project_root_callback': 'ale#handlers#ccls#GetProjectRoot',
-\   'initialization_options_callback':ale#VarFunc('c_ccls_init_options'),
-\})

ale_linters/c/clangd.vim

@@ -6,7 +6,6 @@ call ale#Set('c_clangd_options', '')
 
 function! ale_linters#c#clangd#GetProjectRoot(buffer) abort
     let l:project_root = ale#path#FindNearestFile(a:buffer, 'compile_commands.json')
-
     return !empty(l:project_root) ? fnamemodify(l:project_root, ':h') : ''
 endfunction
 

ale_linters/c/clangtidy.vim

@@ -10,15 +10,33 @@ call ale#Set('c_clangtidy_executable', 'clang-tidy')
 " Consult the check list in clang-tidy's documentation:
 " http://clang.llvm.org/extra/clang-tidy/checks/list.html
 
-call ale#Set('c_clangtidy_checks', [])
+call ale#Set('c_clangtidy_checks', ['*'])
 " Set this option to manually set some options for clang-tidy.
 " This will disable compile_commands.json detection.
 call ale#Set('c_clangtidy_options', '')
 call ale#Set('c_build_dir', '')
 
+function! s:GetBuildDirectory(buffer) abort
+    " Don't include build directory for header files, as compile_commands.json
+    " files don't consider headers to be translation units, and provide no
+    " commands for compiling header files.
+    if expand('#' . a:buffer) =~# '\v\.(h|hpp)$'
+        return ''
+    endif
+
+    let l:build_dir = ale#Var(a:buffer, 'c_build_dir')
+
+    " c_build_dir has the priority if defined
+    if !empty(l:build_dir)
+        return l:build_dir
+    endif
+
+    return ale#path#Dirname(ale#c#FindCompileCommands(a:buffer))
+endfunction
+
 function! ale_linters#c#clangtidy#GetCommand(buffer) abort
     let l:checks = join(ale#Var(a:buffer, 'c_clangtidy_checks'), ',')
-    let l:build_dir = ale#c#GetBuildDirectory(a:buffer)
+    let l:build_dir = s:GetBuildDirectory(a:buffer)
 
     " Get the extra options if we couldn't find a build directory.
     let l:options = empty(l:build_dir)

ale_linters/c/cquery.vim

@@ -6,11 +6,6 @@ call ale#Set('c_cquery_cache_directory', expand('~/.cache/cquery'))
 
 function! ale_linters#c#cquery#GetProjectRoot(buffer) abort
     let l:project_root = ale#path#FindNearestFile(a:buffer, 'compile_commands.json')
-
-    if empty(l:project_root)
-        let l:project_root = ale#path#FindNearestFile(a:buffer, '.cquery')
-    endif
-
     return !empty(l:project_root) ? fnamemodify(l:project_root, ':h') : ''
 endfunction
 

ale_linters/clojure/joker.vim

@@ -9,11 +9,9 @@ function! ale_linters#clojure#joker#HandleJokerFormat(buffer, lines) abort
 
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
         let l:type = 'E'
-
         if l:match[4] is? 'Parse warning'
           let l:type = 'W'
         endif
-
         call add(l:output, {
         \   'lnum': l:match[1] + 0,
         \   'col': l:match[2] + 0,

ale_linters/cpp/ccls.vim

@@ -1,14 +0,0 @@
-" Author: Ye Jingchen <ye.jingchen@gmail.com>, Ben Falconer <ben@falconers.me.uk>, jtalowell <jtalowell@protonmail.com>
-" Description: A language server for C++
-
-call ale#Set('cpp_ccls_executable', 'ccls')
-call ale#Set('cpp_ccls_init_options', {})
-
-call ale#linter#Define('cpp', {
-\   'name': 'ccls',
-\   'lsp': 'stdio',
-\   'executable_callback': ale#VarFunc('cpp_ccls_executable'),
-\   'command': '%e',
-\   'project_root_callback': 'ale#handlers#ccls#GetProjectRoot',
-\   'initialization_options_callback': ale#VarFunc('cpp_ccls_init_options'),
-\})

ale_linters/cpp/clangd.vim

@@ -1,23 +0,0 @@
-" Author: Andrey Melentyev <andrey.melentyev@protonmail.com>
-" Description: Clangd language server
-
-call ale#Set('cpp_clangd_executable', 'clangd')
-call ale#Set('cpp_clangd_options', '')
-
-function! ale_linters#cpp#clangd#GetProjectRoot(buffer) abort
-    let l:project_root = ale#path#FindNearestFile(a:buffer, 'compile_commands.json')
-
-    return !empty(l:project_root) ? fnamemodify(l:project_root, ':h') : ''
-endfunction
-
-function! ale_linters#cpp#clangd#GetCommand(buffer) abort
-    return '%e' . ale#Pad(ale#Var(a:buffer, 'cpp_clangd_options'))
-endfunction
-
-call ale#linter#Define('cpp', {
-\   'name': 'clangd',
-\   'lsp': 'stdio',
-\   'executable_callback': ale#VarFunc('cpp_clangd_executable'),
-\   'command_callback': 'ale_linters#cpp#clangd#GetCommand',
-\   'project_root_callback': 'ale_linters#cpp#clangd#GetProjectRoot',
-\})

ale_linters/cpp/clangtidy.vim

@@ -4,15 +4,33 @@
 
 call ale#Set('cpp_clangtidy_executable', 'clang-tidy')
 " Set this option to check the checks clang-tidy will apply.
-call ale#Set('cpp_clangtidy_checks', [])
+call ale#Set('cpp_clangtidy_checks', ['*'])
 " Set this option to manually set some options for clang-tidy.
 " This will disable compile_commands.json detection.
 call ale#Set('cpp_clangtidy_options', '')
 call ale#Set('c_build_dir', '')
 
+function! s:GetBuildDirectory(buffer) abort
+    " Don't include build directory for header files, as compile_commands.json
+    " files don't consider headers to be translation units, and provide no
+    " commands for compiling header files.
+    if expand('#' . a:buffer) =~# '\v\.(h|hpp)$'
+        return ''
+    endif
+
+    let l:build_dir = ale#Var(a:buffer, 'c_build_dir')
+
+    " c_build_dir has the priority if defined
+    if !empty(l:build_dir)
+        return l:build_dir
+    endif
+
+    return ale#path#Dirname(ale#c#FindCompileCommands(a:buffer))
+endfunction
+
 function! ale_linters#cpp#clangtidy#GetCommand(buffer) abort
     let l:checks = join(ale#Var(a:buffer, 'cpp_clangtidy_checks'), ',')
-    let l:build_dir = ale#c#GetBuildDirectory(a:buffer)
+    let l:build_dir = s:GetBuildDirectory(a:buffer)
 
     " Get the extra options if we couldn't find a build directory.
     let l:options = empty(l:build_dir)

ale_linters/cpp/clazy.vim

@@ -1,32 +0,0 @@
-" Description: clazy linter for cpp files (clang-based and Qt-oriented)
-
-call ale#Set('cpp_clazy_executable', 'clazy-standalone')
-" Set this option to check the checks clazy will apply.
-call ale#Set('cpp_clazy_checks', ['level1'])
-" Set this option to manually set some options for clazy.
-" This will disable compile_commands.json detection.
-call ale#Set('cpp_clazy_options', '')
-call ale#Set('c_build_dir', '')
-
-function! ale_linters#cpp#clazy#GetCommand(buffer) abort
-    let l:checks = join(ale#Var(a:buffer, 'cpp_clazy_checks'), ',')
-    let l:build_dir = ale#c#GetBuildDirectory(a:buffer)
-
-    " Get the extra options if we couldn't find a build directory.
-    let l:options = ale#Var(a:buffer, 'cpp_clazy_options')
-
-    return '%e'
-    \   . (!empty(l:checks) ? ' -checks=' . ale#Escape(l:checks) : '')
-    \   . (!empty(l:build_dir) ? ' -p ' . ale#Escape(l:build_dir) : '')
-    \   . (!empty(l:options) ? ' ' . l:options : '')
-    \   . ' %s'
-endfunction
-
-call ale#linter#Define('cpp', {
-\   'name': 'clazy',
-\   'output_stream': 'stderr',
-\   'executable_callback': ale#VarFunc('cpp_clazy_executable'),
-\   'command_callback': 'ale_linters#cpp#clazy#GetCommand',
-\   'callback': 'ale#handlers#gcc#HandleGCCFormat',
-\   'lint_file': 1,
-\})

ale_linters/cpp/cquery.vim

@@ -7,10 +7,6 @@ call ale#Set('cpp_cquery_cache_directory', expand('~/.cache/cquery'))
 function! ale_linters#cpp#cquery#GetProjectRoot(buffer) abort
     let l:project_root = ale#path#FindNearestFile(a:buffer, 'compile_commands.json')
 
-    if empty(l:project_root)
-        let l:project_root = ale#path#FindNearestFile(a:buffer, '.cquery')
-    endif
-
     return !empty(l:project_root) ? fnamemodify(l:project_root, ':h') : ''
 endfunction
 

ale_linters/cucumber/cucumber.vim

@@ -22,7 +22,6 @@ function! ale_linters#cucumber#cucumber#Handle(buffer, lines) abort
     endtry
 
     let l:output = []
-
     for l:element in get(l:json, 'elements', [])
         for l:step in l:element['steps']
             if l:step['result']['status'] is# 'undefined'

ale_linters/cuda/nvcc.vim

@@ -8,6 +8,7 @@ function! ale_linters#cuda#nvcc#GetCommand(buffer) abort
     " Unused: use ale#util#nul_file
     " let l:output_file = ale#util#Tempname() . '.ii'
     " call ale#engine#ManageFile(a:buffer, l:output_file)
+
     return '%e -cuda'
     \   . ale#Pad(ale#c#IncludeOptions(ale#c#FindLocalHeaderPaths(a:buffer)))
     \   . ale#Pad(ale#Var(a:buffer, 'cuda_nvcc_options'))
@@ -22,6 +23,7 @@ function! ale_linters#cuda#nvcc#HandleNVCCFormat(buffer, lines) abort
     let l:output = []
 
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
+
         let l:item = {
         \   'lnum': str2nr(l:match[2]),
         \   'type': l:match[4] =~# 'error' ? 'E' : 'W',

ale_linters/d/dls.vim

@@ -1,22 +0,0 @@
-" Author: aurieh <me@aurieh.me>
-" Description: A Language Server implementation for D
-
-call ale#Set('d_dls_executable', 'dls')
-
-function! ale_linters#d#dls#GetExecutable(buffer) abort
-    return ale#Var(a:buffer, 'd_dls_executable')
-endfunction
-
-function! ale_linters#d#dls#FindProjectRoot(buffer) abort
-    " Note: this will return . if dub config is empty
-    " dls can run outside DUB projects just fine
-    return fnamemodify(ale#d#FindDUBConfig(a:buffer), ':h')
-endfunction
-
-call ale#linter#Define('d', {
-\   'name': 'dls',
-\   'lsp': 'stdio',
-\   'executable_callback': 'ale_linters#d#dls#GetExecutable',
-\   'command_callback': 'ale_linters#d#dls#GetExecutable',
-\   'project_root_callback': 'ale_linters#d#dls#FindProjectRoot',
-\})

ale_linters/d/dmd.vim

@@ -1,6 +1,20 @@
 " Author: w0rp <devw0rp@gmail.com>
 " Description: "dmd for D files"
 
+function! s:FindDUBConfig(buffer) abort
+    " Find a DUB configuration file in ancestor paths.
+    " The most DUB-specific names will be tried first.
+    for l:possible_filename in ['dub.sdl', 'dub.json', 'package.json']
+        let l:dub_file = ale#path#FindNearestFile(a:buffer, l:possible_filename)
+
+        if !empty(l:dub_file)
+            return l:dub_file
+        endif
+    endfor
+
+    return ''
+endfunction
+
 function! ale_linters#d#dmd#DUBCommand(buffer) abort
     " If we can't run dub, then skip this command.
     if !executable('dub')
@@ -8,7 +22,7 @@ function! ale_linters#d#dmd#DUBCommand(buffer) abort
         return ''
     endif
 
-    let l:dub_file = ale#d#FindDUBConfig(a:buffer)
+    let l:dub_file = s:FindDUBConfig(a:buffer)
 
     if empty(l:dub_file)
         return ''

ale_linters/dafny/dafny.vim

@@ -13,7 +13,6 @@ function! ale_linters#dafny#dafny#Handle(buffer, lines) abort
         \    'type': l:match[4] =~# '^Error' ? 'E' : 'W'
         \ })
     endfor
-
     return l:output
 endfunction
 

ale_linters/dockerfile/dockerfile_lint.vim

@@ -1,61 +0,0 @@
-" Author: Alexander Olofsson <alexander.olofsson@liu.se>
-
-call ale#Set('dockerfile_dockerfile_lint_executable', 'dockerfile_lint')
-call ale#Set('dockerfile_dockerfile_lint_options', '')
-
-function! ale_linters#dockerfile#dockerfile_lint#GetType(type) abort
-    if a:type is? 'error'
-        return 'E'
-    elseif a:type is? 'warn'
-        return 'W'
-    endif
-
-    return 'I'
-endfunction
-
-function! ale_linters#dockerfile#dockerfile_lint#Handle(buffer, lines) abort
-    try
-        let l:data = json_decode(join(a:lines, ''))
-    catch
-        return []
-    endtry
-
-    if empty(l:data)
-        " Should never happen, but it's better to be on the safe side
-        return []
-    endif
-
-    let l:messages = []
-
-    for l:type in ['error', 'warn', 'info']
-        for l:object in l:data[l:type]['data']
-            let l:line = get(l:object, 'line', -1)
-            let l:message = l:object['message']
-
-            if get(l:object, 'description', 'None') isnot# 'None'
-                let l:message = l:message . '. ' . l:object['description']
-            endif
-
-            call add(l:messages, {
-            \   'lnum': l:line,
-            \   'text': l:message,
-            \   'type': ale_linters#dockerfile#dockerfile_lint#GetType(l:type),
-            \})
-        endfor
-    endfor
-
-    return l:messages
-endfunction
-
-function! ale_linters#dockerfile#dockerfile_lint#GetCommand(buffer) abort
-    return '%e' . ale#Pad(ale#Var(a:buffer, 'dockerfile_dockerfile_lint_options'))
-    \   . ' -p -j -f'
-    \   . ' %t'
-endfunction
-
-call ale#linter#Define('dockerfile', {
-\   'name': 'dockerfile_lint',
-\   'executable_callback': ale#VarFunc('dockerfile_dockerfile_lint_executable'),
-\   'command_callback': 'ale_linters#dockerfile#dockerfile_lint#GetCommand',
-\   'callback': 'ale_linters#dockerfile#dockerfile_lint#Handle',
-\})

ale_linters/dockerfile/hadolint.vim

@@ -82,11 +82,9 @@ endfunction
 
 function! ale_linters#dockerfile#hadolint#GetCommand(buffer) abort
     let l:command = ale_linters#dockerfile#hadolint#GetExecutable(a:buffer)
-
     if l:command is# 'docker'
         return 'docker run --rm -i ' . ale#Var(a:buffer, 'dockerfile_hadolint_docker_image')
     endif
-
     return 'hadolint -'
 endfunction
 

ale_linters/elixir/credo.vim

@@ -11,18 +11,10 @@ function! ale_linters#elixir#credo#Handle(buffer, lines) abort
         let l:type = l:match[3]
         let l:text = l:match[4]
 
-        " Refactoring opportunities
+        if l:type is# 'C'
-        if l:type is# 'F'
+            let l:type = 'E'
-            let l:type = 'W'
-        " Consistency
-        elseif l:type is# 'C'
-            let l:type = 'W'
-        " Software Design
-        elseif l:type is# 'D'
-            let l:type = 'I'
-        " Code Readability
         elseif l:type is# 'R'
-            let l:type = 'I'
+            let l:type = 'W'
         endif
 
         call add(l:output, {
@@ -37,16 +29,9 @@ function! ale_linters#elixir#credo#Handle(buffer, lines) abort
     return l:output
 endfunction
 
-function! ale_linters#elixir#credo#GetCommand(buffer) abort
-    let l:project_root = ale#handlers#elixir#FindMixProjectRoot(a:buffer)
-
-    return ale#path#CdString(l:project_root)
-    \ . ' mix help credo && mix credo suggest --format=flycheck --read-from-stdin %s'
-endfunction
-
 call ale#linter#Define('elixir', {
 \   'name': 'credo',
 \   'executable': 'mix',
-\   'command_callback': 'ale_linters#elixir#credo#GetCommand',
+\   'command': 'mix help credo && mix credo suggest --format=flycheck --read-from-stdin %s',
 \   'callback': 'ale_linters#elixir#credo#Handle',
 \})

ale_linters/elixir/dialyxir.vim

@@ -25,17 +25,10 @@ function! ale_linters#elixir#dialyxir#Handle(buffer, lines) abort
     return l:output
 endfunction
 
-function! ale_linters#elixir#dialyxir#GetCommand(buffer) abort
-    let l:project_root = ale#handlers#elixir#FindMixProjectRoot(a:buffer)
-
-    return ale#path#CdString(l:project_root)
-    \ . ' mix help dialyzer && mix dialyzer'
-endfunction
-
 call ale#linter#Define('elixir', {
 \   'name': 'dialyxir',
 \   'executable': 'mix',
-\   'command_callback': 'ale_linters#elixir#dialyxir#GetCommand',
+\   'command': 'mix help dialyzer && mix dialyzer',
 \   'callback': 'ale_linters#elixir#dialyxir#Handle',
 \})
 

ale_linters/elixir/dogma.vim

@@ -29,17 +29,10 @@ function! ale_linters#elixir#dogma#Handle(buffer, lines) abort
     return l:output
 endfunction
 
-function! ale_linters#elixir#dogma#GetCommand(buffer) abort
-    let l:project_root = ale#handlers#elixir#FindMixProjectRoot(a:buffer)
-
-    return ale#path#CdString(l:project_root)
-    \ . ' mix help dogma && mix dogma %s --format=flycheck'
-endfunction
-
 call ale#linter#Define('elixir', {
 \   'name': 'dogma',
 \   'executable': 'mix',
-\   'command_callback': 'ale_linters#elixir#dogma#GetCommand',
+\   'command': 'mix help dogma && mix dogma %s --format=flycheck',
 \   'lint_file': 1,
 \   'callback': 'ale_linters#elixir#dogma#Handle',
 \})

ale_linters/elixir/elixir_ls.vim

@@ -1,21 +0,0 @@
-" Author: Jon Parise <jon@indelible.org>
-" Description: ElixirLS integration (https://github.com/JakeBecker/elixir-ls)
-
-call ale#Set('elixir_elixir_ls_release', 'elixir-ls')
-call ale#Set('elixir_elixir_ls_config', {})
-
-function! ale_linters#elixir#elixir_ls#GetExecutable(buffer) abort
-    let l:dir = ale#path#Simplify(ale#Var(a:buffer, 'elixir_elixir_ls_release'))
-    let l:cmd = ale#Has('win32') ? '\language_server.bat' : '/language_server.sh'
-
-    return l:dir . l:cmd
-endfunction
-
-call ale#linter#Define('elixir', {
-\   'name': 'elixir-ls',
-\   'lsp': 'stdio',
-\   'executable_callback': 'ale_linters#elixir#elixir_ls#GetExecutable',
-\   'command_callback': 'ale_linters#elixir#elixir_ls#GetExecutable',
-\   'project_root_callback': 'ale#handlers#elixir#FindMixUmbrellaRoot',
-\   'lsp_config_callback': ale#VarFunc('elixir_elixir_ls_config'),
-\})

ale_linters/elixir/mix.vim

@@ -10,6 +10,7 @@ function! ale_linters#elixir#mix#Handle(buffer, lines) abort
     "
     " TODO: Warning format
     " warning: variable "foobar" does not exist and is being expanded to "foobar()", please use parentheses to remove the ambiguity or change the variable name
+
     let l:pattern = '\v\(([^\)]+Error)\) ([^:]+):([^:]+): (.+)$'
     let l:output = []
 
@@ -29,8 +30,16 @@ function! ale_linters#elixir#mix#Handle(buffer, lines) abort
     return l:output
 endfunction
 
+function! ale_linters#elixir#mix#FindProjectRoot(buffer) abort
+    let l:mix_file = ale#path#FindNearestFile(a:buffer, 'mix.exs')
+    if !empty(l:mix_file)
+      return fnamemodify(l:mix_file, ':p:h')
+    endif
+    return '.'
+endfunction
+
 function! ale_linters#elixir#mix#GetCommand(buffer) abort
-    let l:project_root = ale#handlers#elixir#FindMixProjectRoot(a:buffer)
+    let l:project_root = ale_linters#elixir#mix#FindProjectRoot(a:buffer)
 
     let l:temp_dir = ale#engine#CreateDirectory(a:buffer)
 
@@ -39,8 +48,8 @@ function! ale_linters#elixir#mix#GetCommand(buffer) abort
     \   : 'MIX_BUILD_PATH=' . ale#Escape(l:temp_dir)
 
     return ale#path#CdString(l:project_root)
-    \ . l:mix_build_path
+          \ . l:mix_build_path
-    \ . ' mix compile %s'
+          \ . ' mix compile %s'
 endfunction
 
 call ale#linter#Define('elixir', {

ale_linters/eruby/ruumba.vim

@@ -1,62 +0,0 @@
-" Author: aclemons - https://github.com/aclemons
-" based on the ale rubocop linter
-" Description: Ruumba, RuboCop linting for ERB templates.
-
-call ale#Set('eruby_ruumba_executable', 'ruumba')
-call ale#Set('eruby_ruumba_options', '')
-
-function! ale_linters#eruby#ruumba#GetCommand(buffer) abort
-    let l:executable = ale#Var(a:buffer, 'eruby_ruumba_executable')
-
-    return ale#handlers#ruby#EscapeExecutable(l:executable, 'ruumba')
-    \   . ' --format json --force-exclusion '
-    \   . ale#Var(a:buffer, 'eruby_ruumba_options')
-    \   . ' --stdin ' . ale#Escape(expand('#' . a:buffer . ':p'))
-endfunction
-
-function! ale_linters#eruby#ruumba#Handle(buffer, lines) abort
-    try
-        let l:errors = json_decode(a:lines[0])
-    catch
-        return []
-    endtry
-
-    if !has_key(l:errors, 'summary')
-    \|| l:errors['summary']['offense_count'] == 0
-    \|| empty(l:errors['files'])
-        return []
-    endif
-
-    let l:output = []
-
-    for l:error in l:errors['files'][0]['offenses']
-        let l:start_col = l:error['location']['column'] + 0
-        call add(l:output, {
-        \   'lnum': l:error['location']['line'] + 0,
-        \   'col': l:start_col,
-        \   'end_col': l:start_col + l:error['location']['length'] - 1,
-        \   'code': l:error['cop_name'],
-        \   'text': l:error['message'],
-        \   'type': ale_linters#eruby#ruumba#GetType(l:error['severity']),
-        \})
-    endfor
-
-    return l:output
-endfunction
-
-function! ale_linters#eruby#ruumba#GetType(severity) abort
-    if a:severity is? 'convention'
-    \|| a:severity is? 'warning'
-    \|| a:severity is? 'refactor'
-        return 'W'
-    endif
-
-    return 'E'
-endfunction
-
-call ale#linter#Define('eruby', {
-\   'name': 'ruumba',
-\   'executable_callback': ale#VarFunc('eruby_ruumba_executable'),
-\   'command_callback': 'ale_linters#eruby#ruumba#GetCommand',
-\   'callback': 'ale_linters#eruby#ruumba#Handle',
-\})

ale_linters/gitcommit/gitlint.vim

@@ -23,10 +23,8 @@ function! ale_linters#gitcommit#gitlint#Handle(buffer, lines) abort
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
         let l:code = l:match[2]
 
-        if !ale#Var(a:buffer, 'warn_about_trailing_whitespace')
+        if l:code is# 'T2' && !ale#Var(a:buffer, 'warn_about_trailing_whitespace')
-            if l:code is# 'T2' || l:code is# 'B2'
+            continue
-                continue
-            endif
         endif
 
         let l:item = {

ale_linters/go/gobuild.vim

@@ -3,15 +3,38 @@
 " Description: go build for Go files
 " inspired by work from dzhou121 <dzhou121@gmail.com>
 
-call ale#Set('go_go_executable', 'go')
 call ale#Set('go_gobuild_options', '')
 
-function! ale_linters#go#gobuild#GetCommand(buffer) abort
+function! ale_linters#go#gobuild#ResetEnv() abort
+    unlet! s:go_env
+endfunction
+
+function! ale_linters#go#gobuild#GoEnv(buffer) abort
+    if exists('s:go_env')
+        return ''
+    endif
+
+    return 'go env GOPATH GOROOT'
+endfunction
+
+function! ale_linters#go#gobuild#GetCommand(buffer, goenv_output) abort
     let l:options = ale#Var(a:buffer, 'go_gobuild_options')
 
+    if !exists('s:go_env')
+        let s:go_env = {
+        \   'GOPATH': a:goenv_output[0],
+        \   'GOROOT': a:goenv_output[1],
+        \}
+    endif
+
+    let l:gopath_env_command = has('win32')
+    \   ? 'set GOPATH=' . ale#Escape(s:go_env.GOPATH) . ' && '
+    \   : 'GOPATH=' . ale#Escape(s:go_env.GOPATH) . ' '
+
     " Run go test in local directory with relative path
-    return ale#path#BufferCdString(a:buffer)
+    return l:gopath_env_command
-    \   . ale#Var(a:buffer, 'go_go_executable') . ' test'
+    \   . ale#path#BufferCdString(a:buffer)
+    \   . 'go test'
     \   . (!empty(l:options) ? ' ' . l:options : '')
     \   . ' -c -o /dev/null ./'
 endfunction
@@ -22,6 +45,7 @@ function! ale_linters#go#gobuild#GetMatches(lines) abort
     " file.go:27: missing argument for Printf("%s"): format reads arg 2, have only 1 args
     " file.go:53:10: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
     " file.go:5:2: expected declaration, found 'STRING' "log"
+
     " go test returns relative paths so use tail of filename as part of pattern matcher
     let l:pattern = '\v^([a-zA-Z]?:?[^:]+):(\d+):?(\d+)?:? (.+)$'
 
@@ -48,9 +72,11 @@ endfunction
 call ale#linter#Define('go', {
 \   'name': 'gobuild',
 \   'aliases': ['go build'],
-\   'executable_callback': ale#VarFunc('go_go_executable'),
+\   'executable': 'go',
-\   'command_callback': 'ale_linters#go#gobuild#GetCommand',
+\   'command_chain': [
-\   'output_stream': 'stderr',
+\     {'callback': 'ale_linters#go#gobuild#GoEnv', 'output_stream': 'stdout'},
+\     {'callback': 'ale_linters#go#gobuild#GetCommand', 'output_stream': 'stderr'},
+\   ],
 \   'callback': 'ale_linters#go#gobuild#Handler',
 \   'lint_file': 1,
 \})

ale_linters/go/golangci_lint.vim

@@ -1,56 +0,0 @@
-" Author: Sascha Grunert <mail@saschagrunert.de>
-" Description: Adds support of golangci-lint
-
-call ale#Set('go_golangci_lint_options', '--enable-all')
-call ale#Set('go_golangci_lint_executable', 'golangci-lint')
-call ale#Set('go_golangci_lint_package', 0)
-
-function! ale_linters#go#golangci_lint#GetCommand(buffer) abort
-    let l:filename = expand('#' . a:buffer . ':t')
-    let l:options = ale#Var(a:buffer, 'go_golangci_lint_options')
-    let l:lint_package = ale#Var(a:buffer, 'go_golangci_lint_package')
-
-    if l:lint_package
-        return ale#path#BufferCdString(a:buffer)
-        \   . '%e run '
-        \   .  l:options
-    endif
-
-    return ale#path#BufferCdString(a:buffer)
-    \   . '%e run '
-    \   . ale#Escape(l:filename)
-    \   . ' ' . l:options
-endfunction
-
-function! ale_linters#go#golangci_lint#GetMatches(lines) abort
-    let l:pattern = '\v^([a-zA-Z]?:?[^:]+):(\d+):?(\d+)?:?:?:?\s\*?(.+)$'
-
-    return ale#util#GetMatches(a:lines, l:pattern)
-endfunction
-
-function! ale_linters#go#golangci_lint#Handler(buffer, lines) abort
-    let l:dir = expand('#' . a:buffer . ':p:h')
-    let l:output = []
-
-    for l:match in ale_linters#go#golangci_lint#GetMatches(a:lines)
-        " l:match[1] will already be an absolute path, output from
-        " golangci_lint
-        call add(l:output, {
-        \   'filename': ale#path#GetAbsPath(l:dir, l:match[1]),
-        \   'lnum': l:match[2] + 0,
-        \   'col': l:match[3] + 0,
-        \   'type': 'E',
-        \   'text': l:match[4],
-        \})
-    endfor
-
-    return l:output
-endfunction
-
-call ale#linter#Define('go', {
-\   'name': 'golangci-lint',
-\   'executable_callback': ale#VarFunc('go_golangci_lint_executable'),
-\   'command_callback': 'ale_linters#go#golangci_lint#GetCommand',
-\   'callback': 'ale_linters#go#golangci_lint#Handler',
-\   'lint_file': 1,
-\})

ale_linters/go/golint.vim

@@ -1,21 +1,10 @@
 " Author: neersighted <bjorn@neersighted.com>
 " Description: golint for Go files
 
-call ale#Set('go_golint_executable', 'golint')
-call ale#Set('go_golint_options', '')
-
-function! ale_linters#go#golint#GetCommand(buffer) abort
-    let l:options = ale#Var(a:buffer, 'go_golint_options')
-
-    return '%e'
-    \   . (!empty(l:options) ? ' ' . l:options : '')
-    \   . ' %t'
-endfunction
-
 call ale#linter#Define('go', {
 \   'name': 'golint',
 \   'output_stream': 'both',
-\   'executable_callback': ale#VarFunc('go_golint_executable'),
+\   'executable': 'golint',
-\   'command_callback': 'ale_linters#go#golint#GetCommand',
+\   'command': 'golint %t',
 \   'callback': 'ale#handlers#unix#HandleAsWarning',
 \})

ale_linters/go/govet.vim

@@ -4,23 +4,15 @@
 " Author: John Eikenberry <jae@zhar.net>
 " Description: updated to work with go1.10
 
-call ale#Set('go_go_executable', 'go')
-call ale#Set('go_govet_options', '')
-
 function! ale_linters#go#govet#GetCommand(buffer) abort
-    let l:options = ale#Var(a:buffer, 'go_govet_options')
+    return ale#path#BufferCdString(a:buffer) . ' go vet .'
-
-    return ale#path#BufferCdString(a:buffer) . ' '
-    \   . ale#Var(a:buffer, 'go_go_executable') . ' vet '
-    \   . (!empty(l:options) ? ' ' . l:options : '')
-    \   . ' .'
 endfunction
 
 call ale#linter#Define('go', {
 \   'name': 'govet',
 \   'aliases': ['go vet'],
 \   'output_stream': 'stderr',
-\   'executable_callback': ale#VarFunc('go_go_executable'),
+\   'executable': 'go',
 \   'command_callback': 'ale_linters#go#govet#GetCommand',
 \   'callback': 'ale#handlers#go#Handler',
 \   'lint_file': 1,

ale_linters/go/langserver.vim

@@ -1,28 +0,0 @@
-" Author: Horacio Sanson <https://github.com/hsanson>
-" Description: Support for go-langserver https://github.com/sourcegraph/go-langserver
-
-call ale#Set('go_langserver_executable', 'go-langserver')
-call ale#Set('go_langserver_options', '')
-
-function! ale_linters#go#langserver#GetCommand(buffer) abort
-    let l:executable = [ale#Escape(ale#Var(a:buffer, 'go_langserver_executable'))]
-    let l:options = ale#Var(a:buffer, 'go_langserver_options')
-    let l:options = substitute(l:options, '-gocodecompletion', '', 'g')
-    let l:options = filter(split(l:options, ' '), 'empty(v:val) != 1')
-
-    if(ale#Var(a:buffer, 'completion_enabled') == 1)
-      call add(l:options, '-gocodecompletion')
-    endif
-
-    let l:options = uniq(sort(l:options))
-
-    return join(extend(l:executable, l:options), ' ')
-endfunction
-
-call ale#linter#Define('go', {
-\   'name': 'golangserver',
-\   'lsp': 'stdio',
-\   'executable_callback': ale#VarFunc('go_langserver_executable'),
-\   'command_callback': 'ale_linters#go#langserver#GetCommand',
-\   'project_root_callback': 'ale#go#FindProjectRoot',
-\})

ale_linters/haml/hamllint.vim

@@ -1,12 +1,6 @@
 " Author: Patrick Lewis - https://github.com/patricklewis, thenoseman - https://github.com/thenoseman
 " Description: haml-lint for Haml files
 
-call ale#Set('haml_hamllint_executable', 'haml-lint')
-
-function! ale_linters#haml#hamllint#GetExecutable(buffer) abort
-    return ale#Var(a:buffer, 'haml_hamllint_executable')
-endfunction
-
 function! ale_linters#haml#hamllint#GetCommand(buffer) abort
     let l:prefix = ''
 
@@ -27,7 +21,7 @@ function! ale_linters#haml#hamllint#GetCommand(buffer) abort
     endif
 
     return (!empty(l:prefix) ? l:prefix . ' ' : '')
-    \   . ale_linters#haml#hamllint#GetExecutable(a:buffer)
+    \   . 'haml-lint'
     \   . (!empty(l:hamllint_config_file_path) ? ' --config ' . ale#Escape(l:hamllint_config_file_path) : '')
     \   . ' %t'
 endfunction
@@ -51,7 +45,7 @@ endfunction
 
 call ale#linter#Define('haml', {
 \   'name': 'hamllint',
-\   'executable_callback': 'ale_linters#haml#hamllint#GetExecutable',
+\   'executable': 'haml-lint',
 \   'command_callback': 'ale_linters#haml#hamllint#GetCommand',
 \   'callback': 'ale_linters#haml#hamllint#Handle'
 \})

ale_linters/haskell/ghc-mod.vim

@@ -0,0 +1,18 @@
+" Author: wizzup <wizzup@gmail.com>
+" Description: ghc-mod for Haskell files
+
+call ale#linter#Define('haskell', {
+\   'name': 'ghc_mod',
+\   'aliases': ['ghc-mod'],
+\   'executable': 'ghc-mod',
+\   'command': 'ghc-mod --map-file %s=%t check %s',
+\   'callback': 'ale#handlers#haskell#HandleGHCFormat',
+\})
+
+call ale#linter#Define('haskell', {
+\   'name': 'stack_ghc_mod',
+\   'aliases': ['stack-ghc-mod'],
+\   'executable': 'stack',
+\   'command': 'stack exec ghc-mod -- --map-file %s=%t check %s',
+\   'callback': 'ale#handlers#haskell#HandleGHCFormat',
+\})

ale_linters/haskell/ghc_mod.vim

@@ -1,19 +0,0 @@
-" Author: wizzup <wizzup@gmail.com>
-" Description: ghc-mod for Haskell files
-
-call ale#Set('haskell_ghc_mod_executable', 'ghc-mod')
-
-function! ale_linters#haskell#ghc_mod#GetCommand (buffer) abort
-    let l:executable = ale#Var(a:buffer, 'haskell_ghc_mod_executable')
-
-    return ale#handlers#haskell_stack#EscapeExecutable(l:executable, 'ghc-mod')
-    \   . ' --map-file %s=%t check %s'
-endfunction
-
-call ale#linter#Define('haskell', {
-\   'name': 'ghc_mod',
-\   'aliases': ['ghc-mod'],
-\   'executable_callback': ale#VarFunc('haskell_ghc_mod_executable'),
-\   'command_callback': 'ale_linters#haskell#ghc_mod#GetCommand',
-\   'callback': 'ale#handlers#haskell#HandleGHCFormat',
-\})

ale_linters/haskell/hdevtools.vim

@@ -5,10 +5,7 @@ call ale#Set('haskell_hdevtools_executable', 'hdevtools')
 call ale#Set('haskell_hdevtools_options', get(g:, 'hdevtools_options', '-g -Wall'))
 
 function! ale_linters#haskell#hdevtools#GetCommand(buffer) abort
-    let l:executable = ale#Var(a:buffer, 'haskell_hdevtools_executable')
+    return '%e check' . ale#Pad(ale#Var(a:buffer, 'haskell_hdevtools_options'))
-
-    return ale#handlers#haskell_stack#EscapeExecutable(l:executable, 'hdevtools')
-    \ . ' check' . ale#Pad(ale#Var(a:buffer, 'haskell_hdevtools_options'))
     \ . ' -p %s %t'
 endfunction
 

ale_linters/haskell/hie.vim

@@ -3,6 +3,10 @@
 
 call ale#Set('haskell_hie_executable', 'hie')
 
+function! ale_linters#haskell#hie#GetExecutable(buffer) abort
+    return ale#Var(a:buffer, 'haskell_hie_executable')
+endfunction
+
 function! ale_linters#haskell#hie#GetProjectRoot(buffer) abort
     " Search for the stack file first
     let l:project_file = ale#path#FindNearestFile(a:buffer, 'stack.yaml')
@@ -31,17 +35,10 @@ function! ale_linters#haskell#hie#GetProjectRoot(buffer) abort
     return l:project_file
 endfunction
 
-function! ale_linters#haskell#hie#GetCommand(buffer) abort
-    let l:executable = ale#Var(a:buffer, 'haskell_hie_executable')
-
-    return ale#handlers#haskell_stack#EscapeExecutable(l:executable, 'hie')
-\        . ' --lsp'
-endfunction
-
 call ale#linter#Define('haskell', {
 \   'name': 'hie',
 \   'lsp': 'stdio',
-\   'command_callback': 'ale_linters#haskell#hie#GetCommand',
+\   'command': '%e --lsp',
-\   'executable_callback': ale#VarFunc('haskell_hie_executable'),
+\   'executable_callback': 'ale_linters#haskell#hie#GetExecutable',
 \   'project_root_callback': 'ale_linters#haskell#hie#GetProjectRoot',
 \})

ale_linters/haskell/hlint.vim

@@ -1,9 +1,6 @@
 " Author: jparoz <jesse.paroz@gmail.com>
 " Description: hlint for Haskell files
 
-call ale#Set('haskell_hlint_executable', 'hlint')
-call ale#Set('haskell_hlint_options', get(g:, 'hlint_options', ''))
-
 function! ale_linters#haskell#hlint#Handle(buffer, lines) abort
     let l:output = []
 
@@ -29,18 +26,9 @@ function! ale_linters#haskell#hlint#Handle(buffer, lines) abort
     return l:output
 endfunction
 
-function! ale_linters#haskell#hlint#GetCommand(buffer) abort
-    let l:hlintopts = '--color=never --json'
-
-    return ale#handlers#hlint#GetExecutable(a:buffer)
-    \      . ' ' . ale#Var(a:buffer, 'haskell_hlint_options')
-    \      . ' ' . l:hlintopts
-    \      . ' -'
-endfunction
-
 call ale#linter#Define('haskell', {
 \   'name': 'hlint',
-\   'executable_callback': ale#VarFunc('haskell_hlint_executable'),
+\   'executable': 'hlint',
-\   'command_callback': 'ale_linters#haskell#hlint#GetCommand' ,
+\   'command': 'hlint --color=never --json -',
 \   'callback': 'ale_linters#haskell#hlint#Handle',
 \})

ale_linters/haskell/stack_build.vim

@@ -16,7 +16,7 @@ call ale#linter#Define('haskell', {
 \   'name': 'stack_build',
 \   'aliases': ['stack-build'],
 \   'output_stream': 'stderr',
-\   'executable_callback': 'ale#handlers#haskell#GetStackExecutable',
+\   'executable': 'stack',
 \   'command_callback': 'ale_linters#haskell#stack_build#GetCommand',
 \   'lint_file': 1,
 \   'callback': 'ale#handlers#haskell#HandleGHCFormat',

ale_linters/haskell/stack_ghc.vim

@@ -5,7 +5,7 @@ call ale#linter#Define('haskell', {
 \   'name': 'stack_ghc',
 \   'aliases': ['stack-ghc'],
 \   'output_stream': 'stderr',
-\   'executable_callback': 'ale#handlers#haskell#GetStackExecutable',
+\   'executable': 'stack',
 \   'command': 'stack ghc -- -fno-code -v0 %t',
 \   'callback': 'ale#handlers#haskell#HandleGHCFormat',
 \})

ale_linters/html/stylelint.vim

@@ -1,27 +0,0 @@
-" Author: Filipe Kiss <hello@filipekiss.com.br> http://github.com/filipekiss
-
-call ale#Set('html_stylelint_executable', 'stylelint')
-call ale#Set('html_stylelint_options', '')
-call ale#Set('html_stylelint_use_global', 0)
-
-function! ale_linters#html#stylelint#GetExecutable(buffer) abort
-    return ale#node#FindExecutable(a:buffer, 'html_stylelint', [
-    \   'node_modules/.bin/stylelint',
-    \])
-endfunction
-
-function! ale_linters#html#stylelint#GetCommand(buffer) abort
-    let l:executable = ale_linters#html#stylelint#GetExecutable(a:buffer)
-    let l:options = ale#Var(a:buffer, 'html_stylelint_options')
-
-    return ale#Escape(l:executable)
-    \   . (!empty(l:options) ? ' ' . l:options : '')
-    \   . ' --stdin-filename %s'
-endfunction
-
-call ale#linter#Define('html', {
-\   'name': 'stylelint',
-\   'executable_callback': 'ale_linters#html#stylelint#GetExecutable',
-\   'command_callback': 'ale_linters#html#stylelint#GetCommand',
-\   'callback': 'ale#handlers#css#HandleStyleLintFormat',
-\})

ale_linters/html/tidy.vim

@@ -25,7 +25,6 @@ function! ale_linters#html#tidy#GetCommand(buffer) abort
     " On macOS, old tidy (released on 31 Oct 2006) is installed. It does not
     " consider HTML5 so we should avoid it.
     let l:executable = ale#Var(a:buffer, 'html_tidy_executable')
-
     if has('mac') && l:executable is# 'tidy' && exists('*exepath')
     \  && exepath(l:executable) is# '/usr/bin/tidy'
         return ''
@@ -41,6 +40,7 @@ endfunction
 function! ale_linters#html#tidy#Handle(buffer, lines) abort
     " Matches patterns lines like the following:
     " line 7 column 5 - Warning: missing </title> before </head>
+
     let l:pattern = '^line \(\d\+\) column \(\d\+\) - \(Warning\|Error\): \(.\+\)$'
     let l:output = []
 

ale_linters/idris/idris.vim

@@ -12,7 +12,7 @@ endfunction
 
 function! ale_linters#idris#idris#Handle(buffer, lines) abort
     " This was copied almost verbatim from ale#handlers#haskell#HandleGHCFormat
-    "
+
     " Look for lines like the following:
     " foo.idr:2:6:When checking right hand side of main with expected type
     " bar.idr:11:11-13:
@@ -30,7 +30,6 @@ function! ale_linters#idris#idris#Handle(buffer, lines) abort
             else
                 let l:corrected_lines[-1] .= l:line
             endif
-
             let l:corrected_lines[-1] = substitute(l:corrected_lines[-1], '\s\+', ' ', 'g')
         endif
     endfor

ale_linters/ispc/ispc.vim

@@ -1,45 +0,0 @@
-" Author: Martino Pilia <martino.pilia@gmail.com>
-" Description: Lint ispc files with the Intel(R) SPMD Program Compiler
-
-call ale#Set('ispc_ispc_executable', 'ispc')
-call ale#Set('ispc_ispc_options', '')
-
-function! ale_linters#ispc#ispc#GetCommand(buffer) abort
-    " --nowrap: do not wrap message lines
-    return '%e --nowrap'
-    \   . ale#Pad(ale#c#IncludeOptions(ale#c#FindLocalHeaderPaths(a:buffer)))
-    \   . ale#Pad(ale#Var(a:buffer, 'ispc_ispc_options'))
-    \   . ' %s'
-endfunction
-
-" Note that we ignore the two warnings in the beginning of the compiler output
-" ('no output file specified' and 'no --target specified'), since they have
-" nothing to do with linting.
-function! ale_linters#ispc#ispc#Handle(buffer, lines) abort
-    " Message format: <filename>:<lnum>:<col> <type>: <text>
-    " As far as I know, <type> can be any of:
-    "   'error', 'Error', 'fatal error', 'Warning', 'Performance Warning'
-    let l:re = '\v.+:([0-9]+):([0-9]+):\s+([^:]+):\s+(.+)'
-    let l:output = []
-
-    for l:match in ale#util#GetMatches(a:lines, l:re)
-        call add(l:output, {
-        \   'bufnr': a:buffer,
-        \   'lnum': str2nr(l:match[1]),
-        \   'col': str2nr(l:match[2]),
-        \   'type': l:match[3] =~? 'error' ? 'E' : 'W',
-        \   'text': l:match[4],
-        \})
-    endfor
-
-    return l:output
-endfunction
-
-call ale#linter#Define('ispc', {
-\   'name': 'ispc',
-\   'output_stream': 'stderr',
-\   'executable_callback': ale#VarFunc('ispc_ispc_executable'),
-\   'command_callback': 'ale_linters#ispc#ispc#GetCommand',
-\   'callback': 'ale_linters#ispc#ispc#Handle',
-\   'lint_file': 1,
-\})

ale_linters/java/checkstyle.vim

@@ -2,10 +2,8 @@
 " Description: checkstyle for Java files
 
 function! ale_linters#java#checkstyle#Handle(buffer, lines) abort
-    let l:output = []
-
-    " modern checkstyle versions
     let l:pattern = '\v\[(WARN|ERROR)\] [a-zA-Z]?:?[^:]+:(\d+):(\d+)?:? (.*) \[(.+)\]$'
+    let l:output = []
 
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
         call add(l:output, {
@@ -17,24 +15,13 @@ function! ale_linters#java#checkstyle#Handle(buffer, lines) abort
         \})
     endfor
 
-    " old checkstyle versions
-    let l:pattern = '\v(.+):(\d+): ([^:]+): (.+)$'
-
-    for l:match in ale#util#GetMatches(a:lines, l:pattern)
-        call add(l:output, {
-        \   'type': l:match[3] is? 'warning' ? 'W' : 'E',
-        \   'lnum': l:match[2] + 0,
-        \   'text': l:match[4],
-        \})
-    endfor
-
     return l:output
 endfunction
 
 function! ale_linters#java#checkstyle#GetCommand(buffer) abort
     return 'checkstyle '
     \ . ale#Var(a:buffer, 'java_checkstyle_options')
-    \ . ' %s'
+    \ . ' %t'
 endfunction
 
 if !exists('g:ale_java_checkstyle_options')
@@ -46,5 +33,4 @@ call ale#linter#Define('java', {
 \   'executable': 'checkstyle',
 \   'command_callback': 'ale_linters#java#checkstyle#GetCommand',
 \   'callback': 'ale_linters#java#checkstyle#Handle',
-\   'lint_file': 1,
 \})

ale_linters/java/javac.vim

@@ -16,7 +16,6 @@ function! ale_linters#java#javac#GetImportPaths(buffer) abort
     endif
 
     let l:classpath_command = ale#gradle#BuildClasspathCommand(a:buffer)
-
     if !empty(l:classpath_command)
         return l:classpath_command
     endif
@@ -91,6 +90,7 @@ function! ale_linters#java#javac#Handle(buffer, lines) abort
     "
     " Main.java:13: warning: [deprecation] donaught() in Testclass has been deprecated
     " Main.java:16: error: ';' expected
+
     let l:directory = expand('#' . a:buffer . ':p:h')
     let l:pattern = '\v^(.*):(\d+): (.+):(.+)$'
     let l:col_pattern = '\v^(\s*\^)$'

ale_linters/java/javalsp.vim

@@ -1,23 +0,0 @@
-" Author: Horacio Sanson <https://github.com/hsanson>
-" Description: Support for the Java language server https://github.com/georgewfraser/vscode-javac
-
-call ale#Set('java_javalsp_jar', 'javacs.jar')
-
-function! ale_linters#java#javalsp#Executable(buffer) abort
-    return 'java'
-endfunction
-
-function! ale_linters#java#javalsp#Command(buffer) abort
-    let l:jar = ale#Var(a:buffer, 'java_javalsp_jar')
-
-    return ale#Escape('java -cp ' . l:jar . ' -Xverify:none org.javacs.Main')
-endfunction
-
-call ale#linter#Define('java', {
-\   'name': 'javalsp',
-\   'lsp': 'stdio',
-\   'executable_callback': 'ale_linters#java#javalsp#Executable',
-\   'command_callback': 'ale_linters#java#javalsp#Command',
-\   'language': 'java',
-\   'project_root_callback': 'ale#java#FindProjectRoot',
-\})

ale_linters/java/pmd.vim

@@ -2,7 +2,7 @@
 " Description: PMD for Java files
 
 function! ale_linters#java#pmd#Handle(buffer, lines) abort
-    let l:pattern = '"\(\d\+\)",".*","\(.\+\)","\(\d\+\)","\(\d\+\)","\(.\+\)","\(.\+\)","\(.\+\)"$'
+    let l:pattern = '"\(\d\+\)",".\+","\(.\+\)","\(\d\+\)","\(\d\+\)","\(.\+\)","\(.\+\)","\(.\+\)"$'
     let l:output = []
 
     for l:match in ale#util#GetMatches(a:lines, l:pattern)

ale_linters/javascript/flow.vim

@@ -91,6 +91,7 @@ function! s:GetDetails(error) abort
     let l:detail = ''
 
     for l:extra_error in a:error.extra
+
         if has_key(l:extra_error, 'message')
             for l:extra_message in l:extra_error.message
                 let l:detail = s:ExtraErrorMsg(l:detail, l:extra_message.descr)
@@ -104,6 +105,7 @@ function! s:GetDetails(error) abort
                 endfor
             endfor
         endif
+
     endfor
 
     return l:detail
@@ -159,6 +161,7 @@ function! ale_linters#javascript#flow#Handle(buffer, lines) abort
         endif
 
         call add(l:output, l:errorToAdd)
+
     endfor
 
     return l:output

ale_linters/javascript/jshint.vim

@@ -18,7 +18,7 @@ function! ale_linters#javascript#jshint#GetCommand(buffer) abort
         let l:command .= ' --config ' . ale#Escape(l:jshint_config)
     endif
 
-    let l:command .= ' --filename %s -'
+    let l:command .= ' -'
 
     return l:command
 endfunction

ale_linters/json/jsonlint.vim

@@ -3,6 +3,7 @@
 function! ale_linters#json#jsonlint#Handle(buffer, lines) abort
     " Matches patterns like the following:
     " line 2, col 15, found: 'STRING' - expected: 'EOF', '}', ',', ']'.
+
     let l:pattern = '^line \(\d\+\), col \(\d*\), \(.\+\)$'
     let l:output = []
 

ale_linters/julia/languageserver.vim

@@ -1,21 +0,0 @@
-" Author: Bartolomeo Stellato <bartolomeo.stellato@gmail.com>
-" Description: A language server for Julia
-
-" Set julia executable variable
-call ale#Set('julia_executable', 'julia')
-
-function! ale_linters#julia#languageserver#GetCommand(buffer) abort
-    let l:julia_executable = ale#Var(a:buffer, 'julia_executable')
-    let l:cmd_string = 'using LanguageServer; server = LanguageServer.LanguageServerInstance(isdefined(Base, :stdin) ? stdin : STDIN, isdefined(Base, :stdout) ? stdout : STDOUT, false); server.runlinter = true; run(server);'
-
-    return ale#Escape(l:julia_executable) . ' --startup-file=no --history-file=no -e ' . ale#Escape(l:cmd_string)
-endfunction
-
-call ale#linter#Define('julia', {
-\   'name': 'languageserver',
-\   'lsp': 'stdio',
-\   'executable_callback': ale#VarFunc('julia_executable'),
-\   'command_callback': 'ale_linters#julia#languageserver#GetCommand',
-\   'language': 'julia',
-\   'project_root_callback': 'ale#julia#FindProjectRoot',
-\})

ale_linters/kotlin/kotlinc.vim

@@ -17,14 +17,12 @@ function! ale_linters#kotlin#kotlinc#GetImportPaths(buffer) abort
         return ''
     else
         let l:pom_path = ale#path#FindNearestFile(a:buffer, 'pom.xml')
-
         if !empty(l:pom_path) && executable('mvn')
             return ale#path#CdString(fnamemodify(l:pom_path, ':h'))
                         \ . 'mvn dependency:build-classpath'
         endif
 
         let l:classpath_command = ale#gradle#BuildClasspathCommand(a:buffer)
-
         if !empty(l:classpath_command)
             return l:classpath_command
         endif
@@ -80,13 +78,12 @@ function! ale_linters#kotlin#kotlinc#GetCommand(buffer, import_paths) abort
     endif
 
     let l:fname = ''
-
     if ale#Var(a:buffer, 'kotlin_kotlinc_sourcepath') isnot# ''
         let l:fname .= expand(ale#Var(a:buffer, 'kotlin_kotlinc_sourcepath'), 1) . ' '
     else
         " Find the src directory for files in this project.
-        let l:project_root = ale#gradle#FindProjectRoot(a:buffer)
 
+        let l:project_root = ale#gradle#FindProjectRoot(a:buffer)
         if !empty(l:project_root)
             let l:src_dir = l:project_root
         else
@@ -96,7 +93,6 @@ function! ale_linters#kotlin#kotlinc#GetCommand(buffer, import_paths) abort
 
         let l:fname .= expand(l:src_dir, 1) . ' '
     endif
-
     let l:fname .= ale#Escape(expand('#' . a:buffer . ':p'))
     let l:command .= l:kotlinc_opts . ' ' . l:fname
 
@@ -128,7 +124,6 @@ function! ale_linters#kotlin#kotlinc#Handle(buffer, lines) abort
         if l:buf_abspath isnot# l:curbuf_abspath
             continue
         endif
-
         let l:type_marker_str = l:type is# 'warning' ? 'W' : 'E'
 
         call add(l:output, {

ale_linters/make/checkmake.vim

@@ -13,7 +13,6 @@ function! ale_linters#make#checkmake#Handle(buffer, lines) abort
         \    'text': l:match[3],
         \})
     endfor
-
     return l:output
 endfunction
 

ale_linters/markdown/remark_lint.vim

@@ -24,12 +24,10 @@ function! ale_linters#markdown#remark_lint#Handle(buffer, lines) abort
         \   'type': l:match[6] is# 'error' ? 'E' : 'W',
         \   'text': l:match[7],
         \}
-
         if l:match[3] isnot# ''
             let l:item.end_lnum = l:match[4] + 0
             let l:item.end_col = l:match[5] + 0
         endif
-
         call add(l:output, l:item)
     endfor
 

ale_linters/objc/ccls.vim

@@ -1,14 +0,0 @@
-" Author: Ye Jingchen <ye.jingchen@gmail.com>, Ben Falconer <ben@falconers.me.uk>, jtalowell <jtalowell@protonmail.com>
-" Description: A language server for Objective-C
-
-call ale#Set('objc_ccls_executable', 'ccls')
-call ale#Set('objc_ccls_init_options', {})
-
-call ale#linter#Define('objc', {
-\   'name': 'ccls',
-\   'lsp': 'stdio',
-\   'executable_callback': ale#VarFunc('objc_ccls_executable'),
-\   'command': '%e',
-\   'project_root_callback': 'ale#handlers#ccls#GetProjectRoot',
-\   'initialization_options_callback': ale#VarFunc('objc_ccls_init_options'),
-\})

ale_linters/objc/clangd.vim

@@ -1,23 +0,0 @@
-" Author: Andrey Melentyev <andrey.melentyev@protonmail.com>
-" Description: Clangd language server
-
-call ale#Set('objc_clangd_executable', 'clangd')
-call ale#Set('objc_clangd_options', '')
-
-function! ale_linters#objc#clangd#GetProjectRoot(buffer) abort
-    let l:project_root = ale#path#FindNearestFile(a:buffer, 'compile_commands.json')
-
-    return !empty(l:project_root) ? fnamemodify(l:project_root, ':h') : ''
-endfunction
-
-function! ale_linters#objc#clangd#GetCommand(buffer) abort
-    return '%e' . ale#Pad(ale#Var(a:buffer, 'objc_clangd_options'))
-endfunction
-
-call ale#linter#Define('objc', {
-\   'name': 'clangd',
-\   'lsp': 'stdio',
-\   'executable_callback': ale#VarFunc('objc_clangd_executable'),
-\   'command_callback': 'ale_linters#objc#clangd#GetCommand',
-\   'project_root_callback': 'ale_linters#objc#clangd#GetProjectRoot',
-\})

ale_linters/objcpp/clangd.vim

@@ -1,23 +0,0 @@
-" Author: Andrey Melentyev <andrey.melentyev@protonmail.com>
-" Description: Clangd language server
-
-call ale#Set('objcpp_clangd_executable', 'clangd')
-call ale#Set('objcpp_clangd_options', '')
-
-function! ale_linters#objcpp#clangd#GetProjectRoot(buffer) abort
-    let l:project_root = ale#path#FindNearestFile(a:buffer, 'compile_commands.json')
-
-    return !empty(l:project_root) ? fnamemodify(l:project_root, ':h') : ''
-endfunction
-
-function! ale_linters#objcpp#clangd#GetCommand(buffer) abort
-    return '%e' . ale#Pad(ale#Var(a:buffer, 'objcpp_clangd_options'))
-endfunction
-
-call ale#linter#Define('objcpp', {
-\   'name': 'clangd',
-\   'lsp': 'stdio',
-\   'executable_callback': ale#VarFunc('objcpp_clangd_executable'),
-\   'command_callback': 'ale_linters#objcpp#clangd#GetCommand',
-\   'project_root_callback': 'ale_linters#objcpp#clangd#GetProjectRoot',
-\})

ale_linters/perl/perl.vim

@@ -23,7 +23,6 @@ function! ale_linters#perl#perl#Handle(buffer, lines) abort
     let l:basename = expand('#' . a:buffer . ':t')
 
     let l:type = 'E'
-
     if a:lines[-1] =~# 'syntax OK'
         let l:type = 'W'
     endif

ale_linters/perl6/perl6.vim

@@ -1,166 +0,0 @@
-" Author:Travis Gibson <https://github.com/Garland-g>
-" Description: This file adds support for checking perl6 syntax
-
-let g:ale_perl6_perl6_executable =
-\   get(g:, 'ale_perl6_perl6_executable', 'perl6')
-
-let g:ale_perl6_perl6_options =
-\   get(g:, 'ale_perl6_perl6_options', '-c -Ilib')
-
-let $PERL6_EXCEPTIONS_HANDLER = 'JSON'
-
-let $RAKUDO_ERROR_COLOR = 0
-
-function! ale_linters#perl6#perl6#GetExecutable(buffer) abort
-    return ale#Var(a:buffer, 'perl6_perl6_executable')
-endfunction
-
-function! ale_linters#perl6#perl6#GetCommand(buffer) abort
-    return ale_linters#perl6#perl6#GetExecutable(a:buffer)
-    \   . ' ' . ale#Var(a:buffer, 'perl6_perl6_options')
-    \   . ' %t'
-endfunction
-
-function! ale_linters#perl6#perl6#ExtractError(dict, item, type, buffer) abort
-    let l:file = ''
-    let l:line = 1
-    let l:column = ''
-    let l:text = ''
-    let l:pre = ''
-    let l:counter = 2
-    let l:end_line = ''
-    let l:linepatternmessage = 'at\s\+line\s\+\(\d\+\)'
-
-    if has_key(a:dict[a:item], 'filename') && !empty(a:dict[a:item]['filename'])
-        let l:file = a:dict[a:item]['filename']
-    endif
-
-    if has_key(a:dict[a:item], 'line') && !empty(a:dict[a:item]['line'])
-      let l:line = a:dict[a:item]['line']
-      let l:counter -= 1
-    endif
-
-    if has_key(a:dict[a:item], 'column') && !empty(a:dict[a:item]['column'])
-        let l:column = a:dict[a:item]['column']
-    endif
-
-    if has_key(a:dict[a:item], 'message') && !empty(a:dict[a:item]['message'])
-        let l:text = substitute(a:dict[a:item]['message'], '\s*\n\s*', ' ', 'g')
-        let l:counter -= 1
-    endif
-
-    if has_key(a:dict[a:item], 'line-real') && !empty(a:dict[a:item]['line-real'])
-        let l:end_line = l:line
-        let l:line = a:dict[a:item]['line-real']
-    endif
-
-    for l:match in ale#util#GetMatches(l:text, l:linepatternmessage)
-        let l:line = l:match[1]
-        let l:counter -= 1
-    endfor
-
-" Currently, filenames and line numbers are not always given in the error output
-    if l:counter < 2
-   \&& ( ale#path#IsBufferPath(a:buffer, l:file) || l:file is# '' )
-        return {
-        \   'lnum': '' . l:line,
-        \   'text': l:text,
-        \   'type': a:type,
-        \   'col': l:column,
-        \   'end_lnum': l:end_line,
-        \   'code': a:item,
-        \}
-    endif
-
-    return ''
-endfunction
-
-function! ale_linters#perl6#perl6#Handle(buffer, lines) abort
-    let l:output = []
-
-    if empty(a:lines)
-        return l:output
-    endif
-
-    if a:lines[0] is# 'Syntax OK'
-      return l:output
-    endif
-
-    try
-        let l:json = json_decode(join(a:lines, ''))
-    catch /E474/
-        call add(l:output, {
-        \   'lnum': '1',
-        \   'text': 'Received output in the default Perl6 error format. See :ALEDetail for details',
-        \   'detail': join(a:lines, "\n"),
-        \   'type': 'W',
-        \   })
-
-        return l:output
-    endtry
-
-    if type(l:json) is v:t_dict
-        for l:key in keys(l:json)
-            if has_key(l:json[l:key], 'sorrows') &&
-            \  has_key(l:json[l:key], 'worries')
-                if !empty(l:json[l:key]['sorrows'])
-                    for l:dictionary in get(l:json[l:key], 'sorrows')
-                        for l:item in keys(l:dictionary)
-                            let l:result =
-                            \   ale_linters#perl6#perl6#ExtractError(
-                            \       l:dictionary,
-                            \       l:item,
-                            \       'E',
-                            \       a:buffer,
-                            \   )
-
-                            if l:result isnot# ''
-                              call add(l:output, l:result)
-                            endif
-                        endfor
-                    endfor
-                endif
-
-                if !empty(l:json[l:key]['worries'])
-                    for l:dictionary in get(l:json[l:key], 'worries')
-                        for l:item in keys(l:dictionary)
-                            let l:result =
-                            \   ale_linters#perl6#perl6#ExtractError(
-                            \       l:dictionary,
-                            \       l:item,
-                            \       'W',
-                            \       a:buffer,
-                            \   )
-
-                            if l:result isnot# ''
-                              call add(l:output, l:result)
-                            endif
-                        endfor
-                    endfor
-                endif
-            else
-                let l:result = ale_linters#perl6#perl6#ExtractError(
-                \     l:json,
-                \     l:key,
-                \     'E',
-                \     a:buffer,
-                \   )
-
-                if l:result isnot# ''
-                  call add(l:output, l:result)
-                endif
-            endif
-        endfor
-    endif
-
-    return l:output
-endfunction
-
-call ale#linter#Define('perl6', {
-\   'name': 'perl6',
-\   'executable_callback': 'ale_linters#perl6#perl6#GetExecutable',
-\   'output_stream': 'both',
-\   'command_callback': 'ale_linters#perl6#perl6#GetCommand',
-\   'callback': 'ale_linters#perl6#perl6#Handle',
-\})
-

ale_linters/php/php.vim

@@ -1,8 +1,6 @@
 " Author: Spencer Wood <https://github.com/scwood>, Adriaan Zonnenberg <amz@adriaan.xyz>
 " Description: This file adds support for checking PHP with php-cli
 
-call ale#Set('php_php_executable', 'php')
-
 function! ale_linters#php#php#Handle(buffer, lines) abort
     " Matches patterns like the following:
     "
@@ -32,8 +30,8 @@ endfunction
 
 call ale#linter#Define('php', {
 \   'name': 'php',
-\   'executable_callback': ale#VarFunc('php_php_executable'),
+\   'executable': 'php',
 \   'output_stream': 'stdout',
-\   'command': '%e -l -d error_reporting=E_ALL -d display_errors=1 -d log_errors=0 --',
+\   'command': 'php -l -d error_reporting=E_ALL -d display_errors=1 -d log_errors=0 --',
 \   'callback': 'ale_linters#php#php#Handle',
 \})

ale_linters/php/phpcs.vim

@@ -3,7 +3,6 @@
 
 let g:ale_php_phpcs_standard = get(g:, 'ale_php_phpcs_standard', '')
 
-call ale#Set('php_phpcs_options', '')
 call ale#Set('php_phpcs_executable', 'phpcs')
 call ale#Set('php_phpcs_use_global', get(g:, 'ale_use_global_executables', 0))
 
@@ -12,11 +11,8 @@ function! ale_linters#php#phpcs#GetCommand(buffer) abort
     let l:standard_option = !empty(l:standard)
     \   ? '--standard=' . l:standard
     \   : ''
-    let l:options = ale#Var(a:buffer, 'php_phpcs_options')
 
-    return '%e -s --report=emacs --stdin-path=%s'
+    return '%e -s --report=emacs --stdin-path=%s' . ale#Pad(l:standard_option)
-    \    . ale#Pad(l:standard_option)
-    \    . ale#Pad(l:options)
 endfunction
 
 function! ale_linters#php#phpcs#Handle(buffer, lines) abort

ale_linters/php/phpstan.vim

@@ -6,40 +6,15 @@ let g:ale_php_phpstan_executable = get(g:, 'ale_php_phpstan_executable', 'phpsta
 let g:ale_php_phpstan_level = get(g:, 'ale_php_phpstan_level', '4')
 let g:ale_php_phpstan_configuration = get(g:, 'ale_php_phpstan_configuration', '')
 
-function! ale_linters#php#phpstan#GetExecutable(buffer) abort
+function! ale_linters#php#phpstan#GetCommand(buffer) abort
-    return ale#Var(a:buffer, 'php_phpstan_executable')
-endfunction
-
-function! ale_linters#php#phpstan#VersionCheck(buffer) abort
-    let l:executable = ale_linters#php#phpstan#GetExecutable(a:buffer)
-
-    " If we have previously stored the version number in a cache, then
-    " don't look it up again.
-    if ale#semver#HasVersion(l:executable)
-        " Returning an empty string skips this command.
-        return ''
-    endif
-
-    let l:executable = ale#Escape(l:executable)
-
-    return l:executable . ' --version'
-endfunction
-
-function! ale_linters#php#phpstan#GetCommand(buffer, version_output) abort
     let l:configuration = ale#Var(a:buffer, 'php_phpstan_configuration')
     let l:configuration_option = !empty(l:configuration)
     \   ? ' -c ' . l:configuration
     \   : ''
 
-    let l:executable = ale_linters#php#phpstan#GetExecutable(a:buffer)
-    let l:version = ale#semver#GetVersion(l:executable, a:version_output)
-    let l:error_format = ale#semver#GTE(l:version, [0, 10, 3])
-    \   ? ' --error-format raw'
-    \   : ' --errorFormat raw'
-
     return '%e analyze -l'
     \   . ale#Var(a:buffer, 'php_phpstan_level')
-    \   . l:error_format
+    \   . ' --errorFormat raw'
     \   . l:configuration_option
     \   . ' %s'
 endfunction
@@ -65,10 +40,7 @@ endfunction
 
 call ale#linter#Define('php', {
 \   'name': 'phpstan',
-\   'executable_callback': 'ale_linters#php#phpstan#GetExecutable',
+\   'executable_callback': ale#VarFunc('php_phpstan_executable'),
-\   'command_chain': [
+\   'command_callback': 'ale_linters#php#phpstan#GetCommand',
-\       {'callback': 'ale_linters#php#phpstan#VersionCheck'},
-\       {'callback': 'ale_linters#php#phpstan#GetCommand'},
-\   ],
 \   'callback': 'ale_linters#php#phpstan#Handle',
 \})

ale_linters/php/psalm.vim

@@ -1,21 +0,0 @@
-" Author: Matt Brown <https://github.com/muglug>
-" Description: plugin for Psalm, static analyzer for PHP
-
-call ale#Set('psalm_langserver_executable', 'psalm-language-server')
-call ale#Set('psalm_langserver_use_global', get(g:, 'ale_use_global_executables', 0))
-
-function! ale_linters#php#psalm#GetProjectRoot(buffer) abort
-    let l:git_path = ale#path#FindNearestDirectory(a:buffer, '.git')
-
-    return !empty(l:git_path) ? fnamemodify(l:git_path, ':h:h') : ''
-endfunction
-
-call ale#linter#Define('php', {
-\   'name': 'psalm',
-\   'lsp': 'stdio',
-\   'executable_callback': ale#node#FindExecutableFunc('psalm_langserver', [
-\       'vendor/bin/psalm-language-server',
-\   ]),
-\   'command': '%e',
-\   'project_root_callback': 'ale_linters#php#psalm#GetProjectRoot',
-\})

ale_linters/prolog/swipl.vim

@@ -1,100 +0,0 @@
-" Author: Takuya Fujiwara <tyru.exe@gmail.com>
-" Description: swipl syntax / semantic check for Prolog files
-
-call ale#Set('prolog_swipl_executable', 'swipl')
-call ale#Set('prolog_swipl_load', 'current_prolog_flag(argv, [File]), load_files(File, [sandboxed(true)]), halt.')
-call ale#Set('prolog_swipl_timeout', 3)
-call ale#Set('prolog_swipl_alarm', 'alarm(%t, (%h), _, [])')
-call ale#Set('prolog_swipl_alarm_handler', 'writeln(user_error, "ERROR: Exceeded %t seconds, Please change g:prolog_swipl_timeout to modify the limit."), halt(1)')
-
-function! ale_linters#prolog#swipl#GetCommand(buffer) abort
-    let l:goals = ale#Var(a:buffer, 'prolog_swipl_load')
-    let l:goals = l:goals =~# '^\s*$' ? 'halt' : l:goals
-    let l:timeout = ale#Var(a:buffer, 'prolog_swipl_timeout') + 0
-
-    if l:timeout > 0
-        let l:goals = s:GetAlarm(a:buffer, l:timeout) . ', ' . l:goals
-    endif
-
-    return '%e -g ' . ale#Escape(l:goals) . ' -- %s'
-endfunction
-
-function! s:GetAlarm(buffer, timeout) abort
-    let l:handler = ale#Var(a:buffer, 'prolog_swipl_alarm_handler')
-    let l:handler = s:Subst(l:handler, {'t': a:timeout})
-    let l:alarm = ale#Var(a:buffer, 'prolog_swipl_alarm')
-    let l:alarm = s:Subst(l:alarm, {'t': a:timeout, 'h': l:handler})
-
-    return l:alarm
-endfunction
-
-function! s:Subst(format, vars) abort
-    let l:vars = extend(copy(a:vars), {'%': '%'})
-
-    return substitute(a:format, '%\(.\)', '\=get(l:vars, submatch(1), "")', 'g')
-endfunction
-
-function! ale_linters#prolog#swipl#Handle(buffer, lines) abort
-    let l:pattern = '\v^(ERROR|Warning)+%(:\s*[^:]+:(\d+)%(:(\d+))?)?:\s*(.*)$'
-    let l:output = []
-    let l:i = 0
-
-    while l:i < len(a:lines)
-        let l:match = matchlist(a:lines[l:i], l:pattern)
-
-        if empty(l:match)
-            let l:i += 1
-            continue
-        endif
-
-        let [l:i, l:text] = s:GetErrMsg(l:i, a:lines, l:match[4])
-        let l:item = {
-        \   'lnum': (l:match[2] + 0 ? l:match[2] + 0 : 1),
-        \   'col': l:match[3] + 0,
-        \   'text': l:text,
-        \   'type': (l:match[1] is# 'ERROR' ? 'E' : 'W'),
-        \}
-
-        if !s:Ignore(l:item)
-            call add(l:output, l:item)
-        endif
-    endwhile
-
-    return l:output
-endfunction
-
-" This returns [<next line number>, <error message string>]
-function! s:GetErrMsg(i, lines, text) abort
-    if a:text !~# '^\s*$'
-        return [a:i + 1, a:text]
-    endif
-
-    let l:i = a:i + 1
-    let l:text = []
-
-    while l:i < len(a:lines) && a:lines[l:i] =~# '^\s'
-        call add(l:text, s:Trim(a:lines[l:i]))
-        let l:i += 1
-    endwhile
-
-    return [l:i, join(l:text, '. ')]
-endfunction
-
-function! s:Trim(str) abort
-    return substitute(a:str, '\v^\s+|\s+$', '', 'g')
-endfunction
-
-" Skip sandbox error which is caused by directives
-" because what we want is syntactic or semantic check.
-function! s:Ignore(item) abort
-    return a:item.type is# 'E' &&
-    \      a:item.text =~# '\vNo permission to (call|directive|assert) sandboxed'
-endfunction
-
-call ale#linter#Define('prolog', {
-\   'name': 'swipl',
-\   'output_stream': 'stderr',
-\   'executable_callback': ale#VarFunc('prolog_swipl_executable'),
-\   'command_callback': 'ale_linters#prolog#swipl#GetCommand',
-\   'callback': 'ale_linters#prolog#swipl#Handle',
-\})

ale_linters/puppet/languageserver.vim

@@ -8,7 +8,6 @@ function! ale_linters#puppet#languageserver#GetProjectRoot(buffer) abort
     " there's no requirement to have it, so fall back to the other possible
     " Puppet module directories
     let l:root_path = ale#path#FindNearestFile(a:buffer, 'metadata.json')
-
     if !empty(l:root_path)
         return fnamemodify(l:root_path, ':h')
     endif
@@ -18,7 +17,6 @@ function! ale_linters#puppet#languageserver#GetProjectRoot(buffer) abort
     \   'templates',
     \]
         let l:root_path = ale#path#FindNearestDirectory(a:buffer, l:test_path)
-
         if !empty(l:root_path)
             return fnamemodify(l:root_path, ':h:h')
         endif

ale_linters/puppet/puppet.vim

@@ -1,13 +1,11 @@
 " Author: Alexander Olofsson <alexander.olofsson@liu.se>
 
-call ale#Set('puppet_puppet_executable', 'puppet')
-call ale#Set('puppet_puppet_options', '')
-
 function! ale_linters#puppet#puppet#Handle(buffer, lines) abort
     " Matches patterns like the following:
     " Error: Could not parse for environment production: Syntax error at ':' at /root/puppetcode/modules/nginx/manifests/init.pp:43:12
     " Error: Could not parse for environment production: Syntax error at '='; expected '}' at /root/puppetcode/modules/pancakes/manifests/init.pp:5"
     " Error: Could not parse for environment production: Syntax error at 'parameter1' (file: /tmp/modules/mariadb/manifests/slave.pp, line: 4, column: 5)
+
     let l:pattern = '^Error: .*: \(.\+\) \((file:\|at\) .\+\.pp\(, line: \|:\)\(\d\+\)\(, column: \|:\)\=\(\d*\)'
     let l:output = []
 
@@ -22,16 +20,10 @@ function! ale_linters#puppet#puppet#Handle(buffer, lines) abort
     return l:output
 endfunction
 
-function! ale_linters#puppet#puppet#GetCommand(buffer) abort
-    return '%e parser validate --color=false '
-    \    . ale#Pad(ale#Var(a:buffer, 'puppet_puppet_options'))
-    \    . ' %t'
-endfunction
-
 call ale#linter#Define('puppet', {
 \   'name': 'puppet',
-\   'executable_callback': ale#VarFunc('puppet_puppet_executable'),
+\   'executable': 'puppet',
 \   'output_stream': 'stderr',
-\   'command_callback': 'ale_linters#puppet#puppet#GetCommand',
+\   'command': 'puppet parser validate --color=false %t',
 \   'callback': 'ale_linters#puppet#puppet#Handle',
 \})

ale_linters/python/flake8.vim

@@ -5,18 +5,12 @@ call ale#Set('python_flake8_executable', 'flake8')
 call ale#Set('python_flake8_options', '')
 call ale#Set('python_flake8_use_global', get(g:, 'ale_use_global_executables', 0))
 call ale#Set('python_flake8_change_directory', 1)
-call ale#Set('python_flake8_auto_pipenv', 0)
 
 function! s:UsingModule(buffer) abort
     return ale#Var(a:buffer, 'python_flake8_options') =~# ' *-m flake8'
 endfunction
 
 function! ale_linters#python#flake8#GetExecutable(buffer) abort
-    if (ale#Var(a:buffer, 'python_auto_pipenv') || ale#Var(a:buffer, 'python_flake8_auto_pipenv'))
-    \ && ale#python#PipenvPresent(a:buffer)
-        return 'pipenv'
-    endif
-
     if !s:UsingModule(a:buffer)
         return ale#python#FindExecutable(a:buffer, 'python_flake8', ['flake8'])
     endif
@@ -110,7 +104,6 @@ function! ale_linters#python#flake8#Handle(buffer, lines) abort
         let l:item = {
         \   'lnum': l:match[1] + 0,
         \   'col': l:match[2] + 0,
-        \   'vcol': 1,
         \   'text': l:match[4],
         \   'code': l:code,
         \   'type': 'W',

ale_linters/python/mypy.vim

@@ -5,14 +5,8 @@ call ale#Set('python_mypy_executable', 'mypy')
 call ale#Set('python_mypy_ignore_invalid_syntax', 0)
 call ale#Set('python_mypy_options', '')
 call ale#Set('python_mypy_use_global', get(g:, 'ale_use_global_executables', 0))
-call ale#Set('python_mypy_auto_pipenv', 0)
 
 function! ale_linters#python#mypy#GetExecutable(buffer) abort
-    if (ale#Var(a:buffer, 'python_auto_pipenv') || ale#Var(a:buffer, 'python_mypy_auto_pipenv'))
-    \ && ale#python#PipenvPresent(a:buffer)
-        return 'pipenv'
-    endif
-
     return ale#python#FindExecutable(a:buffer, 'python_mypy', ['mypy'])
 endfunction
 

ale_linters/python/prospector.vim

@@ -1,8 +1,6 @@
 " Author: chocoelho <carlospecter@gmail.com>
 " Description: prospector linter python files
 
-call ale#Set('python_prospector_auto_pipenv', 0)
-
 let g:ale_python_prospector_executable =
 \   get(g:, 'ale_python_prospector_executable', 'prospector')
 
@@ -12,11 +10,6 @@ let g:ale_python_prospector_options =
 let g:ale_python_prospector_use_global = get(g:, 'ale_python_prospector_use_global', get(g:, 'ale_use_global_executables', 0))
 
 function! ale_linters#python#prospector#GetExecutable(buffer) abort
-    if (ale#Var(a:buffer, 'python_auto_pipenv') || ale#Var(a:buffer, 'python_prospector_auto_pipenv'))
-    \ && ale#python#PipenvPresent(a:buffer)
-        return 'pipenv'
-    endif
-
     return ale#python#FindExecutable(a:buffer, 'python_prospector', ['prospector'])
 endfunction
 

ale_linters/python/pycodestyle.vim

@@ -4,14 +4,8 @@
 call ale#Set('python_pycodestyle_executable', 'pycodestyle')
 call ale#Set('python_pycodestyle_options', '')
 call ale#Set('python_pycodestyle_use_global', get(g:, 'ale_use_global_executables', 0))
-call ale#Set('python_pycodestyle_auto_pipenv', 0)
 
 function! ale_linters#python#pycodestyle#GetExecutable(buffer) abort
-    if (ale#Var(a:buffer, 'python_auto_pipenv') || ale#Var(a:buffer, 'python_pycodestyle_auto_pipenv'))
-    \ && ale#python#PipenvPresent(a:buffer)
-        return 'pipenv'
-    endif
-
     return ale#python#FindExecutable(a:buffer, 'python_pycodestyle', ['pycodestyle'])
 endfunction
 

ale_linters/python/pyflakes.vim

@@ -3,14 +3,8 @@
 
 call ale#Set('python_pyflakes_executable', 'pyflakes')
 call ale#Set('python_pyflakes_use_global', get(g:, 'ale_use_global_executables', 0))
-call ale#Set('python_pyflakes_auto_pipenv', 0)
 
 function! ale_linters#python#pyflakes#GetExecutable(buffer) abort
-    if (ale#Var(a:buffer, 'python_auto_pipenv') || ale#Var(a:buffer, 'python_pyflakes_auto_pipenv'))
-    \ && ale#python#PipenvPresent(a:buffer)
-        return 'pipenv'
-    endif
-
     return ale#python#FindExecutable(a:buffer, 'python_pyflakes', ['pyflakes'])
 endfunction
 

ale_linters/python/pylint.vim

@@ -5,14 +5,8 @@ call ale#Set('python_pylint_executable', 'pylint')
 call ale#Set('python_pylint_options', '')
 call ale#Set('python_pylint_use_global', get(g:, 'ale_use_global_executables', 0))
 call ale#Set('python_pylint_change_directory', 1)
-call ale#Set('python_pylint_auto_pipenv', 0)
 
 function! ale_linters#python#pylint#GetExecutable(buffer) abort
-    if (ale#Var(a:buffer, 'python_auto_pipenv') || ale#Var(a:buffer, 'python_pylint_auto_pipenv'))
-    \ && ale#python#PipenvPresent(a:buffer)
-        return 'pipenv'
-    endif
-
     return ale#python#FindExecutable(a:buffer, 'python_pylint', ['pylint'])
 endfunction
 

ale_linters/python/pyls.vim

@@ -3,14 +3,8 @@
 
 call ale#Set('python_pyls_executable', 'pyls')
 call ale#Set('python_pyls_use_global', get(g:, 'ale_use_global_executables', 0))
-call ale#Set('python_pyls_auto_pipenv', 0)
 
 function! ale_linters#python#pyls#GetExecutable(buffer) abort
-    if (ale#Var(a:buffer, 'python_auto_pipenv') || ale#Var(a:buffer, 'python_pyls_auto_pipenv'))
-    \ && ale#python#PipenvPresent(a:buffer)
-        return 'pipenv'
-    endif
-
     return ale#python#FindExecutable(a:buffer, 'python_pyls', ['pyls'])
 endfunction
 

ale_linters/python/pyre.vim

@@ -3,14 +3,8 @@
 
 call ale#Set('python_pyre_executable', 'pyre')
 call ale#Set('python_pyre_use_global', get(g:, 'ale_use_global_executables', 0))
-call ale#Set('python_pyre_auto_pipenv', 0)
 
 function! ale_linters#python#pyre#GetExecutable(buffer) abort
-    if (ale#Var(a:buffer, 'python_auto_pipenv') || ale#Var(a:buffer, 'python_pyre_auto_pipenv'))
-    \ && ale#python#PipenvPresent(a:buffer)
-        return 'pipenv'
-    endif
-
     return ale#python#FindExecutable(a:buffer, 'python_pyre', ['pyre'])
 endfunction
 

ale_linters/rst/rstcheck.vim

@@ -8,7 +8,6 @@ function! ale_linters#rst#rstcheck#Handle(buffer, lines) abort
     let l:pattern = '\v^(.+):(\d*): \(([a-zA-Z]*)/\d*\) (.+)$'
     let l:dir = expand('#' . a:buffer . ':p:h')
     let l:output = []
-
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
         call add(l:output, {
         \   'filename': ale#path#GetAbsPath(l:dir, l:match[1]),

ale_linters/ruby/brakeman.vim

@@ -1,9 +1,8 @@
 " Author: Eddie Lebow https://github.com/elebow
 " Description: Brakeman, a static analyzer for Rails security
 
-call ale#Set('ruby_brakeman_options', '')
+let g:ale_ruby_brakeman_options =
-call ale#Set('ruby_brakeman_executable', 'brakeman')
+\   get(g:, 'ale_ruby_brakeman_options', '')
-call ale#Set('ruby_brakeman_options', '')
 
 function! ale_linters#ruby#brakeman#Handle(buffer, lines) abort
     let l:output = []
@@ -34,17 +33,14 @@ function! ale_linters#ruby#brakeman#GetCommand(buffer) abort
         return ''
     endif
 
-    let l:executable = ale#Var(a:buffer, 'ruby_brakeman_executable')
+    return 'brakeman -f json -q '
-
-    return ale#handlers#ruby#EscapeExecutable(l:executable, 'brakeman')
-    \    . ' -f json -q '
     \    . ale#Var(a:buffer, 'ruby_brakeman_options')
     \    . ' -p ' . ale#Escape(l:rails_root)
 endfunction
 
 call ale#linter#Define('ruby', {
 \    'name': 'brakeman',
-\    'executable_callback': ale#VarFunc('ruby_brakeman_executable'),
+\    'executable': 'brakeman',
 \    'command_callback': 'ale_linters#ruby#brakeman#GetCommand',
 \    'callback': 'ale_linters#ruby#brakeman#Handle',
 \    'lint_file': 1,

ale_linters/ruby/rails_best_practices.vim

@@ -22,18 +22,26 @@ function! ale_linters#ruby#rails_best_practices#Handle(buffer, lines) abort
     return l:output
 endfunction
 
+function! ale_linters#ruby#rails_best_practices#GetExecutable(buffer) abort
+    return ale#Var(a:buffer, 'ruby_rails_best_practices_executable')
+endfunction
+
 function! ale_linters#ruby#rails_best_practices#GetCommand(buffer) abort
+    let l:executable = ale_linters#ruby#rails_best_practices#GetExecutable(a:buffer)
+    let l:exec_args = l:executable =~? 'bundle$'
+    \   ? ' exec rails_best_practices'
+    \   : ''
+
     let l:rails_root = ale#ruby#FindRailsRoot(a:buffer)
 
     if l:rails_root is? ''
         return ''
     endif
 
-    let l:executable = ale#Var(a:buffer, 'ruby_rails_best_practices_executable')
     let l:output_file = ale#Has('win32') ? '%t ' : '/dev/stdout '
     let l:cat_file = ale#Has('win32') ? '; type %t' : ''
 
-    return ale#handlers#ruby#EscapeExecutable(l:executable, 'rails_best_practices')
+    return ale#Escape(l:executable) . l:exec_args
     \    . ' --silent -f json --output-file ' . l:output_file
     \    . ale#Var(a:buffer, 'ruby_rails_best_practices_options')
     \    . ale#Escape(l:rails_root)
@@ -42,7 +50,7 @@ endfunction
 
 call ale#linter#Define('ruby', {
 \    'name': 'rails_best_practices',
-\    'executable_callback': ale#VarFunc('ruby_rails_best_practices_executable'),
+\    'executable_callback': 'ale_linters#ruby#rails_best_practices#GetExecutable',
 \    'command_callback': 'ale_linters#ruby#rails_best_practices#GetCommand',
 \    'callback': 'ale_linters#ruby#rails_best_practices#Handle',
 \    'lint_file': 1,

ale_linters/ruby/reek.vim

@@ -3,8 +3,6 @@
 
 call ale#Set('ruby_reek_show_context', 0)
 call ale#Set('ruby_reek_show_wiki_link', 0)
-call ale#Set('ruby_reek_options', '')
-call ale#Set('ruby_reek_executable', 'reek')
 
 function! ale_linters#ruby#reek#VersionCheck(buffer) abort
     " If we have previously stored the version number in a cache, then
@@ -14,23 +12,18 @@ function! ale_linters#ruby#reek#VersionCheck(buffer) abort
         return ''
     endif
 
-    let l:executable = ale#Var(a:buffer, 'ruby_reek_executable')
+    return 'reek --version'
-
-    return ale#handlers#ruby#EscapeExecutable(l:executable, 'reek')
-    \   . ' --version'
 endfunction
 
 function! ale_linters#ruby#reek#GetCommand(buffer, version_output) abort
     let l:version = ale#semver#GetVersion('reek', a:version_output)
-    let l:executable = ale#Var(a:buffer, 'ruby_reek_executable')
 
     " Tell reek what the filename is if the version of reek is new enough.
     let l:display_name_args = ale#semver#GTE(l:version, [5, 0, 0])
     \   ? ' --stdin-filename %s'
     \   : ''
 
-    return ale#handlers#ruby#EscapeExecutable(l:executable, 'reek')
+    return 'reek -f json --no-progress --no-color'
-    \   . ' -f json --no-progress --no-color --force-exclusion'
     \   . l:display_name_args
 endfunction
 
@@ -69,7 +62,7 @@ endfunction
 
 call ale#linter#Define('ruby', {
 \   'name': 'reek',
-\   'executable_callback': ale#VarFunc('ruby_reek_executable'),
+\   'executable': 'reek',
 \   'command_chain': [
 \       {'callback': 'ale_linters#ruby#reek#VersionCheck'},
 \       {'callback': 'ale_linters#ruby#reek#GetCommand'},

ale_linters/ruby/rubocop.vim

@@ -1,13 +1,13 @@
 " Author: ynonp - https://github.com/ynonp, Eddie Lebow https://github.com/elebow
 " Description: RuboCop, a code style analyzer for Ruby files
 
-call ale#Set('ruby_rubocop_executable', 'rubocop')
-call ale#Set('ruby_rubocop_options', '')
-
 function! ale_linters#ruby#rubocop#GetCommand(buffer) abort
-    let l:executable = ale#Var(a:buffer, 'ruby_rubocop_executable')
+    let l:executable = ale#handlers#rubocop#GetExecutable(a:buffer)
+    let l:exec_args = l:executable =~? 'bundle$'
+    \   ? ' exec rubocop'
+    \   : ''
 
-    return ale#handlers#ruby#EscapeExecutable(l:executable, 'rubocop')
+    return ale#Escape(l:executable) . l:exec_args
     \   . ' --format json --force-exclusion '
     \   . ale#Var(a:buffer, 'ruby_rubocop_options')
     \   . ' --stdin ' . ale#Escape(expand('#' . a:buffer . ':p'))
@@ -55,7 +55,7 @@ endfunction
 
 call ale#linter#Define('ruby', {
 \   'name': 'rubocop',
-\   'executable_callback': ale#VarFunc('ruby_rubocop_executable'),
+\   'executable_callback': 'ale#handlers#rubocop#GetExecutable',
 \   'command_callback': 'ale_linters#ruby#rubocop#GetCommand',
 \   'callback': 'ale_linters#ruby#rubocop#Handle',
 \})

ale_linters/ruby/solargraph.vim

@@ -1,22 +0,0 @@
-" Author: Horacio Sanson - https://github.com/hsanson
-" Description: Solargraph Language Server https://solargraph.org/
-"
-" Author: Devon Meunier <devon.meunier@gmail.com>
-" Description: updated to use stdio
-
-call ale#Set('ruby_solargraph_executable', 'solargraph')
-call ale#Set('ruby_solargraph_options', {})
-
-function! ale_linters#ruby#solargraph#GetCommand(buffer) abort
-    return '%e' . ale#Pad('stdio')
-endfunction
-
-call ale#linter#Define('ruby', {
-\   'name': 'solargraph',
-\   'lsp': 'stdio',
-\   'language': 'ruby',
-\   'executable_callback': ale#VarFunc('ruby_solargraph_executable'),
-\   'command_callback': 'ale_linters#ruby#solargraph#GetCommand',
-\   'project_root_callback': 'ale#ruby#FindProjectRoot',
-\   'initialization_options_callback': ale#VarFunc('ruby_solargraph_options'),
-\})

ale_linters/rust/cargo.vim

@@ -9,8 +9,6 @@ call ale#Set('rust_cargo_check_tests', 0)
 call ale#Set('rust_cargo_avoid_whole_workspace', 1)
 call ale#Set('rust_cargo_default_feature_behavior', 'default')
 call ale#Set('rust_cargo_include_features', '')
-call ale#Set('rust_cargo_use_clippy', 0)
-call ale#Set('rust_cargo_clippy_options', '')
 
 function! ale_linters#rust#cargo#GetCargoExecutable(bufnr) abort
     if ale#path#FindNearestFile(a:bufnr, 'Cargo.toml') isnot# ''
@@ -44,7 +42,6 @@ function! ale_linters#rust#cargo#GetCommand(buffer, version_output) abort
     \   && ale#semver#GTE(l:version, [0, 22, 0])
 
     let l:include_features = ale#Var(a:buffer, 'rust_cargo_include_features')
-
     if !empty(l:include_features)
         let l:include_features = ' --features ' . ale#Escape(l:include_features)
     endif
@@ -62,7 +59,6 @@ function! ale_linters#rust#cargo#GetCommand(buffer, version_output) abort
     endif
 
     let l:default_feature_behavior = ale#Var(a:buffer, 'rust_cargo_default_feature_behavior')
-
     if l:default_feature_behavior is# 'all'
         let l:include_features = ''
         let l:default_feature = ' --all-features'
@@ -72,23 +68,14 @@ function! ale_linters#rust#cargo#GetCommand(buffer, version_output) abort
         let l:default_feature = ''
     endif
 
-    let l:subcommand = l:use_check ? 'check' : 'build'
-    let l:clippy_options = ''
-
-    if ale#Var(a:buffer, 'rust_cargo_use_clippy')
-        let l:subcommand = 'clippy'
-        let l:clippy_options = ' ' . ale#Var(a:buffer, 'rust_cargo_clippy_options')
-    endif
-
     return l:nearest_cargo_prefix . 'cargo '
-    \   . l:subcommand
+    \   . (l:use_check ? 'check' : 'build')
     \   . (l:use_all_targets ? ' --all-targets' : '')
     \   . (l:use_examples ? ' --examples' : '')
     \   . (l:use_tests ? ' --tests' : '')
     \   . ' --frozen --message-format=json -q'
     \   . l:default_feature
     \   . l:include_features
-    \   . l:clippy_options
 endfunction
 
 call ale#linter#Define('rust', {

ale_linters/rust/rustc.vim

@@ -1,7 +1,7 @@
 " Author: Daniel Schemala <istjanichtzufassen@gmail.com>
 " Description: rustc for rust files
 
-call ale#Set('rust_rustc_options', '-Z no-codegen')
+call ale#Set('rust_rustc_options', '-Z no-trans')
 
 function! ale_linters#rust#rustc#RustcCommand(buffer) abort
     " Try to guess the library search path. If the project is managed by cargo,

ale_linters/scala/sbtserver.vim

@@ -1,31 +0,0 @@
-" Author: ophirr33 <coghlan.ty@gmail.com>
-" Description: TCP lsp client for sbt Server
-
-call ale#Set('scala_sbtserver_address', '127.0.0.1:4273')
-call ale#Set('scala_sbtserver_project_root', '')
-
-function! ale_linters#scala#sbtserver#GetProjectRoot(buffer) abort
-    let l:project_root = ale#Var(a:buffer, 'scala_sbtserver_project_root')
-
-    if l:project_root is? ''
-        let l:project_root = ale#path#FindNearestFile(a:buffer, 'build.sbt')
-
-        return !empty(l:project_root) ? fnamemodify(l:project_root, ':h') : ''
-    endif
-
-    return l:project_root
-endfunction
-
-function! ale_linters#scala#sbtserver#GetAddress(buffer) abort
-    let l:address = ale#Var(a:buffer, 'scala_sbtserver_address')
-
-    return l:address
-endfunction
-
-call ale#linter#Define('scala', {
-\   'name': 'sbtserver',
-\   'lsp': 'socket',
-\   'address_callback': 'ale_linters#scala#sbtserver#GetAddress',
-\   'language': 'scala',
-\   'project_root_callback': 'ale_linters#scala#sbtserver#GetProjectRoot',
-\})

ale_linters/scala/scalac.vim

@@ -9,7 +9,7 @@ endfunction
 call ale#linter#Define('scala', {
 \   'name': 'scalac',
 \   'executable_callback': {buf -> s:IsSbt(buf) ? '' : 'scalac'},
-\   'command': '%e -Ystop-before:jvm %t',
+\   'command': '%e -Ystop-after:parser %t',
 \   'callback': 'ale#handlers#scala#HandleScalacLintFormat',
 \   'output_stream': 'stderr',
 \})

ale_linters/scala/scalastyle.vim

@@ -53,14 +53,12 @@ function! ale_linters#scala#scalastyle#GetCommand(buffer) abort
     \   'scalastyle_config.xml',
     \   'scalastyle-config.xml'
     \]
-
     for l:config in l:potential_configs
         let l:scalastyle_config = ale#path#ResolveLocalPath(
         \   a:buffer,
         \   l:config,
         \   ''
         \)
-
         if !empty(l:scalastyle_config)
             break
         endif

ale_linters/scss/stylelint.vim

@@ -1,19 +1,13 @@
 " Author: diartyz <diartyz@gmail.com>
 
 call ale#Set('scss_stylelint_executable', 'stylelint')
-call ale#Set('scss_stylelint_options', '')
 call ale#Set('scss_stylelint_use_global', get(g:, 'ale_use_global_executables', 0))
 
-function! ale_linters#scss#stylelint#GetCommand(buffer) abort
-    return '%e ' . ale#Pad(ale#Var(a:buffer, 'scss_stylelint_options'))
-    \   . ' --stdin-filename %s'
-endfunction
-
 call ale#linter#Define('scss', {
 \   'name': 'stylelint',
 \   'executable_callback': ale#node#FindExecutableFunc('scss_stylelint', [
 \       'node_modules/.bin/stylelint',
 \   ]),
-\   'command_callback': 'ale_linters#scss#stylelint#GetCommand',
+\   'command': '%e --stdin-filename %s',
 \   'callback': 'ale#handlers#css#HandleStyleLintFormat',
 \})

ale_linters/sml/smlnj_cm.vim

@@ -3,7 +3,6 @@
 
 function! ale_linters#sml#smlnj_cm#GetCommand(buffer) abort
     let l:cmfile = ale#handlers#sml#GetCmFile(a:buffer)
-
     return 'sml -m ' . l:cmfile . ' < /dev/null'
 endfunction
 

ale_linters/solidity/solhint.vim

@@ -4,6 +4,7 @@
 function! ale_linters#solidity#solhint#Handle(buffer, lines) abort
     " Matches patterns like the following:
     " /path/to/file/file.sol: line 1, col 10, Error - 'addOne' is defined but never used. (no-unused-vars)
+
     let l:pattern = '\v^[^:]+: line (\d+), col (\d+), (Error|Warning) - (.*) \((.*)\)$'
     let l:output = []
 

ale_linters/tcl/nagelfar.vim

@@ -15,6 +15,7 @@ function! ale_linters#tcl#nagelfar#Handle(buffer, lines) abort
     " Line   5: W Found constant "bepa" which is also a variable.
     " Line  13: E Wrong number of arguments (3) to "set"
     " Line  93: N Close brace not aligned with line 90 (4 0)
+
     let l:pattern = '^Line\s\+\([0-9]\+\): \([NEW]\) \(.*\)$'
     let l:output = []
 

ale_linters/terraform/tflint.vim

@@ -40,7 +40,6 @@ function! ale_linters#terraform#tflint#GetCommand(buffer) abort
     endif
 
     let l:opts = ale#Var(a:buffer, 'terraform_tflint_options')
-
     if !empty(l:opts)
         let l:cmd .= ' ' . l:opts
     endif

ale_linters/tex/lacheck.vim

@@ -8,6 +8,7 @@ function! ale_linters#tex#lacheck#Handle(buffer, lines) abort
     "
     " "book.tex", line 37: possible unwanted space at "{"
     " "book.tex", line 38: missing `\ ' after "etc."
+
     let l:pattern = '^".\+", line \(\d\+\): \(.\+\)$'
     let l:output = []
 

ale_linters/thrift/thrift.vim

@@ -2,7 +2,7 @@
 
 call ale#Set('thrift_thrift_executable', 'thrift')
 call ale#Set('thrift_thrift_generators', ['cpp'])
-call ale#Set('thrift_thrift_includes', ['.'])
+call ale#Set('thrift_thrift_includes', [])
 call ale#Set('thrift_thrift_options', '-strict')
 
 function! ale_linters#thrift#thrift#GetCommand(buffer) abort
@@ -42,14 +42,12 @@ function! ale_linters#thrift#thrift#Handle(buffer, lines) abort
         let l:line = a:lines[l:index]
 
         let l:match = matchlist(l:line, l:pattern)
-
         if empty(l:match)
             let l:index += 1
             continue
         endif
 
         let l:severity = l:match[1]
-
         if l:severity is# 'WARNING'
             let l:type = 'W'
         else
@@ -59,7 +57,6 @@ function! ale_linters#thrift#thrift#Handle(buffer, lines) abort
         " If our text looks like "(last token was ';')", the *next* line
         " should contain a more descriptive error message.
         let l:text = l:match[4]
-
         if l:text =~# '\(last token was .*\)'
             let l:index += 1
             let l:text = get(a:lines, l:index, 'Unknown error ' . l:text)

ale_linters/vim/ale_custom_linting_rules.vim

@@ -25,13 +25,7 @@ endfunction
 function! ale_linters#vim#ale_custom_linting_rules#GetCommand(buffer) abort
     let l:dir = s:GetALEProjectDir(a:buffer)
 
-    let l:temp_dir = ale#engine#CreateDirectory(a:buffer)
+    return ale#path#CdString(l:dir) . '%e .'
-    let l:temp_file = l:temp_dir . '/example.vim'
-
-    let l:lines = getbufline(a:buffer, 1, '$')
-    call ale#util#Writefile(a:buffer, l:lines, l:temp_file)
-
-    return ale#path#CdString(l:dir) . '%e ' . ale#Escape(l:temp_dir)
 endfunction
 
 function! ale_linters#vim#ale_custom_linting_rules#Handle(buffer, lines) abort
@@ -40,17 +34,15 @@ function! ale_linters#vim#ale_custom_linting_rules#Handle(buffer, lines) abort
     let l:pattern = '\v^([a-zA-Z]?:?[^:]+):(\d+) (.+)$'
 
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
-        " Ignore trailing whitespace errors if we've turned them off.
+        let l:filename = ale#path#GetAbsPath(l:dir, l:match[1])
-        if !ale#Var(a:buffer, 'warn_about_trailing_whitespace')
-        \&& l:match[3] is# 'Trailing whitespace'
-            continue
-        endif
 
-        call add(l:output, {
+        if bufnr(l:filename) is a:buffer
-        \   'lnum': l:match[2],
+            call add(l:output, {
-        \   'text': l:match[3],
+            \   'lnum': l:match[2],
-        \   'type': 'W',
+            \   'text': l:match[3],
-        \})
+            \   'type': 'W',
+            \})
+        endif
     endfor
 
     return l:output
@@ -61,5 +53,5 @@ call ale#linter#Define('vim', {
 \   'executable_callback': 'ale_linters#vim#ale_custom_linting_rules#GetExecutable',
 \   'command_callback': 'ale_linters#vim#ale_custom_linting_rules#GetCommand',
 \   'callback': 'ale_linters#vim#ale_custom_linting_rules#Handle',
-\   'read_buffer': 0,
+\   'lint_file': 1,
 \})

ale_linters/xml/xmllint.vim

@@ -25,9 +25,9 @@ function! ale_linters#xml#xmllint#Handle(buffer, lines) abort
     let l:output = []
 
     for l:line in a:lines
+
         " Parse error/warning lines
         let l:match_message = matchlist(l:line, l:pattern_message)
-
         if !empty(l:match_message)
           let l:line = l:match_message[2] + 0
           let l:type = l:match_message[4] =~? 'warning' ? 'W' : 'E'
@@ -44,13 +44,13 @@ function! ale_linters#xml#xmllint#Handle(buffer, lines) abort
 
         " Parse column position
         let l:match_column_token = matchlist(l:line, l:pattern_column_token)
-
         if !empty(l:output) && !empty(l:match_column_token)
           let l:previous = l:output[len(l:output) - 1]
           let l:previous['col'] = len(l:match_column_token[0])
 
           continue
         endif
+
     endfor
 
     return l:output

ale_linters/yang/yang_lsp.vim

@@ -2,7 +2,6 @@ call ale#Set('yang_lsp_executable', 'yang-language-server')
 
 function! ale_linters#yang#yang_lsp#GetProjectRoot(buffer) abort
     let l:project_root = ale#path#FindNearestFile(a:buffer, 'yang.settings')
-
     return !empty(l:project_root) ? fnamemodify(l:project_root, ':h') : ''
 endfunction