VimPlug/django-stubs
1
0
Fork 0
mirror of https://github.com/davidhalter/django-stubs.git synced 2025-12-11 06:21:58 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix extra_context argument type in admin views (#816)

Browse Source 
The `extra_context` argument to `ModelAdmin.changeform_view`,
`add_view`, `change_view`, `changelist_view`, `delete_view`, and
`history_view` is used to pass extra context variables to a template, so
all of these arguments should have type `Optional[Dict[str, Any]]`.
Instead, these are currently typed as `Optional[Dict[str, bool]]`,
`Optional[Dict[str, str]]`, or `None`.
This commit is contained in:
rolandcrosby-check
2022-01-13 15:03:03 -05:00
committed by GitHub
parent 3c1e9e3884
commit 1da693ebff
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
django-stubs/contrib/admin/options.pyi
View File

@@ -249,21 +249,27 @@ class ModelAdmin(BaseModelAdmin[_ModelT]):
request: HttpRequest, request: HttpRequest,
object_id: Optional[str] = ..., object_id: Optional[str] = ...,
form_url: str = ..., form_url: str = ...,
extra_context: Optional[Dict[str, bool]] = ..., extra_context: Optional[Dict[str, Any]] = ...,
) -> Any: ... ) -> Any: ...
def autocomplete_view(self, request: HttpRequest) -> JsonResponse: ... def autocomplete_view(self, request: HttpRequest) -> JsonResponse: ...
def add_view(self, request: HttpRequest, form_url: str = ..., extra_context: None = ...) -> HttpResponse: ... def add_view(
self, request: HttpRequest, form_url: str = ..., extra_context: Optional[Dict[str, Any]] = ...
) -> HttpResponse: ...
def change_view( def change_view(
self, request: HttpRequest, object_id: str, form_url: str = ..., extra_context: Optional[Dict[str, bool]] = ... self, request: HttpRequest, object_id: str, form_url: str = ..., extra_context: Optional[Dict[str, Any]] = ...
) -> HttpResponse: ... ) -> HttpResponse: ...
def changelist_view( def changelist_view(
self, request: HttpRequest, extra_context: Optional[Dict[str, str]] = ... self, request: HttpRequest, extra_context: Optional[Dict[str, Any]] = ...
) -> TemplateResponse: ... ) -> TemplateResponse: ...
def get_deleted_objects( def get_deleted_objects(
self, objs: QuerySet, request: HttpRequest self, objs: QuerySet, request: HttpRequest
) -> Tuple[List[Any], Dict[Any, Any], Set[Any], List[Any]]: ... ) -> Tuple[List[Any], Dict[Any, Any], Set[Any], List[Any]]: ...
def delete_view(self, request: HttpRequest, object_id: str, extra_context: None = ...) -> Any: ... def delete_view(
def history_view(self, request: HttpRequest, object_id: str, extra_context: None = ...) -> HttpResponse: ... self, request: HttpRequest, object_id: str, extra_context: Optional[Dict[str, Any]] = ...
) -> Any: ...
def history_view(
self, request: HttpRequest, object_id: str, extra_context: Optional[Dict[str, Any]] = ...
) -> HttpResponse: ...
class InlineModelAdmin(BaseModelAdmin[_ModelT]): class InlineModelAdmin(BaseModelAdmin[_ModelT]):
model: Type[_ModelT] = ... model: Type[_ModelT] = ...