VimPlug/django-stubs
1
0
Fork 0
mirror of https://github.com/davidhalter/django-stubs.git synced 2025-12-07 12:44:29 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

make ignore_missing_model_attributes behaviour optional (#66)

Browse Source 
make "ignore_missing_model_attributes" behaviour opt-in
This commit is contained in:
Maxim Kurnikov
2019-04-12 17:22:18 +03:00
committed by GitHub
parent fd06816cbb
commit 5dd6eccdb5
7 changed files with 64 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
mypy_django_plugin/config.py
View File

@@ -8,6 +8,7 @@ from dataclasses import dataclass
class Config:
django_settings_module: Optional[str] = None
ignore_missing_settings: bool = False
ignore_missing_model_attributes: bool = False
@classmethod
def from_config_file(cls, fpath: str) -> 'Config':
@@ -22,5 +23,9 @@ class Config:
django_settings = django_settings.strip()
return Config(django_settings_module=django_settings,
ignore_missing_settings=bool(ini_config.get('mypy_django_plugin', 'ignore_missing_settings',
fallback=False)))
ignore_missing_settings=bool(ini_config.get('mypy_django_plugin',
'ignore_missing_settings',
fallback=False)),
ignore_missing_model_attributes=bool(ini_config.get('mypy_django_plugin',
'ignore_missing_model_attributes',
fallback=False)))

7
mypy_django_plugin/main.py
View File

@@ -31,7 +31,7 @@ from mypy_django_plugin.transformers.settings import (
)
def transform_model_class(ctx: ClassDefContext) -> None:
def transform_model_class(ctx: ClassDefContext, ignore_missing_model_attributes: bool) -> None:
try:
sym = ctx.api.lookup_fully_qualified(helpers.MODEL_CLASS_FULLNAME)
except KeyError:
@@ -41,7 +41,7 @@ def transform_model_class(ctx: ClassDefContext) -> None:
if sym is not None and isinstance(sym.node, TypeInfo):
helpers.get_django_metadata(sym.node)['model_bases'][ctx.cls.fullname] = 1
process_model_class(ctx)
process_model_class(ctx, ignore_missing_model_attributes)
def transform_manager_class(ctx: ClassDefContext) -> None:
@@ -248,7 +248,8 @@ class DjangoPlugin(Plugin):
def get_base_class_hook(self, fullname: str
) -> Optional[Callable[[ClassDefContext], None]]:
if fullname in self._get_current_model_bases():
return transform_model_class
return partial(transform_model_class,
ignore_missing_model_attributes=self.config.ignore_missing_model_attributes)
if fullname in self._get_current_manager_bases():
return transform_manager_class

6
mypy_django_plugin/transformers/models.py
View File

@@ -286,7 +286,7 @@ def add_get_set_attr_fallback_to_any(ctx: ClassDefContext):
add_method(ctx, '__setattr__', [name_arg, value_arg], any)
def process_model_class(ctx: ClassDefContext) -> None:
def process_model_class(ctx: ClassDefContext, ignore_unknown_attributes: bool) -> None:
initializers = [
InjectAnyAsBaseForNestedMeta,
AddDefaultObjectsManager,
@@ -299,5 +299,5 @@ def process_model_class(ctx: ClassDefContext) -> None:
add_dummy_init_method(ctx)
# allow unspecified attributes for now
add_get_set_attr_fallback_to_any(ctx)
if ignore_unknown_attributes:
add_get_set_attr_fallback_to_any(ctx)