VimPlug/django-stubs
1
0
Fork 0
mirror of https://github.com/davidhalter/django-stubs.git synced 2025-12-08 04:54:48 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

make ignore_missing_model_attributes behaviour optional (#66)

Browse Source 
make "ignore_missing_model_attributes" behaviour opt-in
This commit is contained in:
Maxim Kurnikov
2019-04-12 17:22:18 +03:00
committed by GitHub
parent fd06816cbb
commit 5dd6eccdb5
7 changed files with 64 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test-data/typecheck/fields.test
View File

@@ -75,7 +75,7 @@ reveal_type(User().my_pk) # E: Revealed type is 'builtins.int*'
reveal_type(User().id)
[out]
main:7: error: Revealed type is 'Any'
main:7: error: Default primary key 'id' is not defined
main:7: error: "User" has no attribute "id"
[/CASE]
[CASE test_meta_nested_class_allows_subclassing_in_multiple_inheritance]

44
test-data/typecheck/model.test
View File

@@ -1,28 +1,60 @@
[CASE test_model_subtype_relationship_and_getting_and_setting_attributes]
[CASE test_typechecking_for_model_subclasses]
from django.db import models
class A(models.Model):
pass
class B(models.Model):
b_attr = 1
pass
class C(A):
pass
def service(a: A) -> int:
pass
b_instance = B()
service(b_instance) # E: Argument 1 to "service" has incompatible type "B"; expected "A"
a_instance = A()
c_instance = C()
service(a_instance)
service(c_instance)
[/CASE]
[CASE fail_if_no_such_attribute_on_model]
from django.db import models
class B(models.Model):
b_attr = 1
pass
b_instance = B()
reveal_type(b_instance.b_attr) # E: Revealed type is 'builtins.int'
reveal_type(b_instance.non_existent_attribute)
b_instance.non_existent_attribute = 2
[out]
main:10: error: Revealed type is 'Any'
main:10: error: "B" has no attribute "non_existent_attribute"
main:11: error: "B" has no attribute "non_existent_attribute"
[/CASE]
[CASE ignore_missing_attributes_if_setting_is_passed]
from django.db import models
class B(models.Model):
pass
b_instance = B()
reveal_type(b_instance.non_existent_attribute) # E: Revealed type is 'Any'
b_instance.non_existent_attribute = 2
service(b_instance) # E: Argument 1 to "service" has incompatible type "B"; expected "A"
[env MYPY_DJANGO_CONFIG=${MYPY_CWD}/mypy_django.ini]
c_instance = C()
service(c_instance)
[file mypy_django.ini]
[[mypy_django_plugin]
ignore_missing_model_attributes = True
[/CASE]

10
test-data/typecheck/related_fields.test
View File

@@ -109,8 +109,10 @@ class View(models.Model):
app = models.ForeignKey(to=App, related_name='views', on_delete=models.CASCADE)
reveal_type(View().app.views) # E: Revealed type is 'django.db.models.manager.RelatedManager[main.View]'
reveal_type(View().app.unknown) # E: Revealed type is 'Any'
reveal_type(View().app.unknown)
[out]
main:7: error: Revealed type is 'Any'
main:7: error: "App" has no attribute "unknown"
[file myapp/__init__.py]
[file myapp/models.py]
@@ -307,6 +309,10 @@ book = Book()
reveal_type(book.publisher) # E: Revealed type is 'main.Publisher*'
publisher = Publisher()
reveal_type(publisher.books) # E: Revealed type is 'Any'
reveal_type(publisher.books)
reveal_type(publisher.books2) # E: Revealed type is 'django.db.models.manager.RelatedManager[main.Book]'
[out]
main:16: error: Revealed type is 'Any'
main:16: error: "Publisher" has no attribute "books"; maybe "books2"?
[/CASE]