Recover after #909 (#925)

* Fix stubs related to `(Async)RequestFactory` and `(Async)Client`

* Revert incorrect removal.

* Allow set as `unique_together`, use shared type alias.

* Revert `Q.__init__` to use only `*args, **kwargs` to remove false-positive with `Q(**{...})`

* Add abstract methods to `HttpResponseBase` to create common interface.

* Remove monkey-patched attributes from `HttpResponseBase` subclasses.

* Add QueryDict mutability checks (+ plugin support)

* Fix lint

* Return back GenericForeignKey to `Options.get_fields`

* Minor fixup

* Make plugin code typecheck with `--warn-unreachable`, minor performance increase.

* Better types for `{unique, index}_together` and Options.

* Fix odd type of `URLResolver.urlconf_name` which isn't a str actually.

* Better types for field migration operations.

* Revert form.files to `MultiValueDict[str, UploadedFile]`

* Compatibility fix (#916)

* Do not assume that `Annotated` is always related to django-stubs (fixes #893)

* Restrict `FormView.get_form` return type to `_FormT` (class type argument). Now it is resolved to `form_class` argument if present, but also errors if it is not subclass of _FormT

* Fix CI (make test runnable on 3.8)

* Fix CI (make test runnable on 3.8 _again_)

mypy_django_plugin/transformers/fields.py

@@ -1,4 +1,4 @@
-from typing import Optional, Tuple, Union, cast
+from typing import TYPE_CHECKING, Optional, Tuple, Union, cast
 
 from django.db.models.fields import AutoField, Field
 from django.db.models.fields.related import RelatedField
@@ -12,10 +12,13 @@ from mypy.types import TypeOfAny, UnionType
 from mypy_django_plugin.django.context import DjangoContext
 from mypy_django_plugin.lib import fullnames, helpers
 
+if TYPE_CHECKING:
+    from django.contrib.contenttypes.fields import GenericForeignKey
+
 
 def _get_current_field_from_assignment(
     ctx: FunctionContext, django_context: DjangoContext
-) -> Optional[Union[Field, ForeignObjectRel]]:
+) -> Optional[Union[Field, ForeignObjectRel, "GenericForeignKey"]]:
     outer_model_info = helpers.get_typechecker_api(ctx).scope.active_class()
     if outer_model_info is None or not helpers.is_model_subclass_info(outer_model_info, django_context):
         return None

mypy_django_plugin/transformers/managers.py

@@ -263,8 +263,6 @@ def create_new_manager_class_from_from_queryset_method(ctx: DynamicClassDefConte
                     semanal_api.defer()
                 return None
             original_return_type = method_type.ret_type
-            if original_return_type is None:
-                continue
 
             # Skip any method that doesn't return _QS
             original_return_type = get_proper_type(original_return_type)

mypy_django_plugin/transformers/models.py

@@ -15,7 +15,7 @@ from mypy.types import TypedDictType, TypeOfAny
 
 from mypy_django_plugin.django.context import DjangoContext
 from mypy_django_plugin.lib import fullnames, helpers
-from mypy_django_plugin.lib.fullnames import ANNOTATIONS_FULLNAME, ANY_ATTR_ALLOWED_CLASS_FULLNAME
+from mypy_django_plugin.lib.fullnames import ANNOTATIONS_FULLNAME, ANY_ATTR_ALLOWED_CLASS_FULLNAME, MODEL_CLASS_FULLNAME
 from mypy_django_plugin.lib.helpers import add_new_class_for_module
 from mypy_django_plugin.transformers import fields
 from mypy_django_plugin.transformers.fields import get_field_descriptor_types
@@ -475,8 +475,8 @@ def handle_annotated_type(ctx: AnalyzeTypeContext, django_context: DjangoContext
     type_arg = ctx.api.analyze_type(args[0])
     api = cast(SemanticAnalyzer, ctx.api.api)  # type: ignore
 
-    if not isinstance(type_arg, Instance):
-        return ctx.api.analyze_type(ctx.type)
+    if not isinstance(type_arg, Instance) or not type_arg.type.has_base(MODEL_CLASS_FULLNAME):
+        return type_arg
 
     fields_dict = None
     if len(args) > 1:

mypy_django_plugin/transformers/request.py

@@ -1,7 +1,7 @@
-from mypy.plugin import AttributeContext
+from mypy.plugin import AttributeContext, MethodContext
 from mypy.types import Instance
 from mypy.types import Type as MypyType
-from mypy.types import UnionType
+from mypy.types import UninhabitedType, UnionType
 
 from mypy_django_plugin.django.context import DjangoContext
 from mypy_django_plugin.lib import helpers
@@ -35,3 +35,10 @@ def set_auth_user_model_as_type_for_request_user(ctx: AttributeContext, django_c
         return ctx.default_attr_type
 
     return UnionType([Instance(user_info, []), Instance(anonymous_user_info, [])])
+
+
+def check_querydict_is_mutable(ctx: MethodContext, django_context: DjangoContext) -> MypyType:
+    ret_type = ctx.default_return_type
+    if isinstance(ret_type, UninhabitedType):
+        ctx.api.fail("This QueryDict is immutable.", ctx.context)
+    return ret_type