VimPlug/django-stubs
1
0 Fork 0
mirror of https://github.com/davidhalter/django-stubs.git synced 2026-11-06 04:13:03 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: remove SuccessMessageMixin.form_valid violation of Liskov substitution principle (#84)

Browse Source
This commit is contained in:
Anton Agestam authored and Maxim Kurnikov committed 2019-06-02 13:23:37 +03:00
1 parent 0e60b70ae4
commit 629ba954b4
1 file changed
+2 -2
Download Patch File Download Diff File Expand all files Collapse all files
django-stubs/contrib/messages/views.pyi
+2 -2
View File
@@ -1,9 +1,9 @@
from typing import Any, Dict, Optional from typing import Any, Dict, Optional
from django.forms.forms import Form from django.forms.forms import BaseForm
from django.http.response import HttpResponseRedirect from django.http.response import HttpResponseRedirect
class SuccessMessageMixin: class SuccessMessageMixin:
success_message: str = ... success_message: str = ...
def form_valid(self, form: Form) -> HttpResponseRedirect: ... def form_valid(self, form: BaseForm) -> HttpResponseRedirect: ...
def get_success_message(self, cleaned_data: Dict[str, str]) -> str: ... def get_success_message(self, cleaned_data: Dict[str, str]) -> str: ...