VimPlug/django-stubs
1
0
Fork 0
mirror of https://github.com/davidhalter/django-stubs.git synced 2025-12-09 05:24:53 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

remove 'need type annotation for setting' error message

Browse Source
This commit is contained in:
Maxim Kurnikov
2018-12-06 19:38:27 +03:00
parent d9a9e5208e
commit 94ddb8c864
2 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
mypy_django_plugin/plugins/settings.py
View File

@@ -50,15 +50,16 @@ def add_settings_to_django_conf_object(ctx: ClassDefContext,
if copied is None:
continue
ctx.cls.info.names[name] = copied
else:
context = Context()
module, node_name = sym.node.fullname().rsplit('.', 1)
module_file = api.modules.get(module)
if module_file is None:
return None
context.set_line(sym.node)
api.msg.report(f"Need type annotation for '{sym.node.name()}'", context,
severity='error', file=module_file.path)
# else:
# TODO: figure out suggestion to add type annotation
# context = Context()
# module, node_name = sym.node.fullname().rsplit('.', 1)
# module_file = api.modules.get(module)
# if module_file is None:
# return None
# context.set_line(sym.node)
# api.msg.report(f"Need type annotation for '{sym.node.name()}'", context,
# severity='error', file=module_file.path)
ctx.cls.info.fallback_to_any = True

2
test-data/typecheck/settings.test
View File

@@ -40,8 +40,6 @@ reveal_type(settings.REGISTRY) # E: Revealed type is 'Union[main.Class, None]'
reveal_type(settings.LIST) # E: Revealed type is 'Any'
reveal_type(settings.BASE_LIST) # E: Revealed type is 'Any'
[out]
mysettings:4: error: Need type annotation for 'LIST'
base:6: error: Need type annotation for 'BASE_LIST'
[env DJANGO_SETTINGS_MODULE=mysettings]
[file mysettings.py]