VimPlug/django-stubs
1
0
Fork 0
mirror of https://github.com/davidhalter/django-stubs.git synced 2025-12-13 15:31:55 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Disable fallback to runtime types for Django settings (#1163)

Browse Source 
This fallback to value.__class__ seems to be doing more harm than
good; see #312 and #1162.  Replace it with a clear error message that
suggests a way to fix the problem rather than incompletely papering
over it.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
This commit is contained in:
Anders Kaseorg
2022-09-24 00:57:45 -07:00
committed by GitHub
parent 02999f3e86
commit 9bd8aed1e1
2 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mypy_django_plugin/django/context.py
View File

@@ -62,7 +62,7 @@ def initialize_django(settings_module: str) -> Tuple["Apps", "LazySettings"]:
apps.get_swappable_settings_name.cache_clear() # type: ignore apps.get_swappable_settings_name.cache_clear() # type: ignore
if not settings.configured: if not settings.configured:
settings._setup() settings._setup() # type: ignore
apps.populate(settings.INSTALLED_APPS) apps.populate(settings.INSTALLED_APPS)

22
mypy_django_plugin/transformers/settings.py
View File

@@ -23,9 +23,6 @@ def get_user_model_hook(ctx: FunctionContext, django_context: DjangoContext) ->
def get_type_of_settings_attribute(ctx: AttributeContext, django_context: DjangoContext) -> MypyType: def get_type_of_settings_attribute(ctx: AttributeContext, django_context: DjangoContext) -> MypyType:
assert isinstance(ctx.context, MemberExpr) assert isinstance(ctx.context, MemberExpr)
setting_name = ctx.context.name setting_name = ctx.context.name
if not hasattr(django_context.settings, setting_name):
ctx.api.fail(f"'Settings' object has no attribute {setting_name!r}", ctx.context)
return ctx.default_attr_type
typechecker_api = helpers.get_typechecker_api(ctx) typechecker_api = helpers.get_typechecker_api(ctx)
@@ -35,15 +32,14 @@ def get_type_of_settings_attribute(ctx: AttributeContext, django_context: Django
for module in [settings_module, global_settings_module]: for module in [settings_module, global_settings_module]:
if module is not None: if module is not None:
sym = module.names.get(setting_name) sym = module.names.get(setting_name)
if sym is not None and sym.type is not None: if sym is not None:
if sym.type is None:
ctx.api.fail(
f"Import cycle from Django settings module prevents type inference for {setting_name!r}",
ctx.context,
)
return ctx.default_attr_type
return sym.type return sym.type
# if by any reason it isn't present there, get type from django settings ctx.api.fail(f"'Settings' object has no attribute {setting_name!r}", ctx.context)
value = getattr(django_context.settings, setting_name) return ctx.default_attr_type
value_fullname = helpers.get_class_fullname(value.__class__)
value_info = helpers.lookup_fully_qualified_typeinfo(typechecker_api, value_fullname)
if value_info is None:
return ctx.default_attr_type
return Instance(value_info, [])