VimPlug/django-stubs
1
0
Fork 0
mirror of https://github.com/davidhalter/django-stubs.git synced 2026-05-22 08:20:21 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add URLPattern options to django.url.conf since they were missing. (#583)

Browse Source 
* Add URLPattern options to django.url.conf since they were missing.

* Fix some wording in the contribution guide & fix a reference to Django version 3.0, which has since been replaced by 3.1 as new stable version.

* My bad - I was misreading the type hints a bit here. Fix tests.

* We need to specify the List[Union[URLResolver, URLPattern]] upfront, since those don't accept List[URLResolver] as argument.

* Add test to ensure that path() accepts a mix of URLPatterns & URLResolvers.

Co-authored-by: LanDinh <coding+sourcetree@khaleesi.ninja>
This commit is contained in:
LanDinh
2021-04-10 17:01:40 +02:00
committed by GitHub
parent 9beb5327de
commit ceb08f1804
5 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CONTRIBUTING.md
+2 -2
View File
@@ -70,11 +70,11 @@ To execute the unit tests, simply run:
pytest
```
We also test the stubs against the Django's own test suite. This is done in CI but you can also do this locally.
We also test the stubs against Django's own test suite. This is done in CI but you can also do this locally.
To execute the script run:
```bash
python ./scripts/typecheck_tests.py --django_version 3.0
python ./scripts/typecheck_tests.py --django_version 3.1
```