From d3dca5b408f89fff02f4c157496e777d945b19f1 Mon Sep 17 00:00:00 2001 From: Peter Law Date: Mon, 23 Sep 2019 15:38:34 +0100 Subject: [PATCH] related_name is Optional[str] (#176) In the current Django (2.1, 2.2), the `related_name` parameter to `OneToOneField` and `ForeignKey` classes (much like `ManyToManyField` and the base `ForeignObject` classes) is `Optional[str]`. While it's true that most authors won't pass `None` here, derived field types will want to be able to do so. --- django-stubs/db/models/fields/related.pyi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/django-stubs/db/models/fields/related.pyi b/django-stubs/db/models/fields/related.pyi index aab35fb..3aa70da 100644 --- a/django-stubs/db/models/fields/related.pyi +++ b/django-stubs/db/models/fields/related.pyi @@ -114,7 +114,7 @@ class ForeignKey(ForeignObject[_ST, _GT]): to: Union[Type[Model], str], on_delete: Callable[..., None], to_field: Optional[str] = ..., - related_name: str = ..., + related_name: Optional[str] = ..., related_query_name: Optional[str] = ..., limit_choices_to: Optional[Union[Dict[str, Any], Callable[[], Any], Q]] = ..., parent_link: bool = ..., @@ -159,7 +159,7 @@ class OneToOneField(RelatedField[_ST, _GT]): to: Union[Type[Model], str], on_delete: Any, to_field: Optional[str] = ..., - related_name: str = ..., + related_name: Optional[str] = ..., related_query_name: Optional[str] = ..., limit_choices_to: Optional[Union[Dict[str, Any], Callable[[], Any], Q]] = ..., parent_link: bool = ...,