VimPlug/django-stubs
1
0
Fork 0
mirror of https://github.com/davidhalter/django-stubs.git synced 2025-12-11 14:31:56 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Do not force django.contrib.* dependencies (#535)

Browse Source 
* Do not force django.contrib.* dependencies

Fixes #428.
Fixes #534.

* Add one more test with contenttypes installed, but auth not
This commit is contained in:
Lysandros Nikolaou
2020-11-24 13:38:03 +02:00
committed by GitHub
parent f3e0872d6e
commit d9c851abce
3 changed files with 25 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
mypy_django_plugin/django/context.py
View File

@@ -148,7 +148,9 @@ class DjangoContext:
raise ValueError("No primary key defined")
def get_expected_types(self, api: TypeChecker, model_cls: Type[Model], *, method: str) -> Dict[str, MypyType]:
from django.contrib.contenttypes.fields import GenericForeignKey
contenttypes_in_apps = self.apps_registry.is_installed("django.contrib.contenttypes")
if contenttypes_in_apps:
from django.contrib.contenttypes.fields import GenericForeignKey
expected_types = {}
# add pk if not abstract=True
@@ -192,7 +194,7 @@ class DjangoContext:
expected_types[field_name] = model_set_type
elif isinstance(field, GenericForeignKey):
elif contenttypes_in_apps and isinstance(field, GenericForeignKey):
# it's generic, so cannot set specific model
field_name = field.name
gfk_info = helpers.lookup_class_typeinfo(api, field.__class__)