Large update (#909)

* Make module declaration precise.

* Make settings match real file.

* Replace `include` with import.

* Make types more specific.

* Replace `WSGIRequest` with `HttpRequest` where possible.

* Replace all `OrderedDict` occurrences with plain `Dict` (it is not used in Django 3.2 and later)

* Add fake datastructures for convenience: _PropertyDescriptor and _ListOrTuple now can live here. Added _IndexableCollection (often useful as alias for 'sequence or queryset')

* Actualize other datastructures.

* Rework MultiValueDict to reflect the fact that some methods can return empty list instead of value.

* Deprecate SafeText in favor of SafeString.

* Minor improvements to utils

* Disallow using str in TimeFormat and DateFormat, drop removed fmt `B`

* Do not let classproperty expect classmethod, make return value covariant.

* Sync with real file.

* Improve types for timezone.

* Sync deprecated, new and removed features in translation utils.

* Drop removed files, sync huge deprecations.

* Fix incompatible decorators (properties, contextmanagers)

* Rework pagination.

* Sync validators with real code. Add _ValidatorCallable for any external use (field validation etc.)

* Add shared type definitions (for fields of both forms and models). Actualize model fields. Mark keyword-only args explicitly in stubs (where code uses **kwargs). Disallow bytes for verbose_name.

* Make all checks return Sequence[CheckMessage] or subclass to be covariant.

* Add bidirectional references between backend.base and other files. Replace some Any's with specific types.

* Actualize db.migrations: remove removed methods, replace "None" annotations in wrong places, improve some wrong annotations.

* Actualize db.utils to match real file.

* Replace FileResponse and TemplateResponse with HttpResponse(Base) where needed: at least HttpResponseNotModified/HttpResponseRedirect can be returned instead of it, so annotation was wrong.

* Replace Any in forms where possible. Actualize class bases and method arguments.

* Improve typing of serializers.

* Actualize views, rename variable bound to Model to _M for consistency.

* Make types of file-related code consistent. Disallow using bytes as path, because many methods expect str-only paths. Make File inherit from IO[AnyStr] instead of IO[Any]: it makes impossible to instantiate file of union type, but allows precise types for some methods.

* Minor improvements: stop using None as annotation in wrong places, replace obvious Any's with precise types, actualize methods (missing/renamed/signature changed).

* Allow less specific containers, replace Any's with specific types.

* Improve types for requests and responses.

* Use AbstractBaseUser instead of User in auth.

* Use broader type for permission_required

* Use wider container types. Add 'type: ignore' to avoid issues with mypy.stubtest.

* Disallow using backend class as argument (it is passed to import_string).

* Add required methods to PasseordValidator.

* Allow using Path instance as argument.

* Actualize methods.

* Add 'type: ignore' to avoid issues with mypy.stubtest.

* Replace Any's with specific types and BaseForm with ModelForm.

* Actualize contrib.postgres

* Remove render_to_response, add 'get_absolute_url' to corresponding protocol.

* Actualize signers.

* Use precise types for handlers. Disallow str as stream type for LimitedStream.

* Exact types for ValidationError

* Replace wrong used Union with Sequence.

* Actualize static handlers.

* More specific types for admin. Fixes #874.

* Improve types and replace 'Tags' with str (it isn't Enum, so annotation was wrong).

* Replace Any with specific types, actualize signatures.

* Add async variants of handlers and clients. Use fake class to distinguish between request types in RequestFactory and AsyncRequestFactory.

* Fix signature, minor improvements.

* Actualize signatures and class names, replace Any with more specific types.

* Fix signature.

* Add some missing methods to Collector

* Combinable rarely returns Self type: almost always it's CombinedExpression.

* No Random in source anymore.

* Drop removed SimpleCol.

* Replace _OutputField with Field: nothing in docs about strings.

* Introduce reusable types, add missing methods. Remove strange types (probably created by stubgen). Remove RawQuery from Compiler: it obviously doesn't work with RawQuery.

* Use literal constants.

* Actualize base classes.

* Callable is not accepted by get_field.

* Add precise types.

* Use property and broader containers where possible. Add missing methods.

* Actualize indexes.

* More specific types for signals.

* Fix signatures, drop missing methods.

* Actualize window functions to match source.

* Actualize text functions, add missing methods, use type aliases for consistency.

* Add missing property decorators, methods and attributes. Use type aliases. Remove absent YearComparisonLookup and any SafeText references (they aren't related to lookups at all).

* Use bound TypeVar, mark all BuiltinLookup descendants as generic explicitly. Remove strange Union from Lookup.__init__

* Apply type alias, fix base class and argument name.

* Actualize BaseExpression methods.

* Fix imports.

* Add missing class and fix incompatible bases.

* Use same types in __init__ and attribute.

* OrderBy accepts F or Expression.

* Non-expressions are converted to Values.

* Add missing attributes.

* Add missing methods, fix 'None' argument type.

* Define properties where possible, remove 'None' argument annotations, remove inadequate type in make_immutable_fields_list.

* Remove absent QueryWrapper. Replace some Any with precise types.

* Fix wrong types and actualize signatures. Deny ManagerDescriptor.__get__ on model instances.

* Use more specific types.

* Arity can be None in subclasses.

* Reformat with black

* Make DeletionMixin generic.

* Fix wrong type variable in _RequestFactory.

* Fix variable name in signature.

* Disallow returning None from Form.clean()

* Allow again returning None from Form.clean

* Drop some unused imports.

* Add tests for MultiValueDict.

* Add tests for utils.timezone.

* Fix #834.

* Add more files to import_all test

* Allow None for `context_object_name`

* Fix CI

* Fix test to work on python 3.8

tests/typecheck/contrib/admin/test_options.yml

@@ -3,7 +3,7 @@
 -   case: test_full_admin
     main: |
       from django.contrib import admin
-      from django.forms import Form, Textarea
+      from django.forms import Form, ModelForm, Textarea
       from django.db import models
       from django.core.paginator import Paginator
       from django.contrib.admin.sites import AdminSite
@@ -30,7 +30,7 @@
               (None, {"fields": ["a", "b"]}),
               ("group", {"fields": ("c",), "classes": ("a",), "description": "foo"}),
           ]
-          form = Form
+          form = ModelForm
           filter_vertical = ("fields",)
           filter_horizontal = ("plenty", "of", "fields")
           radio_fields = {
@@ -48,7 +48,7 @@
           # ModelAdmin
           list_display = ("pk",)
           list_display_links = ("str",)
-          list_filter = ("str", admin.SimpleListFilter, ("str", admin.SimpleListFilter))
+          list_filter = ("str", admin.SimpleListFilter, ("str", admin.FieldListFilter))
           list_select_related = True
           list_per_page = 1
           list_max_show_all = 2

tests/typecheck/contrib/staticfiles/test_finders.yml

@@ -2,38 +2,38 @@
     main: |
       from django.contrib.staticfiles import finders
 
-      reveal_type(finders.find("filepath"))  # N: Revealed type is "Union[builtins.str, builtins.bytes, os.PathLike[Any], None]"
+      reveal_type(finders.find("filepath"))  # N: Revealed type is "Union[builtins.str, os.PathLike[builtins.str], None]"
 
       for finder in finders.get_finders():
-          reveal_type(finder.find("filepath"))  # N: Revealed type is "Union[builtins.str, builtins.bytes, os.PathLike[Any], None]"
+          reveal_type(finder.find("filepath"))  # N: Revealed type is "Union[builtins.str, os.PathLike[builtins.str], None]"
 
-      reveal_type(finders.FileSystemFinder().find("filepath")) # N: Revealed type is "Union[builtins.str, builtins.bytes, os.PathLike[Any], None]"
-      reveal_type(finders.AppDirectoriesFinder().find("filepath")) # N: Revealed type is "Union[builtins.str, builtins.bytes, os.PathLike[Any], None]"
-      reveal_type(finders.DefaultStorageFinder().find("filepath")) # N: Revealed type is "Union[builtins.str, builtins.bytes, os.PathLike[Any], None]"
+      reveal_type(finders.FileSystemFinder().find("filepath")) # N: Revealed type is "Union[builtins.str, os.PathLike[builtins.str], None]"
+      reveal_type(finders.AppDirectoriesFinder().find("filepath")) # N: Revealed type is "Union[builtins.str, os.PathLike[builtins.str], None]"
+      reveal_type(finders.DefaultStorageFinder().find("filepath")) # N: Revealed type is "Union[builtins.str, os.PathLike[builtins.str], None]"
 
 -   case: test_find_all
     main: |
       from django.contrib.staticfiles import finders
 
-      reveal_type(finders.find("filepath", all=True))  # N: Revealed type is "builtins.list[Union[builtins.str, builtins.bytes, os.PathLike[Any]]]"
+      reveal_type(finders.find("filepath", all=True))  # N: Revealed type is "builtins.list[Union[builtins.str, os.PathLike[builtins.str]]]"
 
       for finder in finders.get_finders():
-          reveal_type(finder.find("filepath", all=True))  # N: Revealed type is "builtins.list[Union[builtins.str, builtins.bytes, os.PathLike[Any]]]"
+          reveal_type(finder.find("filepath", all=True))  # N: Revealed type is "builtins.list[Union[builtins.str, os.PathLike[builtins.str]]]"
 
-      reveal_type(finders.FileSystemFinder().find("filepath", all=True)) # N: Revealed type is "builtins.list[Union[builtins.str, builtins.bytes, os.PathLike[Any]]]"
-      reveal_type(finders.AppDirectoriesFinder().find("filepath", all=True)) # N: Revealed type is "builtins.list[Union[builtins.str, builtins.bytes, os.PathLike[Any]]]"
-      reveal_type(finders.DefaultStorageFinder().find("filepath", all=True)) # N: Revealed type is "builtins.list[Union[builtins.str, builtins.bytes, os.PathLike[Any]]]"
+      reveal_type(finders.FileSystemFinder().find("filepath", all=True)) # N: Revealed type is "builtins.list[Union[builtins.str, os.PathLike[builtins.str]]]"
+      reveal_type(finders.AppDirectoriesFinder().find("filepath", all=True)) # N: Revealed type is "builtins.list[Union[builtins.str, os.PathLike[builtins.str]]]"
+      reveal_type(finders.DefaultStorageFinder().find("filepath", all=True)) # N: Revealed type is "builtins.list[Union[builtins.str, os.PathLike[builtins.str]]]"
 
 -   case: test_file_system_finder  # test methods *only* on FileSystemFinder
     main: |
       from django.contrib.staticfiles.finders import FileSystemFinder
 
       finder = FileSystemFinder()
-      reveal_type(finder.find_location(".", "filepath"))  # N: Revealed type is "Union[builtins.str, builtins.bytes, os.PathLike[Any], None]"
+      reveal_type(finder.find_location(".", "filepath"))  # N: Revealed type is "Union[builtins.str, os.PathLike[builtins.str], None]"
 
 -   case: test_app_directories_finder  # test methods *only* on AppDirectoriesFinder
     main: |
       from django.contrib.staticfiles.finders import AppDirectoriesFinder
 
       finder = AppDirectoriesFinder()
-      reveal_type(finder.find_in_app("app", "filepath"))  # N: Revealed type is "Union[builtins.str, builtins.bytes, os.PathLike[Any], None]"
+      reveal_type(finder.find_in_app("app", "filepath"))  # N: Revealed type is "Union[builtins.str, os.PathLike[builtins.str], None]"