Sebastiaan Zeeff a1d3aec3a2 Fix return type for django.shortcuts.render (#1140) ...

The return type for calling `shorcuts.render` without providing a value
for the `permanent` kwarg was `HttpResponsePermanentRedirect`, while it
should be `HttpResponseRedirect`.

The reason is that the first two overloads of the type stub overlap for
the case of using the default argument. While `mypy` does issue an error
for this, it was previously ignored with the `# type: ignore` comment.

As the first overload annotates the function as having the return type
`HttpResponsePermanentRedirect`, this would make mypy assume that the
return type is that instead of `HttpResponseRedirect`.

Since calling `django.shortcuts.redirect` without providing an argument
for `permanent` is the same as calling it with a `Literal[False]`, as
the default value is a `False`, we can improve the stub by only
specifying the option to use the default argument (`= ...`) in the
second overload. This also removes the overlap in stub definitions,
meaning that the `# type: ignore` can now be removed.

This commit fixes #1138.

2022-08-30 15:05:39 +03:00

..

typecheck

Fix return type for django.shortcuts.render (#1140)

2022-08-30 15:05:39 +03:00

test_error_handling.py

Notify when Manager.from_queryset happens inside model class body (#824)

2022-01-21 19:46:56 +03:00