VimPlug/fzf.vim
1
0
Fork 0
mirror of https://github.com/junegunn/fzf.vim.git synced 2025-12-07 13:14:30 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't mutate args to fzf#vim#files() (#1282)

Browse Source 
As the code was written before, if we do this:

   let s:opts = {
   \ 'window': {'width': 0.6, 'height': 0.6, 'relative': v:false},
   \ 'options': ['--layout=reverse', '--info=inline'],
   \}

   call fzf#vim#files('', s:opts, 0)

...then s:opts will get mutated by the call to fzf#vim#files, cloberring
any persistent configuration established this way.

Making a defensive copy solves the problem.
This commit is contained in:
Stefan Kanev
2021-05-09 07:45:33 +03:00
committed by GitHub
parent 75c7e87de1
commit a88311b222
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
autoload/fzf/vim.vim
View File

@@ -302,6 +302,7 @@ function! s:fzf(name, opts, extra)
throw 'invalid number of arguments' throw 'invalid number of arguments'
endif endif
let extra = copy(extra)
let eopts = has_key(extra, 'options') ? remove(extra, 'options') : '' let eopts = has_key(extra, 'options') ? remove(extra, 'options') : ''
let merged = extend(copy(a:opts), extra) let merged = extend(copy(a:opts), extra)
call s:merge_opts(merged, eopts) call s:merge_opts(merged, eopts)