From e653628458947af9b326cf4cf371fb9a58e3851f Mon Sep 17 00:00:00 2001 From: Junegunn Choi Date: Sun, 1 Feb 2026 11:08:11 +0900 Subject: [PATCH] lint: test code --- test/test_core.rb | 16 ++++++++-------- test/test_filter.rb | 2 +- test/test_shell_integration.rb | 8 ++++---- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/test/test_core.rb b/test/test_core.rb index 2802c933..db629ced 100644 --- a/test/test_core.rb +++ b/test/test_core.rb @@ -1191,7 +1191,7 @@ class TestCore < TestInteractive end def test_freeze_left_keep_right - tmux.send_keys %[seq 10000 | #{FZF} --read0 --delimiter "\n" --freeze-left 3 --keep-right --ellipsis XX --no-multi-line --bind space:toggle-multi-line], :Enter + tmux.send_keys %(seq 10000 | #{FZF} --read0 --delimiter "\n" --freeze-left 3 --keep-right --ellipsis XX --no-multi-line --bind space:toggle-multi-line), :Enter tmux.until { |lines| assert_match(/^> 1␊2␊3XX.*10000␊$/, lines[-3]) } tmux.send_keys '5' tmux.until { |lines| assert_match(/^> 1␊2␊3␊4␊5␊.*XX$/, lines[-3]) } @@ -1202,21 +1202,21 @@ class TestCore < TestInteractive end def test_freeze_left_and_right - tmux.send_keys %[seq 10000 | tr "\n" ' ' | #{FZF} --freeze-left 3 --freeze-right 3 --ellipsis XX], :Enter + tmux.send_keys %(seq 10000 | tr "\n" ' ' | #{FZF} --freeze-left 3 --freeze-right 3 --ellipsis XX), :Enter tmux.until { |lines| assert_match(/XX9998 9999 10000$/, lines[-3]) } tmux.send_keys "'1000" - tmux.until { |lines| assert_match(/^> 1 2 3XX.*XX9998 9999 10000$/,lines[-3]) } + tmux.until { |lines| assert_match(/^> 1 2 3XX.*XX9998 9999 10000$/, lines[-3]) } end def test_freeze_left_and_right_delimiter - tmux.send_keys %[seq 10000 | tr "\n" ' ' | sed 's/ / , /g' | #{FZF} --freeze-left 3 --freeze-right 3 --ellipsis XX --delimiter ' , '], :Enter + tmux.send_keys %(seq 10000 | tr "\n" ' ' | sed 's/ / , /g' | #{FZF} --freeze-left 3 --freeze-right 3 --ellipsis XX --delimiter ' , '), :Enter tmux.until { |lines| assert_match(/XX, 9999 , 10000 ,$/, lines[-3]) } tmux.send_keys "'1000" - tmux.until { |lines| assert_match(/^> 1 , 2 , 3 ,XX.*XX, 9999 , 10000 ,$/,lines[-3]) } + tmux.until { |lines| assert_match(/^> 1 , 2 , 3 ,XX.*XX, 9999 , 10000 ,$/, lines[-3]) } end def test_freeze_right_exceed_range - tmux.send_keys %[seq 10000 | tr "\n" ' ' | #{FZF} --freeze-right 100000 --ellipsis XX], :Enter + tmux.send_keys %(seq 10000 | tr "\n" ' ' | #{FZF} --freeze-right 100000 --ellipsis XX), :Enter ['', "'1000"].each do |query| tmux.send_keys query tmux.until { |lines| assert lines.any_include?("> #{query}".strip) } @@ -1228,7 +1228,7 @@ class TestCore < TestInteractive end def test_freeze_right_exceed_range_with_freeze_left - tmux.send_keys %[seq 10000 | tr "\n" ' ' | #{FZF} --freeze-left 3 --freeze-right 100000 --ellipsis XX], :Enter + tmux.send_keys %(seq 10000 | tr "\n" ' ' | #{FZF} --freeze-left 3 --freeze-right 100000 --ellipsis XX), :Enter tmux.until do |lines| assert_match(/^> 1 2 3XX.*9998 9999 10000$/, lines[-3]) assert_equal(1, lines[-3].scan('XX').size) @@ -1241,7 +1241,7 @@ class TestCore < TestInteractive tmux.send_keys(*Array.new(6) { :a }) tmux.until do |lines| assert_match(/> 777g+$/, lines[-3]) - assert_equal 1, lines.count { |l| l.end_with?('g') } + assert_equal(1, lines.count { |l| l.end_with?('g') }) end end diff --git a/test/test_filter.rb b/test/test_filter.rb index b96ed142..e9ca0302 100644 --- a/test/test_filter.rb +++ b/test/test_filter.rb @@ -320,7 +320,7 @@ class TestFilter < TestBase # Multiple field selection writelines(['ID001:John:Developer', 'ID002:Jane:Manager', 'ID003:Bob:Designer']) assert_equal 'ID001', `#{FZF} -d: --with-nth 2 --accept-nth 1 -f John < #{tempname}`.chomp - assert_equal "ID002:Manager", `#{FZF} -d: --with-nth 2 --accept-nth 1,3 -f Jane < #{tempname}`.chomp + assert_equal 'ID002:Manager', `#{FZF} -d: --with-nth 2 --accept-nth 1,3 -f Jane < #{tempname}`.chomp # Test with different delimiters writelines(['emp001 Alice Engineering', 'emp002 Bob Marketing']) diff --git a/test/test_shell_integration.rb b/test/test_shell_integration.rb index 3589f3ac..fa379fcb 100644 --- a/test/test_shell_integration.rb +++ b/test/test_shell_integration.rb @@ -465,11 +465,11 @@ class TestZsh < TestBase # Helper function to run test with Perl and again with Awk def self.test_perl_and_awk(name, &block) - define_method("test_#{name}") do + define_method(:"test_#{name}") do instance_eval(&block) end - define_method("test_#{name}_awk") do + define_method(:"test_#{name}_awk") do tmux.send_keys "unset 'commands[perl]'", :Enter tmux.prepare # Verify perl is actually unset (0 = not found) @@ -559,7 +559,7 @@ class TestZsh < TestBase tmux.prepare # Verify fc shows foreign command with asterisk tmux.send_keys 'fc -rl -1', :Enter - tmux.until { |lines| assert lines.any? { |l| l.match?(/^\s*\d+\* fzf_cmd_foreign/) } } + tmux.until { |lines| assert(lines.any? { |l| l.match?(/^\s*\d+\* fzf_cmd_foreign/) }) } tmux.prepare # Test ctrl-r correctly extracts the foreign command tmux.send_keys 'C-r' @@ -570,7 +570,7 @@ class TestZsh < TestBase tmux.until { |lines| assert_includes lines[-2], '(2)' } tmux.send_keys :Enter tmux.until do |lines| - assert_equal ['fzf_cmd_foreign', 'fzf_cmd_local'], lines[-2..] + assert_equal %w[fzf_cmd_foreign fzf_cmd_local], lines[-2..] end ensure FileUtils.rm_f(histfile)