VimPlug/jedi-fork
1
0
Fork 0
forked from VimPlug/jedi
Code Pull Requests Activity

added additional security to get_definition tests

Browse Source
This commit is contained in:
David Halter
2012-09-06 00:08:41 +02:00
parent eb79942a81
commit 730dfdc012
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/run.py
View File

@@ -55,6 +55,7 @@ def run_definition_test(correct, source, line_nr, index, line, correct_start,
return 1 return 1
else: else:
should_be = set() should_be = set()
number = 0
for index in re.finditer('(?: +|$)', correct): for index in re.finditer('(?: +|$)', correct):
if correct == ' ': if correct == ' ':
continue continue
@@ -62,6 +63,7 @@ def run_definition_test(correct, source, line_nr, index, line, correct_start,
start = index.start() start = index.start()
if print_debug: if print_debug:
functions.set_debug_function(None) functions.set_debug_function(None)
number += 1
try: try:
should_be |= defs(line_nr - 1, start + correct_start) should_be |= defs(line_nr - 1, start + correct_start)
except Exception: except Exception:
@@ -72,6 +74,10 @@ def run_definition_test(correct, source, line_nr, index, line, correct_start,
functions.set_debug_function(debug.print_to_stdout) functions.set_debug_function(debug.print_to_stdout)
# because the objects have different ids, `repr` it, then compare it. # because the objects have different ids, `repr` it, then compare it.
should_str = set(r.desc_with_module for r in should_be) should_str = set(r.desc_with_module for r in should_be)
if len(should_str) < number:
print('Solution @%s not right, too few test results: %s' \
% (line_nr - 1, should_str))
return 1
is_str = set(r.desc_with_module for r in result) is_str = set(r.desc_with_module for r in result)
if is_str != should_str: if is_str != should_str:
print('Solution @%s not right, received %s, wanted %s' \ print('Solution @%s not right, received %s, wanted %s' \