VimPlug/jedi-fork
1
0
Fork 0
forked from VimPlug/jedi
Code Pull Requests Activity

Fix getattr completions on very weird cases, fixes #1573

Browse Source
This commit is contained in:
Dave Halter
2020-05-10 11:37:58 +02:00
parent 12090ce74b
commit bf4ec2282f
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
jedi/api/completion.py
View File

@@ -586,6 +586,9 @@ def _complete_getattr(user_context, instance):
) )
for func in functions: for func in functions:
tree_node = func.tree_node tree_node = func.tree_node
if tree_node.type != 'funcdef':
continue
for return_stmt in tree_node.iter_return_stmts(): for return_stmt in tree_node.iter_return_stmts():
# Basically until the next comment we just try to find out if a # Basically until the next comment we just try to find out if a
# return statement looks exactly like `return getattr(x, name)`. # return statement looks exactly like `return getattr(x, name)`.

7
test/completion/classes.py
View File

@@ -419,6 +419,13 @@ GetattrArray().something[0]
#? [] #? []
GetattrArray().something GetattrArray().something
class WeirdGetattr:
class __getattr__():
pass
#? []
WeirdGetattr().something
# ----------------- # -----------------
# private vars # private vars