From 290e2151df6b2e9937f208097d0548c7d30be56d Mon Sep 17 00:00:00 2001 From: Dave Halter Date: Thu, 23 Jan 2020 23:17:26 +0100 Subject: [PATCH] Remove use_filesystem_cache and additional_dynamic_modules, it hasn't been implemented for a long time --- CHANGELOG.rst | 3 +++ jedi/settings.py | 13 ------------- test/test_settings.py | 11 ----------- 3 files changed, 3 insertions(+), 24 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index be2269c0..acf2f3ee 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -31,6 +31,9 @@ Changelog has reached the end of its life and now it's just about a smooth transition. - Removed ``settings.no_completion_duplicates``. It wasn't tested and nobody was probably using it anyway. +- Removed ``settings.use_filesystem_cache`` and + ``settings.additional_dynamic_modules``, they have no usage anymore. Pretty + much nobody was probably using them. 0.15.2 (2019-12-20) +++++++++++++++++++ diff --git a/jedi/settings.py b/jedi/settings.py index 4e4569f9..9797f049 100644 --- a/jedi/settings.py +++ b/jedi/settings.py @@ -23,7 +23,6 @@ Filesystem cache ~~~~~~~~~~~~~~~~ .. autodata:: cache_directory -.. autodata:: use_filesystem_cache Parser @@ -38,7 +37,6 @@ Dynamic stuff .. autodata:: dynamic_array_additions .. autodata:: dynamic_params .. autodata:: dynamic_params_for_other_modules -.. autodata:: additional_dynamic_modules .. autodata:: auto_import_modules @@ -71,11 +69,6 @@ Removed it again, because in VIM that is not very practical. # Filesystem cache # ---------------- -use_filesystem_cache = True -""" -Use filesystem cache to save once parsed files with pickle. -""" - if platform.system().lower() == 'windows': _cache_directory = os.path.join(os.getenv('APPDATA') or '~', 'Jedi', 'Jedi') @@ -133,12 +126,6 @@ dynamic_params_for_other_modules = True Do the same for other modules. """ -additional_dynamic_modules = [] -""" -Additional modules in which |jedi| checks if statements are to be found. This -is practical for IDEs, that want to administrate their modules themselves. -""" - dynamic_flow_information = True """ Check for `isinstance` and other information to infer a type. diff --git a/test/test_settings.py b/test/test_settings.py index 07be8536..77a763a9 100644 --- a/test/test_settings.py +++ b/test/test_settings.py @@ -23,17 +23,6 @@ def test_auto_import_modules_imports(auto_import_json, Script): assert isinstance(main._name, CompiledValueName) -def test_additional_dynamic_modules(monkeypatch, Script): - # We could add further tests, but for now it's even more important that - # this doesn't fail. - monkeypatch.setattr( - settings, - 'additional_dynamic_modules', - ['/foo/bar/jedi_not_existing_file.py'] - ) - assert not Script('def some_func(f):\n f.').complete() - - def test_cropped_file_size(monkeypatch, get_names, Script): code = 'class Foo(): pass\n' monkeypatch.setattr(