VimPlug/jedi
1
0
Fork 1
mirror of https://github.com/davidhalter/jedi.git synced 2025-12-16 02:27:06 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

definition_end_position -> get_definition_end_position, same for start, see #1584

Browse Source
This commit is contained in:
Dave Halter
2020-05-18 01:17:52 +02:00
parent cb1730f628
commit 2d17b81313
2 changed files with 13 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
jedi/api/classes.py
View File

@@ -231,8 +231,7 @@ class BaseName(object):
return None return None
return start_pos[1] return start_pos[1]
@property def get_definition_start_position(self):
def definition_start_position(self):
""" """
The (row, column) of the start of the definition range. Rows start with The (row, column) of the start of the definition range. Rows start with
1, columns start with 0. 1, columns start with 0.
@@ -244,8 +243,7 @@ class BaseName(object):
return self._name.start_pos return self._name.start_pos
return definition.start_pos return definition.start_pos
@property def get_definition_end_position(self):
def definition_end_position(self):
""" """
The (row, column) of the end of the definition range. Rows start with The (row, column) of the end of the definition range. Rows start with
1, columns start with 0. 1, columns start with 0.

21
test/test_api/test_classes.py
View File

@@ -604,6 +604,7 @@ def test_get_type_hint(Script, code, expected, skip_pre_python36):
def test_pseudotreenameclass_type(Script): def test_pseudotreenameclass_type(Script):
assert Script('from typing import Any\n').get_names()[0].type == 'class' assert Script('from typing import Any\n').get_names()[0].type == 'class'
def test_definition_start_end_position(Script): def test_definition_start_end_position(Script):
'''Tests for definition_start_position and definition_end_position''' '''Tests for definition_start_position and definition_end_position'''
code = '\n'.join([ code = '\n'.join([
@@ -624,17 +625,17 @@ def test_definition_start_end_position(Script):
assert len(names) == 5 assert len(names) == 5
a_func, var1, AClass, hello, func_var = names a_func, var1, AClass, hello, func_var = names
assert a_func.definition_start_position == (1, 0) assert a_func.get_definition_start_position() == (1, 0)
assert a_func.definition_end_position == (2, 16) assert a_func.get_definition_end_position() == (2, 16)
assert var1.definition_start_position == (4, 0) assert var1.get_definition_start_position() == (4, 0)
assert var1.definition_end_position == (4, 9) assert var1.get_definition_end_position() == (4, 9)
assert AClass.definition_start_position == (6, 0) assert AClass.get_definition_start_position() == (6, 0)
assert AClass.definition_end_position == (11, 23) assert AClass.get_definition_end_position() == (11, 23)
assert hello.definition_start_position == (9, 4) assert hello.get_definition_start_position() == (9, 4)
assert hello.definition_end_position == (11, 23) assert hello.get_definition_end_position() == (11, 23)
assert func_var.definition_start_position == (10, 8) assert func_var.get_definition_start_position() == (10, 8)
assert func_var.definition_end_position == (10, 20) assert func_var.get_definition_end_position() == (10, 20)