VimPlug/jedi
1
0
Fork 1
mirror of https://github.com/davidhalter/jedi.git synced 2025-12-08 06:44:46 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Goto definition doesn't work on strings anymore, fixes microsoft/vscode#81520

Browse Source
This commit is contained in:
Dave Halter
2019-12-20 10:29:54 +01:00
parent 540a57766d
commit 45edfbdeeb
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
jedi/api/__init__.py
View File

@@ -238,7 +238,7 @@ class Script(object):
leaf = self._module_node.get_name_of_position(self._pos) leaf = self._module_node.get_name_of_position(self._pos)
if leaf is None: if leaf is None:
leaf = self._module_node.get_leaf_for_position(self._pos) leaf = self._module_node.get_leaf_for_position(self._pos)
if leaf is None: if leaf is None or leaf.type == 'string':
return [] return []
context = self._get_module_context().create_context(leaf) context = self._get_module_context().create_context(leaf)

16
test/test_api/test_api.py
View File

@@ -342,3 +342,19 @@ def test_file_fuzzy_completion(Script):
script = Script('"{}/ep08_i'.format(path)) script = Script('"{}/ep08_i'.format(path))
assert ['pep0484_basic.py"', 'pep0484_typing.py"'] \ assert ['pep0484_basic.py"', 'pep0484_typing.py"'] \
== [comp.name for comp in script.completions(fuzzy=True)] == [comp.name for comp in script.completions(fuzzy=True)]
@pytest.mark.parametrize(
'code, column', [
('"foo"', 0),
('"foo"', 3),
('"foo"', None),
('"""foo"""', 5),
('"""foo"""', 1),
('"""foo"""', 2),
]
)
def test_goto_on_string(Script, code, column):
script = Script(code, column=column)
assert not script.goto_definitions()
assert not script.goto_assignments()