VimPlug/jedi
1
0
Fork 1
mirror of https://github.com/davidhalter/jedi.git synced 2025-12-08 14:54:47 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make sure that kwargs are not repeated when they are inferred

Browse Source
This commit is contained in:
Dave Halter
2020-01-05 01:48:10 +01:00
parent aca2a5a409
commit 74fc29be9a
2 changed files with 21 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
jedi/inference/star_args.py
View File

@@ -127,6 +127,7 @@ def process_params(param_names, star_count=3): # default means both * and **
used_names.add(p.string_name) used_names.add(p.string_name)
yield p yield p
# First process *args
longest_param_names = () longest_param_names = ()
found_arg_signature = False found_arg_signature = False
found_kwarg_signature = False found_kwarg_signature = False
@@ -172,12 +173,7 @@ def process_params(param_names, star_count=3): # default means both * and **
elif arg_names: elif arg_names:
yield arg_names[0] yield arg_names[0]
for p in kw_only_names: # Then process **kwargs
if p.string_name in used_names:
continue
yield p
used_names.add(p.string_name)
for func, arguments in kwarg_callables: for func, arguments in kwarg_callables:
for signature in func.get_signatures(): for signature in func.get_signatures():
found_kwarg_signature = True found_kwarg_signature = True
@@ -186,8 +182,16 @@ def process_params(param_names, star_count=3): # default means both * and **
arguments, arguments,
signature.get_param_names(resolve_stars=False) signature.get_param_names(resolve_stars=False)
)), star_count=2): )), star_count=2):
if p.get_kind() != Parameter.KEYWORD_ONLY or not kwarg_names: if p.get_kind() == Parameter.VAR_KEYWORD:
yield p kwarg_names.append(p)
elif p.get_kind() == Parameter.KEYWORD_ONLY:
kw_only_names.append(p)
for p in kw_only_names:
if p.string_name in used_names:
continue
yield p
used_names.add(p.string_name)
if not found_kwarg_signature and original_kwarg_name is not None: if not found_kwarg_signature and original_kwarg_name is not None:
yield original_kwarg_name yield original_kwarg_name

9
test/test_inference/test_signature.py
View File

@@ -123,6 +123,12 @@ def test_tree_signature(Script, environment, code, expected):
('two_redirects(akw, kw)', 'a, c, *args, **kwargs'), ('two_redirects(akw, kw)', 'a, c, *args, **kwargs'),
('two_redirects(kw, akw)', 'a, b, *args, c, **kwargs'), ('two_redirects(kw, akw)', 'a, b, *args, c, **kwargs'),
('two_kwargs_redirects(simple, simple)', '*args, a, b, c'),
('two_kwargs_redirects(kw, kw)', '*args, a, b, c, **kwargs'),
('two_kwargs_redirects(simple, kw)', '*args, a, b, c, **kwargs'),
('two_kwargs_redirects(simple2, two_kwargs_redirects(simple, simple))',
'*args, x, a, b, c'),
('combined_redirect(simple, simple2)', 'a, b, /, *, x'), ('combined_redirect(simple, simple2)', 'a, b, /, *, x'),
('combined_redirect(simple, simple3)', 'a, b, /, *, a, x: int'), ('combined_redirect(simple, simple3)', 'a, b, /, *, a, x: int'),
('combined_redirect(simple2, simple)', 'x, /, *, a, b, c'), ('combined_redirect(simple2, simple)', 'x, /, *, a, b, c'),
@@ -130,6 +136,7 @@ def test_tree_signature(Script, environment, code, expected):
('combined_redirect(simple, kw)', 'a, b, /, *, a, b, c, **kwargs'), ('combined_redirect(simple, kw)', 'a, b, /, *, a, b, c, **kwargs'),
('combined_redirect(kw, simple)', 'a, b, /, *, a, b, c'), ('combined_redirect(kw, simple)', 'a, b, /, *, a, b, c'),
('combined_redirect(simple, simple2)', 'a, b, /, *, x'),
('combined_lot_of_args(kw, simple4)', '*, b'), ('combined_lot_of_args(kw, simple4)', '*, b'),
('combined_lot_of_args(simple4, kw)', '*, b, c, **kwargs'), ('combined_lot_of_args(simple4, kw)', '*, b, c, **kwargs'),
@@ -163,6 +170,8 @@ def test_nested_signatures(Script, environment, combination, expected, skip_pre_
return lambda *args, **kwargs: func(1, *args, **kwargs) return lambda *args, **kwargs: func(1, *args, **kwargs)
def two_redirects(func1, func2): def two_redirects(func1, func2):
return lambda *args, **kwargs: func1(*args, **kwargs) + func2(1, *args, **kwargs) return lambda *args, **kwargs: func1(*args, **kwargs) + func2(1, *args, **kwargs)
def two_kwargs_redirects(func1, func2):
return lambda *args, **kwargs: func1(**kwargs) + func2(1, **kwargs)
def combined_redirect(func1, func2): def combined_redirect(func1, func2):
return lambda *args, **kwargs: func1(*args) + func2(**kwargs) return lambda *args, **kwargs: func1(*args) + func2(**kwargs)
def combined_lot_of_args(func1, func2): def combined_lot_of_args(func1, func2):