From 855fb5a936c2b242f3a934a75c2e27a112b49ce0 Mon Sep 17 00:00:00 2001 From: Dave Halter Date: Mon, 18 May 2020 19:20:53 +0200 Subject: [PATCH] Fix potential AttributeError in get_defintion_start_position/get_defintion_end_position, see #1584 --- jedi/api/classes.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/jedi/api/classes.py b/jedi/api/classes.py index 13dcda4d..4e0d2635 100644 --- a/jedi/api/classes.py +++ b/jedi/api/classes.py @@ -238,6 +238,8 @@ class BaseName(object): :rtype: Optional[Tuple[int, int]] """ + if self._name.tree_name is None: + return None definition = self._name.tree_name.get_definition() if definition is None: return self._name.start_pos @@ -250,10 +252,10 @@ class BaseName(object): :rtype: Optional[Tuple[int, int]] """ + if self._name.tree_name is None: + return None definition = self._name.tree_name.get_definition() if definition is None: - if self._name.tree_name is None: - return None return self._name.tree_name.end_pos if self.type in ("function", "class"): last_leaf = definition.get_last_leaf()